[Bug 767042] Review Request: js-of-ocaml - OCaml to Javascript compiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=767042 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||js-of-ocaml-1.0.9-1.fc16 Resolution||ERRATA Last Closed||2011-12-30 17:56:23 --- Comment #13 from Fedora Update System upda...@fedoraproject.org 2011-12-30 17:56:23 EST --- js-of-ocaml-1.0.9-1.fc16 has been pushed to the Fedora 16 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 767042] Review Request: js-of-ocaml - OCaml to Javascript compiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=767042 --- Comment #6 from Jerry James loganje...@gmail.com 2011-12-22 10:54:13 EST --- (In reply to comment #5) Indeed. I meant to say this in my mysterious This is way I didn't split produce a separate -debug package sentence in comment 0 as well. (Apparently my command of the English language comes and goes ..) Heh. I'd say your command of English is quite good. It's certainly far better than my command of Mandarin Chinese, which I used to speak (but not read or write) semi-fluently 20-some years ago. Today I have trouble putting a coherent sentence together. I used hyphens because that's what Debian did: Good enough. Thanks for the explanation. And I screwed up on some of the pluses and minuses. Sorry about that. This is what happens when I cut paste from a template. I'm going to make the template have nothing in between the brackets so I'm forced to think about the contents of every single one in the future. Let me draw your attention to 2 more items, with the correct character between the brackets this time: MUST: [=] package meets the packaging guidelines: but consider adding -p to the cp invocations, as per https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps. [-] license field matches the actual license: not quite. The LICENSE file mentions exceptions, so the license should be LGPLv2+ with exceptions. Also, some of the examples are GPLv2+ (e.g., examples/graph_viewer/scene.mli), and one is WTFPL (examples/boulderdash/boulderdash.ml). I think the -doc subpackage will need to have a license along the lines of (LGPLv2+ with exceptions) and GPLv2+ and WTFPL. Everything else looks fine. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 767042] Review Request: js-of-ocaml - OCaml to Javascript compiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=767042 --- Comment #7 from Scott Tsai scottt...@gmail.com 2011-12-22 13:16:50 EST --- (In reply to comment #6) Updated spec at same URL: 1. Preserve timestamps with cp -p 2. Update license fields diff --git a/js-of-ocaml.spec b/js-of-ocaml.spec index 16c048d..7ca3b82 100644 --- a/js-of-ocaml.spec +++ b/js-of-ocaml.spec @@ -7,7 +7,7 @@ Version:1.0.9 Release:1%{?dist} Summary:An OCaml to Javascript compiler -License:LGPLv2+ +License:LGPLv2+ with exceptions URL:http://ocsigen.org/js_of_ocaml Source0:http://ocsigen.org/download/js_of_ocaml-%{version}.tar.gz @@ -38,6 +38,7 @@ Its key features are the following: Summary:User manual and other documentation for %{name} Group: Development/Libraries BuildArch: noarch +License:(LGPLv2+ with exceptions) and GPLv2+ and WTFPL %descriptiondoc The %{name}-doc package contains the user manual, API @@ -56,14 +57,14 @@ export OCAMLFIND_DESTDIR=$RPM_BUILD_ROOT%{_libdir}/ocaml mkdir -p $OCAMLFIND_DESTDIR $OCAMLFIND_DESTDIR/stublibs D=$RPM_BUILD_ROOT%{_libdir}/ocaml/js_of_ocaml mkdir -p $D -cp lib/META \ +cp -p lib/META \ lib/*.{cmi,cma,a,mli} \ lib/syntax/pa_js.cmo \ runtime/runtime.js \ $D mkdir -p $RPM_BUILD_ROOT%{_bindir} -cp compiler/js_of_ocaml $RPM_BUILD_ROOT%{_bindir}/ -cp lib/dlljs_of_ocaml.so $OCAMLFIND_DESTDIR/stublibs/ +cp -p compiler/js_of_ocaml $RPM_BUILD_ROOT%{_bindir}/ +cp -p lib/dlljs_of_ocaml.so $OCAMLFIND_DESTDIR/stublibs/ strip $OCAMLFIND_DESTDIR/stublibs/dll*.so chrpath --delete $OCAMLFIND_DESTDIR/stublibs/dll*.so @@ -76,7 +77,7 @@ echo '-b /usr/bin/js_of_ocaml' $RPM_BUILD_ROOT/etc/prelink.conf.d/js-of-ocaml. # docs find examples '(' -name '*.cmi' -or -name '*.cmo' -or -name '*.byte' -or -name '.depend' ')' -exec rm '{}' ';' # Replacing Makefile.common allows the user to build the examples -cp %{SOURCE1} examples/Makefile.common +cp -p %{SOURCE1} examples/Makefile.common -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 767042] Review Request: js-of-ocaml - OCaml to Javascript compiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=767042 Jerry James loganje...@gmail.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #8 from Jerry James loganje...@gmail.com 2011-12-22 14:27:58 EST --- Looks good. This package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 767042] Review Request: js-of-ocaml - OCaml to Javascript compiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=767042 Scott Tsai scottt...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #9 from Scott Tsai scottt...@gmail.com 2011-12-22 14:35:23 EST --- New Package SCM Request === Package Name: js-of-ocaml Short Description: An OCaml to Javascript compiler Owners: scottt Branches: f16 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 767042] Review Request: js-of-ocaml - OCaml to Javascript compiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=767042 --- Comment #10 from Jon Ciesla limburg...@gmail.com 2011-12-22 14:58:50 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 767042] Review Request: js-of-ocaml - OCaml to Javascript compiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=767042 --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2011-12-22 15:29:47 EST --- js-of-ocaml-1.0.9-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/js-of-ocaml-1.0.9-1.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 767042] Review Request: js-of-ocaml - OCaml to Javascript compiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=767042 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 767042] Review Request: js-of-ocaml - OCaml to Javascript compiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=767042 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #12 from Fedora Update System upda...@fedoraproject.org 2011-12-22 22:30:54 EST --- js-of-ocaml-1.0.9-1.fc16 has been pushed to the Fedora 16 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 767042] Review Request: js-of-ocaml - OCaml to Javascript compiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=767042 Jerry James loganje...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||loganje...@gmail.com AssignedTo|nob...@fedoraproject.org|loganje...@gmail.com Flag||fedora-review? --- Comment #2 from Jerry James loganje...@gmail.com 2011-12-21 13:30:01 EST --- Taking for review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 767042] Review Request: js-of-ocaml - OCaml to Javascript compiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=767042 --- Comment #3 from Jerry James loganje...@gmail.com 2011-12-21 15:13:59 EST --- If you are going to build this package for Fedora only, then there are several elements of the spec file that are not needed. These lines: %global _use_internal_dependency_generator 0 %global __find_requires /usr/lib/rpm/ocaml-find-requires.sh %global __find_provides /usr/lib/rpm/ocaml-find-provides.sh are still specified on the wiki even though they haven't been necessary for a few Fedora releases. In fact, if you remove these, you'll see Requires on libc and libm show up that don't show up with these lines in place. Unfortunately, a Provides of dlljs_of_ocaml.so() also shows up, but it can be filtered like this: %global __provides_exclude_from ^%{_libdir}/ocaml/stublibs/.*\.so$ All current versions of Fedora were released with ocaml 3.12.0, so you can omit the = 3.10.0 on the BuildRequires of ocaml. Finally, the rm -rf $RPM_BUILD_ROOT at the top of %install and the %defattr in %files can be omitted. If you are going to build for EPEL, disregard everything above this line. Legend: +: OK -: must be fixed =: should be fixed (at your discretion) N: not applicable MUST: [-] rpmlint output: js-of-ocaml.x86_64: W: unstripped-binary-or-object /usr/bin/js_of_ocaml js-of-ocaml.x86_64: W: devel-file-in-non-devel-package /usr/lib64/ocaml/js_of_ocaml/regexp.mli js-of-ocaml.x86_64: E: incorrect-fsf-address /usr/lib64/ocaml/js_of_ocaml/regexp.mli js-of-ocaml.x86_64: W: devel-file-in-non-devel-package /usr/lib64/ocaml/js_of_ocaml/libjs_of_ocaml.a js-of-ocaml.x86_64: W: devel-file-in-non-devel-package /usr/lib64/ocaml/js_of_ocaml/form.mli js-of-ocaml.x86_64: E: incorrect-fsf-address /usr/lib64/ocaml/js_of_ocaml/form.mli js-of-ocaml.x86_64: W: devel-file-in-non-devel-package /usr/lib64/ocaml/js_of_ocaml/js.mli js-of-ocaml.x86_64: E: incorrect-fsf-address /usr/lib64/ocaml/js_of_ocaml/js.mli js-of-ocaml.x86_64: W: devel-file-in-non-devel-package /usr/lib64/ocaml/js_of_ocaml/event_arrows.mli js-of-ocaml.x86_64: E: incorrect-fsf-address /usr/lib64/ocaml/js_of_ocaml/event_arrows.mli js-of-ocaml.x86_64: W: devel-file-in-non-devel-package /usr/lib64/ocaml/js_of_ocaml/dom_events.mli js-of-ocaml.x86_64: E: incorrect-fsf-address /usr/lib64/ocaml/js_of_ocaml/dom_events.mli js-of-ocaml.x86_64: W: devel-file-in-non-devel-package /usr/lib64/ocaml/js_of_ocaml/dom.mli js-of-ocaml.x86_64: E: incorrect-fsf-address /usr/lib64/ocaml/js_of_ocaml/dom.mli js-of-ocaml.x86_64: W: devel-file-in-non-devel-package /usr/lib64/ocaml/js_of_ocaml/xmlHttpRequest.mli js-of-ocaml.x86_64: E: incorrect-fsf-address /usr/lib64/ocaml/js_of_ocaml/xmlHttpRequest.mli js-of-ocaml.x86_64: E: incorrect-fsf-address /usr/lib64/ocaml/js_of_ocaml/runtime.js js-of-ocaml.x86_64: W: devel-file-in-non-devel-package /usr/lib64/ocaml/js_of_ocaml/file.mli js-of-ocaml.x86_64: E: incorrect-fsf-address /usr/lib64/ocaml/js_of_ocaml/file.mli js-of-ocaml.x86_64: W: devel-file-in-non-devel-package /usr/lib64/ocaml/js_of_ocaml/url.mli js-of-ocaml.x86_64: E: incorrect-fsf-address /usr/lib64/ocaml/js_of_ocaml/url.mli js-of-ocaml.x86_64: W: devel-file-in-non-devel-package /usr/lib64/ocaml/js_of_ocaml/firebug.mli js-of-ocaml.x86_64: E: incorrect-fsf-address /usr/lib64/ocaml/js_of_ocaml/firebug.mli js-of-ocaml.x86_64: W: devel-file-in-non-devel-package /usr/lib64/ocaml/js_of_ocaml/CSS.mli js-of-ocaml.x86_64: E: incorrect-fsf-address /usr/lib64/ocaml/js_of_ocaml/CSS.mli js-of-ocaml.x86_64: W: devel-file-in-non-devel-package /usr/lib64/ocaml/js_of_ocaml/dom_html.mli js-of-ocaml.x86_64: E: incorrect-fsf-address /usr/lib64/ocaml/js_of_ocaml/dom_html.mli js-of-ocaml.x86_64: W: devel-file-in-non-devel-package /usr/lib64/ocaml/js_of_ocaml/lwt_js.mli js-of-ocaml.x86_64: E: incorrect-fsf-address /usr/lib64/ocaml/js_of_ocaml/lwt_js.mli js-of-ocaml.x86_64: W: devel-file-in-non-devel-package /usr/lib64/ocaml/js_of_ocaml/json.mli js-of-ocaml.x86_64: E: incorrect-fsf-address /usr/lib64/ocaml/js_of_ocaml/json.mli js-of-ocaml.x86_64: W: no-manual-page-for-binary js_of_ocaml js-of-ocaml.x86_64: W: ocaml-naming-policy-not-applied /usr/lib64/ocaml/js_of_ocaml/regexp.mli js-of-ocaml-doc.noarch: E: incorrect-fsf-address /usr/share/doc/js-of-ocaml-doc-1.0.9/examples/graph_viewer/viewer_js.ml js-of-ocaml-doc.noarch: E: incorrect-fsf-address /usr/share/doc/js-of-ocaml-doc-1.0.9/examples/wiki/main.ml js-of-ocaml-doc.noarch: E: incorrect-fsf-address /usr/share/doc/js-of-ocaml-doc-1.0.9/examples/graph_viewer/svg.ml js-of-ocaml-doc.noarch: E: incorrect-fsf-address /usr/share/doc/js-of-ocaml-doc-1.0.9/examples/graph_viewer/converter.ml js-of-ocaml-doc.noarch: E: incorrect-fsf-address /usr/share/doc/js-of-ocaml-doc-1.0.9/examples/graph_viewer/main.ml js-of-ocaml-doc.noarch: E: incorrect-fsf-address
[Bug 767042] Review Request: js-of-ocaml - OCaml to Javascript compiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=767042 --- Comment #4 from Scott Tsai scottt...@gmail.com 2011-12-21 15:55:15 EST --- Updated spec at same URL to incorporate these fixes: 1. Use RPM features not available on EPEL to simplify spec 2. Add /usr/bin/js_of_ocaml to prelink black list 3. Removed examples/graph_viewer/.depend 4. Add ExclusiveArch diff --git a/js-of-ocaml.spec b/js-of-ocaml.spec index 18db785..16c048d 100644 --- a/js-of-ocaml.spec +++ b/js-of-ocaml.spec @@ -1,8 +1,6 @@ %global opt %(test -x %{_bindir}/ocamlopt echo 1 || echo 0) %global debug_package %{nil} -%global _use_internal_dependency_generator 0 -%global __find_requires /usr/lib/rpm/ocaml-find-requires.sh -%global __find_provides /usr/lib/rpm/ocaml-find-provides.sh +%global __provides_exclude_from ^%{_libdir}/ocaml/stublibs/.*\.so$ Name: js-of-ocaml Version:1.0.9 @@ -16,12 +14,13 @@ Source0: http://ocsigen.org/download/js_of_ocaml-%{version}.tar.gz # Allow examples to be built with the distro packaged js-of-ocaml Source1:Makefile.common.js-of-ocaml.examples -BuildRequires: ocaml = 3.10.0 +BuildRequires: ocaml BuildRequires: ocaml-findlib-devel BuildRequires: ocaml-ocamldoc BuildRequires: ocaml-camlp4-devel BuildRequires: ocaml-lwt = 2.3.0 BuildRequires: chrpath +ExclusiveArch: %{ocaml_arches} %description js_of_ocaml is a compiler of OCaml byte-code to JavaScript. @@ -52,7 +51,6 @@ reference and examples for %{name}. make %install -rm -rf $RPM_BUILD_ROOT export DESTDIR=$RPM_BUILD_ROOT export OCAMLFIND_DESTDIR=$RPM_BUILD_ROOT%{_libdir}/ocaml mkdir -p $OCAMLFIND_DESTDIR $OCAMLFIND_DESTDIR/stublibs @@ -70,17 +68,22 @@ cp lib/dlljs_of_ocaml.so $OCAMLFIND_DESTDIR/stublibs/ strip $OCAMLFIND_DESTDIR/stublibs/dll*.so chrpath --delete $OCAMLFIND_DESTDIR/stublibs/dll*.so +# NB. Do NOT strip the binaries and prevent prelink from stripping them too. +# (https://bugzilla.redhat.com/show_bug.cgi?id=435559) +mkdir -p $RPM_BUILD_ROOT/etc/prelink.conf.d +echo '-b /usr/bin/js_of_ocaml' $RPM_BUILD_ROOT/etc/prelink.conf.d/js-of-ocaml.conf + # docs -find examples '(' -name '*.cmi' -or -name '*.cmo' -or -name '*.byte' ')' -exec rm '{}' ';' +find examples '(' -name '*.cmi' -or -name '*.cmo' -or -name '*.byte' -or -name '.depend' ')' -exec rm '{}' ';' # Replacing Makefile.common allows the user to build the examples cp %{SOURCE1} examples/Makefile.common %files -%defattr(-,root,root,-) %doc LICENSE README %{_libdir}/ocaml/js_of_ocaml/ %{_libdir}/ocaml/stublibs/*.so %{_bindir}/js_of_ocaml +%config(noreplace) /etc/prelink.conf.d/js-of-ocaml.conf -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 767042] Review Request: js-of-ocaml - OCaml to Javascript compiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=767042 --- Comment #5 from Scott Tsai scottt...@gmail.com 2011-12-21 16:20:20 EST --- (In reply to comment #3) I assume the devel-file-in-non-devel-package warnings are because those devel files are needed in the translation process. Is that right? Indeed. I meant to say this in my mysterious This is way I didn't split produce a separate -debug package sentence in comment 0 as well. (Apparently my command of the English language comes and goes ..) [=] follows package naming guidelines: why did you change the underscores to hyphens? I used hyphens because that's what Debian did: http://packages.debian.org/sid/js-of-ocaml Say you're trying to build some upstream open source project and the upstream website says Run apt-get ... to install the build dependencies. I run into this often enough that I'd like to keep the package name consistent with Debian unless there's a strong reason not to. [-] package functions as described: only minimal testing The bundled examples are built so the OCaml to Javascript compiler is minimally tested. I can't run the generated code since they are interactive programs that assumes a user clicking in a browser. I have personally built a large non trivial program and ran it successfully with this js-of-ocaml package though: http://blog.scottt.tw/2011/12/compiling-web-interface-of-ppcmemarmmem.html I can see how collecting simple OCaml programs and running the generated code with a command line Javascript interpreter like /usr/bin/js could work but lack the motivation to do that since upstream didn't. [=] package contains man pages for binaries/scripts Upstream didn't include a man page. I can't find one I can conveniently steal from other distros so I punted here as well. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 767042] Review Request: js-of-ocaml - OCaml to Javascript compiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=767042 --- Comment #1 from Scott Tsai scottt...@gmail.com 2011-12-12 22:48:01 EST --- Successful Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3581663 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review