[Bug 768500] Review Request: subscription-manager - Tools and libraries for subscription and repository management.

2016-08-14 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=768500

Igor Gnatenko  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |CURRENTRELEASE
Last Closed||2016-08-14 11:52:52



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 768500] Review Request: subscription-manager - Tools and libraries for subscription and repository management.

2012-01-02 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=768500

Lukáš Zapletal  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||l...@redhat.com
 AssignedTo|nob...@fedoraproject.org|l...@redhat.com

--- Comment #1 from Lukáš Zapletal  2012-01-02 14:02:36 EST ---
Taking the review.

First look:

rpmlint subscription-manager-0.99.2-1.fc16.src.rpm 
subscription-manager.src:11: W: macro-in-comment %{version}
subscription-manager.src:11: W: macro-in-comment %{release}
subscription-manager.src:162: E: hardcoded-library-path in
%{_prefix}/lib/yum-plugins/subscription-manager.py*
subscription-manager.src:163: E: hardcoded-library-path in
%{_prefix}/lib/yum-plugins/product-id.py*
subscription-manager.src:164: E: hardcoded-library-path in
%{_prefix}/lib/yum-plugins/katello.py*
subscription-manager.src: W: invalid-url Source0:
subscription-manager-0.99.2.tar.gz

All errors and warning above are properly commented in the spec and are not
problems. Formal review will follow later on.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 768500] Review Request: subscription-manager - Tools and libraries for subscription and repository management.

2012-01-02 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=768500

Lukáš Zapletal  changed:

   What|Removed |Added

   Flag||fedora-review?

--- Comment #2 from Lukáš Zapletal  2012-01-02 14:27:19 EST ---
http://koji.fedoraproject.org/koji/taskinfo?taskID=3614692

FORMAL REVIEW

MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.[4]

The LICENSE file is missing, distribution for all subpackages is recommended.

MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.

I would suggest to add one line instructing user to install tito, not all of
use know what tito is. Not a blocker.

Excelent work for such a complicated package, only minor points.

*** APPROVED ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 768500] Review Request: subscription-manager - Tools and libraries for subscription and repository management.

2012-01-02 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=768500

Lukáš Zapletal  changed:

   What|Removed |Added

 AssignedTo|l...@redhat.com |dgood...@redhat.com
   Flag|fedora-review?  |fedora-review+

--- Comment #3 from Lukáš Zapletal  2012-01-02 14:31:07 EST ---
Devan, please fix the minor issue (LICENSE file distribution) before you commit
to the distgit.

*** PACKAGE IS APPROVED ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 768500] Review Request: subscription-manager - Tools and libraries for subscription and repository management.

2012-01-02 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=768500

--- Comment #4 from Lukáš Zapletal  2012-01-02 14:35:29 EST ---
For completeness I am attaching rpmlint for binaries:

subscription-manager-firstboot.i686: W: no-documentation
subscription-manager-gnome.i686: W: non-conffile-in-etc
/etc/pam.d/subscription-manager-gui
subscription-manager-gnome.i686: W: non-conffile-in-etc
/etc/security/console.apps/subscription-manager-gui
subscription-manager.src:11: W: macro-in-comment %{version}
subscription-manager.src:11: W: macro-in-comment %{release}
subscription-manager.src:162: E: hardcoded-library-path in
%{_prefix}/lib/yum-plugins/subscription-manager.py*
subscription-manager.src:163: E: hardcoded-library-path in
%{_prefix}/lib/yum-plugins/product-id.py*
subscription-manager.src:164: E: hardcoded-library-path in
%{_prefix}/lib/yum-plugins/katello.py*
subscription-manager.src: W: invalid-url Source0:
subscription-manager-0.99.2.tar.gz
subscription-manager.i686: W: only-non-binary-in-usr-lib
subscription-manager.i686: W: non-conffile-in-etc
/etc/bash_completion.d/subscription-manager
subscription-manager.i686: W: non-conffile-in-etc
/etc/security/console.apps/subscription-manager
subscription-manager.i686: W: no-dependency-on usermode
subscription-manager.i686: W: manual-page-warning
/usr/share/man/man8/subscription-manager.8.gz 672: warning: macro `pp' not
defined
subscription-manager.i686: W: non-conffile-in-etc
/etc/pam.d/subscription-manager
subscription-manager.i686: W: service-default-enabled
/etc/rc.d/init.d/rhsmcertd
subscription-manager.i686: W: incoherent-init-script-name rhsmcertd
('subscription-manager', 'subscription-managerd')
5 packages and 0 specfiles checked; 3 errors, 14 warnings.

No blockers.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 768500] Review Request: subscription-manager - Tools and libraries for subscription and repository management.

2012-01-03 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=768500

--- Comment #5 from Devan Goodwin  2012-01-03 11:33:53 EST 
---
New Package SCM Request
===
Package Name: subscription-manager
Short Description: Tools and libraries for subscription and repository
management.
Owners: dgoodwin jbowes
Branches: f15 f16
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 768500] Review Request: subscription-manager - Tools and libraries for subscription and repository management.

2012-01-03 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=768500

Devan Goodwin  changed:

   What|Removed |Added

   Flag||fedora-cvs?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 768500] Review Request: subscription-manager - Tools and libraries for subscription and repository management.

2012-01-03 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=768500

Devan Goodwin  changed:

   What|Removed |Added

 CC||dgood...@rm-rf.ca
 AssignedTo|dgood...@redhat.com |dgood...@rm-rf.ca

--- Comment #6 from Devan Goodwin  2012-01-03 11:38:49 EST 
---
Filed this on my work account, suspect that is why I can't set fedora-cvs flag.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 768500] Review Request: subscription-manager - Tools and libraries for subscription and repository management.

2012-01-03 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=768500

--- Comment #7 from Jon Ciesla  2012-01-03 11:50:22 EST 
---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review