[Bug 769096] Review Request: gnome-shell-extension-windowoverlay-icons - Easily discover which application to select by viewing the app icons in the windows overview.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769096 --- Comment #15 from Yader Velásquez yajo...@gmail.com 2012-01-29 17:32:00 EST --- Ok, issue solved SPEC: http://yaderv.fedorapeople.org/rpm/gnome-shell-extension-sustmi/gnome-shell-extension-sustmi.spec SRPM: http://yaderv.fedorapeople.org/rpm/gnome-shell-extension-sustmi/gnome-shell-extension-sustmi-3.0-6.git72282ce.fc16.src.rpm Description: This package provides two GNOME Shell extensions, windowoverlay-icons and historymanager-prefix-search -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769096] Review Request: gnome-shell-extension-windowoverlay-icons - Easily discover which application to select by viewing the app icons in the windows overview.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769096 --- Comment #14 from Mohamed El Morabity pikachu.2...@gmail.com 2012-01-24 20:21:07 EST --- $ rpmlint gnome-shell-extension-sustmi-historymanager-prefix-search-3.0-5.git72282ce.fc16.noarch.rpm gnome-shell-extension-sustmi-historymanager-prefix-search.noarch: W: spelling-error %description -l en_US eg - eh, e, g gnome-shell-extension-sustmi-historymanager-prefix-search.noarch: E: description-line-too-long C Use PageUp and PageDown to move in HistoryManager (eg. RunCommand, Looking Glass) 1 packages and 0 specfiles checked; 1 errors, 1 warnings. You should fix the description of gnome-shell-extension-sustmi-historymanager-prefix-search. The spellong issues can be ignored. Don't forget also to modify the description of this review, to comply with the current name of the source package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769096] Review Request: gnome-shell-extension-windowoverlay-icons - Easily discover which application to select by viewing the app icons in the windows overview.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769096 --- Comment #13 from Yader Velásquez yajo...@gmail.com 2012-01-15 23:19:45 EST --- I've fixed an error in the package above SPEC: http://yaderv.fedorapeople.org/rpm/gnome-shell-extension-sustmi/gnome-shell-extension-sustmi.spec SRPM: http://yaderv.fedorapeople.org/rpm/gnome-shell-extension-sustmi/gnome-shell-extension-sustmi-3.0-5.git72282ce.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769096] Review Request: gnome-shell-extension-windowoverlay-icons - Easily discover which application to select by viewing the app icons in the windows overview.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=769096
--- Comment #12 from Yader Velásquez yajo...@gmail.com 2012-01-14 03:57:31
EST ---
Hi Mohamed, I've followed your review.
I only have some warnings messages with rpmlint over the srpm
rpmlint gnome-shell-extension-sustmi-3.0-4.git72282ce.fc16.src.rpm
gnome-shell-extension-sustmi.src: W: spelling-error Summary(en_US)
windowoverlay - window overlay, window-overlay, windowpane
gnome-shell-extension-sustmi.src: W: spelling-error Summary(en_US)
historymanager - history manager, history-manager, historiographer
gnome-shell-extension-sustmi.src: W: spelling-error %description -l en_US
windowoverlay - window overlay, window-overlay, windowpane
gnome-shell-extension-sustmi.src: W: spelling-error %description -l en_US
historymanager - history manager, history-manager, historiographer
1 packages and 0 specfiles checked; 0 errors, 4 warnings.
I want to explain that the .spec uses a macro %{github} because the name in the
repository has a 's' more.
SRPM:
http://yaderv.fedorapeople.org/rpm/gnome-shell-extension-sustmi/gnome-shell-extension-sustmi-3.0-4.git72282ce.fc16.src.rpm
Spec:
http://yaderv.fedorapeople.org/rpm/gnome-shell-extension-sustmi/gnome-shell-extension-sustmi.spec
Regards :)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769096] Review Request: gnome-shell-extension-windowoverlay-icons - Easily discover which application to select by viewing the app icons in the windows overview.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=769096
Mohamed El Morabity pikachu.2...@gmail.com changed:
What|Removed |Added
AssignedTo|nob...@fedoraproject.org|pikachu.2...@gmail.com
--- Comment #11 from Mohamed El Morabity pikachu.2...@gmail.com 2012-01-10
18:31:52 EST ---
You don't have to use two %install targets per extension (and it doesn't work
anyway, as you have seen). All you have to do is to merge them, as below:
%install
# Install windowoverlay-icons extension
mkdir -p %{buildroot}%{_datadir}/gnome-shell/extensions/%{wiuuid}
install -Dp -m 0644
windowoverlay-icons/{extension.js,metadata.json,stylesheet.css} \
%{buildroot}%{_datadir}/gnome-shell/extensions/%{wiuuid}/
# Install historymanager-prefix-search extension
mkdir -p %{buildroot}%{_datadir}/gnome-shell/extensions/%{hpsuiid}
install -Dp -m 0644
historymanager-prefix-search/{extension.js,metadata.json,stylesheet.css} \
%{buildroot}%{_datadir}/gnome-shell/extensions/%{hpsuuid}/
Don't forget also to set a %description for the package; there are only
descriptions for each extension. Even if there is no
gnome-shell-extension-sustmi package build in fact, a description is needed for
the source RPM; for example:
[...]
BuildArch: noarch
Requires: gnome-shell
%description
This package provides two GNOME Shell extensions, windowoverlay-icons and
historymanager-prefix-search
%package windowoverlay-icons
[...]
You can drop the buildroot cleaning, as well as the %defattr macro:
http://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions
http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean
Be careful, the macro %{github} used in %prep is no more defined in your latest
.spec file.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769096] Review Request: gnome-shell-extension-windowoverlay-icons - Easily discover which application to select by viewing the app icons in the windows overview.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769096 Yader Velásquez yajo...@gmail.com changed: What|Removed |Added URL||rrttr464 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769096] Review Request: gnome-shell-extension-windowoverlay-icons - Easily discover which application to select by viewing the app icons in the windows overview.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769096 --- Comment #10 from Yader Velásquez yajo...@gmail.com 2012-01-06 02:24:47 EST --- Yes, I'm not have problem to package both :) But I have a question about the %install: What is the logic in this step? Because each sub-package needs to be copied to a different dir with the name of the uuid. I received an error due two %install. You can see my test work here: http://yaderv.fedorapeople.org/rpm/gnome-shell-extension-sustmi.spec Regards -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769096] Review Request: gnome-shell-extension-windowoverlay-icons - Easily discover which application to select by viewing the app icons in the windows overview.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769096 Mohamed El Morabity pikachu.2...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED Flag||fedora-review? --- Comment #9 from Mohamed El Morabity pikachu.2...@gmail.com 2012-01-03 07:56:27 EST --- That looks perfect :). I've just thinking about something: since the git repository contains in fact two extensions (windowoverlay-icons and historymanager-prefix-search), would you be OK to package both? You'll just have to rename your spec file to gnome-shell-extensions-sustmi and create a subpackage for each extension. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769096] Review Request: gnome-shell-extension-windowoverlay-icons - Easily discover which application to select by viewing the app icons in the windows overview.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769096 --- Comment #8 from Yader Velásquez yajo...@gmail.com 2011-12-26 01:42:34 EST --- Hi Mohamed, I've packaged it basing on the post-release section in the naming guideline[1] Spec URL: http://yaderv.fedorapeople.org/rpm/gnome-shell-windowoverlay-icons/gnome-shell-extension-windowoverlay-icons.spec SRPM URL: http://yaderv.fedorapeople.org/rpm/gnome-shell-windowoverlay-icons/gnome-shell-extension-windowoverlay-icons-3.0-3.git72282ce.fc16.src.rpm Regards :) [1]https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Post-Release_packages -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769096] Review Request: gnome-shell-extension-windowoverlay-icons - Easily discover which application to select by viewing the app icons in the windows overview.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769096 Mohamed El Morabity pikachu.2...@gmail.com changed: What|Removed |Added CC||pikachu.2...@gmail.com --- Comment #5 from Mohamed El Morabity pikachu.2...@gmail.com 2011-12-23 05:05:24 EST --- There is no version 3.0 for this extension. Please use instead the git commit to identify the version of the extension you package. Many packaged GNOME Shell extensions are in such a case, you can use them as examples to fix your spec file. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769096] Review Request: gnome-shell-extension-windowoverlay-icons - Easily discover which application to select by viewing the app icons in the windows overview.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769096 --- Comment #6 from Yader Velásquez yajo...@gmail.com 2011-12-23 13:54:17 EST --- I assumed that this was the version number[1], but reading the git logs I don't find any release message. Are you talking about a pre-release version[2]? [1] https://github.com/sustmi/gnome-shell-extensions-sustmi/tags [2] https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769096] Review Request: gnome-shell-extension-windowoverlay-icons - Easily discover which application to select by viewing the app icons in the windows overview.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769096 --- Comment #7 from Mohamed El Morabity pikachu.2...@gmail.com 2011-12-23 14:10:24 EST --- Sorry, I haven't seen the tag ^^. I suggest you anyway to package instead the latest commit of the extension, which supports both GNOME Shell 3.0 and 3.2. For the 3.0 version, the metadata.json file indicates that only GNOME Shell 3.0 is supported. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769096] Review Request: gnome-shell-extension-windowoverlay-icons - Easily discover which application to select by viewing the app icons in the windows overview.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=769096
Willington Vega wv...@wvega.com changed:
What|Removed |Added
CC||wv...@wvega.com
--- Comment #1 from Willington Vega wv...@wvega.com 2011-12-20 13:44:13 EST
---
Hello Yader,
I would like to provide an informal review for this package.
rpmlint shows the following errors and warnings for the SRPM:
rpmlint SRPMS/gnome-shell-extension-windowoverlay-icons-3.0-1.fc16.src.rpm
gnome-shell-extension-windowoverlay-icons.src: W: summary-ended-with-dot C
Easily discover which application to select by viewing the app icons in the
windows overview.
gnome-shell-extension-windowoverlay-icons.src: E: summary-too-long C Easily
discover which application to select by viewing the app icons in the windows
overview.
gnome-shell-extension-windowoverlay-icons.src: E: description-line-too-long C
This extension allow to view the icons over the application in the windows
overview.
gnome-shell-extension-windowoverlay-icons.src: E: description-line-too-long C
Useful to avoid confusion with the windows when you have a lot of them open on
the
1 packages and 0 specfiles checked; 3 errors, 1 warnings.
No errors or warnings for the SPEC file.
Using wget to download the sources from URL listed as Source0 doesn't return a
tar file with proper name. I think using a comment to describe how to generate
the tarball and using that tarball as Source is better [1]. I propose the
following changes:
# wget https://github.com/sustmi/gnome-shell-extensions-sustmi/tarball/%%{git}
-O %%{name}-%%{version}-%%{git}.tar.gz
Source0:%%{name}-%%{version}-%%{git}.tar.gz
With the above changes it builds on mock with target fedora-15. A warning is
added because no URL is being used in Source0.
1. https://fedoraproject.org/wiki/Packaging/SourceURL#Using_Revision_Control
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769096] Review Request: gnome-shell-extension-windowoverlay-icons - Easily discover which application to select by viewing the app icons in the windows overview.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769096 --- Comment #2 from Yader Velásquez yajo...@gmail.com 2011-12-20 17:09:37 EST --- I fixed the errors and warnings. About the Source0 I understand what you are saying, but if you use spectool -g pkgspec.spec you can download the source and avoid the warning in mock, just saying. I can change it if you consider is the best practice. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769096] Review Request: gnome-shell-extension-windowoverlay-icons - Easily discover which application to select by viewing the app icons in the windows overview.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769096 --- Comment #3 from Willington Vega wv...@wvega.com 2011-12-21 00:27:55 EST --- Yader, Thank you for the quick reply. First I want to be clear about the kind of review I'm doing. I'm still learning the packaging guidelines and I do informal reviews as a way to gain a better understanding of how properly create packages for Fedora. I'm not allowed to approve or reject this package. At some point someone will do an official review and decide whether the package is ready to be included or not. All we are doing right is trying to improve the package to save some time to the official reviewer. When you update your spec is expected that you provide the URL for the updated SPEC and SRPM. There should be a different URL for each update and you should increase the release number in the SPEC file and add the corresponding entry to the changelog section. For the Source0, I didn't consider using spectool. It works. I think the official reviewer should decide which one is the best practice in this case. If you provide the updated SPEC I will continue with the informal review. Have you introduced yourself to fedora-devel-list[1][2]? 1. http://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Introduce_yourself 2. http://www.redhat.com/mailman/listinfo/fedora-devel-list -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769096] Review Request: gnome-shell-extension-windowoverlay-icons - Easily discover which application to select by viewing the app icons in the windows overview.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769096 --- Comment #4 from Yader Velásquez yajo...@gmail.com 2011-12-21 01:09:31 EST --- Hi Willington, I appreciate your help :) I updated the spec and srpm. Spec URL: http://yaderv.fedorapeople.org/rpm/gnome-shell-windowoverlay-icons/gnome-shell-extension-windowoverlay-icons.spec SRPM URL: http://yaderv.fedorapeople.org/rpm/gnome-shell-windowoverlay-icons/gnome-shell-extension-windowoverlay-icons-3.0-2.fc16.src.rpm Yes, I have already wrote to the list. Regards from Nicaragua. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
