[Bug 769487] Review Request: python-glumpy - Small python library for rapid visualization of numpy arrays

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=769487

Nicolas Chauvet (kwizart)  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |EOL
Last Closed||2019-05-24 10:07:23



--- Comment #19 from Nicolas Chauvet (kwizart)  ---
Trying to figure out what's on my side for this ticket I except there is not
much improvements.

The missing dependency is still here and if there is indeed an issue to have
it, it could eventually be made into RPM Fusion nonfree section (provided that
it's considered as redistributable).
Once the requested dependency is here, glumpy would need to be reviewed in the
same nonfree section (unless triangle can be made optional in glumpy).

Please re-open only if the spec/src.rpm are in a working state.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 769487] Review Request: python-glumpy - Small python library for rapid visualization of numpy arrays

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=769487

Elliott Sales de Andrade  changed:

   What|Removed |Added

 CC||quantum.anal...@gmail.com



--- Comment #18 from Elliott Sales de Andrade  ---
I'm pretty sure the (C code) triangle license effectively means this will never
be packaged as it stands:

>  This program may be freely redistributed under the condition that the
>copyright notices (including this entire header and the copyright
>notice printed when the `-h' switch is selected) are not removed, and
>no compensation is received.  Private, research, and institutional
>use is free.  You may distribute modified versions of this code UNDER
>THE CONDITION THAT THIS CODE AND ANY MODIFICATIONS MADE TO IT IN THE
>SAME FILE REMAIN UNDER COPYRIGHT OF THE ORIGINAL AUTHOR, BOTH SOURCE
>AND OBJECT CODE ARE MADE FREELY AVAILABLE WITHOUT CHARGE, AND CLEAR
>NOTICE IS GIVEN OF THE MODIFICATIONS.  Distribution of this code as
>part of a commercial system is permissible ONLY BY DIRECT ARRANGEMENT
>WITH THE AUTHOR.  (If you are not directly supplying this code to a
>customer, and you are instead telling them how they can obtain it for
>free, then you are not required to make any arrangement with me.)

Stuff like "no compensation is received", "part of a commercial system", etc.
sound rather non-Free to me and I doubt they'd get by legal.

See also https://github.com/glumpy/glumpy/issues/118

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 769487] Review Request: python-glumpy - Small python library for rapid visualization of numpy arrays

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=769487

Nicolas Chauvet (kwizart)  changed:

   What|Removed |Added

  Flags|fedora-review+  |fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 769487] Review Request: python-glumpy - Small python library for rapid visualization of numpy arrays

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=769487

Nicolas Chauvet (kwizart)  changed:

   What|Removed |Added

  Flags||fedora-review+



--- Comment #17 from Nicolas Chauvet (kwizart)  ---
Okay going forward with this.
I still cannot import glumpy , missing triangle:

https://pypi.python.org/pypi/triangle

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 769487] Review Request: python-glumpy - Small python library for rapid visualization of numpy arrays

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=769487



--- Comment #16 from Nicolas Chauvet (kwizart)  ---
Hi,
And sorry again for the long reply:
rpmlint ins't clean:

python3-glumpy.x86_64: W: spelling-error Summary(en_US) blosc -> blocs, bloc,
blossom
python3-glumpy.x86_64: W: spelling-error %description -l en_US blosc -> blocs,
bloc, blossom
python3-glumpy.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python3.5/site-packages/glumpy/ext/sdf/sdf.h
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
rpmlint python2-glumpy
python2-glumpy.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python2.7/site-packages/glumpy/ext/sdf/sdf.h
1 packages and 0 specfiles checked; 0 errors, 1 warnings.


The python3 description is not accurate.

Is there work for packaging python-triangle ?
I also found that you might be able to use ImageMagick and ffmpeg, but the
latter cannot be used as Recommands

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 769487] Review Request: python-glumpy - Small python library for rapid visualization of numpy arrays

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=769487



--- Comment #15 from Thibault North  ---
Hu, there is a missing dependency to triangle that I didn't spot:
http://dzhelil.info/triangle/index.html

Looks like python-triangle needs to be packaged first (as well as the
underlining C library?)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 769487] Review Request: python-glumpy - Small python library for rapid visualization of numpy arrays

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=769487



--- Comment #14 from Thibault North  ---
Hi Nicolas,
Thanks for the review. 
The package was indeed really outdated, here is an updated version with py2 and
py3 support:

http://tnorth.fedorapeople.org/python-glumpy-1.0.6-1.fc24.src.rpm

There is also a scratch build here:
http://koji.fedoraproject.org/koji/taskinfo?taskID=15889442

This needs yet another review :-)

Thanks,

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 769487] Review Request: python-glumpy - Small python library for rapid visualization of numpy arrays

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=769487

Nicolas Chauvet (kwizart)  changed:

   What|Removed |Added

  Flags|needinfo?(kwiz...@gmail.com |
   |)   |



--- Comment #13 from Nicolas Chauvet (kwizart)  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package contains BR: python2-devel or python3-devel
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file COPYING.txt is not marked as %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
- Changelog: Fix missing space indent with "initial spec file"
- You might need to package for both python2/3 stacks
- Probably a missing requires when importing scipy.weave
- Update the requires to the current package name (python2-pyopengl, etc).


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (3 clause)", "BSD (2 clause)", "CeCILL", "BSL (v1)",
 "Unknown or generated". 19 files have unknown license. Detailed output
 of licensecheck in /home/builder/769487-python-glumpy/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
 Note: rm -rf %{buildroot} present but not required
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[!]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[!]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 839680 bytes in 32 files.
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[!]: Package meets the Packaging Guidelines::Python
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[!]: Sources can be downloaded from URI in Source: tag
 Note: Could not download Source0:
 http://glumpy.googlecode.com/files/glumpy-0.2.1.tar.gz
 See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query 

[Bug 769487] Review Request: python-glumpy - Small python library for rapid visualization of numpy arrays

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=769487



--- Comment #12 from Nicolas Chauvet (kwizart)  ---
Thx for the reminder. I was very busy these time with a certain 3rd part
repository migration. But I should be more responsible now.

I will provide a formal review from the current state of the spec in a few.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 769487] Review Request: python-glumpy - Small python library for rapid visualization of numpy arrays

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=769487

Charalampos Stratakis  changed:

   What|Removed |Added

  Flags||needinfo?(kwiz...@gmail.com
   ||)



--- Comment #11 from Charalampos Stratakis  ---
Current version is 1.0.6 now and project is hosted on [0] and pypi[1]

Nicholas is it possible to continue with the review or should someone else take
it?

[0]https://github.com/glumpy/glumpy
[1]https://pypi.python.org/pypi/glumpy

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 769487] Review Request: python-glumpy - Small python library for rapid visualization of numpy arrays

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=769487

Thibault North  changed:

   What|Removed |Added

  Flags|needinfo?(thibault.north@gm |
   |ail.com)|



--- Comment #10 from Thibault North  ---
Nope, haven't had time to look into it yet. Any help appreciated!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 769487] Review Request: python-glumpy - Small python library for rapid visualization of numpy arrays

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=769487

Charalampos Stratakis  changed:

   What|Removed |Added

 CC||cstra...@redhat.com,
   ||thibault.no...@gmail.com
  Flags||needinfo?(thibault.north@gm
   ||ail.com)



--- Comment #9 from Charalampos Stratakis  ---
Project seems active on github now. Any movements on the package?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 769487] Review Request: python-glumpy - Small python library for rapid visualization of numpy arrays

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=769487

--- Comment #8 from Thibault North thibault.no...@gmail.com ---
Hmm no spec update, because no new release was prepared upstream. 
Do the last upstream commits fix your crash problem ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=aUiOhFb5i4a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 769487] Review Request: python-glumpy - Small python library for rapid visualization of numpy arrays

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=769487

--- Comment #7 from Nicolas Chauvet (kwizart) kwiz...@gmail.com ---
Sorry for such long review.

The last time I tried to runtime test this, I've experienced a very bad crash.
I can test it with nvidia and intel hardware.  Is there any spec update ? (this
seems the last upstream version).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=GkxyBssOwTa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 769487] Review Request: python-glumpy - Small python library for rapid visualization of numpy arrays

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=769487

--- Comment #6 from Thibault North thibault.no...@gmail.com 2012-01-30 
21:05:59 EST ---
That is right, thank you.

Some fixes regarding the requires have been made.
Spec URL: http://tnorth.fedorapeople.org/python-glumpy.spec
SRPM URL: http://tnorth.fedorapeople.org/python-glumpy-0.2.1-3.fc15.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 769487] Review Request: python-glumpy - Small python library for rapid visualization of numpy arrays

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=769487

--- Comment #5 from Thomas Spura toms...@fedoraproject.org 2012-01-10 
04:48:46 EST ---
(In reply to comment #3)
 - Included ipython

Why? I don't see a import IPython in the sources...

Maybe because of this: (???)

You will also need IPython (http://ipython.scipy.org/) for running interactive
sessions where you can interact with glumpy.
 (from http://code.google.com/p/glumpy/)

When you want any interactive sessions, you need the proper python interpreter
or ipython, but that shouldn't be a reason to R ipython...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 769487] Review Request: python-glumpy - Small python library for rapid visualization of numpy arrays

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=769487

Volker Fröhlich volke...@gmx.at changed:

   What|Removed |Added

 CC||volke...@gmx.at

--- Comment #2 from Volker Fröhlich volke...@gmx.at 2012-01-09 08:54:06 EST 
---
The spec looks pretty good. A few comments:

- Usually Name comes before Summary
- Is Development/Languages really the correct group?
- You could shorten that for-loop by using sed -i there as well.
- Did you consider to Require ipython?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 769487] Review Request: python-glumpy - Small python library for rapid visualization of numpy arrays

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=769487

--- Comment #3 from Thibault North thibault.no...@gmail.com 2012-01-09 
09:22:30 EST ---
Thanks.
- Name position: fixed
- Indeed, that's not the good group. I forgot to change that one. What about
Development/Libraries ? (same as matplotlib)
- The for loop was used to keep the original timestamps. Does it matter?
- Included ipython

Spec URL: http://tnorth.fedorapeople.org/python-glumpy.spec
SRPM URL: http://tnorth.fedorapeople.org/python-glumpy-0.2.1-2.fc15.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 769487] Review Request: python-glumpy - Small python library for rapid visualization of numpy arrays

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=769487

--- Comment #4 from Volker Fröhlich volke...@gmx.at 2012-01-09 10:20:29 EST 
---
No, I don't think it matters.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 769487] Review Request: python-glumpy - Small python library for rapid visualization of numpy arrays

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=769487

Nicolas Chauvet (kwizart) kwiz...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||kwiz...@gmail.com
 AssignedTo|nob...@fedoraproject.org|kwiz...@gmail.com

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 769487] Review Request: python-glumpy - Small python library for rapid visualization of numpy arrays

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=769487

Thomas Spura toms...@fedoraproject.org changed:

   What|Removed |Added

 CC||toms...@fedoraproject.org

--- Comment #1 from Thomas Spura toms...@fedoraproject.org 2011-12-22 
05:21:13 EST ---
Nice program :)

Also run into the same problem like you:
http://code.google.com/p/glumpy/issues/detail?id=13

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review