[Bug 769919] Review Request: hydra - Very fast network log-on cracker
https://bugzilla.redhat.com/show_bug.cgi?id=769919 Michal Ambroz changed: What|Removed |Added Alias|hydra | --- Comment #44 from Michal Ambroz --- removing alias so bugzilla can be searched for hydra -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 769919] Review Request: hydra - Very fast network log-on cracker
https://bugzilla.redhat.com/show_bug.cgi?id=769919 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Af7KhxxppWa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769919] Review Request: hydra - Very fast network log-on cracker
https://bugzilla.redhat.com/show_bug.cgi?id=769919 Athmane Madjoudj athma...@gmail.com changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #42 from Athmane Madjoudj athma...@gmail.com --- Package Change Request == Package Name: hydra New Branches: el6 Owners: athmane -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PBeObXFhTta=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769919] Review Request: hydra - Very fast network log-on cracker
https://bugzilla.redhat.com/show_bug.cgi?id=769919 --- Comment #41 from Fedora Update System upda...@fedoraproject.org --- hydra-7.3-10.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769919] Review Request: hydra - Very fast network log-on cracker
https://bugzilla.redhat.com/show_bug.cgi?id=769919 --- Comment #40 from Fedora Update System upda...@fedoraproject.org --- hydra-7.3-10.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/hydra-7.3-10.fc16 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769919] Review Request: hydra - Very fast network log-on cracker
https://bugzilla.redhat.com/show_bug.cgi?id=769919 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769919] Review Request: hydra - Very fast network log-on cracker
https://bugzilla.redhat.com/show_bug.cgi?id=769919 --- Comment #37 from Fedora Update System upda...@fedoraproject.org --- hydra-7.3-9.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/hydra-7.3-9.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769919] Review Request: hydra - Very fast network log-on cracker
https://bugzilla.redhat.com/show_bug.cgi?id=769919 --- Comment #38 from Fedora Update System upda...@fedoraproject.org --- hydra-7.3-9.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/hydra-7.3-9.fc16 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769919] Review Request: hydra - Very fast network log-on cracker
https://bugzilla.redhat.com/show_bug.cgi?id=769919 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |ERRATA Last Closed||2012-05-27 21:21:43 --- Comment #39 from Fedora Update System upda...@fedoraproject.org --- hydra-7.3-9.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769919] Review Request: hydra - Very fast network log-on cracker
https://bugzilla.redhat.com/show_bug.cgi?id=769919 Michal Ambroz re...@seznam.cz changed: What|Removed |Added Assignee|nob...@fedoraproject.org|re...@seznam.cz --- Comment #33 from Michal Ambroz re...@seznam.cz --- Kevin thank you for information. If Athmane is already sponsored, I can take the review of the package. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769919] Review Request: hydra - Very fast network log-on cracker
https://bugzilla.redhat.com/show_bug.cgi?id=769919 Michal Ambroz re...@seznam.cz changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769919] Review Request: hydra - Very fast network log-on cracker
https://bugzilla.redhat.com/show_bug.cgi?id=769919 Michal Ambroz re...@seznam.cz changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769919] Review Request: hydra - Very fast network log-on cracker
https://bugzilla.redhat.com/show_bug.cgi?id=769919 --- Comment #34 from Michal Ambroz re...@seznam.cz --- ACCEPT In my opinion the package is ready to be accepted for Fedora. Athmane please when you will be raising SCM admin request, put my id rebus to the InitialCC field. http://fedoraproject.org/wiki/Package_SCM_admin_requests -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769919] Review Request: hydra - Very fast network log-on cracker
https://bugzilla.redhat.com/show_bug.cgi?id=769919 Michal Ambroz re...@seznam.cz changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769919] Review Request: hydra - Very fast network log-on cracker
https://bugzilla.redhat.com/show_bug.cgi?id=769919 Athmane Madjoudj athma...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #35 from Athmane Madjoudj athma...@gmail.com --- New Package SCM Request === Package Name: hydra Short Description: Very fast network log-on cracker Owners: athmane Branches: f16 f17 InitialCC: rebus -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769919] Review Request: hydra - Very fast network log-on cracker
https://bugzilla.redhat.com/show_bug.cgi?id=769919 --- Comment #36 from Kevin Fenzi ke...@scrye.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769919] Review Request: hydra - Very fast network log-on cracker
https://bugzilla.redhat.com/show_bug.cgi?id=769919 Kevin Fenzi ke...@scrye.com changed: What|Removed |Added Blocks|177841 | --- Comment #32 from Kevin Fenzi ke...@scrye.com --- I've sponsored Athmane, removing FE_NEEDSPONSOR. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769919] Review Request: hydra - Very fast network log-on cracker
https://bugzilla.redhat.com/show_bug.cgi?id=769919 --- Comment #31 from Michal Ambroz re...@seznam.cz --- Hi Athmane, I have not found any other issues other then those, which have already been fixed or reported to upstream. From my point of view the package is OK. Good luck with searching for sponsor. Michal Ambroz -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769919] Review Request: hydra - Very fast network log-on cracker
https://bugzilla.redhat.com/show_bug.cgi?id=769919 --- Comment #29 from Michal Ambroz re...@seznam.cz --- Hello Athmane, please leave the release number (9) as it is now, but for next upstream versions the release should always reset to 1. http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Release_Tag Thank you Michal Ambroz -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769919] Review Request: hydra - Very fast network log-on cracker
https://bugzilla.redhat.com/show_bug.cgi?id=769919 --- Comment #30 from Athmane Madjoudj athma...@gmail.com --- (In reply to comment #29) Hello Athmane, please leave the release number (9) as it is now, but for next upstream versions the release should always reset to 1. http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Release_Tag I didn't reset release number to 1 because 7.3 is a bugfix release (ie. no major changes), I'll do it next time, thanks. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769919] Review Request: hydra - Very fast network log-on cracker
https://bugzilla.redhat.com/show_bug.cgi?id=769919 --- Comment #28 from Athmane Madjoudj athma...@gmail.com --- New upstream release (7.3): SPEC: http://athmane.fedorapeople.org/pkgs/hydra.spec SRPM: http://athmane.fedorapeople.org/pkgs/hydra-7.3-9.fc17.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4095451 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769919] Review Request: hydra - Very fast network log-on cracker
https://bugzilla.redhat.com/show_bug.cgi?id=769919 --- Comment #27 from Michal Ambroz re...@seznam.cz --- Thank you Athmane. By me everything is OK. Good luck with searching for sponsor. Best regards Michal Ambroz -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769919] Review Request: hydra - Very fast network log-on cracker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769919 --- Comment #24 from Athmane Madjoudj athma...@gmail.com 2012-05-18 19:13:12 EDT --- (In reply to comment #23) snip Summary: - Generally I would say the package is good and ready to be accepted. There are only minor easy-to fix glitches - Please fix these issues: - use postgres header files from the installed postgresql-devel package - add dir of /usr/share/hydra - include LICENSE.OPENSSL as doc - please inform the upstream about the wrong address of FSF in hmacmd5 files Fixed those issues, also synced with upstream (informed him about wrong FSF address, submitted postgres patch and suggested to remove the bundled postgres headers) SPEC: http://athmane.fedorapeople.org/pkgs/hydra.spec SRPM: http://athmane.fedorapeople.org/pkgs/hydra-7.2-8.fc16.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4087791 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769919] Review Request: hydra - Very fast network log-on cracker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769919 --- Comment #25 from Athmane Madjoudj athma...@gmail.com 2012-05-18 20:39:45 EDT --- According licensing matrices [1]: - Public Domain (not a license) is compatible with GPLv2+ and GPLv3+ - GPLv2+ is compatible GPLv3+ [1] http://fedoraproject.org/wiki/Licensing -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769919] Review Request: hydra - Very fast network log-on cracker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769919 Athmane Madjoudj athma...@gmail.com changed: What|Removed |Added CC||tcall...@redhat.com --- Comment #26 from Athmane Madjoudj athma...@gmail.com 2012-05-18 20:40:42 EDT --- CCing Tom 'spot' Callaway -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769919] Review Request: hydra - Very fast network log-on cracker
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=769919
--- Comment #23 from Michal Ambroz re...@seznam.cz 2012-05-17 20:46:24 EDT ---
Hello,
unfortunately I am not sponsor so I can provide only with the informal
non-authoritative review.
Package Review
==
Generated by fedora-review 0.1.3 + manual review
Key:
- = N/A
x = Pass (by automated check)
X = Pass (manual check)
! = Fail
? = Not evaluated / Needs attention
C/C++
[x]: MUST Header files in -devel subpackage, if present.
[x]: MUST Package does not contain any libtool archives (.la)
[X]: MUST Package does not contain kernel modules.
[X]: MUST Package contains no static executables.
[X]: MUST Rpath absent or only used for internal libs.
[X]: MUST Package is not relocatable.
Generic
[X?]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
- package released under GPLv3+ with exemption allowing linking with openssl
- contains GPLv2+ code and publi domain code
- exceptions were sufficient for the license to be accepted to Debian
- I would recommend to cross check with Tom 'spot' Callaway
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
- koji build is referenced in the review request
- I have successfully re-build package for Fedora 17
[X]: MUST %build honors applicable compiler flags or justifies otherwise.
- Makefile.am is patched to include CFLAGS in OPTS, OPTS are used in
Makefile then
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[!]: MUST Package contains no bundled libraries.
- package doesn't contain bundled libraries, but it contains header files
from PostgreSQL
- I would recommend to patch to use the header files from the installed
postgresql-devel package
- similar patch is contained in debian
http://packages.debian.org/source/testing/hydra
[X]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL is required
[X]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[X]: MUST Macros in Summary, %description expandable at SRPM build time.
[X]: MUST Package contains a properly installed %{name}.desktop using desktop-
file-install file if it is a GUI application.
[X]: MUST Package requires other packages for directories it uses.
[X]: MUST Package uses nothing in %doc for runtime.
[-]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Fully versioned dependency in subpackages, if present.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
[-]: MUST Large documentation files are in a -doc subpackage, if required.
[!]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
- file LICENSE.OPENSSL is missing in the doc
[X]: MUST License field in the package spec file matches the actual license.
[X]: MUST License file installed when any subpackage combination is installed.
[X]: MUST Package consistently uses macros (instead of hard-coded directory
names).
[x]: MUST Package is named according to the Package Naming Guidelines.
[X]: MUST Package does not generate any conflict.
[X]: MUST Package obeys FHS, except libexecdir and /usr/target.
[!]: MUST Package must own all directories that it creates.
- directory /usr/share/hydra should be owned with the %dir directive
[X]: MUST Package does not own files or directories owned by other packages.
[X]: MUST Package installs properly.
[-]: MUST Requires correct, justified where necessary.
[X?]: MUST Rpmlint output is silent.
- please notify the upstream about the incorrect fsf addreass
- other than that i believe it is good
rpmlint hydra-debuginfo-7.2-7.fc17.x86_64.rpm
hydra-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/hydra-7.2-src/hmacmd5.h
hydra-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/hydra-7.2-src/hmacmd5.c
1 packages and 0 specfiles checked; 2 errors, 0 warnings.
rpmlint
[Bug 769919] Review Request: hydra - Very fast network log-on cracker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769919 --- Comment #22 from Michal Ambroz re...@seznam.cz 2012-04-30 04:08:39 EDT --- Thank you ... dpl4hydra works fine for me now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769919] Review Request: hydra - Very fast network log-on cracker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769919 --- Comment #18 from Athmane Madjoudj athma...@gmail.com 2012-04-16 19:19:33 EDT --- I've reversed a patch because it breaks brute-forcing NTLM-enabled services (upstream confirmed that it's not necessary) SPEC: http://athmane.fedorapeople.org/pkgs/hydra.spec SRPM: http://athmane.fedorapeople.org/pkgs/hydra-7.2-6.fc16.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3996524 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769919] Review Request: hydra - Very fast network log-on cracker
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=769919
--- Comment #19 from Michal Ambroz re...@seznam.cz 2012-04-16 20:11:40 EDT ---
Created attachment 577860
-- https://bugzilla.redhat.com/attachment.cgi?id=577860
hydra-7.2-destdir.patch
Tested now on Fedora 17 and it works (tested ssh and mysql) - thanks.
Please would you consider adding the dpl2hydra files to the package? It can be
usefull.
%{_bindir}/dpl4hydra.sh
%{_datadir}/%{name}/dpl4hydra*.csv
Attached is a patch which I use for the DESTDIR install and putting the csv
database to /usr/share/hydra directory.
Best regards
Michal Ambroz
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769919] Review Request: hydra - Very fast network log-on cracker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769919 --- Comment #20 from Michal Ambroz re...@seznam.cz 2012-04-16 20:28:43 EDT --- (In reply to comment #15) - Added mysql support (I need to investigate more on this because it does not seem to find a valid user/pass against mysql server 5.5.x) BTW I was testing against mysql server 5.5.22 from Fedora 17 and seemd to worked fine for me with small dictionary containing the right password in dozen of other words. Problem is that it reports false positives also on some other words if you use bigger dictionary. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769919] Review Request: hydra - Very fast network log-on cracker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769919 --- Comment #21 from Athmane Madjoudj athma...@gmail.com 2012-04-16 21:40:51 EDT --- Thanks Michal, I've included dpl4hydra and added the patch for DESTDIR. SPEC: http://athmane.fedorapeople.org/pkgs/hydra.spec SRPM: http://athmane.fedorapeople.org/pkgs/hydra-7.2-7.fc16.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3996813 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769919] Review Request: hydra - Very fast network log-on cracker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769919 --- Comment #14 from Athmane Madjoudj athma...@gmail.com 2012-03-13 04:35:28 EDT --- (In reply to comment #13) Yes, it fails, if mysql-devel is installed. Can you solve that? That error appears because 'hash_password' and 'scramble' are defined in the headers but not exposed by libmysql. I have a workaround for that issue, just testing it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769919] Review Request: hydra - Very fast network log-on cracker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769919 --- Comment #15 from Athmane Madjoudj athma...@gmail.com 2012-03-13 09:24:57 EDT --- - Fixed compilation warnings (important one). - Added mysql support (I need to investigate more on this because it does not seem to find a valid user/pass against mysql server 5.5.x) SPEC: http://athmane.fedorapeople.org/pkgs/hydra.spec SRPM: http://athmane.fedorapeople.org/pkgs/hydra-7.2-5.fc16.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=342 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769919] Review Request: hydra - Very fast network log-on cracker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769919 --- Comment #16 from Athmane Madjoudj athma...@gmail.com 2012-03-13 09:46:46 EDT --- (In reply to comment #15) (I need to investigate more on this because it does not seem to find a valid user/pass against mysql server 5.5.x) Nevermind, I had the same issue with a package from other distro (it's an issue with hydra-mysql itself). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769919] Review Request: hydra - Very fast network log-on cracker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769919 --- Comment #17 from Athmane Madjoudj athma...@gmail.com 2012-03-13 13:11:57 EDT --- Upstream responded that he'll include the patchs/fixes. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769919] Review Request: hydra - Very fast network log-on cracker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769919 --- Comment #13 from Volker Fröhlich volke...@gmx.at 2012-03-11 18:51:00 EDT --- Yes, it fails, if mysql-devel is installed. Can you solve that? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769919] Review Request: hydra - Very fast network log-on cracker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769919 --- Comment #11 from Volker Fröhlich volke...@gmx.at 2012-03-08 13:56:12 EST --- Hm, I don't feel very happy about having to install PostgreSQL and Firebird libraries, just to be able to use this program for SVN, for instance. There is at least some GPLv3+ code. Have you dug through the code? It is quite a mixture, but I assume GPLv3+ as the overall license could be fine. Please preserve the timestamps for the manpages and the icon (-p). What is the group X-Red-Hat-Base for? There are several format warnings when you compile the code. Try to fix them and submit it to upstream. On my F16 64 bit system a build with rpmbuild fails for some reason, while it works with Mock. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769919] Review Request: hydra - Very fast network log-on cracker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769919 --- Comment #12 from Athmane Madjoudj athma...@gmail.com 2012-03-08 14:48:04 EST --- (In reply to comment #11) Hm, I don't feel very happy about having to install PostgreSQL and Firebird libraries, just to be able to use this program for SVN, for instance. It's a multi-protocols brute-forcer, there's a similar package in fedora 'medusa', packaged in the same way even if it has a modular architecture (.so for each service, but the package depends on libssh2, postgresql libs etc...), hydra is on binary :/. There is at least some GPLv3+ code. Have you dug through the code? It is quite a mixture, but I assume GPLv3+ as the overall license could be fine. It seems to be 'GPLv3 with exceptions' (because of OpenSSL), I checked with Gentoo (GPL-3) and Debian (GPL-3.0+ with OpenSSL exception) Please preserve the timestamps for the manpages and the icon (-p). Fixed in -4 What is the group X-Red-Hat-Base for? Removed in -4, There are several format warnings when you compile the code. Try to fix them and submit it to upstream. I noticed them when I enabled CFLAGS, I'm using this build at work and it seems very stable (heavily tested with SSH and FTP), but I'll try to help upstream to fix them (along with mysql and CFLAGS support) On my F16 64 bit system a build with rpmbuild fails for some reason, while it works with Mock. Maybe you have mysql-devel, can attach the errors SPEC: http://athmane.fedorapeople.org/pkgs/hydra.spec SRPM: http://athmane.fedorapeople.org/pkgs/hydra-7.2-4.fc16.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3870495 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769919] Review Request: hydra - Very fast network log-on cracker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769919 --- Comment #5 from Athmane Madjoudj athma...@gmail.com 2012-02-11 15:47:32 EST --- New upstream release (7.2): Spec URL: http://athmane.fedorapeople.org/pkgs/hydra.spec SRPM URL: http://athmane.fedorapeople.org/pkgs/hydra-7.2-1.fc16.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3783373 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769919] Review Request: hydra - Very fast network log-on cracker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769919 Volker Fröhlich volke...@gmx.at changed: What|Removed |Added CC||volke...@gmx.at --- Comment #6 from Volker Fröhlich volke...@gmx.at 2012-02-11 17:42:38 EST --- Just a couple of comments: As MySQL 4 seemingly doesn't work, consider to remove MySQL from the description. Do you leave out support for Firebird for a reason? Looking at the build, the optflags aren't actually used. Please remove The hydra package must be installed before installing the hydra front end., as dependency resolution takes care of that. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769919] Review Request: hydra - Very fast network log-on cracker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769919 --- Comment #7 from Athmane Madjoudj athma...@gmail.com 2012-02-11 18:18:09 EST --- Thanks for your comments, (In reply to comment #6) Just a couple of comments: As MySQL 4 seemingly doesn't work, consider to remove MySQL from the description. Fixed, removed the protocols list since it's in constant change. Do you leave out support for Firebird for a reason? Fixed, added support for Firebird Looking at the build, the optflags aren't actually used. Yes they are not used, I can ask upstream to use CFLAGS if it's necessary. Please remove The hydra package must be installed before installing the hydra front end., as dependency resolution takes care of that. Fixed New URLs: Spec URL: http://athmane.fedorapeople.org/pkgs/hydra.spec SRPM URL: http://athmane.fedorapeople.org/pkgs/hydra-7.2-2.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769919] Review Request: hydra - Very fast network log-on cracker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769919 --- Comment #8 from Volker Fröhlich volke...@gmx.at 2012-02-11 18:42:47 EST --- Please use the compiler flags from the rpm configuration. Asking upstream to include it wouldn't hurt though, I guess. http://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769919] Review Request: hydra - Very fast network log-on cracker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769919 --- Comment #9 from Athmane Madjoudj athma...@gmail.com 2012-02-11 19:22:09 EST --- (In reply to comment #8) Please use the compiler flags from the rpm configuration. Asking upstream to include it wouldn't hurt though, I guess. http://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags I've added a workaround to force CFLAGS: Spec URL: http://athmane.fedorapeople.org/pkgs/hydra.spec SRPM URL: http://athmane.fedorapeople.org/pkgs/hydra-7.2-3.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769919] Review Request: hydra - Very fast network log-on cracker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769919 --- Comment #10 from Athmane Madjoudj athma...@gmail.com 2012-02-11 19:29:00 EST --- Koji scratch build (to check CFLAGS and Firebird support): http://koji.fedoraproject.org/koji/taskinfo?taskID=3783454 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769919] Review Request: hydra - Very fast network log-on cracker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769919 Athmane Madjoudj athma...@gmail.com changed: What|Removed |Added Alias||hydra -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769919] Review Request: hydra - Very fast network log-on cracker
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=769919
--- Comment #4 from Athmane Madjoudj athma...@gmail.com 2011-12-27 13:41:57
EST ---
Removed rm -rf %{buildroot} from %install
Spec URL: http://athmane.fedorapeople.org/pkgs/hydra.spec
SRPM URL: http://athmane.fedorapeople.org/pkgs/hydra-7.1-3.fc16.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769919] Review Request: hydra - Very fast network log-on cracker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769919 Athmane Madjoudj athma...@gmail.com changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR), ||563471(FE-SECLAB) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769919] Review Request: hydra - Very fast network log-on cracker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769919 --- Comment #1 from Athmane Madjoudj athma...@gmail.com 2011-12-22 13:30:35 EST --- rpmlint output: $ rpmlint hydra-7.1-1.fc16.src.rpm hydra.src: W: spelling-error %description -l en_US parallelized - paralleled, palatalized, pluralized hydra.src: W: spelling-error %description -l en_US auth - auto, Ruth, author 1 packages and 0 specfiles checked; 0 errors, 2 warnings. $ rpmlint hydra-7.1-1.fc16.x86_64.rpm hydra.x86_64: W: spelling-error %description -l en_US parallelized - paralleled, palatalized, pluralized hydra.x86_64: W: spelling-error %description -l en_US auth - auto, Ruth, author 1 packages and 0 specfiles checked; 0 errors, 2 warnings. $ rpmlint hydra-frontend-7.1-1.fc16.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint hydra.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769919] Review Request: hydra - Very fast network log-on cracker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769919 --- Comment #2 from Athmane Madjoudj athma...@gmail.com 2011-12-22 14:07:53 EST --- Updated license to 'GPLv3 with exceptions' since it seems to be GPLv3 with OpenSSL exception Spec URL: http://athmane.fedorapeople.org/pkgs/hydra.spec SRPM URL: http://athmane.fedorapeople.org/pkgs/hydra-7.1-2.fc16.src.rpm rpmlint output: $ rpmtlint hydra-7.1-2.fc16.src.rpm hydra.src: W: spelling-error %description -l en_US parallelized - paralleled, palatalized, pluralized hydra.src: W: spelling-error %description -l en_US auth - auto, Ruth, author 1 packages and 0 specfiles checked; 0 errors, 2 warnings. $ rpmtlint hydra-7.1-2.fc16.x86_64.rpm hydra.x86_64: W: spelling-error %description -l en_US parallelized - paralleled, palatalized, pluralized hydra.x86_64: W: spelling-error %description -l en_US auth - auto, Ruth, author 1 packages and 0 specfiles checked; 0 errors, 2 warnings. $ rpmtlint hydra-frontend-7.1-2.fc16.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmtlint hydra.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 769919] Review Request: hydra - Very fast network log-on cracker
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=769919 --- Comment #3 from Athmane Madjoudj athma...@gmail.com 2011-12-22 15:16:46 EST --- Koji scratch build (x86_64 and i686): http://koji.fedoraproject.org/koji/taskinfo?taskID=3601861 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
