[Bug 770129] Review Request: drupal7-workbench - Provides overall improvements for managing content
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770129 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|drupal7-workbench-1.1-1.fc1 |drupal7-workbench-1.1-1.el5 |5 | --- Comment #10 from Fedora Update System upda...@fedoraproject.org 2012-01-15 18:21:24 EST --- drupal7-workbench-1.1-1.el5 has been pushed to the Fedora EPEL 5 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770129] Review Request: drupal7-workbench - Provides overall improvements for managing content
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770129 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|drupal7-workbench-1.1-1.el5 |drupal7-workbench-1.1-1.el6 --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2012-01-15 18:26:47 EST --- drupal7-workbench-1.1-1.el6 has been pushed to the Fedora EPEL 6 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770129] Review Request: drupal7-workbench - Provides overall improvements for managing content
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770129 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version||drupal7-workbench-1.1-1.fc1 ||6 Resolution|NEXTRELEASE |ERRATA --- Comment #8 from Fedora Update System upda...@fedoraproject.org 2012-01-11 01:04:51 EST --- drupal7-workbench-1.1-1.fc16 has been pushed to the Fedora 16 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770129] Review Request: drupal7-workbench - Provides overall improvements for managing content
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770129 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|drupal7-workbench-1.1-1.fc1 |drupal7-workbench-1.1-1.fc1 |6 |5 --- Comment #9 from Fedora Update System upda...@fedoraproject.org 2012-01-11 01:05:38 EST --- drupal7-workbench-1.1-1.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770129] Review Request: drupal7-workbench - Provides overall improvements for managing content
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770129 --- Comment #3 from Jon Ciesla limburg...@gmail.com 2011-12-27 11:36:21 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770129] Review Request: drupal7-workbench - Provides overall improvements for managing content
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770129 Peter Borsa peter.bo...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #2 from Peter Borsa peter.bo...@gmail.com 2011-12-27 08:22:23 EST --- New Package SCM Request === Package Name: drupal7-workbench Short Description: Provides overall improvements for managing content Owners: asrob sdodson Branches: f15 f16 el5 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770129] Review Request: drupal7-workbench - Provides overall improvements for managing content
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770129 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770129] Review Request: drupal7-workbench - Provides overall improvements for managing content
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770129 --- Comment #4 from Fedora Update System upda...@fedoraproject.org 2011-12-27 15:57:28 EST --- drupal7-workbench-1.1-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/drupal7-workbench-1.1-1.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770129] Review Request: drupal7-workbench - Provides overall improvements for managing content
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770129 --- Comment #5 from Fedora Update System upda...@fedoraproject.org 2011-12-27 16:06:09 EST --- drupal7-workbench-1.1-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/drupal7-workbench-1.1-1.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770129] Review Request: drupal7-workbench - Provides overall improvements for managing content
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770129 --- Comment #6 from Fedora Update System upda...@fedoraproject.org 2011-12-27 16:12:41 EST --- drupal7-workbench-1.1-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/drupal7-workbench-1.1-1.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770129] Review Request: drupal7-workbench - Provides overall improvements for managing content
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770129 --- Comment #7 from Fedora Update System upda...@fedoraproject.org 2011-12-27 16:21:18 EST --- drupal7-workbench-1.1-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/drupal7-workbench-1.1-1.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770129] Review Request: drupal7-workbench - Provides overall improvements for managing content
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770129 Peter Borsa peter.bo...@gmail.com changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution||NEXTRELEASE Last Closed||2011-12-27 16:22:55 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770129] Review Request: drupal7-workbench - Provides overall improvements for managing content
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=770129
Scott Dodson sdod...@sdodson.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||sdod...@sdodson.com
AssignedTo|nob...@fedoraproject.org|sdod...@sdodson.com
Flag||fedora-review+
--- Comment #1 from Scott Dodson sdod...@sdodson.com 2011-12-26 19:47:41 EST
---
[ O K ] MUST: rpmlint must be run on every package. The output should be posted
in the review.
$ rpmlint drupal7-workbench.spec ~/rpmbuild/RPMS/noarch/drupal7-workbench-1.
drupal7-workbench-1.0-1.fc15.noarch.rpm
drupal7-workbench-1.0-1.fc16.noarch.rpm
drupal7-workbench-1.1-1.fc16.noarch.rpm
[sdodson@sdodson SPECS]$ rpmlint drupal7-workbench.spec
~/rpmbuild/RPMS/noarch/drupal7-workbench-1.1-1.fc16.noarch.rpm
~/rpmbuild/SRPMS/drupal7-workbench-1.1-1.fc16.src.rpm
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
[ O K ] MUST: The package must be named according to the Package Naming
Guidelines.
[ O K ] MUST: The spec file name must match the base package %{name}, in the
format %{name}.spec unless your package has an exemption.
[ O K ] MUST: The package must meet the Packaging Guidelines.
[ O K ] MUST: The package must be licensed with a Fedora approved license and
meet the Licensing Guidelines.
[ O K ] MUST: The License field in the package spec file must match the actual
license.
[ O K ] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[ O K ] MUST: The spec file must be written in American English.
[ O K ] MUST: The spec file for the package MUST be legible.
[ O K ] MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use md5sum for this task.
If no upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
$ md5sum ../SOURCES/workbench-7.x-1.1.tar.gz ; curl -s -o -
http://ftp.drupal.org/files/projects/workbench-7.x-1.1.tar.gz | md5sum
d013d19898d1f60a0707b137ae9084e6 ../SOURCES/workbench-7.x-1.1.tar.gz
d013d19898d1f60a0707b137ae9084e6 -
[ O K ] MUST: The package MUST successfully compile and build into binary rpms
on at least one primary architecture.
[ N/A ] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[ O K ] MUST: All build dependencies must be listed in BuildRequires, except
for any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[ O K ] MUST: The spec file MUST handle locales properly. This is done by using
the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[ N/A ] MUST: Every binary RPM package (or subpackage) which stores shared
library files (not just symlinks) in any of the dynamic linker's default paths,
must call ldconfig in %post and %postun.
[ O K ] MUST: Packages must NOT bundle copies of system libraries.
[ N/A ] MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[ O K ] MUST: A package must own all directories that it creates. If it does
not create a directory that it uses, then it should require a package which
does create that directory.
[ O K ] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations)
[ O K ] MUST: Permissions on files must be set properly. Executables should be
set with executable permissions, for example. Every %files section must include
a %defattr(...) line.
[ O K ] MUST: Each package must consistently use macros.
[ O K ] MUST: The package must contain code, or permissable content.
[ N/A ] MUST: Large documentation files must go in a -doc subpackage. (The
definition of large is left up to the packager's best judgement, but is not
restricted to size. Large can refer to either size or quantity).
[ O K ] MUST: If a package includes something as %doc, it must not affect the
runtime of the application. To summarize: If it is in %doc, the
[Bug 770129] Review Request: drupal7-workbench - Provides overall improvements for managing content
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770129 Peter Borsa peter.bo...@gmail.com changed: What|Removed |Added Blocks||662103(InsightReviews) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
