[Bug 770283] Review Request: uptimed - A daemon to record and keep track of system up times
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770283 Mattia changed: What|Removed |Added CC||mattia.ve...@tiscali.it --- Comment #1 from Mattia 2011-12-27 12:50:22 EST --- I think the subpackage is missing the 'Group' directive. A subpackage requires at least 'Summary', 'Group' and '%description' directives. See http://docs.fedoraproject.org/en-US/Fedora_Draft_Documentation/0.1/html/RPM_Guide/ch10s04.html -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770283] Review Request: uptimed - A daemon to record and keep track of system up times
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770283 --- Comment #2 from Tomasz Torcz 2011-12-28 06:46:21 EST --- Thank you, I've added Group: and Requires: on main package to -devel. Spec URL: http://pipebreaker.pl/dump/uptimed.spec SRPM URL: http://pipebreaker.pl/dump/uptimed-0.3.16-2.fc16.src.rpm Scratch : http://koji.fedoraproject.org/koji/taskinfo?taskID=3608256 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770283] Review Request: uptimed - A daemon to record and keep track of system up times
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=770283
Ivan Romanov changed:
What|Removed |Added
CC||dr...@land.ru
--- Comment #3 from Ivan Romanov 2011-12-31 11:25:05 EST ---
Hi Tomaz.
%clean stage can be dropped.
https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
use %defattr(-,root,root,-) instead of %defattr(-,root,root)
BuildRoot can be dropped.
https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
Your package doesn't provide any .h files. But it provides -devel subpackage. I
think you should use libuptimed/*.h
Your package doesn't provide /etc/init.d/uptimed file. But it works with
systemctl.
I think rm -rf "%{buildroot}" can be dropped. Really this command always are
doing when you use rpmbuild -bb some.spec
Can you provide -static subpackage? It's not necessarily but would be more
prefarable.
For directories use %dir in %files.
%dir %{_localstatedir}/spool/uptimed/
You must drop .la file
https://fedoraproject.org/wiki/Packaging/Guidelines#Packaging_Static_Libraries
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770283] Review Request: uptimed - A daemon to record and keep track of system up times
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770283 --- Comment #4 from Tomasz Torcz 2012-01-01 16:49:53 EST --- Hi Ivan, Thanks for your review. In -3, I've corrected everything except one thing. You are right about -devel package containing almost nothing. I've did it because rpmlint complained that libuptimed.so should go into separate package. During testing I've found out that uptimed works fine without this .so file. And after some analysis, it seems that library is here only because both uptimed (daemon) and uprecords (client) use the same functions. No other program is expected to use this API Therefore I'd rather drop this unversioned .so and -devel package. Would it be OK? Current spec: Spec URL: http://pipebreaker.pl/dump/uptimed.spec SRPM URL: http://pipebreaker.pl/dump/uptimed-0.3.16-3.fc16.src.rpm Scratch : http://koji.fedoraproject.org/koji/taskinfo?taskID=3613084 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770283] Review Request: uptimed - A daemon to record and keep track of system up times
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770283 --- Comment #5 from Ivan Romanov 2012-01-01 22:45:02 EST --- I've read your last changelog ... and I can't understand which changes you do? Please avoid such 'correct review issues'. It's prefer to describe every atomic changes in changelog. And to write explanations in comments above changes. Please correct changelog. Someone would want to use uptimed library for him owner program. But you are not providing him this feature. I think it is bad. My opinion packages should always provides -devel and -static subpackages when it is possible. In your case it looks as issue (devel library without headers) for upstream. I think you should to get explanations from upstream before we can continue review. You skipped question about /etc/init.d/uptimed. I think it's important. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770283] Review Request: uptimed - A daemon to record and keep track of system up times
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770283 --- Comment #6 from Tomasz Torcz 2012-01-02 01:34:15 EST --- uptimed.spec with corrected changelog is uploaded to above URL. I will ask upstream about devel issue and get back with info. For SysV init script, it is obsolete and I won't be providing it: "SysV Initscripts Packages may also provide a SysV initscript file, but are not required to do so. This format is considered legacy" from http://fedoraproject.org/wiki/Packaging:Systemd#Unit_Files -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770283] Review Request: uptimed - A daemon to record and keep track of system up times
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770283 --- Comment #7 from Tomasz Torcz 2012-01-09 17:50:28 EST --- Upstream did not answer for over a week. I've checked what other distribution do, and I will provide urec.h as uptimed.h in -devel package. Debian apparently does it this way for 7 years now. So, shipping uptimed.h is only change in -4 Spec URL: http://pipebreaker.pl/dump/uptimed.spec SRPM URL: http://pipebreaker.pl/dump/uptimed-0.3.16-4.fc16.src.rpm Scratch : http://koji.fedoraproject.org/koji/taskinfo?taskID=3634073 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770283] Review Request: uptimed - A daemon to record and keep track of system up times
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770283 --- Comment #9 from Ivan Romanov 2012-01-09 23:09:27 EST --- Correct summary and description for devel subpackage. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770283] Review Request: uptimed - A daemon to record and keep track of system up times
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=770283
--- Comment #8 from Ivan Romanov 2012-01-09 23:06:15 EST ---
use
Requires: %name%{?_isa} = %{epoch}:%{version}-%{release}
instead of
Requires: %name = %{epoch}:%{version}-%{release}
> MUST: In the vast majority of cases, devel packages must require the base
> package using a fully versioned dependency: Requires: %{name}%{?_isa} =
> %{version}-%{release}
http://fedoraproject.org/wiki/Packaging/Guidelines#RequiringBasePackage
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770283] Review Request: uptimed - A daemon to record and keep track of system up times
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=770283
--- Comment #10 from Tomasz Torcz 2012-01-14 06:59:18 EST ---
I've added %{?_isa} to -devel requires and mentioned headers in -devel
description/summary.
Spec URL: http://pipebreaker.pl/dump/uptimed.spec
SRPM URL: http://pipebreaker.pl/dump/uptimed-0.3.16-5.fc16.src.rpm
Scratch : http://koji.fedoraproject.org/koji/taskinfo?taskID=3675084
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770283] Review Request: uptimed - A daemon to record and keep track of system up times
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=770283
--- Comment #11 from Ivan Romanov 2012-01-14 08:16:36 EST ---
fail.
Requires: %{name}{?_isa} = %{epoch}:%{version}-%{release}
You skipped %
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770283] Review Request: uptimed - A daemon to record and keep track of system up times
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770283 --- Comment #12 from Tomasz Torcz 2012-01-14 09:21:48 EST --- Oh crap. Fixed in -6: Spec URL: http://pipebreaker.pl/dump/uptimed.spec SRPM URL: http://pipebreaker.pl/dump/uptimed-0.3.16-6.fc16.src.rpm Scratch : http://koji.fedoraproject.org/koji/taskinfo?taskID=3677407 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770283] Review Request: uptimed - A daemon to record and keep track of system up times
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770283 Ivan Romanov changed: What|Removed |Added Flag||fedora-review? --- Comment #13 from Ivan Romanov 2012-01-14 12:25:31 EST --- Ok. Now package looks good and I can start a review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770283] Review Request: uptimed - A daemon to record and keep track of system up times
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770283 Ivan Romanov changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770283] Review Request: uptimed - A daemon to record and keep track of system up times
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770283 --- Comment #14 from Ivan Romanov 2012-01-16 11:12:10 EST --- Links don't work. Can you use permanent store? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770283] Review Request: uptimed - A daemon to record and keep track of system up times
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770283 --- Comment #15 from Tomasz Torcz 2012-01-22 08:44:58 EST --- I've put both files on http://ttorcz.fedorapeople.org/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770283] Review Request: uptimed - A daemon to record and keep track of system up times
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770283 --- Comment #16 from Ivan Romanov 2012-01-22 08:58:43 EST --- Can you review my psi-plus package? https://bugzilla.redhat.com/show_bug.cgi?id=709328 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770283] Review Request: uptimed - A daemon to record and keep track of system up times
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770283 Ivan Romanov changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|dr...@land.ru -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770283] Review Request: uptimed - A daemon to record and keep track of system up times
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770283 --- Comment #17 from Ivan Romanov 2012-01-23 01:25:02 EST --- rpmlint output $ rpmlint uptimed-0.3.16-6.fc16.src.rpm uptimed.src: W: spelling-error %description -l en_US syslog -> slog 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint /home/taurus/rpmbuild/RPMS/i686/uptimed-0.3.16-6.fc15.i686.rpm /home/taurus/rpmbuild/RPMS/i686/uptimed-devel-0.3.16-6.fc15.i686.rpm /home/taurus/rpmbuild/RPMS/i686/uptimed-debuginfo-0.3.16-6.fc15.i686.rpm uptimed.i686: W: spelling-error %description -l en_US syslog -> slog uptimed.i686: W: shared-lib-calls-exit /usr/lib/libuptimed.so.0.0.0 exit@GLIBC_2.0 uptimed.i686: E: incorrect-fsf-address /usr/share/doc/uptimed-0.3.16/COPYING uptimed-devel.i686: W: no-documentation uptimed-devel.i686: E: incorrect-fsf-address /usr/include/uptimed.h uptimed-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/uptimed-0.3.16/src/getopt.h uptimed-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/uptimed-0.3.16/libuptimed/urec.c uptimed-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/uptimed-0.3.16/src/uprecords.c uptimed-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/uptimed-0.3.16/libuptimed/urec.h uptimed-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/uptimed-0.3.16/libuptimed/misc.c uptimed-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/uptimed-0.3.16/libuptimed/milestone.c uptimed-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/uptimed-0.3.16/libuptimed/milestone.h uptimed-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/uptimed-0.3.16/src/uptimed.c 3 packages and 0 specfiles checked; 10 errors, 3 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770283] Review Request: uptimed - A daemon to record and keep track of system up times
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770283 --- Comment #18 from Ivan Romanov 2012-01-23 01:30:46 EST --- (In reply to comment #17) > uptimed.i686: W: shared-lib-calls-exit /usr/lib/libuptimed.so.0.0.0 > exit@GLIBC_2.0 Why I got this warning? > uptimed.i686: E: incorrect-fsf-address /usr/share/doc/uptimed-0.3.16/COPYING You should work with upstream to correct fsf address. If upstream don't answer you might write patch. In any case I think such error is not critical. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770283] Review Request: uptimed - A daemon to record and keep track of system up times
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770283 --- Comment #19 from Tomasz Torcz 2012-01-23 07:54:38 EST --- shared-lib-calls-exit warning comes from the internal organisation of library. It is not a good practice, but that's how it got coded. FSF address will be corrected in next upstream version. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770283] Review Request: uptimed - A daemon to record and keep track of system up times
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770283 --- Comment #20 from Ivan Romanov 2012-01-23 08:18:07 EST --- Ok. So what about psi-plus package? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770283] Review Request: uptimed - A daemon to record and keep track of system up times
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=770283
--- Comment #21 from Ivan Romanov 2012-01-27 06:40:18 EST ---
You use %{epoch} for -devel requires but uptimed hasn't Epoch.
$ sudo rpm -i uptimed-0.3.16-6.fc15.i686.rpm
uptimed-devel-0.3.16-6.fc15.i686.rpm
error: Failed dependencies:
uptimed(x86-32) = %{epoch}:0.3.16-6.fc15 is needed by
uptimed-devel-0.3.16-6.fc15.i686
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770283] Review Request: uptimed - A daemon to record and keep track of system up times
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=770283
--- Comment #22 from Tomasz Torcz 2012-01-29 14:55:30 EST ---
Hi Ivan,
-7 I've removed %{epoch} from devel requires.
Spec URL: http://ttorcz.fedorapeople.org/uptimed.spec
SRPM URL: http://ttorcz.fedorapeople.org/uptimed-0.3.16-7.fc16.src.rpm
Scratch : http://koji.fedoraproject.org/koji/taskinfo?taskID=3744971
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770283] Review Request: uptimed - A daemon to record and keep track of system up times
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770283 --- Comment #23 from Ivan Romanov 2012-01-30 11:35:17 EST --- Okey. Now I can start a formal review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770283] Review Request: uptimed - A daemon to record and keep track of system up times
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770283 --- Comment #24 from Ivan Romanov 2012-02-07 10:39:49 EST --- I've found new issues. first. You skipped %defattr for %files devel next. I've obtain Packaging:Systemd rules. How did you get uptimed.service file? Start description with Upper-case letter. Add After=. In your case you should use After=syslog.target. Maybe another yet. Check it. You haven't Type in Service section. And about man page. I've looked at uptimed man page and haven't found -f option but uptimed has such. I think the man page is very old. It's issue for upstream. You can skip it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770283] Review Request: uptimed - A daemon to record and keep track of system up times
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770283 --- Comment #25 from Ivan Romanov 2012-02-07 10:47:02 EST --- /s/obtain/learned/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770283] Review Request: uptimed - A daemon to record and keep track of system up times
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770283 --- Comment #26 from Tomasz Torcz 2012-02-09 08:08:39 EST --- For -devel %defattr, it was my overlook. But according to http://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions %defattr is not necessary now. For completness, I included it in -8. For systemd unit, I've written this unit myself. "After=syslog.target" is not necessary with F16 and later, the syslog socket is always available now. "Type=" defaults to "simple" if not provided. This with "-f" (foreground) option for daemon makes unit file shorter and simpler. I'll prepare patches for upstream: correcting FSF address in licenses, providing systemd.unit and maybe updated man page from Debian. But this is something not connected with this review. Spec URL: http://ttorcz.fedorapeople.org/uptimed.spec SRPM URL: http://ttorcz.fedorapeople.org/uptimed-0.3.16-8.fc16.src.rpm Scratch : http://koji.fedoraproject.org/koji/taskinfo?taskID=3774940 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770283] Review Request: uptimed - A daemon to record and keep track of system up times
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770283 --- Comment #27 from Ivan Romanov 2012-02-09 13:11:58 EST --- Ok. Now package looks good. I will do a formal review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770283] Review Request: uptimed - A daemon to record and keep track of system up times
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770283 --- Comment #29 from Ivan Romanov 2012-02-10 11:28:56 EST --- *compile whithout bundled getopt -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770283] Review Request: uptimed - A daemon to record and keep track of system up times
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=770283
--- Comment #28 from Ivan Romanov 2012-02-10 11:27:28 EST ---
+ OK
/ Not applicable
[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines
.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines .
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[/] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[+] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[/] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[/] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
[?] MUST: Packages must NOT bundle copies of system libraries.
[/] MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[+] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[+] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations)
[+] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[/] MUST: Large documentation files must go in a -doc subpackage. (The
definition of large is left up to the packager's best judgement, but is not
restricted to size. Large can refer to either size or quantity).
[+] MUST: If a package includes something as %doc, it must not affect the
runtime of the application. To summarize: If it is in %doc, the program must
run properly if it is not present.
[+] MUST: Header files must be in a -devel package.
[/] MUST: Static libraries must be in a -static package.
[+] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), then library files that end in .so (without suffix) must go in
a -devel package.
[+] MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name}%{?_isa} =
%{version}-%{release}
[+] MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.
[/] MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section. If you feel that your packaged GUI application does not need
a .desktop file, you must put a comment in the spec file with your explanation.
[+] MUST: Packages must not own files or directories already owned by other
packages. The rule of thumb here is that the first package to be installed
should own the files or directories that other packages may rely upon. This
means, for example, that no package in Fedora should ever share ownership with
an
[Bug 770283] Review Request: uptimed - A daemon to record and keep track of system up times
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770283 --- Comment #30 from Tomasz Torcz 2012-02-11 09:29:29 EST --- I removed bundled getopt, both files and mention in configure.ac Spec URL: http://ttorcz.fedorapeople.org/uptimed.spec SRPM URL: http://ttorcz.fedorapeople.org/uptimed-0.3.16-9.fc16.src.rpm Scratch : http://koji.fedoraproject.org/koji/taskinfo?taskID=3781973 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770283] Review Request: uptimed - A daemon to record and keep track of system up times
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770283 Ivan Romanov changed: What|Removed |Added Flag|fedora-review? |fedora-review+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770283] Review Request: uptimed - A daemon to record and keep track of system up times
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770283 Tomasz Torcz changed: What|Removed |Added Flag||fedora-cvs? --- Comment #31 from Tomasz Torcz 2012-02-12 05:48:45 EST --- New Package SCM Request === Package Name: uptimed Short Description: A daemon to record and keep track of system up times Owners: ttorcz Branches: f16 f17 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770283] Review Request: uptimed - A daemon to record and keep track of system up times
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770283 --- Comment #32 from Jon Ciesla 2012-02-12 16:18:21 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 770283] Review Request: uptimed - A daemon to record and keep track of system up times
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=770283 Tomasz Torcz changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Last Closed||2012-02-14 06:22:56 --- Comment #33 from Tomasz Torcz 2012-02-14 06:22:56 EST --- Ican, thank you for all this review! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
