[Bug 771295] Review Request: rubygem-delorean - lets you travel in time with Ruby by mocking Time.now

2012-01-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=771295

Vít Ondruch vondr...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||vondr...@redhat.com
 AssignedTo|nob...@fedoraproject.org|vondr...@redhat.com

--- Comment #1 from Vít Ondruch vondr...@redhat.com 2012-01-03 07:06:05 EST 
---
I'll take it for a review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 771295] Review Request: rubygem-delorean - lets you travel in time with Ruby by mocking Time.now

2012-01-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=771295

Vít Ondruch vondr...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-review+

--- Comment #2 from Vít Ondruch vondr...@redhat.com 2012-01-03 07:55:25 EST 
---
* Test suite
  - Please consider execution of the test suite in the %check section? It seems
there are specs available upstream.

* rpmlint output
  - rpmlint complains about permissions of .spec file:

rubygem-delorean.src: W: strange-permission rubygem-delorean.spec 0666L
A file that you listed to include in your package has strange permissions.
Usually, a file should have 0644 permissions.

Otherwise, I have no other comments, so I APPROVE the package. Please fix the
rpmlint before import of the package and consider execution of the test suite.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 771295] Review Request: rubygem-delorean - lets you travel in time with Ruby by mocking Time.now

2012-01-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=771295

--- Comment #3 from Bohuslav Kabrda bkab...@redhat.com 2012-01-03 08:05:08 
EST ---
Thank you for your review. I'll fix these things before making a SCM request.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 771295] Review Request: rubygem-delorean - lets you travel in time with Ruby by mocking Time.now

2012-01-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=771295

Bohuslav Kabrda bkab...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #4 from Bohuslav Kabrda bkab...@redhat.com 2012-01-03 08:41:21 
EST ---
New Package SCM Request
===
Package Name: rubygem-delorean
Short Description: Delorean lets you travel in time with Ruby by mocking
Time.now
Owners: bkabrda
Branches: 
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 771295] Review Request: rubygem-delorean - lets you travel in time with Ruby by mocking Time.now

2012-01-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=771295

--- Comment #5 from Jon Ciesla limburg...@gmail.com 2012-01-03 08:49:05 EST 
---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 771295] Review Request: rubygem-delorean - lets you travel in time with Ruby by mocking Time.now

2012-01-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=771295

Bohuslav Kabrda bkab...@redhat.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE
Last Closed||2012-01-03 09:20:57

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review