needinfo canceled: [Bug 771318] Review Request: showoff - Ruby web app that reads simple configuration files for a presentation

[bugzilla]

Product: Fedora
Version: rawhide
Component: Package Review

Package Review  has canceled Package
Review 's request for Michal Fojtik
's needinfo:
Bug 771318: Review Request: showoff - Ruby web app that reads simple
configuration files for a presentation
https://bugzilla.redhat.com/show_bug.cgi?id=771318



--- Comment #7 from Package Review  ---
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 771318] Review Request: showoff - Ruby web app that reads simple configuration files for a presentation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=771318
Bug 771318 depends on bug 771297, which changed state.

Bug 771297 Summary: Review Request: rubygem-bluecloth - A Ruby implementation 
of John Gruber's Markdown
https://bugzilla.redhat.com/show_bug.cgi?id=771297

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NOTABUG



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 771318] Review Request: showoff - Ruby web app that reads simple configuration files for a presentation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=771318

James Hogarth  changed:

   What|Removed |Added

 Depends On|771314  |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=771314
[Bug 771314] Review Request: rubygem-parslet - Parser construction library
with great error reporting in Ruby
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 771318] Review Request: showoff - Ruby web app that reads simple configuration files for a presentation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=771318
Bug 771318 depends on bug 771311, which changed state.

Bug 771311 Summary: Review Request: rubygem-gli - Git-Like Interface Command 
Line Parser for Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=771311

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |NOTABUG



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 771318] Review Request: showoff - Ruby web app that reads simple configuration files for a presentation

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=771318

Lubomir Rintel lkund...@v3.sk changed:

   What|Removed |Added

 CC||lkund...@v3.sk

--- Comment #5 from Lubomir Rintel lkund...@v3.sk 2012-01-08 17:48:36 EST ---
* Name alright
* Versioning correct
* Source file matches upstream
* SPEC file clean and legible
* Builds fine in mock

1.) Require list not correct

Requires:   ruby(abi) = 1.8

Please drop this -- you don't install modules into 1.8 release specific
location and thus don't need to require a particular ABI.

2.) Licensing is suspicious

You need to clarify this:
# Unknown license (same as JQuery?)
%{app_root}/public/js/jquery.batchImageLoad.js
%{app_root}/public/js/jquery.uuid.js

3.) Rpmlint not happy

showoff.src:60: E: files-attr-not-set
A file or a directory entry in a %files section does not have attributes set
which may result in security issues in the resulting binary package depending
on the system where the package is built.  Add default attributes using
%defattr before it in the %files section, or use per line %attr's.

showoff.src: W: no-%clean-section
The spec file doesn't contain a %clean section to remove the files installed
by the %install section.

showoff.src:11: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 11)
The specfile mixes use of spaces and tabs for indentation, which is a cosmetic
annoyance.  Use either spaces or tabs for indentation, not both.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 771318] Review Request: showoff - Ruby web app that reads simple configuration files for a presentation

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=771318

Michal Fojtik mfoj...@redhat.com changed:

   What|Removed |Added

Summary|Review Request: |Review Request: showoff -
   |rubygem-showoff - Ruby web  |Ruby web app that reads
   |app that reads simple   |simple configuration files
   |configuration files for a   |for a presentation
   |presentation|

--- Comment #3 from Michal Fojtik mfoj...@redhat.com 2012-01-03 08:46:44 EST 
---
Revision -4:

Spec URL: http://omicron.mifo.sk/showoff.spec
SRPM URL: http://omicron.mifo.sk/showoff-0.7.0-4.fc14.src.rpm

* Mon Jan 03 2012 Michal Fojtik mfoj...@redhat.com - 0.7.0-4

- Switched to application package type instead of gem

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 771318] Review Request: showoff - Ruby web app that reads simple configuration files for a presentation

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=771318

--- Comment #4 from Michal Fojtik mfoj...@redhat.com 2012-01-03 09:10:21 EST 
---
Revision -5:

Spec URL: http://omicron.mifo.sk/showoff.spec
SRPM URL: http://omicron.mifo.sk/showoff-0.7.0-5.fc14.src.rpm

* Mon Jan 03 2012 Michal Fojtik mfoj...@redhat.com - 0.7.0-5
- Changed package group to Applications/Publishing

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review