[Bug 771851] Review Request: python-ladon - Multiprotocol approach to creating a webservice
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771851 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||python-ladon-0.6.5-2.fc16 Resolution||ERRATA Last Closed||2012-01-23 16:57:29 --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2012-01-23 16:57:29 EST --- python-ladon-0.6.5-2.fc16 has been pushed to the Fedora 16 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771851] Review Request: python-ladon - Multiprotocol approach to creating a webservice
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771851 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771851] Review Request: python-ladon - Multiprotocol approach to creating a webservice
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771851 --- Comment #8 from Fedora Update System upda...@fedoraproject.org 2012-01-10 03:17:15 EST --- python-ladon-0.6.5-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/python-ladon-0.6.5-2.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771851] Review Request: python-ladon - Multiprotocol approach to creating a webservice
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771851 --- Comment #9 from Fedora Update System upda...@fedoraproject.org 2012-01-10 04:02:28 EST --- python-ladon-0.6.5-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-ladon-0.6.5-2.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771851] Review Request: python-ladon - Multiprotocol approach to creating a webservice
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771851 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System upda...@fedoraproject.org 2012-01-11 00:59:06 EST --- python-ladon-0.6.5-2.fc16 has been pushed to the Fedora 16 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771851] Review Request: python-ladon - Multiprotocol approach to creating a webservice
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771851 --- Comment #7 from Jon Ciesla limburg...@gmail.com 2012-01-09 08:08:59 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771851] Review Request: python-ladon - Multiprotocol approach to creating a webservice
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771851 Bohuslav Kabrda bkab...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #5 from Bohuslav Kabrda bkab...@redhat.com 2012-01-09 01:42:03 EST --- Looks good now, package is APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771851] Review Request: python-ladon - Multiprotocol approach to creating a webservice
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771851 Matthias Runge mru...@matthias-runge.de changed: What|Removed |Added Flag||fedora-cvs? --- Comment #6 from Matthias Runge mru...@matthias-runge.de 2012-01-09 02:29:40 EST --- Bohuslav, thanks for the review. It has been a pleasure for me! New Package SCM Request === Package Name: python-ladon Short Description: Multiprotocol approach to creating a webservice Owners: mrunge Branches: f16, el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771851] Review Request: python-ladon - Multiprotocol approach to creating a webservice
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771851 Bohuslav Kabrda bkab...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||bkab...@redhat.com AssignedTo|nob...@fedoraproject.org|bkab...@redhat.com Flag||fedora-review? --- Comment #1 from Bohuslav Kabrda bkab...@redhat.com 2012-01-06 04:18:14 EST --- I'm taking this one for a review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771851] Review Request: python-ladon - Multiprotocol approach to creating a webservice
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=771851
--- Comment #2 from Bohuslav Kabrda bkab...@redhat.com 2012-01-06 05:02:32
EST ---
- BuildRequires: python-devel should be BuildRequires: python2-devel, see [1].
- When packaging for Fedora 13 or greater, you don't need to define
%python_sitelib yourself, because its in a macro file in python2-devel, see
[2].
- Could you please specify why you need the two identical files in %{_bindir},
only with different names? It is an upstream decision, but maybe you could
query them about this?
- The package seems to have a bundled library python-chardet, which is already
in Fedora. You should unbundle it and make the Fedora package runtime
dependency. (Perhaps query the upstream not to bundle it at all?)
- You probably don't need to use the CFLAGS in %build section, as your package
doesn't contain any binary extensions.
- rm -rf $RPM_BUILD_ROOT is not needed, if you don't plan on getting the
package to EPEL.
- Could you please clarify the LICENSE? Your specfile says GPLv2+, but PKG-INFO
only says GPL.
[1] https://fedoraproject.org/wiki/Packaging:Python#BuildRequires
[2] https://fedoraproject.org/wiki/Packaging:Python#Macros
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771851] Review Request: python-ladon - Multiprotocol approach to creating a webservice
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771851 --- Comment #3 from Matthias Runge mru...@matthias-runge.de 2012-01-06 05:09:11 EST --- Thank you for your review. I'll resolve those questions/issues. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771851] Review Request: python-ladon - Multiprotocol approach to creating a webservice
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=771851
--- Comment #4 from Matthias Runge mru...@matthias-runge.de 2012-01-06
14:46:16 EST ---
updated version:
SPEC: http://www.matthias-runge.de/fedora/python-ladon.spec
(old version, for reference:
http://www.matthias-runge.de/fedora/python-ladon-1.spec )
SRPM: http://www.matthias-runge.de/fedora/python-ladon-0.6.5-2.fc16.src.rpm
Upstream clarified, license is lgpv3+, updated PKG-INFO on
http://pypi.python.org/pypi/ladon
Bundled library is kept upstream for missing reference for chardet (chardet's
upstream is gone). It should be save to remove ladons bundled lib chardet_py2
and replace the only reference to bundled lib to fedoras version of chardet.
CFLAGS removed, buildroot-removal deleted.
for easier reference:
[mrunge@sofja SPECS]$ diff -u python-ladon-1.spec python-ladon.spec ---
python-ladon-1.spec 2012-01-06 20:31:08.574775992 +0100
+++ python-ladon.spec 2012-01-06 20:44:47.248475349 +0100
@@ -1,18 +1,17 @@
-%{!?python_sitelib: %global python_sitelib %(%{__python} -c from
distutils.sysconfig import get_python_lib; print(get_python_lib()))}
-
Name: python-ladon
Version:0.6.5
-Release:1%{?dist}
+Release:2%{?dist}
Summary:Multiprotocol approach to creating a webservice
-License:GPLv2
+License:LGPLv3+
URL:http://ladonize.org
Source0:
http://pypi.python.org/packages/source/l/ladon/ladon-%{version}.tar.gz
# #md5=07dd1d395d0d7123448d7710bb3da32a
BuildArch: noarch
-BuildRequires: python-devel
+BuildRequires: python2-devel
Requires: python-jinja2
+Requires: python-chardet
%description
Ladon is a framework for exposing methods to several internet service
@@ -24,22 +23,33 @@
%prep
%setup -q -n ladon-%{version}
+# replace reference to bundled lib with fedora's reference
+sed -i 's/chardet_py2/chardet/' src/ladon/ladonizer/collection.py
%build
-CFLAGS=$RPM_OPT_FLAGS %{__python} setup.py build
+%{__python} setup.py build
%install
-rm -rf $RPM_BUILD_ROOT
%{__python} setup.py install -O1 --skip-build --root $RPM_BUILD_ROOT
-chmod 755 /%{buildroot}/%{python_sitelib}/ladon/clients/jsonwsp.py
+chmod 755 %{buildroot}/%{python_sitelib}/ladon/clients/jsonwsp.py
+
+# remove file included for windows-builds
+rm %{buildroot}/%{_bindir}/ladon2.7ctl.py
+
+# remove bundled library
+rm -rf %{buildroot}/%{python_sitelib}/chardet_py2
%files
%doc PKG-INFO
%{python_sitelib}/*
%{_bindir}/ladon2.7ctl
-%{_bindir}/ladon2.7ctl.py
%changelog
+* Fri Jan 06 2012 Matthias Runge mru...@matthias-runge.de - 0.6.5-2
+- remove unecessary definition, buildroot cleaning
+- remove bundled library chardet_py2, correct reference to use fedora's
version
+- correct build requirements
+
* Wed Jan 04 2012 Matthias Runge mru...@matthias-runge.de - 0.6.5-1
- initial fedora package
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
