[Bug 771944] Review Request: pykka - Python library that provides concurrency using actor model
https://bugzilla.redhat.com/show_bug.cgi?id=771944 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2012-09-17 17:54:43 --- Comment #19 from Fedora Update System --- pykka-0.15-2.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771944] Review Request: pykka - Python library that provides concurrency using actor model
https://bugzilla.redhat.com/show_bug.cgi?id=771944 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #18 from Fedora Update System --- pykka-0.15-2.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771944] Review Request: pykka - Python library that provides concurrency using actor model
https://bugzilla.redhat.com/show_bug.cgi?id=771944 --- Comment #17 from Fedora Update System --- pykka-0.15-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/pykka-0.15-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771944] Review Request: pykka - Python library that provides concurrency using actor model
https://bugzilla.redhat.com/show_bug.cgi?id=771944 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771944] Review Request: pykka - Python library that provides concurrency using actor model
https://bugzilla.redhat.com/show_bug.cgi?id=771944 --- Comment #16 from Mario Blättermann --- OK, looks fine. Use this for the Git import. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771944] Review Request: pykka - Python library that provides concurrency using actor model
https://bugzilla.redhat.com/show_bug.cgi?id=771944 --- Comment #15 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771944] Review Request: pykka - Python library that provides concurrency using actor model
https://bugzilla.redhat.com/show_bug.cgi?id=771944 --- Comment #14 from Jonathan Dieter --- Sorry, I missed the buildroot tag, though I think I got the %clean section and others you mentioned. Here's another release without the buildroot tag. Updated release: Spec URL: http://lesloueizeh.com/jdieter/pykka.spec SRPM URL: http://lesloueizeh.com/jdieter/pykka-0.15-2.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771944] Review Request: pykka - Python library that provides concurrency using actor model
https://bugzilla.redhat.com/show_bug.cgi?id=771944 --- Comment #13 from Mario Blättermann --- You haven't requested a Git branch for el5, that's why please don't forget to drop the appropriate stuff from your spec before importing it. Means BuildRoot tag, %clean section and so on. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771944] Review Request: pykka - Python library that provides concurrency using actor model
https://bugzilla.redhat.com/show_bug.cgi?id=771944 Jonathan Dieter changed: What|Removed |Added Flags||fedora-cvs? --- Comment #12 from Jonathan Dieter --- New Package SCM Request === Package Name: pykka Short Description: Python library that provides concurrency using actor model Owners: jdieter Branches: f16 f17 f18 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771944] Review Request: pykka - Python library that provides concurrency using actor model
https://bugzilla.redhat.com/show_bug.cgi?id=771944 Mario Blättermann changed: What|Removed |Added Flags||fedora-review+ --- Comment #11 from Mario Blättermann --- (In reply to comment #10) > Do you mind setting the fedora-review+ flag again? Thanks. Done. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771944] Review Request: pykka - Python library that provides concurrency using actor model
https://bugzilla.redhat.com/show_bug.cgi?id=771944 --- Comment #10 from Jonathan Dieter --- Um, fedora-review+ seems to have been unset so my scm request won't go through. Do you mind setting the fedora-review+ flag again? Thanks. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771944] Review Request: pykka - Python library that provides concurrency using actor model
https://bugzilla.redhat.com/show_bug.cgi?id=771944 --- Comment #9 from Mario Blättermann --- I have to set fedora-review+ once the package has been approved by me. Perhaps a bug in Bugzilla itself? Doesn't matter, all is fine again, go ahead. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771944] Review Request: pykka - Python library that provides concurrency using actor model
https://bugzilla.redhat.com/show_bug.cgi?id=771944 Jonathan Dieter changed: What|Removed |Added CC|dw...@infradead.org | Component|0x |Package Review Assignee|dw...@infradead.org |mario.blaetterm...@gmail.co ||m --- Comment #8 from Jonathan Dieter --- I don't know what just happened, but this bug somehow got its component changed, flags reset, and assigned to a different user. I've reset the component and assigned it back to you, Mario, but you'll need to set the review flag yourself, I think. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771944] Review Request: pykka - Python library that provides concurrency using actor model
https://bugzilla.redhat.com/show_bug.cgi?id=771944 Jonathan Dieter changed: What|Removed |Added CC||dw...@infradead.org Component|Package Review |0x Assignee|mario.blaetterm...@gmail.co |dw...@infradead.org |m | Flags|fedora-review+ | --- Comment #7 from Jonathan Dieter --- Updated release: Spec URL: http://lesloueizeh.com/jdieter/pykka.spec SRPM URL: http://lesloueizeh.com/jdieter/pykka-0.15-1.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771944] Review Request: pykka - Python library that provides concurrency using actor model
https://bugzilla.redhat.com/show_bug.cgi?id=771944
--- Comment #6 from Jonathan Dieter ---
(In reply to comment #4)
> CFLAGS="$RPM_OPT_FLAGS" is superfluous here, because there's no C code
> included.
>
> If you don't want to provide it for EPEL 5, drop BuildRoot, the initial
> cleaning of %{buildroot} in %install, the %clean section and the %defattr
> line from %files.
Mario, thanks for the review. I'll push out a new release fixing the items
mentioned above, probably tomorrow.
Stein, I will make sure the new release is based on the latest version and
update the package website url.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771944] Review Request: pykka - Python library that provides concurrency using actor model
https://bugzilla.redhat.com/show_bug.cgi?id=771944 --- Comment #5 from Stein Magnus Jodal --- (In reply to comment #4) > pykka.src: I: checking-url http://jodal.github.com/pykka/ (timeout 10 > seconds) The website was moved to http://pykka.readthedocs.org/ some time ago. > pykka.src: I: checking-url http://github.com/jodal/pykka/tarball/v0.13 > (timeout 10 seconds) v0.15 has been released, so you may consider updating the package. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771944] Review Request: pykka - Python library that provides concurrency using actor model
https://bugzilla.redhat.com/show_bug.cgi?id=771944
Mario Blättermann changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #4 from Mario Blättermann ---
(In reply to comment #2)
> Hi,
>
> I'm the upstream author of Pykka.
>
> I would just like to mention that Gevent is an optional dependency only
> needed if you use the "pykka.gevent" package. Pykka is useful without Gevent.
>
Yes, but it is safe to have it in BuildRequires and require it at runtime.
Another way would be to have to define a subpackage named pykka-gevent, which
requires pykka and python-gevent. But I think don't let us make it more
complicated as it's worth. We speak about requirements of some kilobytes,
that's why I wouldn't think about such a way.
Scratch build for Rawhide:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4420502
$ rpmlint -i -v *
pykka.src: I: checking
pykka.src: W: spelling-error %description -l en_US gevent -> event, g event,
gent
The value of this tag appears to be misspelled. Please double-check.
pykka.src: W: spelling-error %description -l en_US coroutine -> co routine,
co-routine, routine
The value of this tag appears to be misspelled. Please double-check.
pykka.src: W: spelling-error %description -l en_US greenlet -> green let,
green-let, greenbelt
The value of this tag appears to be misspelled. Please double-check.
pykka.src: W: spelling-error %description -l en_US libevent -> lib event,
lib-event, enlivenment
The value of this tag appears to be misspelled. Please double-check.
pykka.src: W: spelling-error %description -l en_US doesn -> does, does n
The value of this tag appears to be misspelled. Please double-check.
pykka.src: I: checking-url http://jodal.github.com/pykka/ (timeout 10 seconds)
pykka.src: I: checking-url http://github.com/jodal/pykka/tarball/v0.13 (timeout
10 seconds)
pykka.noarch: I: checking
pykka.noarch: W: spelling-error %description -l en_US gevent -> event, g event,
gent
The value of this tag appears to be misspelled. Please double-check.
pykka.noarch: W: spelling-error %description -l en_US coroutine -> co routine,
co-routine, routine
The value of this tag appears to be misspelled. Please double-check.
pykka.noarch: W: spelling-error %description -l en_US greenlet -> green let,
green-let, greenbelt
The value of this tag appears to be misspelled. Please double-check.
pykka.noarch: W: spelling-error %description -l en_US libevent -> lib event,
lib-event, enlivenment
The value of this tag appears to be misspelled. Please double-check.
pykka.noarch: W: spelling-error %description -l en_US doesn -> does, does n
The value of this tag appears to be misspelled. Please double-check.
pykka.noarch: I: checking-url http://jodal.github.com/pykka/ (timeout 10
seconds)
pykka.spec: I: checking-url http://github.com/jodal/pykka/tarball/v0.13
(timeout 10 seconds)
2 packages and 1 specfiles checked; 0 errors, 10 warnings.
A few spelling errors which could be safely ignored.
CFLAGS="$RPM_OPT_FLAGS" is superfluous here, because there's no C code
included.
If you don't want to provide it for EPEL 5, drop BuildRoot, the initial
cleaning of %{buildroot} in %install, the %clean section and the %defattr line
from %files.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
ASL 2.0
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
$ sha256sum *
81a4fe294489e53269509a135d856a669bb9e8374815d96faae5e8b797bb3941
v0.13.orig
81a4fe294489e53269509a135d856a669bb9e8374815d96faae5e8b797bb3941 v0.13
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one prima
[Bug 771944] Review Request: pykka - Python library that provides concurrency using actor model
https://bugzilla.redhat.com/show_bug.cgi?id=771944 Mario Blättermann changed: What|Removed |Added Status|NEW |ASSIGNED CC||mario.blaetterm...@gmail.co ||m Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co ||m Flags||fedora-review? --- Comment #3 from Mario Blättermann --- Taking for review. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771944] Review Request: pykka - Python library that provides concurrency using actor model
https://bugzilla.redhat.com/show_bug.cgi?id=771944 --- Comment #2 from Stein Magnus Jodal --- Hi, I'm the upstream author of Pykka. I would just like to mention that Gevent is an optional dependency only needed if you use the "pykka.gevent" package. Pykka is useful without Gevent. Thanks! -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 771944] Review Request: pykka - Python library that provides concurrency using actor model
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771944 --- Comment #1 from Jonathan Dieter 2012-01-05 08:46:46 EST --- $ rpmlint pykka.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint ../RPMS/noarch/pykka-0.13.0-1.fc16.noarch.rpm pykka.noarch: W: spelling-error %description -l en_US gevent -> event, g event, gent pykka.noarch: W: spelling-error %description -l en_US coroutine -> co routine, co-routine, routine pykka.noarch: W: spelling-error %description -l en_US greenlet -> green let, green-let, greenbelt pykka.noarch: W: spelling-error %description -l en_US libevent -> lib event, lib-event, enlivenment pykka.noarch: W: spelling-error %description -l en_US doesn -> does, does n 1 packages and 0 specfiles checked; 0 errors, 5 warnings. $ rpmlint ../SRPMS/pykka-0.13.0-1.fc16.src.rpm pykka.src: W: spelling-error %description -l en_US gevent -> event, g event, gent pykka.src: W: spelling-error %description -l en_US coroutine -> co routine, co-routine, routine pykka.src: W: spelling-error %description -l en_US greenlet -> green let, green-let, greenbelt pykka.src: W: spelling-error %description -l en_US libevent -> lib event, lib-event, enlivenment pykka.src: W: spelling-error %description -l en_US doesn -> does, does n 1 packages and 0 specfiles checked; 0 errors, 5 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
