[Bug 772362] Review Request: sigil - Free, Open Source WYSIWYG ebook editor
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=772362 Hans de Goede hdego...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2012-11-26 05:00:40 --- Comment #34 from Hans de Goede hdego...@redhat.com --- Imported, build for f16+ and bodhi tickets created for f16+, closing. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772362] Review Request: sigil - Free, Open Source WYSIWYG ebook editor
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=772362 Dan Horák d...@danny.cz changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #29 from Dan Horák d...@danny.cz --- formal review is here, see the notes explaining OK* and BAD statuses below: OK source files match upstream: 541bc65c86158433adb2c5926e3ae43e46ed4fb6 Sigil-0.6.0-Code.zip OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK license field matches the actual license. OK license is open source-compatible (GPLv3+). License text included in package. OK latest version is being packaged. OK BuildRequires are proper. OK compiler flags are appropriate. OK package builds in mock (Rawhide/x86_64). OK debuginfo package looks complete. OK* rpmlint is silent. BAD final provides and requires look sane. N/A %check is present and all tests pass. OK no shared libraries are added to the regular linker search paths. OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK correct scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK no headers. OK no pkgconfig files. OK no libtool .la droppings. OK GUI app with desktop file - the spell checker doesn't like ebook and ePub, can be ignored - Provides: bundled(libtidy) needed for bundled stuff is missing APPROVED, please fix the missing Provides before import And one more note - I would like to keep the condition for using the bundled PCRE as I will build the latest sigil packages for older Fedoras in my repo. For Fedora 16 and 17 we can provide sigil 0.5.3 as it doesn't depend on UTF-16 support in pcre. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772362] Review Request: sigil - Free, Open Source WYSIWYG ebook editor
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=772362 --- Comment #30 from Hans de Goede hdego...@redhat.com --- (In reply to comment #29) - Provides: bundled(libtidy) needed for bundled stuff is missing APPROVED, please fix the missing Provides before import Will do. And one more note - I would like to keep the condition for using the bundled PCRE as I will build the latest sigil packages for older Fedoras in my repo. For Fedora 16 and 17 we can provide sigil 0.5.3 as it doesn't depend on UTF-16 support in pcre. I was actually planning on keeping the condition for the bundled PCRE, and simply building with a bundled PCRE for F-16 and F-17, given that we've a fix for this bundling in the latest release I don't see this as an issue. I'll hold of with building for F-16 and F-17 till we've an agreement on how to deal with this. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772362] Review Request: sigil - Free, Open Source WYSIWYG ebook editor
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=772362 Hans de Goede hdego...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #31 from Hans de Goede hdego...@redhat.com --- New Package SCM Request === Package Name: sigil Short Description: Free, Open Source WYSIWYG ebook editor Owners: jwrdegoede sharkcz Branches: f16 f17 f18 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772362] Review Request: sigil - Free, Open Source WYSIWYG ebook editor
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=772362 --- Comment #32 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772362] Review Request: sigil - Free, Open Source WYSIWYG ebook editor
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=772362 --- Comment #33 from Dan Horák d...@danny.cz --- (In reply to comment #30) (In reply to comment #29) - Provides: bundled(libtidy) needed for bundled stuff is missing APPROVED, please fix the missing Provides before import Will do. And one more note - I would like to keep the condition for using the bundled PCRE as I will build the latest sigil packages for older Fedoras in my repo. For Fedora 16 and 17 we can provide sigil 0.5.3 as it doesn't depend on UTF-16 support in pcre. I was actually planning on keeping the condition for the bundled PCRE, and simply building with a bundled PCRE for F-16 and F-17, given that we've a fix for this bundling in the latest release I don't see this as an issue. I'll hold of with building for F-16 and F-17 till we've an agreement on how to deal with this. well, your option will make my life easier, so I agree with your plan :-) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772362] Review Request: sigil - Free, Open Source WYSIWYG ebook editor
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=772362
--- Comment #28 from Hans de Goede hdego...@redhat.com ---
(In reply to comment #27)
Great news!
Ok, I can spot a small packaging issue - sigil has a .desktop file so this
applies:
http://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files
Basically, there must be BuildRequires: desktop-file-utils and if the
.desktop file isn't modified during the install, something along the lines
of desktop-file-validate %{buildroot}/%{_datadir}/applications/foo.desktop
in the check or install section.
Good point, here is a new version fixing this:
Spec URL: http://people.fedoraproject.org/~jwrdegoede/sigil.spec
SRPM URL:
http://people.fedoraproject.org/~jwrdegoede/sigil-0.6.0-2.fc15.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772362] Review Request: sigil - Free, Open Source WYSIWYG ebook editor
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=772362 --- Comment #26 from Hans de Goede hdego...@redhat.com --- Ok, good news, we've gotten an exception for tidy from the fpc, so here is a new version: Spec URL: http://people.fedoraproject.org/~jwrdegoede/sigil.spec SRPM URL: http://people.fedoraproject.org/~jwrdegoede/sigil-0.6.0-1.fc15.src.rpm Never mind the .fc15 I'm using the pre-git erra makefiles to build not yet imported rpms... This is based on the srpm from comment #23. It is exactly the same except for the release field in the latest changelog entry being fixed :) Dan, I would like to suggest that I keep the submitter role and you the reviewer role for the rest of this review, and then after the review we co-maintain ? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772362] Review Request: sigil - Free, Open Source WYSIWYG ebook editor
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=772362
--- Comment #27 from LightDot light...@gmail.com ---
Great news!
Ok, I can spot a small packaging issue - sigil has a .desktop file so this
applies:
http://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files
Basically, there must be BuildRequires: desktop-file-utils and if the
.desktop file isn't modified during the install, something along the lines of
desktop-file-validate %{buildroot}/%{_datadir}/applications/foo.desktop in
the check or install section.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772362] Review Request: sigil - Free, Open Source WYSIWYG ebook editor
https://bugzilla.redhat.com/show_bug.cgi?id=772362 --- Comment #22 from Hans de Goede hdego...@redhat.com --- (In reply to comment #15) Created attachment 576293 [details] diff between sigil and upstream libtidy Hans, I'm working on the review again, sorry for the delays. These are the changes between sigil and upstream version of libtidy. The good thing is that it doesn't change ABI or API in an incompatible way. Thanks for this, I also cannot spot any ABI or API changes, but there are a lot of behavioral changes which clearly make the bundled version not compatible with the system version and which are likely undesirable to add to the system version (such as case insensitive attribute matching. So as Sigil upstream already suggested in a past mails about bundling with them, although they support using system versions of all the other libs, they believe it is best to stick with a bundled libtidy and I agree with them. I'll go and file an fpc ticket for this. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772362] Review Request: sigil - Free, Open Source WYSIWYG ebook editor
https://bugzilla.redhat.com/show_bug.cgi?id=772362 --- Comment #23 from Dan Horák d...@danny.cz --- btw latest sigil is packaged at http://fedora.danny.cz/danny/development/SRPMS/repoview/sigil.html I've also tried to create a patch for usign system spelling dictionaries, but the issue (http://code.google.com/p/sigil/issues/detail?id=1646) was closed as WontFix, I have asked John for the reason in a private email, but no response yet. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772362] Review Request: sigil - Free, Open Source WYSIWYG ebook editor
https://bugzilla.redhat.com/show_bug.cgi?id=772362 --- Comment #24 from Hans de Goede hdego...@redhat.com --- Bundling exception request is here: https://fedorahosted.org/fpc/ticket/219 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772362] Review Request: sigil - Free, Open Source WYSIWYG ebook editor
https://bugzilla.redhat.com/show_bug.cgi?id=772362 --- Comment #25 from Dan Horák d...@danny.cz --- re tidy - it has a new life at http://w3c.github.com/tidy-html5/ -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772362] Review Request: sigil - Free, Open Source WYSIWYG ebook editor
https://bugzilla.redhat.com/show_bug.cgi?id=772362 --- Comment #21 from Dan Horák d...@danny.cz --- (In reply to comment #20) Hi, (In reply to comment #17) With 0.5.3 sources, with dropped patches, rebuilt FlightCrew and ZipArchive, rebuilt Sigil works just fine on Fedora 16 (local mock build). Has this review stopped due to embedded libtidy? That, and a serious case of -ENOTIME, if an interested Fedora packager want to take this over, please feel free to do so, What needs to be done to finish this up...? A good question, Dan, what is your intent of comment #15, do you want sigil to move to the system libtidy? And if so, just use the system libtidy as is (could be troublesome), or try to get the sigil patches added (probably also trouble some since they seem somewhat ebook specific)... ideally the local changes to libtidy would be integrated to upstream libtidy or to the Fedora package, libtidy seems as not-so-alive project, so even having the local copy in sigil is fine with me One good thing about sigil upstream is that it now has checks for all the bundled libraries in the cmake control file. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772362] Review Request: sigil - Free, Open Source WYSIWYG ebook editor
https://bugzilla.redhat.com/show_bug.cgi?id=772362 --- Comment #20 from Hans de Goede hdego...@redhat.com --- Hi, (In reply to comment #17) With 0.5.3 sources, with dropped patches, rebuilt FlightCrew and ZipArchive, rebuilt Sigil works just fine on Fedora 16 (local mock build). Has this review stopped due to embedded libtidy? That, and a serious case of -ENOTIME, if an interested Fedora packager want to take this over, please feel free to do so, What needs to be done to finish this up...? A good question, Dan, what is your intent of comment #15, do you want sigil to move to the system libtidy? And if so, just use the system libtidy as is (could be troublesome), or try to get the sigil patches added (probably also trouble some since they seem somewhat ebook specific)... Regards, Hans -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772362] Review Request: sigil - Free, Open Source WYSIWYG ebook editor
https://bugzilla.redhat.com/show_bug.cgi?id=772362 LightDot light...@gmail.com changed: What|Removed |Added CC||light...@gmail.com --- Comment #17 from LightDot light...@gmail.com --- With 0.5.3 sources, with dropped patches, rebuilt FlightCrew and ZipArchive, rebuilt Sigil works just fine on Fedora 16 (local mock build). Has this review stopped due to embedded libtidy? What needs to be done to finish this up...? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772362] Review Request: sigil - Free, Open Source WYSIWYG ebook editor
https://bugzilla.redhat.com/show_bug.cgi?id=772362 --- Comment #18 from Mihai Limbășan mi...@limbasan.ro --- Please note that, siarting with commit 0fdb1bcf3a6b7d74e7041c3f8336b80a58893c59 (details at http://code.google.com/p/sigil/source/detail?r=0fdb1bcf3a6b7d74e7041c3f8336b80a58893c59 ) , sigil has dropped ZipArchive and has switched to minizip ( http://www.winimage.com/zLibDll/minizip.html ) for ZIP support. Assuming Sigil 0.6.0 is released in time for F18, ZipArchive can be dropped since Sigil is the only consumer, AFAIK. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772362] Review Request: sigil - Free, Open Source WYSIWYG ebook editor
https://bugzilla.redhat.com/show_bug.cgi?id=772362 --- Comment #19 from Mihai Limbășan mi...@limbasan.ro --- Additional maintainer notE: Upstream Sigil now bundles zlib 1.2.7 ( http://code.google.com/p/sigil/source/detail?r=89f6780e8e00b1ad6754c8780e2447069c3f638d ) and PCRE 8.31 ( http://code.google.com/p/sigil/source/detail?r=a800f78e373e7fe75ccb7efaeb8bea97cc2aa9dd ). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772362] Review Request: sigil - Free, Open Source WYSIWYG ebook editor
https://bugzilla.redhat.com/show_bug.cgi?id=772362 Mikko Tiihonen mikko.tiiho...@iki.fi changed: What|Removed |Added CC||mikko.tiiho...@iki.fi --- Comment #16 from Mikko Tiihonen mikko.tiiho...@iki.fi --- With 0.5.3 sources and http://people.fedoraproject.org/~jwrdegoede/sigil.spec the build works nicely when all the patches are commented out (the patches had already been applied upstream). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772362] Review Request: sigil - Free, Open Source WYSIWYG ebook editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772362 --- Comment #15 from Dan Horák d...@danny.cz 2012-04-09 15:47:51 EDT --- Created attachment 576293 -- https://bugzilla.redhat.com/attachment.cgi?id=576293 diff between sigil and upstream libtidy Hans, I'm working on the review again, sorry for the delays. These are the changes between sigil and upstream version of libtidy. The good thing is that it doesn't change ABI or API in an incompatible way. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772362] Review Request: sigil - Free, Open Source WYSIWYG ebook editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772362 --- Comment #14 from Hans de Goede hdego...@redhat.com 2012-04-04 10:11:43 EDT --- Dan, I know you're probably busy with other stuff, still any chance you could finish this review? Thanks, Hans -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772362] Review Request: sigil - Free, Open Source WYSIWYG ebook editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772362 --- Comment #13 from Hans de Goede hdego...@redhat.com 2012-02-01 03:06:34 EST --- Note, during some tests I found out that my sigil packages would not open some epubs I've tracked this down to a problem with ZipArchive and build a fixed ZipArchive package. So please download the latest ZipArchive from koji before running any tests. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772362] Review Request: sigil - Free, Open Source WYSIWYG ebook editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772362 Bug 772362 depends on bug 783151, which changed state. Bug 783151 Summary: Review Request: FlightCrew - EPUB validation library https://bugzilla.redhat.com/show_bug.cgi?id=783151 What|Old Value |New Value Resolution||RAWHIDE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772362] Review Request: sigil - Free, Open Source WYSIWYG ebook editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772362 --- Comment #11 from Hans de Goede hdego...@redhat.com 2012-01-24 03:07:52 EST --- I've all send all the patches for both Sigil and FlightCrew upstream and I just got a mail from upstreaming stating that they will integrate them over the next couple of days. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772362] Review Request: sigil - Free, Open Source WYSIWYG ebook editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772362 Dan Horák d...@danny.cz changed: What|Removed |Added Status|NEW |ASSIGNED Depends on||783151 AssignedTo|nob...@fedoraproject.org|d...@danny.cz Flag||fedora-review? --- Comment #12 from Dan Horák d...@danny.cz 2012-01-24 03:28:15 EST --- (In reply to comment #11) I've all send all the patches for both Sigil and FlightCrew upstream and I just got a mail from upstreaming stating that they will integrate them over the next couple of days. That's a great news and thanks for finishing the work I've started. I will take a look on the remaining reviews later this week. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772362] Review Request: sigil - Free, Open Source WYSIWYG ebook editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772362 Bug 772362 depends on bug 773313, which changed state. Bug 773313 Summary: Review Request: ZipArchive - The ZipArchive library https://bugzilla.redhat.com/show_bug.cgi?id=773313 What|Old Value |New Value Resolution||RAWHIDE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772362] Review Request: sigil - Free, Open Source WYSIWYG ebook editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772362 --- Comment #10 from Hans de Goede hdego...@redhat.com 2012-01-23 17:09:10 EST --- Hi, Here is an updated package using Sigil 0.5.0, patched to use system versions of pcre and hunspell. Spec URL: http://people.fedoraproject.org/~jwrdegoede/sigil.spec SRPM URL: http://people.fedoraproject.org/~jwrdegoede/sigil-0.5.0-1.fc15.src.rpm Regards, Hans -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772362] Review Request: sigil - Free, Open Source WYSIWYG ebook editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772362 --- Comment #9 from Mihai Limbășan mi...@limbasan.ro 2012-01-21 12:40:33 EST --- Ping: Sigil 0.5.0 stable was just released. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772362] Review Request: sigil - Free, Open Source WYSIWYG ebook editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772362 --- Comment #7 from Hans de Goede hdego...@redhat.com 2012-01-18 11:01:31 EST --- (In reply to comment #6) Hans, it's completely fine if you base the packages on my work. But we still need a plan Agreed we need a plan :) , because the patches are still not complete, my sigil patchset needs to be updated for the external FlightCrew and all patches submitted upstream. There is a good chance he will accept the patches after reading the answer to the Debian guys. And the main remaining issue is the modified libtidy, but IMHO the changes are not very intrusive and should be upstreamable. Another issue is packaging FlightCrew in such way that it will also provide XercesExtensions as a library. Any ideas are welcome :-) So let's start with me submitting ZipArchive as a standalone package. Then do FlightCrew and finally Sigil itself. I've just submitted a ZipArchive package based on your work for review, see bug 782823. Here are the changes from your version: * Thu Jan 12 2012 Hans de Goede hdego...@redhat.com - 4.1.1-4 - Make -devel package Requires on main package include isa - Drop buildroot and defattr boilerplate (no longer needed with recent rpm) - Fix building with gcc-4.7 - Fix various rpmlint warnings I'm now working on making the FlightCrew package provide both XercesExtensions and zipios as libraries, since both are duplicated in Sigil itself. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772362] Review Request: sigil - Free, Open Source WYSIWYG ebook editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772362 --- Comment #6 from Dan Horák d...@danny.cz 2012-01-11 08:07:06 EST --- Hans, it's completely fine if you base the packages on my work. But we still need a plan, because the patches are still not complete, my sigil patchset needs to be updated for the external FlightCrew and all patches submitted upstream. There is a good chance he will accept the patches after reading the answer to the Debian guys. And the main remaining issue is the modified libtidy, but IMHO the changes are not very intrusive and should be upstreamable. Another issue is packaging FlightCrew in such way that it will also provide XercesExtensions as a library. Any ideas are welcome :-) So let's start with me submitting ZipArchive as a standalone package. Then do FlightCrew and finally Sigil itself. And the dependency on xerces-3.1 in XercesExtensions (IIRC) limits Sigil to F=16. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772362] Review Request: sigil - Free, Open Source WYSIWYG ebook editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772362 Hans de Goede hdego...@redhat.com changed: What|Removed |Added Flag|needinfo?(hdegoede@redhat.c | |om) | --- Comment #5 from Hans de Goede hdego...@redhat.com 2012-01-09 03:46:39 EST --- Dan, Brendan, I was not aware that FlightCrew and ZipArchive were separate standalone libs. I agree that separating them seems to be the right thing. I'll look into this all as time permits and submit reviews for standalone FlightCrew and ZipArchive packages when I've them + put a link to a new sigil package using them here. Dan, I assume it is ok with you if I base my work of your work? Also I would not mind you submitting them for review, me reviewing them and then co-maintaining them in the future? Regards, Hans -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772362] Review Request: sigil - Free, Open Source WYSIWYG ebook editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772362 Brendan Jones brendan.jones...@gmail.com changed: What|Removed |Added CC||brendan.jones...@gmail.com Flag||needinfo? --- Comment #1 from Brendan Jones brendan.jones...@gmail.com 2012-01-08 09:51:52 EST --- Hi Hans, I'm just wondering whether flightcrew should be packaged on its own? I found this link http://www.mobileread.com/forums/showthread.php?t=140946 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772362] Review Request: sigil - Free, Open Source WYSIWYG ebook editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772362 Dan Horák d...@danny.cz changed: What|Removed |Added CC||d...@danny.cz Flag|needinfo? | --- Comment #2 from Dan Horák d...@danny.cz 2012-01-08 10:43:01 EST --- Please see for my work on unbundling stuff in sigil - http://fedora.danny.cz/sigil/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772362] Review Request: sigil - Free, Open Source WYSIWYG ebook editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772362 --- Comment #3 from Dan Horák d...@danny.cz 2012-01-08 10:54:33 EST --- ZipArchive needs unbundling, see URL above, bzip2 is not needed at all in the GPLed version of ZipArchive. And please also see Debian effort in packaging Sigil at http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=590180 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772362] Review Request: sigil - Free, Open Source WYSIWYG ebook editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772362 Brendan Jones brendan.jones...@gmail.com changed: What|Removed |Added Flag||needinfo?(hdegoede@redhat.c ||om) --- Comment #4 from Brendan Jones brendan.jones...@gmail.com 2012-01-08 15:05:58 EST --- Thanks Dan. Hans, Unbundling is line with Fedora policy unless we can find good reason to make an exception. http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries As it looks like part of the work has already done, I would recommend against seeking an exception. I leave it for the two of you to discuss how you'd like to proceed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
