[Bug 772504] Review Request: btkbdd - Software bluetooth keyboard

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=772504

Lubomir Rintel  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution||NEXTRELEASE
Last Closed||2012-02-16 12:04:24

--- Comment #10 from Lubomir Rintel  2012-02-16 12:04:24 EST ---
Imported and build.
Thank you!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 772504] Review Request: btkbdd - Software bluetooth keyboard

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=772504

--- Comment #9 from Jon Ciesla  2012-02-16 08:22:49 EST 
---
Git done (by process-git-requests).

Michal, please take ownership of review BZs, thanks!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 772504] Review Request: btkbdd - Software bluetooth keyboard

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=772504

Lubomir Rintel  changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #8 from Lubomir Rintel  2012-02-16 04:25:30 EST ---
New Package SCM Request
===
Package Name: btkbdd
Short Description: Software bluetooth keyboard
Owners: lkundrak
Branches: f15 f16 el6 f17

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 772504] Review Request: btkbdd - Software bluetooth keyboard

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=772504

Michal Fojtik  changed:

   What|Removed |Added

 CC||mfoj...@redhat.com
   Flag||fedora-review+

--- Comment #7 from Michal Fojtik  2012-02-16 03:46:43 EST 
---
This package looks safe and match with latest guidelines. It has proper
licence, spec file looks safe enough. Also please don't forget to remove
BuildRoot if you are willing to build this package for Fedora.

Also works nicely with my iPad (/me hides). Good job Lubomir!

review+

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 772504] Review Request: btkbdd - Software bluetooth keyboard

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=772504

--- Comment #6 from Lubomir Rintel  2012-01-09 11:47:19 EST ---
> > > I tried your software but messed up somehow. Let's see if I can get it 
> > > working
> > > for me! :)
> > 
> > Let me know then please. Be sure not to skip manual's BUGS section.
> 
> Hm, I still don't manage, nevermind! :)

I am quite interested, since you probably are second person (apart from me)
that uses the thing and I really intended to make it 'just work' :)

Feel free to reach me at IRC (lkundrak at freenode) or drop a mail at
lubo.rin...@gooddata.com if you don't feel like polluting this review request.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 772504] Review Request: btkbdd - Software bluetooth keyboard

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=772504

--- Comment #5 from Volker Fröhlich  2012-01-09 10:09:26 EST 
---
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > Thank you for your suggestions. Here are the updated packages:
> > > 
> > > SPEC: http://v3.sk/~lkundrak/SPECS/btkbdd.spec
> > > SRPM: http://v3.sk/~lkundrak/SRPMS/btkbdd-1.1-2.el6.src.rpm
> > > 
> > > (In reply to comment #1)
> > > > I think the package summary does not describe the package very well. The
> > > > description gave me a completely different view.
> > > 
> > > What view did it give you? I can't really think of a better description 
> > > and
> > > would appreciate help here.
> > > 
> > 
> > The way you put it now sounds a lot better to me! :)
> 
> Oh, I reworded the summary. I thought you were referring to the description.
> 
> > > > Defattr is no longer necessary. If you're not going for EPEL 5, you can 
> > > > drop
> > > > the clean section, buildroot definition and the rm in the install 
> > > > section.
> > > 
> > 
> > (Defattr is not necessary for EPEL 5 either.)
> 
> rpmlint whines then :(
> Would you mind if I leave it there just to make el6 rpmlint (that I use) 
> happy?

No, just keep it, it doesn't hurt!
> 
> > > > The FSF address is outdated.
> > > 
> > > Changed that to , which seems to be used in GPLv3.
> > 
> > No, I meant the postal address. They moved from Temple Place to Franklin 
> > Street
> > in 2005.
> 
> Yes. The GPLv3 text does not include the postal address, just an URL, thus I
> just leave just an URL here as well.

I see!
> 
> > I tried your software but messed up somehow. Let's see if I can get it 
> > working
> > for me! :)
> 
> Let me know then please. Be sure not to skip manual's BUGS section.

Hm, I still don't manage, nevermind! :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 772504] Review Request: btkbdd - Software bluetooth keyboard

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=772504

--- Comment #4 from Lubomir Rintel  2012-01-09 09:15:13 EST ---
(In reply to comment #3)
> (In reply to comment #2)
> > Thank you for your suggestions. Here are the updated packages:
> > 
> > SPEC: http://v3.sk/~lkundrak/SPECS/btkbdd.spec
> > SRPM: http://v3.sk/~lkundrak/SRPMS/btkbdd-1.1-2.el6.src.rpm
> > 
> > (In reply to comment #1)
> > > I think the package summary does not describe the package very well. The
> > > description gave me a completely different view.
> > 
> > What view did it give you? I can't really think of a better description and
> > would appreciate help here.
> > 
> 
> The way you put it now sounds a lot better to me! :)

Oh, I reworded the summary. I thought you were referring to the description.

> > > Defattr is no longer necessary. If you're not going for EPEL 5, you can 
> > > drop
> > > the clean section, buildroot definition and the rm in the install section.
> > 
> 
> (Defattr is not necessary for EPEL 5 either.)

rpmlint whines then :(
Would you mind if I leave it there just to make el6 rpmlint (that I use) happy?

> > > The FSF address is outdated.
> > 
> > Changed that to , which seems to be used in GPLv3.
> 
> No, I meant the postal address. They moved from Temple Place to Franklin 
> Street
> in 2005.

Yes. The GPLv3 text does not include the postal address, just an URL, thus I
just leave just an URL here as well.

> I tried your software but messed up somehow. Let's see if I can get it working
> for me! :)

Let me know then please. Be sure not to skip manual's BUGS section.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 772504] Review Request: btkbdd - Software bluetooth keyboard

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=772504

--- Comment #3 from Volker Fröhlich  2012-01-09 08:26:17 EST 
---
(In reply to comment #2)
> Thank you for your suggestions. Here are the updated packages:
> 
> SPEC: http://v3.sk/~lkundrak/SPECS/btkbdd.spec
> SRPM: http://v3.sk/~lkundrak/SRPMS/btkbdd-1.1-2.el6.src.rpm
> 
> (In reply to comment #1)
> > I think the package summary does not describe the package very well. The
> > description gave me a completely different view.
> 
> What view did it give you? I can't really think of a better description and
> would appreciate help here.
> 

The way you put it now sounds a lot better to me! :)

> > Defattr is no longer necessary. If you're not going for EPEL 5, you can drop
> > the clean section, buildroot definition and the rm in the install section.
> 

(Defattr is not necessary for EPEL 5 either.)

> I choose not to break compatibility with el5 rebuilds for packages that 
> rebuild
> cleanly. As it gets more obsolete, I'll remove those parts.
> 
> > Please use the name macro, as you did in Source. Looking at your manpage, 
> > you
> > forgot a "d" in %{_localstatedir}/lib/btkbd.
> 
> The manpage was actually wrong (the example udev rules wrote to
> /var/lib/btkbd). However, it makes more sense with two "d"s, so I adjusted 
> that
> appropriately.
> 
> > There's a macro called sharedstatedir, by the way, that is equivalent to
> > %{_localstatedir}/lib.
> 
> This would break el5 builds:
> 
> $ rpm --eval %_sharedstatedir
> /usr/com
> 
Ah, I wasn't aware of that.

> > The FSF address is outdated.
> 
> Changed that to , which seems to be used in GPLv3.

No, I meant the postal address. They moved from Temple Place to Franklin Street
in 2005.

> > Why do you want to own %{_sysconfdir}/udev/rules.d?
> 
> That was a mistake. Removed it.
> 
> > Why do you require pod2man explicitly?
> 
> I choose to :)
> 
> It is not intuitively obvious (to me) that it is part of perl, nor that it
> won't change in future or that perl will stay in build group forever. Though
> all of that is unlikely, I like it to be specified explicitly.

I tried your software but messed up somehow. Let's see if I can get it working
for me! :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 772504] Review Request: btkbdd - Software bluetooth keyboard

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=772504

--- Comment #2 from Lubomir Rintel  2012-01-09 04:34:57 EST ---
Thank you for your suggestions. Here are the updated packages:

SPEC: http://v3.sk/~lkundrak/SPECS/btkbdd.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/btkbdd-1.1-2.el6.src.rpm

(In reply to comment #1)
> I think the package summary does not describe the package very well. The
> description gave me a completely different view.

What view did it give you? I can't really think of a better description and
would appreciate help here.

> Defattr is no longer necessary. If you're not going for EPEL 5, you can drop
> the clean section, buildroot definition and the rm in the install section.

I choose not to break compatibility with el5 rebuilds for packages that rebuild
cleanly. As it gets more obsolete, I'll remove those parts.

> Please use the name macro, as you did in Source. Looking at your manpage, you
> forgot a "d" in %{_localstatedir}/lib/btkbd.

The manpage was actually wrong (the example udev rules wrote to
/var/lib/btkbd). However, it makes more sense with two "d"s, so I adjusted that
appropriately.

> There's a macro called sharedstatedir, by the way, that is equivalent to
> %{_localstatedir}/lib.

This would break el5 builds:

$ rpm --eval %_sharedstatedir
/usr/com

> The FSF address is outdated.

Changed that to , which seems to be used in GPLv3.

> Why do you want to own %{_sysconfdir}/udev/rules.d?

That was a mistake. Removed it.

> Why do you require pod2man explicitly?

I choose to :)

It is not intuitively obvious (to me) that it is part of perl, nor that it
won't change in future or that perl will stay in build group forever. Though
all of that is unlikely, I like it to be specified explicitly.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 772504] Review Request: btkbdd - Software bluetooth keyboard

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=772504

Volker Fröhlich  changed:

   What|Removed |Added

 CC||volke...@gmx.at

--- Comment #1 from Volker Fröhlich  2012-01-09 03:12:12 EST 
---
I think the package summary does not describe the package very well. The
description gave me a completely different view.

Defattr is no longer necessary. If you're not going for EPEL 5, you can drop
the clean section, buildroot definition and the rm in the install section.

Please use the name macro, as you did in Source. Looking at your manpage, you
forgot a "d" in %{_localstatedir}/lib/btkbd.

There's a macro called sharedstatedir, by the way, that is equivalent to
%{_localstatedir}/lib.

The FSF address is outdated.

Why do you want to own %{_sysconfdir}/udev/rules.d?

Why do you require pod2man explicitly?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review