[Bug 772594] Review Request: felix-gogo-command - Provides basic shell commands for apache felix Gogo.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772594 Krzysztof Daniel kdan...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Last Closed||2012-01-11 03:30:02 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772594] Review Request: felix gogo command - Provides basic shell commands for apache felix Gogo.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=772594
--- Comment #6 from Alexander Kurtakov akurt...@redhat.com 2012-01-10
03:04:11 EST ---
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
Generic
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported architecture.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[!]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
[!]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[!]: MUST License file installed when any subpackage combination is installed.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
names).
[x]: MUST Package meets the Packaging Guidelines.
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generates any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[!]: MUST Rpmlint output is silent.
rpmlint felix-gogo-command-0.12.0-1.fc17.noarch.rpm
felix-gogo-command.noarch: W: incoherent-version-in-changelog 0.12.0
['0.12.0-1.fc17', '0.12.0-1']
felix-gogo-command.noarch: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
rpmlint felix-gogo-command-0.12.0-1.fc17.src.rpm
felix-gogo-command.src:17: W: mixed-use-of-spaces-and-tabs (spaces: line 9,
tab: line 17)
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
rpmlint felix-gogo-command-javadoc-0.12.0-1.fc17.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
/home/akurtakov/tmp/772594/org.apache.felix.gogo.command-0.12.0-project.tar.gz
:
MD5SUM this package : de755fb40d8512ba9ed261cbbcd077f3
MD5SUM upstream package : de755fb40d8512ba9ed261cbbcd077f3
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[x]: SHOULD Reviewer should test that the package builds in mock.
[x]: SHOULD If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to
include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[x]: SHOULD Package functions as described.
[x]: SHOULD Package does not include license text files separate from
upstream.
[x]: SHOULD Patches link to upstream bugs/comments/lists or are otherwise
justified.
[!]: SHOULD SourceX / PatchY prefixed with %{name}.
Note: Patch0: 0001-pom.xml.patch (0001-pom.xml.patch)
[x]: SHOULD SourceX is a working URL.
[-]: SHOULD Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: SHOULD
[Bug 772594] Review Request: felix gogo command - Provides basic shell commands for apache felix Gogo.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772594 --- Comment #7 from Krzysztof Daniel kdan...@redhat.com 2012-01-10 04:00:31 EST --- A new version - I *think* I have addressed all the issues. Spec URL: http://libra.cs.put.poznan.pl/kdaniel/felix-gogo-command3/felix-gogo-command.spec SRPM URL: http://libra.cs.put.poznan.pl/kdaniel/felix-gogo-command3/felix-gogo-command-0.12.0-1.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772594] Review Request: felix gogo command - Provides basic shell commands for apache felix Gogo.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772594 --- Comment #8 from Alexander Kurtakov akurt...@redhat.com 2012-01-10 04:56:25 EST --- Well still few more issues: * everytime you do changes you're supposed to bump the release and add a changelog entry describing the change. * jar_repack definition is still there please remove it * javadoc subpackage is still missing License - please add %doc LICENSE in the %files javadoc section * there is no need to do formatting in %description - please drop the empty line -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772594] Review Request: felix gogo command - Provides basic shell commands for apache felix Gogo.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772594 --- Comment #9 from Krzysztof Daniel kdan...@redhat.com 2012-01-10 05:32:34 EST --- Spec URL: http://libra.cs.put.poznan.pl/kdaniel/felix-gogo-command4/felix-gogo-command.spec SRPM URL: http://libra.cs.put.poznan.pl/kdaniel/felix-gogo-command4/felix-gogo-command-0.12.0-2.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772594] Review Request: felix gogo command - Provides basic shell commands for apache felix Gogo.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772594 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #10 from Alexander Kurtakov akurt...@redhat.com 2012-01-10 06:15:36 EST --- Thanks, APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772594] Review Request: felix gogo command - Provides basic shell commands for apache felix Gogo.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772594 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) | --- Comment #11 from Alexander Kurtakov akurt...@redhat.com 2012-01-10 06:50:33 EST --- Sponsored. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772594] Review Request: felix gogo command - Provides basic shell commands for apache felix Gogo.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772594 Krzysztof Daniel kdan...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #12 from Krzysztof Daniel kdan...@redhat.com 2012-01-10 07:40:04 EST --- New Package SCM Request === Package Name: felix-gogo-command Short Description: Provides basic shell commands for Gogo. Owners: kdaniel Branches: f16 InitialCC: akurtakov -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772594] Review Request: felix gogo command - Provides basic shell commands for apache felix Gogo.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772594 --- Comment #13 from Jon Ciesla limburg...@gmail.com 2012-01-10 08:02:37 EST --- Summary and SCM request package names don't match, and cannot contain spaces. Please fix. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772594] Review Request: felix-gogo-command - Provides basic shell commands for apache felix Gogo.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772594 Krzysztof Daniel kdan...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #14 from Krzysztof Daniel kdan...@redhat.com 2012-01-10 08:12:37 EST --- bug title updated -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772594] Review Request: felix-gogo-command - Provides basic shell commands for apache felix Gogo.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772594 Krzysztof Daniel kdan...@redhat.com changed: What|Removed |Added Summary|Review Request: felix gogo |Review Request: |command - Provides basic|felix-gogo-command - |shell commands for apache |Provides basic shell |felix Gogo. |commands for apache felix ||Gogo. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772594] Review Request: felix-gogo-command - Provides basic shell commands for apache felix Gogo.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772594 --- Comment #15 from Jon Ciesla limburg...@gmail.com 2012-01-10 08:54:16 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772594] Review Request: felix gogo command - Provides basic shell commands for apache felix Gogo.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772594 Krzysztof Daniel kdan...@redhat.com changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772594] Review Request: felix gogo command - Provides basic shell commands for apache felix Gogo.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772594 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||akurt...@redhat.com AssignedTo|nob...@fedoraproject.org|akurt...@redhat.com Flag||fedora-review? --- Comment #1 from Alexander Kurtakov akurt...@redhat.com 2012-01-09 06:29:58 EST --- I'll do this one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772594] Review Request: felix gogo command - Provides basic shell commands for apache felix Gogo.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772594 --- Comment #2 from Alexander Kurtakov akurt...@redhat.com 2012-01-09 08:55:25 EST --- It fails to build in mock. [ERROR] The build could not read 1 project - [Help 1] [ERROR] [ERROR] The project org.apache.felix:org.apache.felix.gogo.command:0.12.0 (/builddir/build/BUILD/org.apache.felix.gogo.command-0.12.0/pom.xml) has 1 error [ERROR] Non-resolvable parent POM: The repository system is offline but the artifact org.apache.felix:gogo-parent:pom:0.6.0 is not available in the local repository. and 'parent.relativePath' points at wrong local POM @ line 22, column 11 - [Help 2] You should try a mock build in order to verify you have all the buildrequires specified. In this case there is a missing BuildRequires: felix-gogo-parent. Details on using mock are at http://fedoraproject.org/wiki/Using_Mock_to_test_package_builds or at http://fedoraproject.org/wiki/Fedora_Packager_For_Eclipse_User_Guide . Please also fill the changelog. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772594] Review Request: felix gogo command - Provides basic shell commands for apache felix Gogo.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772594 --- Comment #3 from Krzysztof Daniel kdan...@redhat.com 2012-01-09 12:42:26 EST --- I have updated the spec. Here is a new version: http://libra.cs.put.poznan.pl/kdaniel/felix-gogo-command2/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772594] Review Request: felix gogo command - Provides basic shell commands for apache felix Gogo.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772594 --- Comment #4 from Alexander Kurtakov akurt...@redhat.com 2012-01-09 13:49:45 EST --- Spec URL: http://libra.cs.put.poznan.pl/kdaniel/felix-gogo-command2/felix-gogo-command.spec SRPM URL: http://libra.cs.put.poznan.pl/kdaniel/felix-gogo-command2/felix-gogo-command-0.12.0-1.fc15.src.rpm For completeness (and fedora-review ). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772594] Review Request: felix gogo command - Provides basic shell commands for apache felix Gogo.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772594 --- Comment #5 from Alexander Kurtakov akurt...@redhat.com 2012-01-09 13:51:15 EST --- One more time correct links. Spec URL: http://libra.cs.put.poznan.pl/kdaniel/felix-gogo-command2/felix-gogo-command.spec SRPM URL: http://libra.cs.put.poznan.pl/kdaniel/felix-gogo-command2/felix-gogo-command-0.12.0-1.fc17.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
