[Bug 772988] Review Request: globus-gram-job-manager-pbs - Globus Toolkit - PBS Job Manager Support
https://bugzilla.redhat.com/show_bug.cgi?id=772988 --- Comment #2 from Mattias Ellert --- Updated package: http://www.grid.tsl.uu.se/review/globus-gram-job-manager-pbs.spec http://www.grid.tsl.uu.se/review/globus-gram-job-manager-pbs-1.5-1.fc16.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772988] Review Request: globus-gram-job-manager-pbs - Globus Toolkit - PBS Job Manager Support
https://bugzilla.redhat.com/show_bug.cgi?id=772988 Adam Huffman changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|bl...@verdurin.com --- Comment #3 from Adam Huffman --- I'll review this within a couple of days. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772988] Review Request: globus-gram-job-manager-pbs - Globus Toolkit - PBS Job Manager Support
https://bugzilla.redhat.com/show_bug.cgi?id=772988 Adam Huffman changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772988] Review Request: globus-gram-job-manager-pbs - Globus Toolkit - PBS Job Manager Support
https://bugzilla.redhat.com/show_bug.cgi?id=772988 --- Comment #4 from Adam Huffman --- I will review this package -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772988] Review Request: globus-gram-job-manager-pbs - Globus Toolkit - PBS Job Manager Support
https://bugzilla.redhat.com/show_bug.cgi?id=772988
--- Comment #5 from Adam Huffman ---
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
C/C++
[x]: MUST Header files in -devel subpackage, if present.
[x]: MUST ldconfig called in %post and %postun if required.
[!]: MUST Package does not contain any libtool archives (.la)
Note: globus-gram-job-manager-pbs-setup-seg-1.5-1.fc17.x86_64.rpm :
globus-gram-job-manager-pbs-setup-seg-1.5-1.fc17.x86_64.rpm globus-gram-
job-manager-pbs-setup-seg-1.5-1.fc17.x86_64.rpm : globus-gram-job-
manager-pbs-debuginfo-1.5-1.fc17.x86_64.rpm globus-gram-job-manager-pbs-
setup-seg-1.5-1.fc17.x86_64.rpm : globus-gram-job-manager-pbs-setup-
poll-1.5-1.fc17.noarch.rpm globus-gram-job-manager-pbs-setup-
seg-1.5-1.fc17.x86_64.rpm : globus-gram-job-manager-
pbs-1.5-1.fc17.x86_64.rpm globus-gram-job-manager-pbs-
debuginfo-1.5-1.fc17.x86_64.rpm : globus-gram-job-manager-pbs-setup-
seg-1.5-1.fc17.x86_64.rpm globus-gram-job-manager-pbs-
debuginfo-1.5-1.fc17.x86_64.rpm : globus-gram-job-manager-pbs-
debuginfo-1.5-1.fc17.x86_64.rpm globus-gram-job-manager-pbs-
debuginfo-1.5-1.fc17.x86_64.rpm : globus-gram-job-manager-pbs-setup-
poll-1.5-1.fc17.noarch.rpm globus-gram-job-manager-pbs-
debuginfo-1.5-1.fc17.x86_64.rpm : globus-gram-job-manager-
pbs-1.5-1.fc17.x86_64.rpm globus-gram-job-manager-pbs-setup-
poll-1.5-1.fc17.noarch.rpm : globus-gram-job-manager-pbs-setup-
seg-1.5-1.fc17.x86_64.rpm globus-gram-job-manager-pbs-setup-
poll-1.5-1.fc17.noarch.rpm : globus-gram-job-manager-pbs-
debuginfo-1.5-1.fc17.x86_64.rpm globus-gram-job-manager-pbs-setup-
poll-1.5-1.fc17.noarch.rpm : globus-gram-job-manager-pbs-setup-
poll-1.5-1.fc17.noarch.rpm globus-gram-job-manager-pbs-setup-
poll-1.5-1.fc17.noarch.rpm : globus-gram-job-manager-
pbs-1.5-1.fc17.x86_64.rpm globus-gram-job-manager-
pbs-1.5-1.fc17.x86_64.rpm : globus-gram-job-manager-pbs-setup-
seg-1.5-1.fc17.x86_64.rpm globus-gram-job-manager-
pbs-1.5-1.fc17.x86_64.rpm : globus-gram-job-manager-pbs-
debuginfo-1.5-1.fc17.x86_64.rpm globus-gram-job-manager-
pbs-1.5-1.fc17.x86_64.rpm : globus-gram-job-manager-pbs-setup-
poll-1.5-1.fc17.noarch.rpm globus-gram-job-manager-
pbs-1.5-1.fc17.x86_64.rpm : globus-gram-job-manager-
pbs-1.5-1.fc17.x86_64.rpm
[ ]: MUST Package does not contain kernel modules.
[ ]: MUST Package contains no static executables.
[x]: MUST Rpath absent or only used for internal libs.
Generic
[x]: EXTRA Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: EXTRA Spec file according to URL is the same as in SRPM.
[ ]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[ ]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[ ]: MUST Package contains no bundled libraries.
[ ]: MUST Changelog in prescribed format.
[ ]: MUST Sources contain only permissible code or content.
[x]: MUST %config files are marked noreplace or the reason is justified.
[!]: MUST Each %files section contains %defattr if rpm < 4.4
Note: defattr() present in %files -f package.filelist section. This
is OK if packaging for EPEL5. Otherwise not needed
[ ]: MUST Macros in Summary, %description expandable at SRPM build time.
[ ]: MUST Package contains desktop file if it is a GUI application.
[ ]: MUST Development files must be in a -devel package
[ ]: MUST Package requires other packages for directories it uses.
[ ]: MUST Package uses nothing in %doc for runtime.
[ ]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Fully versioned dependency in subpackages, if present.
[ ]: MUST Package complies to the Packaging Guidelines
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf is only needed if supporting EPEL5
[ ]: MUST Large documentation files are in a -doc subpackage, if required.
[!]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[ ]: MUST License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Apache (v2.0)", "GPL (v2
[Bug 772988] Review Request: globus-gram-job-manager-pbs - Globus Toolkit - PBS Job Manager Support
https://bugzilla.redhat.com/show_bug.cgi?id=772988 --- Comment #6 from Mattias Ellert --- Thank you for looking at this review request. The reason for including the .la file in the package is stated in a comment in the spec file: # This library is opened using lt_dlopenext, so the libtool archive # (.la file) can not be removed The plugin handling in the Globus Toolkit is based on the use of the libtool dynamic loader library (libltdl). This mechanism works by first parsing the .la file to obtain the full name of the library to open (including the soname) and then dynamically opening the versioned library. Without the .la file present the lookup will not work. Other globus packages that provides libraries that are opened using this mechanism already include the .la file in the packages: /usr/lib64/libglobus_seg_job_manager.la /usr/lib64/libglobus_thread_pthread.la /usr/lib64/libglobus_xio_gsi_driver.la /usr/lib64/libglobus_xio_pipe_driver.la /usr/lib64/libglobus_xio_popen_driver.la This is also approved by the Packaging Guidelines: https://fedoraproject.org/wiki/Packaging:Globus#Plugins -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772988] Review Request: globus-gram-job-manager-pbs - Globus Toolkit - PBS Job Manager Support
https://bugzilla.redhat.com/show_bug.cgi?id=772988 Adam Huffman changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #7 from Adam Huffman --- Thanks for the clarification. Same comment applies as to the other package - consider making the use of macros consistent in a future release. APPROVED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772988] Review Request: globus-gram-job-manager-pbs - Globus Toolkit - PBS Job Manager Support
https://bugzilla.redhat.com/show_bug.cgi?id=772988 Mattias Ellert changed: What|Removed |Added Flags||fedora-cvs? --- Comment #8 from Mattias Ellert --- Many thanks for the review. New Package SCM Request === Package Name: globus-gram-job-manager-pbs Short Description: Globus Toolkit - PBS Job Manager Support Owners: ellert Branches: f16 f17 f18 f19 el5 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772988] Review Request: globus-gram-job-manager-pbs - Globus Toolkit - PBS Job Manager Support
https://bugzilla.redhat.com/show_bug.cgi?id=772988 --- Comment #9 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772988] Review Request: globus-gram-job-manager-pbs - Globus Toolkit - PBS Job Manager Support
https://bugzilla.redhat.com/show_bug.cgi?id=772988 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772988] Review Request: globus-gram-job-manager-pbs - Globus Toolkit - PBS Job Manager Support
https://bugzilla.redhat.com/show_bug.cgi?id=772988 --- Comment #10 from Fedora Update System --- globus-gram-job-manager-sge-1.5-1.fc18,globus-gram-job-manager-pbs-1.5-1.fc18,globus-gram-job-manager-fork-1.5-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/globus-gram-job-manager-sge-1.5-1.fc18,globus-gram-job-manager-pbs-1.5-1.fc18,globus-gram-job-manager-fork-1.5-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772988] Review Request: globus-gram-job-manager-pbs - Globus Toolkit - PBS Job Manager Support
https://bugzilla.redhat.com/show_bug.cgi?id=772988 --- Comment #11 from Fedora Update System --- globus-gram-job-manager-sge-1.5-1.el6,globus-gram-job-manager-pbs-1.5-1.el6,globus-gram-job-manager-fork-1.5-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/globus-gram-job-manager-sge-1.5-1.el6,globus-gram-job-manager-pbs-1.5-1.el6,globus-gram-job-manager-fork-1.5-1.el6 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772988] Review Request: globus-gram-job-manager-pbs - Globus Toolkit - PBS Job Manager Support
https://bugzilla.redhat.com/show_bug.cgi?id=772988 --- Comment #12 from Fedora Update System --- globus-gram-job-manager-sge-1.5-1.fc16,globus-gram-job-manager-pbs-1.5-1.fc16,globus-gram-job-manager-fork-1.5-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/globus-gram-job-manager-sge-1.5-1.fc16,globus-gram-job-manager-pbs-1.5-1.fc16,globus-gram-job-manager-fork-1.5-1.fc16 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772988] Review Request: globus-gram-job-manager-pbs - Globus Toolkit - PBS Job Manager Support
https://bugzilla.redhat.com/show_bug.cgi?id=772988 --- Comment #13 from Fedora Update System --- globus-gram-job-manager-sge-1.5-1.el5,globus-gram-job-manager-pbs-1.5-1.el5,globus-gram-job-manager-fork-1.5-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/globus-gram-job-manager-sge-1.5-1.el5,globus-gram-job-manager-pbs-1.5-1.el5,globus-gram-job-manager-fork-1.5-1.el5 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772988] Review Request: globus-gram-job-manager-pbs - Globus Toolkit - PBS Job Manager Support
https://bugzilla.redhat.com/show_bug.cgi?id=772988 --- Comment #14 from Fedora Update System --- globus-gram-job-manager-sge-1.5-1.fc17,globus-gram-job-manager-pbs-1.5-1.fc17,globus-gram-job-manager-fork-1.5-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/globus-gram-job-manager-sge-1.5-1.fc17,globus-gram-job-manager-pbs-1.5-1.fc17,globus-gram-job-manager-fork-1.5-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772988] Review Request: globus-gram-job-manager-pbs - Globus Toolkit - PBS Job Manager Support
https://bugzilla.redhat.com/show_bug.cgi?id=772988 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #15 from Fedora Update System --- globus-gram-job-manager-sge-1.5-1.fc18, globus-gram-job-manager-pbs-1.5-1.fc18, globus-gram-job-manager-fork-1.5-1.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772988] Review Request: globus-gram-job-manager-pbs - Globus Toolkit - PBS Job Manager Support
https://bugzilla.redhat.com/show_bug.cgi?id=772988 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2012-09-17 19:39:18 --- Comment #16 from Fedora Update System --- globus-gram-job-manager-sge-1.5-1.fc18, globus-gram-job-manager-pbs-1.5-1.fc18, globus-gram-job-manager-fork-1.5-1.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772988] Review Request: globus-gram-job-manager-pbs - Globus Toolkit - PBS Job Manager Support
https://bugzilla.redhat.com/show_bug.cgi?id=772988 --- Comment #17 from Fedora Update System --- globus-gram-job-manager-sge-1.5-1.fc17, globus-gram-job-manager-pbs-1.5-1.fc17, globus-gram-job-manager-fork-1.5-1.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772988] Review Request: globus-gram-job-manager-pbs - Globus Toolkit - PBS Job Manager Support
https://bugzilla.redhat.com/show_bug.cgi?id=772988 --- Comment #18 from Fedora Update System --- globus-gram-job-manager-sge-1.5-1.fc16, globus-gram-job-manager-pbs-1.5-1.fc16, globus-gram-job-manager-fork-1.5-1.fc16 has been pushed to the Fedora 16 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772988] Review Request: globus-gram-job-manager-pbs - Globus Toolkit - PBS Job Manager Support
https://bugzilla.redhat.com/show_bug.cgi?id=772988 --- Comment #19 from Fedora Update System --- globus-gram-job-manager-sge-1.5-1.el5, globus-gram-job-manager-pbs-1.5-1.el5, globus-gram-job-manager-fork-1.5-1.el5 has been pushed to the Fedora EPEL 5 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772988] Review Request: globus-gram-job-manager-pbs - Globus Toolkit - PBS Job Manager Support
https://bugzilla.redhat.com/show_bug.cgi?id=772988 --- Comment #20 from Fedora Update System --- globus-gram-job-manager-sge-1.5-1.el6, globus-gram-job-manager-pbs-1.5-1.el6, globus-gram-job-manager-fork-1.5-1.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 772988] Review Request: globus-gram-job-manager-pbs - Globus Toolkit - PBS Job Manager Support
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=772988 --- Comment #1 from Mattias Ellert 2012-01-30 03:53:40 EST --- Updated package: http://www.grid.tsl.uu.se/review/globus-gram-job-manager-pbs.spec http://www.grid.tsl.uu.se/review/globus-gram-job-manager-pbs-1.1-2.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
