[Bug 773492] Review Request: ibsim - InfiniBand network simulator
https://bugzilla.redhat.com/show_bug.cgi?id=773492 Jon Stanley jonstan...@gmail.com changed: What|Removed |Added Status|NEW |CLOSED CC||jonstan...@gmail.com Resolution|--- |INSUFFICIENT_DATA Flags|needinfo? | Last Closed||2014-01-21 08:33:10 --- Comment #12 from Jon Stanley jonstan...@gmail.com --- Sure thing. Since there's nothing different from this bug other than the maintainer, I'm just going to clone it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 773492] Review Request: ibsim - InfiniBand network simulator
https://bugzilla.redhat.com/show_bug.cgi?id=773492 Jon Stanley jonstan...@gmail.com changed: What|Removed |Added Blocks||1056054 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1056054 [Bug 1056054] Review Request: ibsim - InfiniBand network simulator -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 773492] Review Request: ibsim - InfiniBand network simulator
https://bugzilla.redhat.com/show_bug.cgi?id=773492 --- Comment #11 from Jiri Popelka jpope...@redhat.com --- Wow, looks like the one who's actually been unresponsive here has been me - no idea why I haven't responded to comment #6. Anyway, Jon, as others pointed out it'd probably be better to fill a new request and make this one duplicate of it. Could you do that ? Thanks -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 773492] Review Request: ibsim - InfiniBand network simulator
https://bugzilla.redhat.com/show_bug.cgi?id=773492 Volker Fröhlich volke...@gmx.at changed: What|Removed |Added Flags||needinfo? --- Comment #10 from Volker Fröhlich volke...@gmx.at --- Now how is this going to continue? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 773492] Review Request: ibsim - InfiniBand network simulator
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=773492 --- Comment #9 from Thomas Moschny thomas.mosc...@gmx.de --- (In reply to comment #8) Huh? This is just a change in maintainer from Doug to me. I'll happily open a new request if wanted, but it doesn't seem to apply in this case. The last section in http://fedoraproject.org/wiki/Policy_for_stalled_package_reviews can be read in such a way that when the original submitter is not going to finish the submission, a new ticket shall be opened by the new/next submitter. While meant for the case of a not responding submitter, I'd say the procedure itself also fits here. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aDD84vK3swa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 773492] Review Request: ibsim - InfiniBand network simulator
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=773492 Volker Fröhlich volke...@gmx.at changed: What|Removed |Added CC||volke...@gmx.at --- Comment #7 from Volker Fröhlich volke...@gmx.at --- I think you should open a new review request then. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=T2jLqVee4na=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 773492] Review Request: ibsim - InfiniBand network simulator
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=773492 Jon Stanley jon.stan...@gs.com changed: What|Removed |Added CC||jon.stan...@gs.com --- Comment #8 from Jon Stanley jon.stan...@gs.com --- Huh? This is just a change in maintainer from Doug to me. I'll happily open a new request if wanted, but it doesn't seem to apply in this case. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hrIdxrWJdJa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 773492] Review Request: ibsim - InfiniBand network simulator
https://bugzilla.redhat.com/show_bug.cgi?id=773492 --- Comment #6 from Jon Stanley jstan...@rmrf.net --- New SRPM: http://jstanley.fedorapeople.org/ibsim-0.5-6.20120810git.fc19.src.rpm New spec: http://jstanley.fedorapeople.org/ibsim.spec -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 773492] Review Request: ibsim - InfiniBand network simulator
https://bugzilla.redhat.com/show_bug.cgi?id=773492 Jon Stanley jstan...@rmrf.net changed: What|Removed |Added CC||jstan...@rmrf.net --- Comment #5 from Jon Stanley jstan...@rmrf.net --- I'll take this review from Doug after talking with him. I'll get this one taken care of shortly. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 773492] Review Request: ibsim - InfiniBand network simulator
https://bugzilla.redhat.com/show_bug.cgi?id=773492
Jiri Popelka jpope...@redhat.com changed:
What|Removed |Added
CC||jpope...@redhat.com
Assignee|nob...@fedoraproject.org|jpope...@redhat.com
Flags||fedora-review?
--- Comment #4 from Jiri Popelka jpope...@redhat.com ---
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
C/C++
[-]: MUST Header files in -devel subpackage, if present.
[x]: MUST Package does not contain any libtool archives (.la)
[x]: MUST Package does not contain kernel modules.
[x]: MUST Rpath absent or only used for internal libs.
[x]: MUST Package is not relocatable.
[x]: MUST Development (unversioned) .so files in -devel subpackage, if present.
%{_libdir}/umad2sim/libumad2sim.so is ok in main package because it's not used
for development.
Also there seem to be no versioned library files installed, so
%{_libdir}/umad2sim/libumad2sim*.so*
could be I think changed to
%{_libdir}/umad2sim/libumad2sim.so
Generic
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[!]: MUST Buildroot is not present
See https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[!]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
See https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean
[x]: MUST Sources contain only permissible code or content.
[!]: MUST Each %files section contains %defattr if rpm 4.4
No need to use %defattr macro,
see https://fedoraproject.org/wiki/Packaging/Guidelines#File_Permissions
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[-]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[!]: MUST Package is not known to require ExcludeArch.
see
https://fedoraproject.org/wiki/Architectures#ExcludeArch_.26_ExclusiveArch
https://fedoraproject.org/wiki/Architectures#Tracker_Bugs
https://fedoraproject.org/wiki/Packaging/Guidelines#Architecture_Build_Failures
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
See https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
[-]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
names).
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[!]: MUST Package must own all directories that it creates.
It creates %{_libdir}/umad2sim/, doesn't it ?
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint output is silent.
Just some harmless warnings.
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
MD5SUM this package : 8f4928dbee64b0c0caaf838d03d95a86
MD5SUM upstream package : 8f4928dbee64b0c0caaf838d03d95a86
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: MUST File names are valid UTF-8.
[x]: MUST Useful -debuginfo package or justification otherwise.
[x]: SHOULD Reviewer should test that the package builds in mock.
[x]: SHOULD Dist tag is present.
[x]: SHOULD Latest version is packaged.
[x]: SHOULD SourceX is a working URL.
I didn't find any openib[-diag] package, so I think the
Conflicts: openib-diags 1.3
line could be removed.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
[Bug 773492] Review Request: ibsim - InfiniBand network simulator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=773492 --- Comment #1 from Doug Ledford dledf...@redhat.com 2012-01-11 18:28:13 EST --- [dledford@schwoop SPECS]$ rpmlint ibsim.spec ../SRPMS/ibsim-0.5-5.fc15.src.rpm ../RPMS/x86_64/ibsim-* ibsim.src: W: spelling-error %description -l en_US infiniband - infinitude ibsim.x86_64: W: spelling-error %description -l en_US infiniband - infinitude ibsim.x86_64: W: no-manual-page-for-binary ibsim 3 packages and 1 specfiles checked; 0 errors, 3 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 773492] Review Request: ibsim - InfiniBand network simulator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=773492 --- Comment #2 from Doug Ledford dledf...@redhat.com 2012-01-11 18:28:38 EST --- Created attachment 552254 -- https://bugzilla.redhat.com/attachment.cgi?id=552254 ibsim spec file -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 773492] Review Request: ibsim - InfiniBand network simulator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=773492 --- Comment #3 from Albert Strasheim full...@gmail.com 2012-01-12 00:52:13 EST --- Looks good. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
