[Bug 784175] Review Request: SuperLU - Subroutines to solve sparse linear systems
https://bugzilla.redhat.com/show_bug.cgi?id=784175 Björn besser82 Esser bjoern.es...@gmail.com changed: What|Removed |Added CC||bjoern.es...@gmail.com Flags|fedora-cvs+ |fedora-cvs? --- Comment #21 from Björn besser82 Esser bjoern.es...@gmail.com --- Package Change Request == Package Name: SuperLU New Branches: el5 el6 Owners: besser82 shakthimaan InitialCC: ml-sig I want to build this for el = 6, because this is a BR for my WIP eigen3 = 3.2.0 for those epel-branches. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 784175] Review Request: SuperLU - Subroutines to solve sparse linear systems
https://bugzilla.redhat.com/show_bug.cgi?id=784175 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 784175] Review Request: SuperLU - Subroutines to solve sparse linear systems
https://bugzilla.redhat.com/show_bug.cgi?id=784175 --- Comment #22 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 784175] Review Request: SuperLU - Subroutines to solve sparse linear systems
https://bugzilla.redhat.com/show_bug.cgi?id=784175 --- Comment #20 from Fedora Update System upda...@fedoraproject.org --- SuperLU-4.3-3.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 784175] Review Request: SuperLU - Subroutines to solve sparse linear systems
https://bugzilla.redhat.com/show_bug.cgi?id=784175 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2012-09-08 22:48:13 --- Comment #18 from Fedora Update System upda...@fedoraproject.org --- SuperLU-4.3-3.fc16 has been pushed to the Fedora 16 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 784175] Review Request: SuperLU - Subroutines to solve sparse linear systems
https://bugzilla.redhat.com/show_bug.cgi?id=784175 --- Comment #19 from Fedora Update System upda...@fedoraproject.org --- SuperLU-4.3-3.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 784175] Review Request: SuperLU - Subroutines to solve sparse linear systems
https://bugzilla.redhat.com/show_bug.cgi?id=784175 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|RELEASE_PENDING |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 784175] Review Request: SuperLU - Subroutines to solve sparse linear systems
https://bugzilla.redhat.com/show_bug.cgi?id=784175 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- SuperLU-4.3-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/SuperLU-4.3-3.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 784175] Review Request: SuperLU - Subroutines to solve sparse linear systems
https://bugzilla.redhat.com/show_bug.cgi?id=784175 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- SuperLU-4.3-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/SuperLU-4.3-3.fc16 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 784175] Review Request: SuperLU - Subroutines to solve sparse linear systems
https://bugzilla.redhat.com/show_bug.cgi?id=784175 --- Comment #16 from Fedora Update System upda...@fedoraproject.org --- SuperLU-4.3-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/SuperLU-4.3-3.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 784175] Review Request: SuperLU - Subroutines to solve sparse linear systems
https://bugzilla.redhat.com/show_bug.cgi?id=784175 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #17 from Fedora Update System upda...@fedoraproject.org --- SuperLU-4.3-3.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 784175] Review Request: SuperLU - Subroutines to solve sparse linear systems
https://bugzilla.redhat.com/show_bug.cgi?id=784175 Shakthi Kannan shakthim...@gmail.com changed: What|Removed |Added Status|ASSIGNED|RELEASE_PENDING Flags||fedora-cvs? --- Comment #12 from Shakthi Kannan shakthim...@gmail.com --- Thanks for the review. New Package SCM Request === Package Name: SuperLU Short Description: Subroutines to solve sparse linear systems Owners: shakthimaan Branches: f16 f17 f18 InitialCC: shakthimaan -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 784175] Review Request: SuperLU - Subroutines to solve sparse linear systems
https://bugzilla.redhat.com/show_bug.cgi?id=784175 --- Comment #13 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 784175] Review Request: SuperLU - Subroutines to solve sparse linear systems
https://bugzilla.redhat.com/show_bug.cgi?id=784175 Jerry James loganje...@gmail.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #11 from Jerry James loganje...@gmail.com --- OK, it looks great. This package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 784175] Review Request: SuperLU - Subroutines to solve sparse linear systems
https://bugzilla.redhat.com/show_bug.cgi?id=784175
--- Comment #10 from Shakthi Kannan shakthim...@gmail.com ---
Thanks for the review.
I have made the following changes:
- Use README in main package and DOC in devel package
- chmod a-x on SRC/qselect.c
- Remove -latlas linking in prep section
- Added Patch comments
- Use name RPM macro in patch name
Will inform upstream about not using exit in the library.
I would like the package to be made available for EPEL5, and hence have not
removed rm -rf %{buildroot} from %install, and %defattr from both %files
sections.
I haven't added the testing check, because, it uses the static library, which
we don't build now.
Updated:
SPEC: http://shakthimaan.fedorapeople.org/SPECS/SuperLU.spec
SRPM: http://shakthimaan.fedorapeople.org/SRPMS/SuperLU-4.3-3.fc16.src.rpm
Successful Koji builds for F16, F17 and F18 respectively:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4421670
http://koji.fedoraproject.org/koji/taskinfo?taskID=4421679
http://koji.fedoraproject.org/koji/taskinfo?taskID=4421684
$ rpmlint SuperLU.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
$ rpmlint SuperLU-4.3-3.fc16.src.rpm
SuperLU.src: W: spelling-error %description -l en_US preordered - reordered, p
reordered, prerecorded
SuperLU.src: W: spelling-error %description -l en_US preordering - reordering,
p reordering, preordaining
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
$ rpmlint SuperLU-4.3-3.fc16.x86_64.rpm
SuperLU.x86_64: W: spelling-error %description -l en_US preordered -
reordered, p reordered, prerecorded
SuperLU.x86_64: W: spelling-error %description -l en_US preordering -
reordering, p reordering, preordaining
SuperLU.x86_64: W: shared-lib-calls-exit /usr/lib64/libsuperlu.so.4.3
exit@GLIBC_2.2.5
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
$ rpmlint SuperLU-devel-4.3-3.fc16.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 784175] Review Request: SuperLU - Subroutines to solve sparse linear systems
https://bugzilla.redhat.com/show_bug.cgi?id=784175 Jerry James loganje...@gmail.com changed: What|Removed |Added Assignee|chitl...@gmail.com |loganje...@gmail.com Flags|fedora-review? | --- Comment #8 from Jerry James loganje...@gmail.com --- Chitlesh has not responded here, nor to private email. I will take over the review. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 784175] Review Request: SuperLU - Subroutines to solve sparse linear systems
https://bugzilla.redhat.com/show_bug.cgi?id=784175
Jerry James loganje...@gmail.com changed:
What|Removed |Added
Flags||fedora-review?
--- Comment #9 from Jerry James loganje...@gmail.com ---
There are a few things to fix, all of them minor, and some of them optional.
1) I think the two %doc lines should be switched. The README file contains
the license text, so it should be in the main package. The material in DOC
is suitable for a developer of the library, rather than a user, so it
should be in the -devel package.
2) Unless you plan to use the same spec file for EPEL5, remove
rm -rf %{buildroot} from %install, and %defattr from both %files
sections.
3) Ask upstream to avoid calling exit() in a library.
4) Add chmod a-x SRC/qselect.c to %prep to get rid of the
spurious-executable-perm warning from rpmlint.
5) Remove -latlas from the last sed expression in %prep. The f77blas
library is already linked against libatlas. Removing explicit mention of
it from the link line gets rid of the unused-direct-shlib-dependency
warning from rpmlint.
6) Add comments about the upstream status of the patches (optional). See
https://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment
7) Change the patch names to %{name}-add-fpic.patch, etc. That hushes up
one of the complaints in the SHOULD section below (optional).
8) Add a %check script to run the tests in TESTING (optional).
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
C/C++
[x]: MUST Header files in -devel subpackage, if present.
[x]: MUST ldconfig called in %post and %postun if required.
[x]: MUST Package does not contain any libtool archives (.la)
[x]: MUST Package does not contain kernel modules.
[x]: MUST Package contains no static executables.
[x]: MUST Rpath absent or only used for internal libs.
[x]: MUST Development (unversioned) .so files in -devel subpackage, if
present.
Generic
[x]: EXTRA Rpmlint is run on all installed packages.
Note: No rpmlint messages.
[x]: EXTRA Spec file according to URL is the same as in SRPM.
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Sources contain only permissible code or content.
[!]: MUST Each %files section contains %defattr if rpm 4.4
Note: defattr() present in %files devel section. This is OK if
packaging for EPEL5. Otherwise not needed
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package contains desktop file if it is a GUI application.
[x]: MUST Development files must be in a -devel package
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Fully versioned dependency in subpackages, if present.
[x]: MUST Package complies to the Packaging Guidelines
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf is only needed if supporting EPEL5
[x]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
GPL (with incorrect FSF address) For detailed output of licensecheck
see file: /home/jamesjer/784175-SuperLU/licensecheck.txt
[!]: MUST License file installed when any subpackage combination is installed.
[x]: MUST Package consistently uses macro is (instead of hard-coded directory
names).
[x]: MUST Package is named using only allowed ascii characters.
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[x]: MUST Package obeys FHS, except libexecdir
[Bug 784175] Review Request: SuperLU - Subroutines to solve sparse linear systems
https://bugzilla.redhat.com/show_bug.cgi?id=784175 --- Comment #6 from Jerry James loganje...@gmail.com --- Chitlesh, this review is stalled. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews#Reviewer_not_responding, please respond within the next week. Shakthi, are you still ready to move forward with this review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 784175] Review Request: SuperLU - Subroutines to solve sparse linear systems
https://bugzilla.redhat.com/show_bug.cgi?id=784175 --- Comment #7 from Shakthi Kannan shakthim...@gmail.com --- Yes. It would be good if someone can review this package. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 784175] Review Request: SuperLU - Subroutines to solve sparse linear systems
https://bugzilla.redhat.com/show_bug.cgi?id=784175 Jerry James loganje...@gmail.com changed: What|Removed |Added CC||loganje...@gmail.com --- Comment #5 from Jerry James loganje...@gmail.com --- Chitlesh, do you intend to continue with this review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 784175] Review Request: SuperLU - Subroutines to solve sparse linear systems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=784175 --- Comment #4 from Shakthi Kannan shakthim...@gmail.com 2012-02-01 07:18:53 EST --- I have updated: * to use RPM_OPT_FLAGS and LIBS when building the sources * to use Atlas library instead of blas * Replaced names and version with their respective macros SPEC: http://shakthimaan.fedorapeople.org/SPECS/SuperLU.spec SRPM: http://shakthimaan.fedorapeople.org/SRPMS/SuperLU-4.3-2.fc15.src.rpm Successful Koji builds for F15, F16, F17 and EL6: http://koji.fedoraproject.org/koji/taskinfo?taskID=3751616 http://koji.fedoraproject.org/koji/taskinfo?taskID=3751621 http://koji.fedoraproject.org/koji/taskinfo?taskID=3751625 http://koji.fedoraproject.org/koji/taskinfo?taskID=3751623 $ rpmlint SuperLU.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint SuperLU-4.3-2.fc15.src.rpm SuperLU.src: W: spelling-error %description -l en_US preordered - reordered, p reordered, prerecorded SuperLU.src: W: spelling-error %description -l en_US preordering - reordering, p reordering, preordaining 1 packages and 0 specfiles checked; 0 errors, 2 warnings. $ rpmlint SuperLU-4.3-2.fc15.x86_64.rpm SuperLU.x86_64: W: spelling-error %description -l en_US preordered - reordered, p reordered, prerecorded SuperLU.x86_64: W: spelling-error %description -l en_US preordering - reordering, p reordering, preordaining SuperLU.x86_64: W: shared-lib-calls-exit /usr/lib64/libsuperlu.so.4.3 exit@GLIBC_2.2.5 1 packages and 0 specfiles checked; 0 errors, 3 warnings. $ rpmlint SuperLU-devel-4.3-2.fc15.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 784175] Review Request: SuperLU - Subroutines to solve sparse linear systems
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=784175
Jussi Lehtola jussi.leht...@iki.fi changed:
What|Removed |Added
CC||jussi.leht...@iki.fi
--- Comment #3 from Jussi Lehtola jussi.leht...@iki.fi 2012-01-24 02:56:24
EST ---
Don't build against reference BLAS. Use ATLAS instead, it's an order of
magnitude faster. To link against the ATLAS BLAS library use
-L%{_libdir}/atlas -lf77blas -latlas.
You also might want to use %{version} instead of 4.3 in the spec file, e.g.
in %setup.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 784175] Review Request: SuperLU - Subroutines to solve sparse linear systems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=784175 --- Comment #1 from Shakthi Kannan shakthim...@gmail.com 2012-01-24 00:39:18 EST --- $ rpmlint SuperLU.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint SuperLU-4.3-1.fc15.src.rpm SuperLU.src: W: spelling-error %description -l en_US preordered - reordered, p reordered, prerecorded SuperLU.src: W: spelling-error %description -l en_US preordering - reordering, p reordering, preordaining 1 packages and 0 specfiles checked; 0 errors, 2 warnings. $ rpmlint SuperLU-4.3-1.fc15.x86_64.rpm SuperLU.x86_64: W: spelling-error %description -l en_US preordered - reordered, p reordered, prerecorded SuperLU.x86_64: W: spelling-error %description -l en_US preordering - reordering, p reordering, preordaining SuperLU.x86_64: W: shared-lib-calls-exit /usr/lib64/libsuperlu.so.4.3 exit@GLIBC_2.2.5 1 packages and 0 specfiles checked; 0 errors, 3 warnings. $ rpmlint SuperLU-devel-4.3-1.fc15.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Successful Koji builds for F15, F16, F17 and EL6: http://koji.fedoraproject.org/koji/taskinfo?taskID=3727885 http://koji.fedoraproject.org/koji/taskinfo?taskID=3727890 http://koji.fedoraproject.org/koji/taskinfo?taskID=3727892 http://koji.fedoraproject.org/koji/taskinfo?taskID=3727895 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 784175] Review Request: SuperLU - Subroutines to solve sparse linear systems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=784175 Chitlesh GOORAH chitl...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||chitl...@gmail.com AssignedTo|nob...@fedoraproject.org|chitl...@gmail.com Flag||fedora-review? --- Comment #2 from Chitlesh GOORAH chitl...@gmail.com 2012-01-24 01:50:47 EST --- Hello Shakthi, It appears that the CFLAGS are not parsed correctly. http://koji.fedoraproject.org/koji/getfile?taskID=3727891name=build.log -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
