[Bug 785450] Review Request: php-horde-Horde-Cache - Horde Caching API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785450 Nick Bebout changed: What|Removed |Added Alias|horde-cache |Horde_Cache -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9vkWCifUss&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785450] Review Request: php-horde-Horde-Cache - Horde Caching API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785450 Nick Bebout changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2013-01-11 22:10:28 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8dAvAf5jxl&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785450] Review Request: php-horde-Horde-Cache - Horde Caching API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785450 --- Comment #13 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0GBi3j5kS2&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785450] Review Request: php-horde-Horde-Cache - Horde Caching API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785450 Nick Bebout changed: What|Removed |Added Flags||fedora-cvs? --- Comment #12 from Nick Bebout --- New Package SCM Request === Package Name: php-horde-Horde-Cache Short Description: This package provides a simple, functional caching API for Horde Owners: nb Branches: f17 f18 el6 InitialCC: remi -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=uW9tReWGiQ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785450] Review Request: php-horde-Horde-Cache - Horde Caching API
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=785450
Shawn Iwinski changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #11 from Shawn Iwinski ---
= COULD items =
* "s/pear.horde.org/%{pear_channel}/" and add "%global pear_channel
pear.horde.org"
* Add a note in %description letting end-users know that they are responsible
for installing whichever support opcode cache they would like.
No blockers.
= APPROVED =
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=0NVOFGgiU6&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785450] Review Request: php-horde-Horde-Cache - Horde Caching API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785450 --- Comment #10 from Shawn Iwinski --- Created attachment 666398 --> https://bugzilla.redhat.com/attachment.cgi?id=666398&action=edit php-horde-Horde-Cache-review.txt Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -b 785450 --mock-config fedora-rawhide-x86_64 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oixJgnFi4P&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785450] Review Request: php-horde-Horde-Cache - Horde Caching API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785450 --- Comment #9 from Shawn Iwinski --- Created attachment 666397 --> https://bugzilla.redhat.com/attachment.cgi?id=666397&action=edit phpci.log -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=20bCNrzirc&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785450] Review Request: php-horde-Horde-Cache - Horde Caching API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785450 Nick Bebout changed: What|Removed |Added Whiteboard|NotReady| --- Comment #8 from Nick Bebout --- Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Cache.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Cache-2.0.1-2.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mQavbOOwP4&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785450] Review Request: php-horde-Horde-Cache - Horde Caching API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785450 Shawn Iwinski changed: What|Removed |Added Whiteboard||NotReady --- Comment #7 from Shawn Iwinski --- Please remove APC from requires. It is an optional require and end-users should not be forced to install APC if they are using one of the other opcode caches. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eZYuEkCB1U&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785450] Review Request: php-horde-Horde-Cache - Horde Caching API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785450 Nick Bebout changed: What|Removed |Added Whiteboard|NotReady| -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=k9hjsBuBbO&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785450] Review Request: php-horde-Horde-Cache - Horde Caching API
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=785450 --- Comment #6 from Nick Bebout --- Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Cache.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Cache-2.0.1-1.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=uHGsvJ0wmK&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785450] Review Request: php-horde-Horde-Cache - Horde Caching API
https://bugzilla.redhat.com/show_bug.cgi?id=785450 --- Comment #5 from Shawn Iwinski --- (In reply to comment #4) > [OPTIONAL] I'm not sure what the exact Fedora packaging guidelines are for > this, but I prefer to be very verbose and would list both the min and max > requirements instead of just max (even though you know you don't have < > 1.0.0 in Fedora): > Requires: php-pear(pear.horde.org/PACKAGE) >= 1.0.0 > Requires: php-pear(pear.horde.org/PACKAGE) < 2.0.0 Per https://bugzilla.redhat.com/show_bug.cgi?id=785446#c6, ignore this -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785450] Review Request: php-horde-Horde-Cache - Horde Caching API
https://bugzilla.redhat.com/show_bug.cgi?id=785450
Shawn Iwinski changed:
What|Removed |Added
Whiteboard||NotReady
--- Comment #4 from Shawn Iwinski ---
[MUST] "Requires: php-common >= 5.2.0" to satisfy package.xml
[MUST] Change
Requires: php-pear(pear.horde.org/Horde_Util) <= 2.0.0
to
Requires: php-pear(pear.horde.org/Horde_Util) < 2.0.0
to satisfy package.xml
[OPTIONAL] For readability, you may want to group your Build* and Requires*
[OPTIONAL] I'm not sure what the exact Fedora packaging guidelines are for
this, but I prefer to be very verbose and would list both the min and max
requirements instead of just max (even though you know you don't have < 1.0.0
in Fedora):
Requires: php-pear(pear.horde.org/PACKAGE) >= 1.0.0
Requires: php-pear(pear.horde.org/PACKAGE) < 2.0.0
[OPTIONAL] You may want to consider adding requires for the following optional
dependencies (from package.xml):
* php-pear(pear.horde.org/Horde_Db)
* php-pear(pear.horde.org/Horde_Log)
* php-pear(pear.horde.org/Horde_Memcache) -- be careful with this one as I
don't know whether this would cause issues in certain environments like APC
does (which is also an optional requirement of this package)
[OPTIONAL] phpci: You may want to consider adding the following requires:
* php-date
* php-hash
* php-spl
* php-pecl(LZF) >= 1.5.2
--- NOTE: package.xml lists the hash extension as required, but it is a virtual
package of php-common (as php-hash) so it would automatically be installed.
You may want to consider adding the requirement to be thorough and prevent any
future issue of there is PHP package changes.
--- NOTE: You may want to have upstream add the additional optional extensions
(LZF is already listed in package.xml as optional)
[OPTIONAL] You may want to s/pear.horde.org/%{pear_channel}/ and then add
"%global pear_channel pear.horde.org"
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785450] Review Request: php-horde-Horde-Cache - Horde Caching API
https://bugzilla.redhat.com/show_bug.cgi?id=785450 Nick Bebout changed: What|Removed |Added CC||fed...@famillecollet.com --- Comment #3 from Nick Bebout --- I believe all of the normal blockers for the php-horde-Horde-* packages are fixed with this package. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785450] Review Request: php-horde-Horde-Cache - Horde Caching API
https://bugzilla.redhat.com/show_bug.cgi?id=785450 Shawn Iwinski changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785450] Review Request: php-horde-Horde-Cache - Horde Caching API
https://bugzilla.redhat.com/show_bug.cgi?id=785450 --- Comment #2 from Shawn Iwinski --- I will review this package -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785450] Review Request: php-horde-Horde-Cache - Horde Caching API
https://bugzilla.redhat.com/show_bug.cgi?id=785450 Shawn Iwinski changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785450] Review Request: php-horde-Horde-Cache - Horde Caching API
https://bugzilla.redhat.com/show_bug.cgi?id=785450 Shawn Iwinski changed: What|Removed |Added Assignee|nob...@fedoraproject.org|shawn.iwin...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785450] Review Request: php-horde-Horde-Cache - Horde Caching API
https://bugzilla.redhat.com/show_bug.cgi?id=785450 --- Comment #1 from Nick Bebout --- Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Cache.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Cache-1.0.5-1.fc16.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785450] Review Request: php-horde-Horde-Cache - Horde Caching API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=785450 Bug 785450 depends on bug 785424, which changed state. Bug 785424 Summary: Review Request: php-channel-horde - Adds pear.horde.org channel to PEAR https://bugzilla.redhat.com/show_bug.cgi?id=785424 What|Old Value |New Value Status|ASSIGNED|MODIFIED Status|MODIFIED|ON_QA Resolution||ERRATA Status|ON_QA |CLOSED Bug 785450 depends on bug 785436, which changed state. Bug 785436 Summary: Review Request: php-horde-Horde-Exception - Horde Exception Handler https://bugzilla.redhat.com/show_bug.cgi?id=785436 What|Old Value |New Value Resolution||CURRENTRELEASE Status|NEW |CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785450] Review Request: php-horde-Horde-Cache - Horde Caching API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=785450 Bug 785450 depends on bug 785439, which changed state. Bug 785439 Summary: Review Request: php-horde-Horde-Util - Horde Utility Libraries https://bugzilla.redhat.com/show_bug.cgi?id=785439 What|Old Value |New Value Resolution||CURRENTRELEASE Status|NEW |CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785450] Review Request: php-horde-Horde-Cache - Horde Caching API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=785450 Nick Bebout changed: What|Removed |Added Depends on||785436(horde-exception), ||785439(horde-util) Alias||horde-cache -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785450] Review Request: php-horde-Horde-Cache - Horde Caching API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=785450 Nick Bebout changed: What|Removed |Added Depends on||785424 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
