[Bug 785619] Review Request: lutok - Lightweight C++ API library for Lua
https://bugzilla.redhat.com/show_bug.cgi?id=785619 Björn besser82 Esser bjoern.es...@gmail.com changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785619] Review Request: lutok - Lightweight C++ API library for Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=785619 --- Comment #14 from Julio Merino j...@julipedia.org 2012-05-06 11:16:36 EDT --- Package Change Request == Package Name: lutok New Branches: f17 Owners: jmmv Oops... my previous comment listed a mismatched package name. I presume this will be caught by whichever scripts handle this... but otherwise filing a new request here in the hope that it overrides the previous one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785619] Review Request: lutok - Lightweight C++ API library for Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=785619 Julio Merino j...@julipedia.org changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? --- Comment #13 from Julio Merino j...@julipedia.org 2012-05-06 11:13:11 EDT --- Package Change Request == Package Name: atf New Branches: f17 Owners: jmmv -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785619] Review Request: lutok - Lightweight C++ API library for Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=785619 --- Comment #15 from Jon Ciesla limburg...@gmail.com 2012-05-06 16:57:30 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785619] Review Request: lutok - Lightweight C++ API library for Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=785619 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version||lutok-0.1-1.fc16 Resolution|NEXTRELEASE |ERRATA --- Comment #12 from Fedora Update System upda...@fedoraproject.org 2012-02-25 03:37:15 EST --- lutok-0.1-1.fc16 has been pushed to the Fedora 16 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785619] Review Request: lutok - Lightweight C++ API library for Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=785619 Julio Merino j...@julipedia.org changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Last Closed||2012-02-07 22:01:37 --- Comment #10 from Julio Merino j...@julipedia.org 2012-02-07 22:01:37 EST --- Thanks for the review! I have submitted the package into git and issued builds for f17 and f16. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785619] Review Request: lutok - Lightweight C++ API library for Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=785619 --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2012-02-07 22:07:30 EST --- lutok-0.1-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/lutok-0.1-1.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785619] Review Request: lutok - Lightweight C++ API library for Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=785619 Julio Merino j...@julipedia.org changed: What|Removed |Added Flag||fedora-cvs? --- Comment #8 from Julio Merino j...@julipedia.org 2012-02-06 18:34:09 EST --- New Package SCM Request === Package Name: lutok Short Description: Lightweight C++ API library for Lua Owners: jmmv Branches: f16 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785619] Review Request: lutok - Lightweight C++ API library for Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=785619 --- Comment #9 from Jon Ciesla limburg...@gmail.com 2012-02-06 19:14:58 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785619] Review Request: lutok - Lightweight C++ API library for Lua
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=785619
--- Comment #4 from Michel Alexandre Salim michel+...@sylvestre.me 2012-02-03
08:59:38 EST ---
Hi Julio,
(note: you forgot to update the SRPM, but the spec looks really close now)
- %{_libdir}/liblutok.so.0 should be in the main package, not in -devel. only
*.so should go to devel
- The html and examples files are still ending up in the main package. Try
installing them to %{_defaultdocdir}/%{name}-doc-%{version} instead
%doc behavior is a bit confusing indeed. I'm pretty sure files in
%{_defaultdocdir}/%{name}-%{version} automatically get registered as part of
the package, and files tagged as %doc without absolute paths get copied there.
- BuildRoot declaration, and cleanup in %install, can be removed
- %files devel should have %{_includedir}/lutok/ _without_ the trailing *.
With,
you're telling RPM to own the files but not the directory itself
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785619] Review Request: lutok - Lightweight C++ API library for Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=785619 --- Comment #5 from Julio Merino j...@julipedia.org 2012-02-03 10:17:45 EST --- Hmm, this is weird. I had addressed some of the comments you mention in your last mail (like getting rid of the buildroot), but somehow I screwed up when uploading the new versions of the files to the ftp site... Anyway! Fixed the doc issues by putting the files in a lutok-doc-0.1 directory as you suggest. Also added a missing Group: Documentation to the doc package. Also hopefully fixed the rest of issues mentioned. Updated the spec and srpm files (hopefully correctly this time!). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785619] Review Request: lutok - Lightweight C++ API library for Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=785619 Michel Alexandre Salim michel+...@sylvestre.me changed: What|Removed |Added Status|NEW |ASSIGNED CC||michel+...@sylvestre.me AssignedTo|nob...@fedoraproject.org|michel+...@sylvestre.me Flag||fedora-review? --- Comment #1 from Michel Alexandre Salim michel+...@sylvestre.me 2012-02-02 06:00:13 EST --- Welcome back, Julio! Do you have a test Fedora installation (whether virtualized or on a physical machine) that you can use to keep up with package maintenance? The spec looks straightforward; I'll start the review later today. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785619] Review Request: lutok - Lightweight C++ API library for Lua
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=785619
--- Comment #2 from Michel Alexandre Salim michel+...@sylvestre.me 2012-02-02
08:42:26 EST ---
Some short notes, we'll do the full review once this is taken care of.
- license field should be just License: BSD. see the short name column in
http://fedoraproject.org/wiki/Licensing#Good_Licenses
- will you be packaging this for Fedora only, or also for RHEL? Unless you're
targeting RHEL version 5 or below, you don't need to declare the BuildRoot, and
you don't need to clean it at the beginning of %install:
http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
- likewise, %clean section can be removed unless you're targeting RHEL 6 or
below.
- %setup defaults to -n %{name}-%{version}. Unless you do something unusual
here you can just do %setup -q
(to think about it, we don't have a Lua package naming guideline yet. Not
sure
if this should be lutok, lua-lutok, or lua-tok. The Python precedent is that
packages starting with py don't need to be prefixed with python-, so
in lieu of an explicit guideline the name seems OK for now)
- the INSTALL file describes a 'make check' step. I take it without ATF the
tests don't do anything, but since they run just fine anyway, could you add a
check section under %install, as such:
%check
make check
that way once ATF is packaged you don't have to change this package much. Since
you're the author of ATF as well, do you want to submit it for inclusion as
well?
- you're installing documentation twice -- %doc list-of-files copy the files to
%{_defaultdocdir}/%{name}-%{version}/ and you also have files in
%{_defaultdocdir}/%{name}. The former is canonical, just remove the latter as
part of %install, or update the build script to make doc installation a
separate step
- consider packaging examples and HTML docs in a separate -doc subpackage
- devel subpackage should Require: %{name} = %{version}-%{release} (it should
match the main package)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785619] Review Request: lutok - Lightweight C++ API library for Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=785619 --- Comment #3 from Julio Merino j...@julipedia.org 2012-02-02 11:21:07 EST --- Hello Michel, Thanks for the review. Some answers to your questions, in no particular order: Yes, I do have a Fedora VM installation that I intend to keep. In fact, I have had it for a long time already and use it regularly for the development of Lutok, ATF, etc. The reason is that Fedora includes a more up-to-date GCC and header files than my other build platforms (NetBSD, OS X)... which does wonders in catching programming errors :-) (I.e. more warnings, strict validation of explicit includes, etc.) No, I'm not targeting RHEL, so I have removed the extra boilerplate. Regarding the tests, yes, I am planning to package ATF later. I didn't do so yet because I wanted to get started with something simpler. The package for ATF will be trickier and potentially-controversial due to file layout issues, so I'd rather sort this out later once I've got the basics of packaging straight. I have created a separate doc package to include the html files and the examples. Lastly, I have fixed the documentation issue by preventing the Makefile from installing the documents. I have also changed the package to install its documentation into a name-version directory instead of just name to prevent having both doc/lutok and doc/lutok-0.1. (I was confused about the behavior of %doc, hence why I had listed the documents twice in the previous spec version.) The spec and srpm files have been updated. Please take another look and thanks in advance! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785619] Review Request: lutok - Lightweight C++ API library for Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=785619 Julio M. Merino Vidal j...@netbsd.org changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
