[Bug 785663] Review Request: rubygem-journey - Journey is a router
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=785663 Bohuslav Kabrda changed: What|Removed |Added Status|NEW |ASSIGNED CC||bkab...@redhat.com AssignedTo|nob...@fedoraproject.org|bkab...@redhat.com Flag||fedora-review? --- Comment #1 from Bohuslav Kabrda 2012-01-30 04:15:53 EST --- I'll take this for a review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785663] Review Request: rubygem-journey - Journey is a router
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=785663 Bohuslav Kabrda changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #2 from Bohuslav Kabrda 2012-01-30 04:41:13 EST --- - README.md should be present in the main package, as it contains licensing information. - Otherwise the package is OK (although, as FPC [1], I have a general feel of distaste about the bundled javascript libraries - but since they are currently allowed, it is not a blocker). [1] https://fedorahosted.org/fpc/ticket/113 So after you fix the issue, this package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785663] Review Request: rubygem-journey - Journey is a router
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=785663 Vít Ondruch changed: What|Removed |Added Flag||fedora-cvs? --- Comment #3 from Vít Ondruch 2012-01-30 04:55:47 EST --- (In reply to comment #2) > - README.md should be present in the main package, as it contains licensing > information. Done > - Otherwise the package is OK (although, as FPC [1], I have a general feel of > distaste about the bundled javascript libraries - but since they are currently > allowed, it is not a blocker). > > [1] https://fedorahosted.org/fpc/ticket/113 > > > So after you fix the issue, this package is APPROVED. Thank you for your review! New Package SCM Request === Package Name: rubygem-journey Short Description: Journey is a router Owners: vondruch Branches: InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785663] Review Request: rubygem-journey - Journey is a router
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=785663 --- Comment #4 from Jon Ciesla 2012-01-30 08:31:24 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785663] Review Request: rubygem-journey - Journey is a router
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=785663 Vít Ondruch changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Last Closed||2012-01-30 09:14:24 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
