[Bug 785946] Review Request: python-django-horizon - Django application for talking to Openstack
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=785946 --- Comment #13 from Jon Ciesla limburg...@gmail.com 2012-04-05 08:10:34 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785946] Review Request: python-django-horizon - Django application for talking to Openstack
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=785946 Pádraig Brady p...@draigbrady.com changed: What|Removed |Added CC||p...@draigbrady.com Flag|fedora-cvs+ |fedora-cvs? --- Comment #12 from Pádraig Brady p...@draigbrady.com 2012-04-04 19:17:07 EDT --- Package Change Request == Package Name: python-django-horizon New Branches: el6 Owners: crobinso markmc pbrady This is to support openstack dashboard in the Essex upgrade in EPEL -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785946] Review Request: python-django-horizon - Django application for talking to Openstack
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=785946 Matthias Runge mru...@matthias-runge.de changed: What|Removed |Added Status|NEW |ASSIGNED Flag||fedora-review? --- Comment #3 from Matthias Runge mru...@matthias-runge.de 2012-02-06 13:53:56 EST --- I'll do a review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785946] Review Request: python-django-horizon - Django application for talking to Openstack
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=785946 Matthias Runge mru...@matthias-runge.de changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|mru...@matthias-runge.de -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785946] Review Request: python-django-horizon - Django application for talking to Openstack
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=785946 --- Comment #4 from Cole Robinson crobi...@redhat.com 2012-02-06 14:20:38 EST --- Thanks Matthias! FYI this package is associated with an F17 feature: http://fedoraproject.org/w/index.php?title=Features/OpenStack_Horizon so I was ideally hoping that it would be committable by tomorrow (F17 feature freeze), but I can probably get an extension if that isn't feasible -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785946] Review Request: python-django-horizon - Django application for talking to Openstack
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=785946
--- Comment #5 from Matthias Runge mru...@matthias-runge.de 2012-02-06
14:43:37 EST ---
Phew, this may get a little tough
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
Generic
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST %config files are marked noreplace or the reason is justified.
[x]: MUST Each %files section contains %defattr if rpm 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[!]: MUST License field in the package spec file matches the actual license.
[x]: MUST License file installed when any subpackage combination is installed.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
names).
[x]: MUST Package meets the Packaging Guidelines.
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST No %config files under /usr.
[x]: MUST Package does not generates any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[!]: MUST Rpmlint output is silent.
rpmlint python-django-horizon-doc-2012.1-0.1.e3.fc17.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
rpmlint openstack-dashboard-2012.1-0.1.e3.fc17.noarch.rpm
openstack-dashboard.noarch: W: no-documentation
openstack-dashboard.noarch: E: python-bytecode-inconsistent-mtime
/usr/share/openstack-dashboard/local/local_settings.pyc 2012-02-06T20:14:22
/etc/openstack-dashboard/local_settings 2012-02-06T20:14:35
1 packages and 0 specfiles checked; 1 errors, 1 warnings.
rpmlint python-django-horizon-2012.1-0.1.e3.fc17.noarch.rpm
python-django-horizon.noarch: W: no-documentation
python-django-horizon.noarch: E: zero-length
/usr/lib/python2.7/site-packages/horizon/dashboards/syspanel/instances/tests.py
python-django-horizon.noarch: E: zero-length
/usr/lib/python2.7/site-packages/horizon/dashboards/syspanel/flavors/tests.py
python-django-horizon.noarch: E: zero-length
/usr/lib/python2.7/site-packages/horizon/dashboards/syspanel/services/tests.py
python-django-horizon.noarch: E: zero-length
/usr/lib/python2.7/site-packages/horizon/dashboards/nova/instances_and_volumes/volumes/tests.py
python-django-horizon.noarch: E: zero-length
/usr/lib/python2.7/site-packages/horizon/dashboards/syspanel/images/tests.py
python-django-horizon.noarch: E: zero-length
/usr/lib/python2.7/site-packages/horizon/dashboards/syspanel/quotas/tests.py
python-django-horizon.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/horizon/dashboards/settings/templates/settings/tenant/openrc.sh.template
0644L /bin/bash
1 packages and 0 specfiles checked; 7 errors, 1 warnings.
rpmlint python-django-horizon-2012.1-0.1.e3.fc17.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
/home/mrunge/785946/horizon-2012.1~e3.tar.gz :
MD5SUM this package : 189c537031386cc7f140784bc124a50a
MD5SUM upstream package :
[Bug 785946] Review Request: python-django-horizon - Django application for talking to Openstack
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=785946 Cole Robinson crobi...@redhat.com changed: What|Removed |Added Flag||needinfo?(mrunge@matthias-r ||unge.de) --- Comment #6 from Cole Robinson crobi...@redhat.com 2012-02-06 15:00:01 EST --- Matthias, please see comment 2. I tried to provide justification/confusion for those 2 rpmlint warnings. Let me know what you think of those explanations. Those packages are required for Build because we generate the docs at build time, and sphinx seems to actually import the python module code in process of generating the docs (yes, completely annoying but non trivial to work around for the time being). Good spot on the license issue, does that mean I just update the License: tag to specify BSD as well? Or is there more to the process. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785946] Review Request: python-django-horizon - Django application for talking to Openstack
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=785946 Matthias Runge mru...@matthias-runge.de changed: What|Removed |Added Flag|fedora-review?, |fedora-review+ |needinfo?(mrunge@matthias-r | |unge.de)| --- Comment #7 from Matthias Runge mru...@matthias-runge.de 2012-02-06 15:26:07 EST --- license: I'd state this as ASL2 and BSD. You should also comment (in spec), which parts are BSD. I think, it's really strange to require those at build time, but don't want to argue about that. I'd expect you to correct the license field. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785946] Review Request: python-django-horizon - Django application for talking to Openstack
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=785946 --- Comment #8 from Cole Robinson crobi...@redhat.com 2012-02-06 15:43:56 EST --- Agreed, the buildrequires are dumb, I plan on investigating a way to drop it. Thanks a lot for the review! I'll make that spec change when pushing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785946] Review Request: python-django-horizon - Django application for talking to Openstack
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=785946 Cole Robinson crobi...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #9 from Cole Robinson crobi...@redhat.com 2012-02-06 15:46:28 EST --- New Package SCM Request === Package Name: python-django-horizon Short Description: Django application for talking to Openstack Owners: crobinso Branches: InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785946] Review Request: python-django-horizon - Django application for talking to Openstack
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=785946 --- Comment #10 from Jon Ciesla limburg...@gmail.com 2012-02-06 19:15:35 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785946] Review Request: python-django-horizon - Django application for talking to Openstack
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=785946 Cole Robinson crobi...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||CURRENTRELEASE Last Closed||2012-02-06 20:10:33 --- Comment #11 from Cole Robinson crobi...@redhat.com 2012-02-06 20:10:33 EST --- Built now -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785946] Review Request: python-django-horizon - Django application for talking to Openstack
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=785946 Cole Robinson crobi...@redhat.com changed: What|Removed |Added Summary|Review Request: |Review Request: |django-horizon - Django |python-django-horizon - |application for talking to |Django application for |Openstack |talking to Openstack --- Comment #2 from Cole Robinson crobi...@redhat.com 2012-02-01 10:53:27 EST --- Spec URL: http://fedorapeople.org/~crobinso/reviews/python-django-horizon.spec SRPM URL: http://fedorapeople.org/~crobinso/reviews/python-django-horizon-2012.1-0.1.e3.fc16.src.rpm Changes since v1: - Changed name to python-django-horizon - Changes to http conf to make it all actually work (thanks to dhiggins) - Deps are in rawhide so mock build now works Current RPMlint openstack-dashboard.noarch: W: no-documentation Not a blocker IMO openstack-dashboard.noarch: E: python-bytecode-inconsistent-mtime /usr/share/openstack-dashboard/local/local_settings.pyc 2012-02-01T10:42:39 /etc/openstack-dashboard/local_settings 2012-02-01T10:42:55 I don't know what to do about this: /usr/share/openstack-dashboard/local/local_settings.py is a symlink to /etc/openstack-dashboard/local_settings.py. Seems to cause the mtimes to get confused. Long run I want to enable this behavior in upstream, but for now this seems like a reasonable hack. I don't think the above problem should cause any problems AFAIK. python-django-horizon.noarch: W: no-documentation Not a blocker IMO (though there is a doc subpackage...) python-django-horizon.noarch: E: zero-length /usr/lib/python2.7/site-packages/horizon/dashboards/syspanel/instances/tests.py python-django-horizon.noarch: E: zero-length /usr/lib/python2.7/site-packages/horizon/dashboards/syspanel/flavors/tests.py python-django-horizon.noarch: E: zero-length /usr/lib/python2.7/site-packages/horizon/dashboards/syspanel/services/tests.py python-django-horizon.noarch: E: zero-length /usr/lib/python2.7/site-packages/horizon/dashboards/nova/instances_and_volumes/volumes/tests.py python-django-horizon.noarch: E: zero-length /usr/lib/python2.7/site-packages/horizon/dashboards/syspanel/images/tests.py python-django-horizon.noarch: E: zero-length /usr/lib/python2.7/site-packages/horizon/dashboards/syspanel/quotas/tests.py This stubs need to be there to appease upstream tests. We could rip them out with a patch but that sounds more dangerous than the alternative of just leaving them in. python-django-horizon.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/horizon/dashboards/settings/templates/settings/tenant/openrc.sh.template 0644L /bin/bash This file is actually a template that is used to generate a bash script that is shown to the user in the UI for them to copy to a local file and run. As such it shouldn't be executable, but it should have the #!/bin/bash header that causes rpmlint to think it should be a script. So not a blocker IMO -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
