[Bug 786213] Review Request: trac-agilo-plugin - A plugin for supporting the Scrum process in Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=786213 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|trac-agilo-plugin-0.9.7-2.f |trac-agilo-plugin-0.9.7-2.e |c17 |l6 --- Comment #16 from Fedora Update System upda...@fedoraproject.org 2012-05-17 16:31:33 EDT --- trac-agilo-plugin-0.9.7-2.el6 has been pushed to the Fedora EPEL 6 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 786213] Review Request: trac-agilo-plugin - A plugin for supporting the Scrum process in Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=786213 --- Comment #15 from Fedora Update System upda...@fedoraproject.org 2012-04-20 05:35:52 EDT --- trac-agilo-plugin-0.9.7-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/trac-agilo-plugin-0.9.7-2.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 786213] Review Request: trac-agilo-plugin - A plugin for supporting the Scrum process in Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=786213 --- Comment #13 from Fedora Update System upda...@fedoraproject.org 2012-04-11 12:52:11 EDT --- trac-agilo-plugin-0.9.7-2.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 786213] Review Request: trac-agilo-plugin - A plugin for supporting the Scrum process in Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=786213 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|trac-agilo-plugin-0.9.7-2.f |trac-agilo-plugin-0.9.7-2.f |c16 |c17 --- Comment #14 from Fedora Update System upda...@fedoraproject.org 2012-04-11 22:28:42 EDT --- trac-agilo-plugin-0.9.7-2.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 786213] Review Request: trac-agilo-plugin - A plugin for supporting the Scrum process in Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=786213 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||trac-agilo-plugin-0.9.7-2.f ||c16 Resolution||ERRATA Last Closed||2012-04-11 00:00:45 Bug 786213 depends on bug 786093, which changed state. Bug 786093 Summary: Review Request: python-windmill - A web application testing framework https://bugzilla.redhat.com/show_bug.cgi?id=786093 What|Old Value |New Value Resolution||ERRATA Status|ON_QA |CLOSED --- Comment #12 from Fedora Update System upda...@fedoraproject.org 2012-04-11 00:00:45 EDT --- trac-agilo-plugin-0.9.7-2.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 786213] Review Request: trac-agilo-plugin - A plugin for supporting the Scrum process in Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=786213 Karel Klíč kk...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #7 from Karel Klíč kk...@redhat.com 2012-03-30 06:45:07 EDT --- Thanks, your co-maintainership is welcome. New Package SCM Request === Package Name: trac-agilo-plugin Short Description: A plugin for supporting the Scrum process in Trac Owners: kklic kevin Branches: f16 f17 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 786213] Review Request: trac-agilo-plugin - A plugin for supporting the Scrum process in Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=786213 --- Comment #8 from Jon Ciesla limburg...@gmail.com 2012-03-30 08:49:51 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 786213] Review Request: trac-agilo-plugin - A plugin for supporting the Scrum process in Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=786213 --- Comment #9 from Fedora Update System upda...@fedoraproject.org 2012-03-30 10:25:28 EDT --- trac-agilo-plugin-0.9.7-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/trac-agilo-plugin-0.9.7-2.fc17 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 786213] Review Request: trac-agilo-plugin - A plugin for supporting the Scrum process in Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=786213 --- Comment #10 from Fedora Update System upda...@fedoraproject.org 2012-03-30 10:25:39 EDT --- trac-agilo-plugin-0.9.7-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/trac-agilo-plugin-0.9.7-2.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 786213] Review Request: trac-agilo-plugin - A plugin for supporting the Scrum process in Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=786213 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 786213] Review Request: trac-agilo-plugin - A plugin for supporting the Scrum process in Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=786213 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2012-03-30 14:01:33 EDT --- Package trac-agilo-plugin-0.9.7-2.fc17: * should fix your issue, * was pushed to the Fedora 17 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing trac-agilo-plugin-0.9.7-2.fc17' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-4942/trac-agilo-plugin-0.9.7-2.fc17 then log in and leave karma (feedback). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 786213] Review Request: trac-agilo-plugin - A plugin for supporting the Scrum process in Trac
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=786213
--- Comment #5 from Karel Klíč kk...@redhat.com 2012-03-28 11:17:18 EDT ---
Kevin, thank you for the review!
Here is an updated version:
Spec URL: http://kklic.fedorapeople.org/trac-agilo-plugin.spec
SRPM URL: http://kklic.fedorapeople.org/trac-agilo-plugin-0.9.7-2.fc16.src.rpm
* Wed Mar 28 2012 Karel Klíč kk...@redhat.com - 0.9.7-2
- Commented macros changed to %%
(In reply to comment #4)
Issues:
1. You might ask upstream to include a copy of the license.
Not a blocker though.
2. You don't need a builtroot or clean section for Fedora anymore, but
you do for EPEL6, so you might add those back for that.
It seems that the BuildRoot tag and the clean section are not required in
EPEL6:
http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#Distribution_specific_guidelines
3. You need a
rm -rf %{buildroot}
at the top of the install section.
This is required only for EPEL5 and older:
http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#Prepping_BuildRoot_For_.25install
4. rpmlint says:
Can be ignored, but man pages would be nice:
trac-agilo-plugin.noarch: W: no-manual-page-for-binary agilo_sqlite2pg
trac-agilo-plugin.noarch: W: no-manual-page-for-binary create_agilo_project
trac-agilo-plugin.noarch: W: no-manual-page-for-binary agilo_svn_hook_commit
You should change all the commented macros to %%
trac-agilo-plugin.src:30: W: macro-in-comment %check
trac-agilo-plugin.src:31: W: macro-in-comment %{python_sitelib}
trac-agilo-plugin.src:32: W: macro-in-comment %{python_sitelib}
trac-agilo-plugin.src:33: W: macro-in-comment %{_defaultdocdir}
trac-agilo-plugin.src:33: W: macro-in-comment %{VERSION}
trac-agilo-plugin.src:34: W: macro-in-comment %{buildroot}
trac-agilo-plugin.src:34: W: macro-in-comment %{python_sitelib}
trac-agilo-plugin.src:34: W: macro-in-comment %{__python}
Done.
Can be ignored:
trac-agilo-plugin.src: W: invalid-url Source0: agilo_source.tar.gz
5. Is there a specific version of trac thats required?
Yes, the upstream package requires trac = 0.11. This condition is satisfied
in all Fedora branches and EPEL6 branch.
Do we have a policy or convention to add the versioned require to the spec
file? I propose adding the version when the non-versioned require one will
cause problems somewhere.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 786213] Review Request: trac-agilo-plugin - A plugin for supporting the Scrum process in Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=786213 Kevin Fenzi ke...@scrye.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #6 from Kevin Fenzi ke...@scrye.com 2012-03-28 13:54:32 EDT --- If all supported branches have the requirement you don't really need to specify. I guess it's a matter of taste. The only place it could be bad is if someone took your src.rpm and tried to build it for another branch with a different version, they could be confused when it fails... but not a big deal. Great. That answers all my issues/questions. I see no further blockers here, so this package is APPROVED. Happy to help co-maintain if you like. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 786213] Review Request: trac-agilo-plugin - A plugin for supporting the Scrum process in Trac
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=786213
--- Comment #4 from Kevin Fenzi ke...@scrye.com 2012-03-21 12:22:35 EDT ---
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (ASL 2.0)
OK - License field in spec matches
See below - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
fe527f0b0a2391394e4c7139b8718dae agilo_source.tar.gz
fe527f0b0a2391394e4c7139b8718dae agilo_source.tar.gz.orig
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
See below - Package has a correct %clean section.
See below - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
See below - Package has rm -rf RPM_BUILD_ROOT at top of %install
OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - Package obey's FHS standard (except for 2 exceptions)
See below - No rpmlint output.
See below - final provides and requires are sane.
SHOULD Items:
OK - Should build in mock.
OK - Should build on all supported archs
OK - Should function as described.
OK - Should have dist tag
OK - Should package latest version
OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or
/usr/sbin
Issues:
1. You might ask upstream to include a copy of the license.
Not a blocker though.
2. You don't need a builtroot or clean section for Fedora anymore, but
you do for EPEL6, so you might add those back for that.
3. You need a
rm -rf %{buildroot}
at the top of the install section.
4. rpmlint says:
Can be ignored, but man pages would be nice:
trac-agilo-plugin.noarch: W: no-manual-page-for-binary agilo_sqlite2pg
trac-agilo-plugin.noarch: W: no-manual-page-for-binary create_agilo_project
trac-agilo-plugin.noarch: W: no-manual-page-for-binary agilo_svn_hook_commit
You should change all the commented macros to %%
trac-agilo-plugin.src:30: W: macro-in-comment %check
trac-agilo-plugin.src:31: W: macro-in-comment %{python_sitelib}
trac-agilo-plugin.src:32: W: macro-in-comment %{python_sitelib}
trac-agilo-plugin.src:33: W: macro-in-comment %{_defaultdocdir}
trac-agilo-plugin.src:33: W: macro-in-comment %{VERSION}
trac-agilo-plugin.src:34: W: macro-in-comment %{buildroot}
trac-agilo-plugin.src:34: W: macro-in-comment %{python_sitelib}
trac-agilo-plugin.src:34: W: macro-in-comment %{__python}
Can be ignored:
trac-agilo-plugin.src: W: invalid-url Source0: agilo_source.tar.gz
5. Is there a specific version of trac thats required?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 786213] Review Request: trac-agilo-plugin - A plugin for supporting the Scrum process in Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=786213 --- Comment #3 from Karel Klíč kk...@redhat.com 2012-03-19 02:18:43 EDT --- All the dependencies are now present in Fedora, so the package can be built in Koji. Spec URL: http://kklic.fedorapeople.org/trac-agilo-plugin.spec SRPM URL: http://kklic.fedorapeople.org/trac-agilo-plugin-0.9.7-1.fc16.src.rpm * Mon Mar 19 2012 Karel Klíč kk...@redhat.com - 0.9.7-1 - Update to the newest upstream release -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 786213] Review Request: trac-agilo-plugin - A plugin for supporting the Scrum process in Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=786213 Kevin Fenzi ke...@scrye.com changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|ke...@scrye.com Flag||fedora-review? --- Comment #2 from Kevin Fenzi ke...@scrye.com 2012-02-17 16:23:55 EST --- Before I start in on the review here, could you update to the latest upstream? agilo-0.9.6.2 seems to be the current version. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 786213] Review Request: trac-agilo-plugin - A plugin for supporting the Scrum process in Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=786213 Kevin Fenzi ke...@scrye.com changed: What|Removed |Added CC||ke...@scrye.com --- Comment #1 from Kevin Fenzi ke...@scrye.com 2012-02-06 15:07:04 EST --- I'll try and find time to review this. Anyone else welcome to review in the mean time. ;) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 786213] Review Request: trac-agilo-plugin - A plugin for supporting the Scrum process in Trac
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=786213 Karel Klíč kk...@redhat.com changed: What|Removed |Added Depends on||786093 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
