[Bug 787858] Review Request: bashmount - a menu-driven bash script for mounting removable media
https://bugzilla.redhat.com/show_bug.cgi?id=787858 Raphael Groner changed: What|Removed |Added See Also||https://bugzilla.redhat.com ||/show_bug.cgi?id=1089493 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 787858] Review Request: bashmount - a menu-driven bash script for mounting removable media
https://bugzilla.redhat.com/show_bug.cgi?id=787858 Björn "besser82" Esser changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 787858] Review Request: bashmount - a menu-driven bash script for mounting removable media
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=787858 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||bashmount-1.6.2-3.fc16 Resolution||ERRATA Last Closed||2012-02-19 18:18:33 --- Comment #14 from Fedora Update System 2012-02-19 18:18:33 EST --- bashmount-1.6.2-3.fc16 has been pushed to the Fedora 16 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 787858] Review Request: bashmount - a menu-driven bash script for mounting removable media
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=787858 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #13 from Fedora Update System 2012-02-11 17:02:26 EST --- bashmount-1.6.2-3.fc16 has been pushed to the Fedora 16 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 787858] Review Request: bashmount - a menu-driven bash script for mounting removable media
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=787858 --- Comment #12 from Fedora Update System 2012-02-10 18:16:02 EST --- bashmount-1.6.2-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/bashmount-1.6.2-3.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 787858] Review Request: bashmount - a menu-driven bash script for mounting removable media
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=787858 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 787858] Review Request: bashmount - a menu-driven bash script for mounting removable media
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=787858 --- Comment #11 from Jon Ciesla 2012-02-09 21:33:02 EST --- Git done (by process-git-requests). Added f17. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 787858] Review Request: bashmount - a menu-driven bash script for mounting removable media
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=787858 Jamie Nguyen changed: What|Removed |Added Flag||fedora-cvs? --- Comment #10 from Jamie Nguyen 2012-02-09 18:31:17 EST --- New Package SCM Request === Package Name: bashmount Short Description: A menu-driven bash script for mounting removable media Owners: jamielinux Branches: f16 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 787858] Review Request: bashmount - a menu-driven bash script for mounting removable media
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=787858 --- Comment #9 from Ian Weller 2012-02-09 16:31:27 EST --- Good review, Jamie -- I'm going to go ahead and sponsor you now. If you have any questions of where to go from here just let me know. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 787858] Review Request: bashmount - a menu-driven bash script for mounting removable media
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=787858 --- Comment #8 from Ian Weller 2012-02-09 15:00:00 EST --- So as we discussed in IRC, before I sponsor you I'm going to have you do a full review of this package: https://bugzilla.redhat.com/show_bug.cgi?id=787128 I've taken the bug, but go ahead and do the review. Let me know if you have any questions. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 787858] Review Request: bashmount - a menu-driven bash script for mounting removable media
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=787858 --- Comment #7 from Jamie Nguyen 2012-02-09 03:18:37 EST --- Thanks for comments. Revised: Spec URL: http://repo.tomoyolinux.co.uk/bashmount.spec SRPM URL: http://repo.tomoyolinux.co.uk/bashmount-1.6.2-3.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 787858] Review Request: bashmount - a menu-driven bash script for mounting removable media
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=787858 --- Comment #6 from Ian Weller 2012-02-08 19:23:11 EST --- Not too late -- I'll just ask Jamie to make those changes when the package is imported into git. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 787858] Review Request: bashmount - a menu-driven bash script for mounting removable media
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=787858
Mohamed El Morabity changed:
What|Removed |Added
CC||pikachu.2...@gmail.com
--- Comment #5 from Mohamed El Morabity 2012-02-08
19:09:58 EST ---
Just a note, maybe too late: maro such as %{__install}, %{__rm} and such should
not be used:
http://fedoraproject.org/wiki/Packaging:Guidelines#Macros
By the way, you shopuld also use the -p option in install, to keep the
timestamp of installed files.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 787858] Review Request: bashmount - a menu-driven bash script for mounting removable media
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=787858
Ian Weller changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #4 from Ian Weller 2012-02-08 18:57:42 EST ---
Review checklist, last updated 2012-02-07
Based on https://fedoraproject.org/wiki/Packaging:ReviewGuidelines
Key: [x] passed, [F] failed, [-] irrelevant
[x] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
bashmount.src: W: spelling-error %description -l en_US udisks -> disks,
u disks, Saudis
bashmount.src: W: spelling-error %description -l en_US unmount ->
unmounted, mount, Mount
bashmount.noarch: W: spelling-error %description -l en_US unmount ->
unmounted, mount, Mount
2 packages and 0 specfiles checked; 0 errors, 3 warnings.
[x] MUST: The package must be named according to the Package Naming Guidelines.
[x] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[x] MUST: The package must meet the Packaging Guidelines.
[x] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[x] MUST: The License field in the package spec file must match the actual
license.
[x] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[x] MUST: The spec file must be written in American English.
[x] MUST: The spec file for the package MUST be legible.
[x] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use md5sum for this task. If
no upstream URL can be specified for this package, please see the Source
URL Guidelines for how to deal with this.
[x] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[-] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed
in bugzilla, describing the reason that the package does not
compile/build/work on that architecture. The bug number MUST be placed in a
comment, next to the corresponding ExcludeArch line.
[x] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines;
inclusion of those as BuildRequires is optional. Apply common sense.
[-] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[-] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths,
must call ldconfig in %post and %postun.
[x] MUST: Packages must NOT bundle copies of system libraries.
[-] MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[x] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which
does create that directory.
[x] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations)
[x] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example.
[x] MUST: Each package must consistently use macros.
[x] MUST: The package must contain code, or permissable content.
[-] MUST: Large documentation files must go in a -doc subpackage. (The
definition of large is left up to the packager's best judgement, but is not
restricted to size. Large can refer to either size or quantity).
[x] MUST: If a package includes something as %doc, it must not affect the
runtime of the application. To summarize: If it is in %doc, the program
must run properly if it is not present.
[-] MUST: Static libraries must be in a -static package.
[-] MUST: Development files must be in a -devel package.
[-] MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency:
Requires: %{name}%{?_isa} = %{version}-%{release}
[-] MUST: Packages must NOT co
[Bug 787858] Review Request: bashmount - a menu-driven bash script for mounting removable media
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=787858 Ian Weller changed: What|Removed |Added Status|NEW |ASSIGNED CC||i...@ianweller.org Flag||fedora-review? --- Comment #3 from Ian Weller 2012-02-08 18:49:58 EST --- I can review this and sponsor you. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 787858] Review Request: bashmount - a menu-driven bash script for mounting removable media
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=787858 Ian Weller changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|i...@ianweller.org -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 787858] Review Request: bashmount - a menu-driven bash script for mounting removable media
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=787858 --- Comment #2 from Jamie Nguyen 2012-02-07 17:45:25 EST --- Thanks for comments. 1. Done. 2. Done. 3. Done. 4. I provide COPYING in the upstream tarball, which I have already packaged. Usually tarballs have one or the other. I've seen both COPYING and LICENSE shipped together in some upstream tarballs (usually to clarify licensing) but I don't think bashmount needs that. Revised: Spec URL: http://repo.tomoyolinux.co.uk/bashmount.spec SRPM URL: http://repo.tomoyolinux.co.uk/bashmount-1.6.2-2.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 787858] Review Request: bashmount - a menu-driven bash script for mounting removable media
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=787858 Ofer Schreiber changed: What|Removed |Added CC||oschr...@redhat.com --- Comment #1 from Ofer Schreiber 2012-02-07 03:44:07 EST --- I'm not a packager, so I can't be a sponsor yet. Some comments though: 1. BuildRoot is no longer needed in Fedora. should be removed. 2. %clean section is not needed in Fedora, should be removed. 3. The %install section should not contain anything that removes the buildroot. 4. LICENSE is missing, you should contact upstream (well, probably yourself) so a LICENSE text will be included in source tarball. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 787858] Review Request: bashmount - a menu-driven bash script for mounting removable media
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=787858 Jamie Nguyen changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
