[Bug 789660] Review Request : xcftools - Command-line tools for extracting information from XCF files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=789660 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||phatch-0.2.7-10.fc17 Resolution||ERRATA Last Closed||2012-03-21 14:40:11 --- Comment #16 from Fedora Update System 2012-03-21 14:40:11 EDT --- phatch-0.2.7-10.fc17, xcftools-1.0.7-5.fc17 has been pushed to the Fedora 17 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 789660] Review Request : xcftools - Command-line tools for extracting information from XCF files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=789660 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #15 from Fedora Update System 2012-03-16 15:02:54 EDT --- phatch-0.2.7-10.fc17, xcftools-1.0.7-5.fc17 has been pushed to the Fedora 17 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 789660] Review Request : xcftools - Command-line tools for extracting information from XCF files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=789660 Fedora Update System changed: What|Removed |Added Status|ON_QA |MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 789660] Review Request : xcftools - Command-line tools for extracting information from XCF files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=789660 --- Comment #14 from Fedora Update System 2012-03-16 08:57:51 EDT --- phatch-0.2.7-10.fc17,xcftools-1.0.7-5.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/phatch-0.2.7-10.fc17,xcftools-1.0.7-5.fc17 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 789660] Review Request : xcftools - Command-line tools for extracting information from XCF files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=789660 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #13 from Fedora Update System 2012-03-08 00:53:30 EST --- xcftools-1.0.7-4.fc17 has been pushed to the Fedora 17 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 789660] Review Request : xcftools - Command-line tools for extracting information from XCF files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=789660 --- Comment #12 from Fedora Update System 2012-03-08 00:05:42 EST --- xcftools-1.0.7-4.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/xcftools-1.0.7-4.fc17 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 789660] Review Request : xcftools - Command-line tools for extracting information from XCF files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=789660 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 789660] Review Request : xcftools - Command-line tools for extracting information from XCF files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=789660 --- Comment #11 from Jon Ciesla 2012-02-19 15:46:30 EST --- Git done (by process-git-requests). Unretired, created f17. Take ownership. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 789660] Review Request : xcftools - Command-line tools for extracting information from XCF files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=789660 --- Comment #10 from Lakshmi Narasimhan 2012-02-18 11:06:03 EST --- Thanks for the review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 789660] Review Request : xcftools - Command-line tools for extracting information from XCF files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=789660 Lakshmi Narasimhan changed: What|Removed |Added Status|NEW |ASSIGNED Flag||fedora-cvs? --- Comment #9 from Lakshmi Narasimhan 2012-02-18 09:57:45 EST --- Thanks, Please unretire devel branch. Package Change Request == Package Name: xcftools New Branches: f17 Owners: narasim -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 789660] Review Request : xcftools - Command-line tools for extracting information from XCF files
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=789660
Brendan Jones changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #8 from Brendan Jones 2012-02-18
03:40:02 EST ---
This package is APPROVED
Legend:
[+] OK
[!] Requires attention
[-] Not applicable
[N] Not evaluated
Required
[+] named according to the Package Naming Guidelines
[+] The spec file name must match the base package %{name}, in the format
%{name}.spec
[+] Meet the Packaging Guidelines
[+] Be licensed with a Fedora approved license and meet the Licensing
Guidelines
[+] The License field in the package spec file must match the actual license
[+] License file must be included in %doc
[+] The spec file must be written in American English
[+] The spec file for the package MUST be legible
[+] The sources used to build the package must match the upstream source
fd960b6470fb23520fc4b1ade6cf6e25 OK
[+] Successfully compile and build into binary rpms on at least one primary
architecture
[+] Proper use of ExcludeArch
[+] All build dependencies must be listed in BuildRequires
[+] The spec file MUST handle locales properly
[-] Shared library files (not just symlinks) in any of the dynamic linker's
default paths, must call ldconfig in %post and %postun
[+] Packages must NOT bundle copies of system libraries
[-] If the package is designed to be relocatable, the packager must state this
fact in the request for review, along with the rationalization for relocation
of that specific package
[+] A package must own all directories that it creates
directories under this
[+] A Fedora package must not list a file more than once in the spec file's
%files listings
[+] Permissions on files must be set properly. Every %files section must
include a %defattr(...) line
[+] Each package must consistently use macros
[+] The package must contain code, or permissable content
[-] Large documentation files must go in a -doc subpackage
[+] If a package includes something as %doc, it must not affect the runtime of
the application
[+] Header files must be in a -devel package
[-] Static libraries must be in a -static package
[+] library files that end in .so (without suffix) must go in a -devel package
[+] devel packages must require the base package using a fully versioned
dependency
[+] Packages must NOT contain any .la libtool archives
[-] GUI apps must include a %{name}.desktop file, properly installed with
desktop-file-install in the %install section
[+] Packages must not own files or directories already owned by other packages
[+] All filenames in rpm packages must be valid UTF-8
Should Items
[-] the packager SHOULD query upstream for any missing license text files to
include it
[-] Non-English language support for description and summary sections in the
package spec if available
[+] The reviewer should test that the package builds in mock
[+] The package should compile and build into binary rpms on all supported
architectures
[N] The reviewer should test that the package functions as described
[+] If scriptlets are used, those scriptlets must be sane
[-] Usually, subpackages other than devel should require the base package using
a fully versioned dependency
[+] The placement of pkgconfig(.pc) should usually be placed in a -devel pkg
[-] If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin consider requiring the package which provides the file
instead of the file itself
[-] Should contain man pages for binaries/scripts
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 789660] Review Request : xcftools - Command-line tools for extracting information from XCF files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=789660 --- Comment #6 from Lakshmi Narasimhan 2012-02-18 03:18:38 EST --- Here is the explanation of the error, In configure script generated by autoconf, there is a variable called program_transform_name initialized to s,x,x. This variable is intended to be passed to sed to modify the executable name. While doing a ./configure, if the user passes --program-prefix=xyz, then the program_transform_name is modified as s,^,xyz. And if we do not pass --program-prefix at all, it takes the default (s,x,x). Now the makefile which is using this variable should not be affected if --program-prefix is not passed at all. From rpmbuild, calling %configure expands to ./configure --program-prefix= .Since an empty prefix is passed, program_transform_name gets assigned to s&^&&. The makefile that uses the program_transform_name variable encounters the command substitution error. It is not necessary have to use program_transform_name variable in the Makefile because configure is passing a empty prefix anyway. I have created a patch that modifies the makefile to just copy the binaries into the destination directories instead of trying to use the program_transform_name variable. Spec file: http://narasim.fedorapeople.org/package_reviews/xcftools.spec Srpm file: http://narasim.fedorapeople.org/package_reviews/xcftools-1.0.7-4.fc15.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 789660] Review Request : xcftools - Command-line tools for extracting information from XCF files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=789660 --- Comment #7 from Lakshmi Narasimhan 2012-02-18 03:20:29 EST --- https://koji.fedoraproject.org/koji/taskinfo?taskID=3800542 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 789660] Review Request : xcftools - Command-line tools for extracting information from XCF files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=789660 --- Comment #5 from Lakshmi Narasimhan 2012-02-13 20:06:29 EST --- Looks like the errors are there in koji build as well but they are not getting propagated back to rpmbuild. I will look into it. Thanks -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 789660] Review Request : xcftools - Command-line tools for extracting information from XCF files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=789660 --- Comment #4 from Lakshmi Narasimhan 2012-02-13 08:20:28 EST --- Thanks, >Wouldn't hurt to be a little more specific in the files section Sure, will change it. >When building I get the following errors x 2. Can you just confirm that this is I built it on f16 via rpmbuild and the build went through. Rawhide builds ok as well. Will give it a try again. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 789660] Review Request : xcftools - Command-line tools for extracting information from XCF files
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=789660
--- Comment #3 from Brendan Jones 2012-02-13
06:46:51 EST ---
%defattr(-,root,root,-) is no longer required in the %files section
Wouldn't hurt to be a little more specific in the files section
%{_mandir}/man1/xcf*.1.gz
%{_mandir}/da/man1/xcf*.1.gz
When building I get the following errors x 2. Can you just confirm that this is
expected:
/bin/sh: command substitution: line 2: syntax error: unexpected end of file
/bin/sh: command substitution: line 2: syntax error: unexpected end of file
/bin/sh: command substitution: line 2: syntax error: unexpected end of file
/bin/sh: command substitution: line 2: syntax error: unexpected end of file
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 789660] Review Request : xcftools - Command-line tools for extracting information from XCF files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=789660 Brendan Jones changed: What|Removed |Added CC||brendan.jones...@gmail.com AssignedTo|nob...@fedoraproject.org|brendan.jones...@gmail.com Flag||fedora-review? --- Comment #2 from Brendan Jones 2012-02-13 06:27:31 EST --- I will take this review -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 789660] Review Request : xcftools - Command-line tools for extracting information from XCF files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=789660 --- Comment #1 from Lakshmi Narasimhan 2012-02-12 00:07:42 EST --- http://koji.fedoraproject.org/koji/taskinfo?taskID=3783488 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
