[Bug 794542] Review Request: dpsearch - DataparkSearch Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=794542 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||dpsearch-4.54-0.2.20120221s ||nap.el6 Resolution||ERRATA Last Closed||2012-03-10 12:32:14 --- Comment #15 from Fedora Update System 2012-03-10 12:32:14 EST --- dpsearch-4.54-0.2.20120221snap.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 794542] Review Request: dpsearch - DataparkSearch Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=794542 --- Comment #14 from Fedora Update System 2012-02-22 21:01:06 EST --- dpsearch-4.54-0.2.20120221snap.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/dpsearch-4.54-0.2.20120221snap.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 794542] Review Request: dpsearch - DataparkSearch Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=794542 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #13 from Fedora Update System 2012-02-20 14:01:29 EST --- dpsearch-4.54-0.1.20120215snap.el6 has been pushed to the Fedora EPEL 6 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 794542] Review Request: dpsearch - DataparkSearch Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=794542 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 794542] Review Request: dpsearch - DataparkSearch Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=794542 --- Comment #12 from Fedora Update System 2012-02-19 17:22:17 EST --- dpsearch-4.54-0.1.20120215snap.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/dpsearch-4.54-0.1.20120215snap.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 794542] Review Request: dpsearch - DataparkSearch Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=794542 --- Comment #11 from Jon Ciesla 2012-02-19 15:47:42 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 794542] Review Request: dpsearch - DataparkSearch Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=794542 Ricky Elrod changed: What|Removed |Added Flag||fedora-cvs? --- Comment #10 from Ricky Elrod 2012-02-19 13:37:42 EST --- New Package SCM Request === Package Name: dpsearch Short Description: DataparkSearch Engine Owners: codeblock Branches: el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 794542] Review Request: dpsearch - DataparkSearch Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=794542 Kevin Fenzi changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #9 from Kevin Fenzi 2012-02-19 12:09:37 EST --- You might use 'rm -f' on the la/a files in case they are permissions that wouldn't let them be removed normally, otherwise, I see no other blockers here, so this package is APPROVED. I'll sponsor you. If you have any questions, let me know. ;) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 794542] Review Request: dpsearch - DataparkSearch Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=794542 --- Comment #8 from Ricky Elrod 2012-02-18 14:23:47 EST --- Moved the CGI's to /usr/bin and updated dpsearch.conf accordingly so we don't have to generate it on build. http://codeblock.fedorapeople.org/dpsearch-4.54-0.1.20120215snap.fc18.src.rpm http://codeblock.fedorapeople.org/dpsearch.spec 1. fixed. 2. fixed. 3. using %% now, "." nuked, -devel requires non-devel now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 794542] Review Request: dpsearch - DataparkSearch Engine
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=794542
--- Comment #7 from Kevin Fenzi 2012-02-18 12:42:03 EST ---
Minor nit:
The dpsearch.conf apache file will have different paths depending on 32bit or
64bit build. Might make sense to construct this in the spec file at build time?
Or comment in it that the path will be one or the other.
1. You should rm the .la and .a files created. In most cases we don't want to
ship static libs or libtool archive files.
2. The cgi's are now in the devel subpackage. That doesn't seem optimal.
Perhaps we should just let them stay in /usr/bin/ ?
3. rpmlint now says (if we filter the fsf-address thing):
Man pages aren't required, so we can ignore this:
dpsearch.i686: W: no-manual-page-for-binary dpconv
dpsearch.i686: W: no-manual-page-for-binary splitter
dpsearch.i686: W: no-manual-page-for-binary cached
dpsearch.i686: W: no-manual-page-for-binary run-splitter
dpsearch.i686: W: no-manual-page-for-binary indexer
dpsearch.i686: W: no-manual-page-for-binary searchd
dpsearch.i686: W: no-manual-page-for-binary stored
dpsearch.i686: W: no-manual-page-for-binary dpguesser
You can fix this by using %%
dpsearch.src:53: W: macro-in-comment %{_prefix}
This is just due to googlecode being stupid.
dpsearch.src: W: invalid-url Source0:
http://dataparksearch.googlecode.com/files/dpsearch-4.54-2012-02-15.tar.bz2
HTTP Error 404: Not Found
dpsearch.x86_64: W: no-manual-page-for-binary dpconv
dpsearch.x86_64: W: no-manual-page-for-binary splitter
dpsearch.x86_64: W: no-manual-page-for-binary cached
dpsearch.x86_64: W: no-manual-page-for-binary run-splitter
dpsearch.x86_64: W: no-manual-page-for-binary indexer
dpsearch.x86_64: W: no-manual-page-for-binary searchd
dpsearch.x86_64: W: no-manual-page-for-binary stored
dpsearch.x86_64: W: no-manual-page-for-binary dpguesser
You should make the devel subpackage require the base package by
version-release:
dpsearch-devel.i686: W: no-dependency-on dpsearch/dpsearch-libs/libdpsearch
Nuke the . :)
dpsearch-devel.i686: W: summary-ended-with-dot C Development files for the
DataparkSearch Engine.
dpsearch-devel.i686: W: no-documentation
dpsearch-devel.x86_64: W: no-dependency-on dpsearch/dpsearch-libs/libdpsearch
dpsearch-devel.x86_64: W: summary-ended-with-dot C Development files for the
DataparkSearch Engine.
dpsearch-devel.x86_64: W: no-documentation
All other issues look good. ;)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 794542] Review Request: dpsearch - DataparkSearch Engine
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=794542
--- Comment #6 from Ricky Elrod 2012-02-17 21:37:18 EST ---
Disabled openssl for now, will poke upstream and ask about them making an
exception for it.
http://codeblock.fedorapeople.org/dpsearch/dpsearch-4.54-0.1.20120215snap.fc18.src.rpm
and
http://codeblock.fedorapeople.org/dpsearch/dpsearch.spec
Should be better. Fixed everything except the man pages thing for now, I can
take a look at that, but there is a lot of html documentation that gets thrown
in %{_defaultdocdir}/%{name}-%{version}.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 794542] Review Request: dpsearch - DataparkSearch Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=794542 --- Comment #4 from Ricky Elrod 2012-02-17 13:28:40 EST --- I actually already fixed most of those, just forgot to upload the new srpm (the specfile was right). Done: http://codeblock.fedorapeople.org/dpsearch/dpsearch-4.54.20120215snap-1.fc18.src.rpm I looked at using %configure and it was a bit more difficult - they tend to clutter some directories that shouldn't be cluttered, by default. I can look into managing that and using %configure and overriding the 2-3 flags to fix those locations, if it's a review-breaker, though. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 794542] Review Request: dpsearch - DataparkSearch Engine
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=794542
--- Comment #3 from Kevin Fenzi 2012-02-17 13:15:07 EST ---
This is a snapshot?
Can you update it based on:
http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages
ie, change versioning and include a comment with how the checkout was made (or
include a script to generate it).
You may also want to try building with 'make %{?_smp_mflags}' and using
'%configure' macro instead of ./configure. ;)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 794542] Review Request: dpsearch - DataparkSearch Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=794542 Kevin Fenzi changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|ke...@scrye.com Flag||fedora-review? --- Comment #2 from Kevin Fenzi 2012-02-16 22:56:09 EST --- I'll look at reviewing... tomorrow or this weekend. ;) Other comments of course welcome before then. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 794542] Review Request: dpsearch - DataparkSearch Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=794542 Ricky Elrod changed: What|Removed |Added CC||ke...@scrye.com --- Comment #1 from Ricky Elrod 2012-02-16 22:53:18 EST --- Kevin offered to review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
