[Bug 797447] Review Request: easybashgui - Bash function library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=797447 Fedora Update System changed: What|Removed |Added Fixed In Version|easybashgui-4.0.2-2.fc16|easybashgui-4.0.2-2.el6 --- Comment #14 from Fedora Update System 2012-03-24 15:08:03 EDT --- easybashgui-4.0.2-2.el6 has been pushed to the Fedora EPEL 6 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 797447] Review Request: easybashgui - Bash function library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=797447 Fedora Update System changed: What|Removed |Added Fixed In Version|easybashgui-4.0.2-2.fc17|easybashgui-4.0.2-2.fc15 --- Comment #12 from Fedora Update System 2012-03-21 21:59:03 EDT --- easybashgui-4.0.2-2.fc15 has been pushed to the Fedora 15 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 797447] Review Request: easybashgui - Bash function library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=797447 Fedora Update System changed: What|Removed |Added Fixed In Version|easybashgui-4.0.2-2.fc15|easybashgui-4.0.2-2.fc16 --- Comment #13 from Fedora Update System 2012-03-21 21:59:28 EDT --- easybashgui-4.0.2-2.fc16 has been pushed to the Fedora 16 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 797447] Review Request: easybashgui - Bash function library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=797447 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||easybashgui-4.0.2-2.fc17 Resolution||ERRATA Last Closed||2012-03-21 15:03:34 --- Comment #11 from Fedora Update System 2012-03-21 15:03:34 EDT --- easybashgui-4.0.2-2.fc17 has been pushed to the Fedora 17 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 797447] Review Request: easybashgui - Bash function library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=797447 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System 2012-03-06 14:32:52 EST --- easybashgui-4.0.2-2.el6 has been pushed to the Fedora EPEL 6 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 797447] Review Request: easybashgui - Bash function library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=797447 --- Comment #9 from Fedora Update System 2012-03-06 12:46:34 EST --- easybashgui-4.0.2-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/easybashgui-4.0.2-2.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 797447] Review Request: easybashgui - Bash function library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=797447 --- Comment #8 from Fedora Update System 2012-03-06 12:31:51 EST --- easybashgui-4.0.2-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/easybashgui-4.0.2-2.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 797447] Review Request: easybashgui - Bash function library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=797447 --- Comment #7 from Fedora Update System 2012-03-06 12:24:37 EST --- easybashgui-4.0.2-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/easybashgui-4.0.2-2.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 797447] Review Request: easybashgui - Bash function library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=797447 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 797447] Review Request: easybashgui - Bash function library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=797447 --- Comment #6 from Fedora Update System 2012-03-06 12:16:47 EST --- easybashgui-4.0.2-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/easybashgui-4.0.2-2.fc17 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 797447] Review Request: easybashgui - Bash function library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=797447 --- Comment #5 from Jon Ciesla 2012-03-06 11:41:45 EST --- Git done (by process-git-requests). Added f17 branch. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 797447] Review Request: easybashgui - Bash function library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=797447 Matthieu Saulnier changed: What|Removed |Added Flag||fedora-cvs? --- Comment #4 from Matthieu Saulnier 2012-03-06 11:15:42 EST --- New Package SCM Request === Package Name: easybashgui Short Description: Bash function library Owners: fantom Branches: f15 f16 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 797447] Review Request: easybashgui - Bash function library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=797447 Remi Collet changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #3 from Remi Collet 2012-03-06 10:55:58 EST --- All MUST fixed Would have prefer to delete the shebang line, something like sed -i '/^#!/d' ./easybashgui_test.sh But, this is only %doc APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 797447] Review Request: easybashgui - Bash function library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=797447 --- Comment #2 from Matthieu Saulnier 2012-03-06 10:43:06 EST --- Thanks a lot Remi I've corrected: Spec URL: http://fantom.fedorapeople.org/easybashgui.spec SRPM URL: http://fantom.fedorapeople.org/easybashgui-4.0.2-2.fc17.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 797447] Review Request: easybashgui - Bash function library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=797447
Remi Collet changed:
What|Removed |Added
CC||fed...@famillecollet.com
AssignedTo|nob...@fedoraproject.org|fed...@famillecollet.com
Flag||fedora-review?
--- Comment #1 from Remi Collet 2012-03-04 03:21:05
EST ---
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
Generic
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines. GPLv3+
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm < 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[-]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[ ]: MUST Package consistently uses macros (instead of hard-coded directory
names).
[x]: MUST Package meets the Packaging Guidelines.
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generates any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[!]: MUST Rpmlint output is silent.
rpmlint easybashgui-4.0.2-1.fc18.src.rpm
easybashgui.src: W: spelling-error %description -l en_US wich -> winch, witch,
which
rpmlint easybashgui-4.0.2-1.fc18.noarch.rpm
easybashgui.noarch: W: spelling-error %description -l en_US wich -> winch,
witch, which
easybashgui.noarch: W: no-manual-page-for-binary easydialog
easybashgui.noarch: W: no-manual-page-for-binary easybashgui-test
easybashgui.noarch: W: no-manual-page-for-binary easybashgui
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL. (md5sum 0c084e5f2776182d2003f14410a00a88)
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[x]: SHOULD Reviewer should test that the package builds in mock.
[-]: SHOULD If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to
include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[x]: SHOULD Package functions as described.
[x]: SHOULD Package does not include license text files separate from
upstream.
[x]: SHOULD Patches link to upstream bugs/comments/lists or are otherwise
justified.
[!]: SHOULD SourceX / PatchY prefixed with %{name}.
Note: Source0: EasyBashGUI_%{version}.tar.gz
(EasyBashGUI_%{version}.tar.gz) => only case.
[!]: SHOULD SourceX is a working URL. => ok as explain
[!]: SHOULD Description and summary sections in the package spec file contains
translations for supported Non-English
