[Bug 799702] Review Request: python-ufl - A compiler for finite element variational forms
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=799702 --- Comment #16 from Fedora Update System upda...@fedoraproject.org --- python-ufl-1.0.0-4.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Qabd9ecrjga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799702] Review Request: python-ufl - A compiler for finite element variational forms
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=799702 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2013-01-06 23:06:08 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aFEnHbuFUXa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799702] Review Request: python-ufl - A compiler for finite element variational forms
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=799702 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- python-ufl-1.0.0-4.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bWcmgQbg41a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799702] Review Request: python-ufl - A compiler for finite element variational forms
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=799702 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- python-ufl-1.0.0-4.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/python-ufl-1.0.0-4.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9N0FRs4XxHa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799702] Review Request: python-ufl - A compiler for finite element variational forms
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=799702 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- python-ufl-1.0.0-4.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-ufl-1.0.0-4.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NO0PvUMXMSa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799702] Review Request: python-ufl - A compiler for finite element variational forms
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=799702 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=91thFvAvnqa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799702] Review Request: python-ufl - A compiler for finite element variational forms
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=799702 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=omH6paqOHta=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799702] Review Request: python-ufl - A compiler for finite element variational forms
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=799702 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- python-ufl-1.0.0-4.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7EjVqeOmvCa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799702] Review Request: python-ufl - A compiler for finite element variational forms
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=799702 --- Comment #9 from Fabian Affolter m...@fabian-affolter.ch --- Thanks for the review, Tomas. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=c8kFEinvfEa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799702] Review Request: python-ufl - A compiler for finite element variational forms
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=799702 Fabian Affolter m...@fabian-affolter.ch changed: What|Removed |Added Flags||fedora-cvs? --- Comment #10 from Fabian Affolter m...@fabian-affolter.ch --- New Package SCM Request === Package Name: python-ufl Short Description: A compiler for finite element variational forms Owners: fab Branches: F17 F18 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=iN9UHy1cNAa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799702] Review Request: python-ufl - A compiler for finite element variational forms
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=799702 --- Comment #11 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ys5o7cWFwGa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799702] Review Request: python-ufl - A compiler for finite element variational forms
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=799702 Tomas Radej tra...@redhat.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #8 from Tomas Radej tra...@redhat.com --- Very good. *** APPROVED *** -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6M0wLoazdha=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799702] Review Request: python-ufl - A compiler for finite element variational forms
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=799702 --- Comment #7 from Fabian Affolter m...@fabian-affolter.ch --- (In reply to comment #6) Issues: === [!]: Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines [!]: License file installed when any subpackage combination is installed. Licence file missing from demo and test packages. Please note that the actual licence file is COPYING.LESSER, while COPYING is provided for files used at compile time, which are not included in the final package. License files added [!]: %check is present and all tests pass. Check section is commented out. Please, either uncomment it or provide reasons why tests aren't being run. %check removed [!]: Requires correct, justified where necessary. Test subpackage requires python2-nose. Should be python-nose Fixed [!]: Permissions on files are set properly. E. g. /usr/lib/python2.7/site-packages/ufl/test/test_lhs_rhs.py does not have the +x permission. I didn't check if the file is to be run, but since it has a shebang, I guess it is. Please also check these files: /usr/lib/python2.7/site-packages/ufl/test/test_book_snippets.py /usr/lib/python2.7/site-packages/ufl/test/test_tensoralgebra.py /usr/lib/python2.7/site-packages/ufl/test/ufltestcase.py Fixed Moreover, the file /usr/lib/python2.7/site-packages/ufl/demo/clean.sh from the demo subpackage is not executable. Please, change that. Fixed [fab@laptop11 SRPMS]$ rpmlint python-ufl-1.0.0-4.fc17.src.rpm python-ufl.src: W: spelling-error Summary(en_US) variational - variation, variegation, motivational python-ufl.src: W: spelling-error %description -l en_US discretizations - indiscretions, discretionary, discolorations python-ufl.src: W: spelling-error %description -l en_US variational - variation, variegation, motivational 1 packages and 0 specfiles checked; 0 errors, 3 warnings. [fab@laptop11 noarch]$ rpmlint python-ufl* python-ufl.noarch: W: spelling-error Summary(en_US) variational - variation, variegation, motivational python-ufl.noarch: W: spelling-error %description -l en_US discretizations - indiscretions, discretionary, discolorations python-ufl.noarch: W: spelling-error %description -l en_US variational - variation, variegation, motivational 3 packages and 0 specfiles checked; 0 errors, 3 warnings. Updated packages: Spec URL: http://fab.fedorapeople.org/packages/SRPMS/python-ufl.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/python-ufl-1.0.0-4.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=L5u3CQUtmga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799702] Review Request: python-ufl - A compiler for finite element variational forms
https://bugzilla.redhat.com/show_bug.cgi?id=799702
--- Comment #6 from Tomas Radej tra...@redhat.com ---
Sorry that it took so long.
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
Issues:
===
[!]: Package installs properly.
Note: Installation errors (see attachment)
See: https://fedoraproject.org/wiki/Packaging:Guidelines
[!]: License file installed when any subpackage combination is installed.
Licence file missing from demo and test packages. Please note that
the actual licence file is COPYING.LESSER, while COPYING is provided
for files used at compile time, which are not included in the final
package.
[!]: %check is present and all tests pass.
Check section is commented out. Please, either uncomment it or provide
reasons why tests aren't being run.
[!]: Requires correct, justified where necessary.
Test subpackage requires python2-nose. Should be python-nose
[!]: Permissions on files are set properly.
E. g. /usr/lib/python2.7/site-packages/ufl/test/test_lhs_rhs.py does not
have the +x permission. I didn't check if the file is to be run, but
since it has a shebang, I guess it is. Please also check these files:
/usr/lib/python2.7/site-packages/ufl/test/test_book_snippets.py
/usr/lib/python2.7/site-packages/ufl/test/test_tensoralgebra.py
/usr/lib/python2.7/site-packages/ufl/test/ufltestcase.py
Moreover, the file /usr/lib/python2.7/site-packages/ufl/demo/clean.sh
from the demo subpackage is not executable. Please, change that.
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[!]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[-]: Large documentation files are in a -doc subpackage, if required.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
LGPL (v3 or later), GPL (v2 or later), GPL (v3 or later), Unknown
or generated. 4 files have unknown license. Detailed output of
licensecheck in /home/tradej/reviews/799702-python-ufl/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[x]: Package do not use a name that already exist
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[!]: Package installs properly.
Note: Installation errors (see attachment)
[x]: Package is not relocatable.
[!]: Requires correct, justified where necessary.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
Python:
[x]: Package contains BR:
[Bug 799702] Review Request: python-ufl - A compiler for finite element variational forms
https://bugzilla.redhat.com/show_bug.cgi?id=799702 Fabian Affolter m...@fabian-affolter.ch changed: What|Removed |Added Flags|needinfo?(mail@fabian-affol | |ter.ch) | --- Comment #5 from Fabian Affolter m...@fabian-affolter.ch --- I messed up with the package names in the first place. Now I'm maintain that package too because it was review and is ready to use. I see no reason to remove it. Of course, the situation is a bit unlovely due to the naming of those packages. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799702] Review Request: python-ufl - A compiler for finite element variational forms
https://bugzilla.redhat.com/show_bug.cgi?id=799702 Tomas Radej tra...@redhat.com changed: What|Removed |Added Flags||needinfo?(mail@fabian-affol ||ter.ch) --- Comment #4 from Tomas Radej tra...@redhat.com --- Just before I proceed with the review, I want to ask you this: The package ufl-python, packaged by you (https://bugzilla.redhat.com/show_bug.cgi?id=693135), is a deliberate independent effort, or was it that you packaged the wrong ufl project by mistake and with this review you're getting in the right one? I'm asking because if the latter is right, I would like you to consider removing the ufl-python package, unless you really want to maintain it. Thank you, TR -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799702] Review Request: python-ufl - A compiler for finite element variational forms
https://bugzilla.redhat.com/show_bug.cgi?id=799702 Tomas Radej tra...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||tra...@redhat.com Assignee|m...@zarb.org |tra...@redhat.com --- Comment #3 from Tomas Radej tra...@redhat.com --- I take the liberty to review this package. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799702] Review Request: python-ufl - A compiler for finite element variational forms
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=799702 Jonathan Underwood jonathan.underw...@gmail.com changed: What|Removed |Added Blocks||821727(dolfin) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799702] Review Request: python-ufl - A compiler for finite element variational forms
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=799702 --- Comment #2 from Fabian Affolter m...@fabian-affolter.ch 2012-05-12 18:01:30 EDT --- * Fri Apr 13 2012 Fabian Affolter m...@fabian-affolter.ch - 1.0.0-3 - License issue fixed - Test subpackage - Demo subpackage Updated packages: Spec URL: http://fab.fedorapeople.org/packages/SRPMS/python-ufl.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/python-ufl-1.0.0-3.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799702] Review Request: python-ufl - A compiler for finite element variational forms
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=799702 Jonathan Underwood jonathan.underw...@gmail.com changed: What|Removed |Added Blocks||820660 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799702] Review Request: python-ufl - A compiler for finite element variational forms
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=799702 Fabian Affolter m...@fabian-affolter.ch changed: What|Removed |Added Alias||python-ufl -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799702] Review Request: python-ufl - A compiler for finite element variational forms
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=799702
Michael Scherer m...@zarb.org changed:
What|Removed |Added
CC||m...@zarb.org
AssignedTo|nob...@fedoraproject.org|m...@zarb.org
Flag||fedora-review?
--- Comment #1 from Michael Scherer m...@zarb.org 2012-03-24 13:30:21 EDT ---
Hi,
- the source code say that the code is under LGPL v3+ , so the license Tag need
to be fixed ( it say GPLv3+ ).
- there seems to be tests, have you tried to enable them in %check ?
- %{_mandir}/man1/*.gz should not hardcode the extension, as this could change
later ( like xz, bz2, etc ). Better use .*
- rm -rf %{buildroot} is no longer needed in %install since a few version of
Fedora.
Once this is fixed, i will start the formal review.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
