[Bug 799810] Review Request: python-picloud - PiCloud client-side Library
https://bugzilla.redhat.com/show_bug.cgi?id=799810 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799810] Review Request: python-picloud - PiCloud client-side Library
https://bugzilla.redhat.com/show_bug.cgi?id=799810 Amit Saha as...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED CC||as...@redhat.com Resolution|--- |WONTFIX Last Closed||2013-11-21 15:13:22 --- Comment #15 from Amit Saha as...@redhat.com --- Closing this for now, since PiCloud is shutting down [1], and I am not sure if at all I will ever work on a client for the new service that PiCloud is going to become. [1] http://blog.picloud.com/2013/11/17/picloud-has-joined-dropbox/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799810] Review Request: python-picloud - PiCloud client-side Library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=799810 --- Comment #14 from Volker Fröhlich volke...@gmx.at --- Amit, have you searched for a sponsor yet? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=E8mNPNDDZ5a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799810] Review Request: python-picloud - PiCloud client-side Library
https://bugzilla.redhat.com/show_bug.cgi?id=799810 --- Comment #13 from Amit Saha amitsaha...@gmail.com --- New upstream release. Updated files: SPEC: https://github.com/amitsaha/rpm_spec/raw/master/python-picloud.spec SRPM: https://github.com/amitsaha/rpm_spec/blob/master/python-picloud-2.5.6-1.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799810] Review Request: python-picloud - PiCloud client-side Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=799810 --- Comment #12 from Amit Saha amitsaha...@gmail.com 2012-03-23 22:47:18 EDT --- New upstream release. Updated files: SPEC: http://amitksaha.fedorapeople.org/contribs/picloud_packaging/python-picloud.spec SRPM: http://amitksaha.fedorapeople.org/contribs/picloud_packaging/python-picloud-2.4.4-1.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799810] Review Request: python-picloud - PiCloud client-side Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=799810 Christoph Wickert cwick...@fedoraproject.org changed: What|Removed |Added Status|NEW |ASSIGNED CC||cwick...@fedoraproject.org AssignedTo|nob...@fedoraproject.org|cwick...@fedoraproject.org Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799810] Review Request: python-picloud - PiCloud client-side Library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=799810
--- Comment #11 from Amit Saha amitsaha...@gmail.com 2012-03-13 22:08:41 EDT
---
(In reply to comment #10)
Please look at these examples:
http://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs
Your format is the one without the dash, but you're missing the release
number.
* Fri Mar 9 2012 Amit Saha amitks...@fedoraproject.org 2.4.2
should be
* Fri Mar 9 2012 Amit Saha amitks...@fedoraproject.org 2.4.2-2
%{_bindir}/ must be %{_bindir}/*, otherwise you're trying to own /usr/bin.
You could also consider to patch setup.py. That'd get you rid of the error
message while installing and you don't have to install manpage and bash
completion file on your own.
On second thoughts: The bash completion should probably not be considered
configuration at all. I looked through a couple of bash completion files (yum,
mock, git, bash-completion) and none of them labels it as configuration. I
guess you should do the same.
rpm -qf /etc/bash_completion.d/mock.bash
rpm -qc mock
...
If you incorporate these changes, the package is pretty fine from my point of
view. Nevertheslles I can't take the review, because you need a sponsor.
For the reviewer: The package now builds in Mock.
Many thanks for the comments. I have incorporated these changes, and checked in
Mock. It seems to be fine. Updated files:
SPEC file:
http://amitksaha.fedorapeople.org/contribs/picloud_packaging/python-picloud.spec
SRPM:
http://amitksaha.fedorapeople.org/contribs/picloud_packaging/python-picloud-2.4.2-3.fc16.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799810] Review Request: python-picloud - PiCloud client-side Library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=799810
--- Comment #10 from Volker Fröhlich volke...@gmx.at 2012-03-11 13:22:01 EDT
---
Please look at these examples:
http://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs
Your format is the one without the dash, but you're missing the release number.
* Fri Mar 9 2012 Amit Saha amitks...@fedoraproject.org 2.4.2
should be
* Fri Mar 9 2012 Amit Saha amitks...@fedoraproject.org 2.4.2-2
%{_bindir}/ must be %{_bindir}/*, otherwise you're trying to own /usr/bin.
You could also consider to patch setup.py. That'd get you rid of the error
message while installing and you don't have to install manpage and bash
completion file on your own.
On second thoughts: The bash completion should probably not be considered
configuration at all. I looked through a couple of bash completion files (yum,
mock, git, bash-completion) and none of them labels it as configuration. I
guess you should do the same.
rpm -qf /etc/bash_completion.d/mock.bash
rpm -qc mock
...
If you incorporate these changes, the package is pretty fine from my point of
view. Nevertheslles I can't take the review, because you need a sponsor.
For the reviewer: The package now builds in Mock.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799810] Review Request: python-picloud - PiCloud client-side Library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=799810
--- Comment #7 from Amit Saha amitsaha...@gmail.com 2012-03-09 09:43:16 EST
---
(In reply to comment #3)
It's not LGPLv2 but LGPLv2+. APL 2.0 and LGPLv2 are not compatible, as far as
I
can see, so you should mention both, as you do. But the three clause BSD
without advertising that src/util/cronexpr.py has, is compatible with GPL. So
i
think the overall license should be LGPLv2+ and ASL 2.0.
Use the macros with mkdir as well!
Remove the Requires for Python at all.
What is it about this comment:
# These packages are not require for python =2.6 but required for python =
2.5
I'm getting two warnings:
#Warning: Could not install bash completion scripts due to [Errno 13]
Permission denied: '/etc/bash_completion.d/picloud'
#Warning: Could not install bash completion scripts due to [Errno 13]
Permission denied: '/usr/share/man/man1/picloud.1'
The last line in the files section should be something like:
%config(noreplace) %{_sysconfdir}/bash_completion.d/*
Otherwise you'll own /etc and /etc/bash_completion. Why do you feel this
should
be (noreplace)? It is not something users usually customize, or is it?
The package still doesn't build in Mock.
Can you please take a look at the current SPEC and SRPM? Thanks for your
comments!
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799810] Review Request: python-picloud - PiCloud client-side Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=799810 --- Comment #8 from Volker Fröhlich volke...@gmx.at 2012-03-09 11:07:15 EST --- Please always bump the release when you change something and post the links. That's easier for reviewers. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799810] Review Request: python-picloud - PiCloud client-side Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=799810 --- Comment #9 from Amit Saha amitsaha...@gmail.com 2012-03-09 18:48:20 EST --- (In reply to comment #8) Please always bump the release when you change something and post the links. That's easier for reviewers. Thanks! Please find the revised files: SPEC: http://amitksaha.fedorapeople.org/contribs/picloud_packaging/python-picloud.spec SRPM: http://amitksaha.fedorapeople.org/contribs/picloud_packaging/python-picloud-2.4.2-2.fc16.src.rpm Shall look forward to your comments. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799810] Review Request: python-picloud - PiCloud client-side Library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=799810
--- Comment #3 from Volker Fröhlich volke...@gmx.at 2012-03-06 09:09:54 EST
---
It's not LGPLv2 but LGPLv2+. APL 2.0 and LGPLv2 are not compatible, as far as I
can see, so you should mention both, as you do. But the three clause BSD
without advertising that src/util/cronexpr.py has, is compatible with GPL. So i
think the overall license should be LGPLv2+ and ASL 2.0.
Use the macros with mkdir as well!
Remove the Requires for Python at all.
What is it about this comment:
# These packages are not require for python =2.6 but required for python = 2.5
I'm getting two warnings:
#Warning: Could not install bash completion scripts due to [Errno 13]
Permission denied: '/etc/bash_completion.d/picloud'
#Warning: Could not install bash completion scripts due to [Errno 13]
Permission denied: '/usr/share/man/man1/picloud.1'
The last line in the files section should be something like:
%config(noreplace) %{_sysconfdir}/bash_completion.d/*
Otherwise you'll own /etc and /etc/bash_completion. Why do you feel this should
be (noreplace)? It is not something users usually customize, or is it?
The package still doesn't build in Mock.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799810] Review Request: python-picloud - PiCloud client-side Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=799810 --- Comment #4 from Matěj Cepl mc...@redhat.com 2012-03-06 17:44:57 EST --- Created attachment 568090 -- https://bugzilla.redhat.com/attachment.cgi?id=568090 build log from the koji scratch build (In reply to comment #3) Use the macros with mkdir as well! Please. None of these silly macros ... see the thread on fedora-devel. What is it about this comment: # These packages are not require for python =2.6 but required for python = 2.5 yes, get rid of these ... there is no python 2.5 anywhere in the Fedora/RHEL world. The package still doesn't build in Mock. Neither does in koji http://koji.fedoraproject.org/koji/taskinfo?taskID=3861037 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799810] Review Request: python-picloud - PiCloud client-side Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=799810 --- Comment #5 from Volker Fröhlich volke...@gmx.at 2012-03-06 17:57:28 EST --- (In reply to comment #4) You're getting me wrong here. I'm referring to _sysconfdir and _datadir. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799810] Review Request: python-picloud - PiCloud client-side Library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=799810
--- Comment #6 from Amit Saha amitsaha...@gmail.com 2012-03-06 19:48:32 EST
---
(In reply to comment #4)
Created attachment 568090 [details]
build log from the koji scratch build
(In reply to comment #3)
Use the macros with mkdir as well!
Please. None of these silly macros ... see the thread on fedora-devel.
What is it about this comment:
# These packages are not require for python =2.6 but required for python =
2.5
yes, get rid of these ... there is no python 2.5 anywhere in the Fedora/RHEL
world.
The package still doesn't build in Mock.
This is probably a hack, but adding this line in the %install section allows
mock to pass successfully:
mkdir -p $RPM_BUILD_ROOT/%{_bindir}/
I have updated the spec file and SRPMS with the other comments. Please take a
look.
Neither does in koji
http://koji.fedoraproject.org/koji/taskinfo?taskID=3861037
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799810] Review Request: python-picloud - PiCloud client-side Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=799810 Amit Saha amitsaha...@gmail.com changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799810] Review Request: python-picloud - PiCloud client-side Library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=799810
--- Comment #1 from Volker Fröhlich volke...@gmx.at 2012-03-05 02:08:00 EST
---
Just a few comments:
- Harmonize on either using $RPM_BUILD_ROOT or %{buildroot}
- Use the _mandir and _sysconfdir macro in the install section and preserve
timestamps for the files you install
- BR python-devel, see
http://fedoraproject.org/wiki/Packaging:Python#BuildRequires
- Package fails to build for me (Rawhide, i386) -- probably for the reason
above
- Since EL 5 has Python 2.4, you're package probably won't work. In that case,
you should remove the rm in the install section and the buildroot definition --
http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#EL5
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 799810] Review Request: python-picloud - PiCloud client-side Library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=799810
--- Comment #2 from Amit Saha amitsaha...@gmail.com 2012-03-05 02:29:10 EST
---
Thanks for your comments:
(In reply to comment #1)
Just a few comments:
- Harmonize on either using $RPM_BUILD_ROOT or %{buildroot}
- Use the _mandir and _sysconfdir macro in the install section and preserve
timestamps for the files you install
- BR python-devel, see
http://fedoraproject.org/wiki/Packaging:Python#BuildRequires
- Package fails to build for me (Rawhide, i386) -- probably for the reason
above
- Since EL 5 has Python 2.4, you're package probably won't work. In that case,
you should remove the rm in the install section and the buildroot definition
--
http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#EL5
Can you please check the SPEC file now:
http://amitksaha.fedorapeople.org/contribs/picloud_packaging/python-picloud.spec
?
Cheers.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
