[Bug 800899] Review Request: spacewalk-pylint - Pylint configuration for spacewalk python packages
https://bugzilla.redhat.com/show_bug.cgi?id=800899 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 800899] Review Request: spacewalk-pylint - Pylint configuration for spacewalk python packages
https://bugzilla.redhat.com/show_bug.cgi?id=800899 --- Comment #20 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 800899] Review Request: spacewalk-pylint - Pylint configuration for spacewalk python packages
https://bugzilla.redhat.com/show_bug.cgi?id=800899 Miroslav Suchý msu...@redhat.com changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #18 from Miroslav Suchý msu...@redhat.com --- Package Change Request == Package Name: spacewalk-pylint New Branches: epel7 Owners: msuchy InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 800899] Review Request: spacewalk-pylint - Pylint configuration for spacewalk python packages
https://bugzilla.redhat.com/show_bug.cgi?id=800899 Miroslav Suchý msu...@redhat.com changed: What|Removed |Added CC||limburg...@gmail.com Flags||needinfo?(limburgher@gmail. ||com) --- Comment #17 from Miroslav Suchý msu...@redhat.com --- branch epel7 was not created, can you investigate that Jon? I will try to submit it again. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 800899] Review Request: spacewalk-pylint - Pylint configuration for spacewalk python packages
https://bugzilla.redhat.com/show_bug.cgi?id=800899 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|needinfo?(limburgher@gmail. | |com)| --- Comment #19 from Jon Ciesla limburg...@gmail.com --- https://fedorahosted.org/rel-eng/ticket/6028 Being investigated. . . -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 800899] Review Request: spacewalk-pylint - Pylint configuration for spacewalk python packages
https://bugzilla.redhat.com/show_bug.cgi?id=800899 Miroslav Suchý msu...@redhat.com changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #15 from Miroslav Suchý msu...@redhat.com --- Package Change Request == Package Name: spacewalk-pylint New Branches: epel7 Owners: msuchy InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 800899] Review Request: spacewalk-pylint - Pylint configuration for spacewalk python packages
https://bugzilla.redhat.com/show_bug.cgi?id=800899 --- Comment #16 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 800899] Review Request: spacewalk-pylint - Pylint configuration for spacewalk python packages
https://bugzilla.redhat.com/show_bug.cgi?id=800899 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 800899] Review Request: spacewalk-pylint - Pylint configuration for spacewalk python packages
https://bugzilla.redhat.com/show_bug.cgi?id=800899 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- spacewalk-pylint-0.5-1.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 800899] Review Request: spacewalk-pylint - Pylint configuration for spacewalk python packages
https://bugzilla.redhat.com/show_bug.cgi?id=800899 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- spacewalk-pylint-0.5-1.el5 has been pushed to the Fedora EPEL 5 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 800899] Review Request: spacewalk-pylint - Pylint configuration for spacewalk python packages
https://bugzilla.redhat.com/show_bug.cgi?id=800899 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Resolution|NEXTRELEASE |ERRATA --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- spacewalk-pylint-0.5-1.fc16 has been pushed to the Fedora 16 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 800899] Review Request: spacewalk-pylint - Pylint configuration for spacewalk python packages
https://bugzilla.redhat.com/show_bug.cgi?id=800899 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- spacewalk-pylint-0.5-1.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 800899] Review Request: spacewalk-pylint - Pylint configuration for spacewalk python packages
https://bugzilla.redhat.com/show_bug.cgi?id=800899 Miroslav Suchý msu...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Miroslav Suchý msu...@redhat.com --- New Package SCM Request === Package Name: spacewalk-pylint Short Description: Pylint configuration for spacewalk python packages Owners: msuchy Branches: F-17, F-16, EL-5, EL-6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 800899] Review Request: spacewalk-pylint - Pylint configuration for spacewalk python packages
https://bugzilla.redhat.com/show_bug.cgi?id=800899 --- Comment #6 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 800899] Review Request: spacewalk-pylint - Pylint configuration for spacewalk python packages
https://bugzilla.redhat.com/show_bug.cgi?id=800899 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 800899] Review Request: spacewalk-pylint - Pylint configuration for spacewalk python packages
https://bugzilla.redhat.com/show_bug.cgi?id=800899 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- spacewalk-pylint-0.5-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/spacewalk-pylint-0.5-1.el5 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 800899] Review Request: spacewalk-pylint - Pylint configuration for spacewalk python packages
https://bugzilla.redhat.com/show_bug.cgi?id=800899 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- spacewalk-pylint-0.5-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/spacewalk-pylint-0.5-1.el6 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 800899] Review Request: spacewalk-pylint - Pylint configuration for spacewalk python packages
https://bugzilla.redhat.com/show_bug.cgi?id=800899 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- spacewalk-pylint-0.5-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/spacewalk-pylint-0.5-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 800899] Review Request: spacewalk-pylint - Pylint configuration for spacewalk python packages
https://bugzilla.redhat.com/show_bug.cgi?id=800899 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- spacewalk-pylint-0.5-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/spacewalk-pylint-0.5-1.fc16 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 800899] Review Request: spacewalk-pylint - Pylint configuration for spacewalk python packages
https://bugzilla.redhat.com/show_bug.cgi?id=800899 Miroslav Suchý msu...@redhat.com changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2012-06-04 10:00:13 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 800899] Review Request: spacewalk-pylint - Pylint configuration for spacewalk python packages
https://bugzilla.redhat.com/show_bug.cgi?id=800899 Tomas Radej tra...@redhat.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #4 from Tomas Radej tra...@redhat.com --- I'm not sure either, but since diff is clean, it doesn't matter. Good to go. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 800899] Review Request: spacewalk-pylint - Pylint configuration for spacewalk python packages
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=800899
Tomas Radej tra...@redhat.com changed:
What|Removed |Added
Flag||fedora-review?
--- Comment #2 from Tomas Radej tra...@redhat.com 2012-05-16 11:00:53 EDT ---
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
Generic
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[!]: MUST Buildroot is not present
Note: Buildroot is not needed unless packager plans to package for EPEL5
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[!]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean is needed only if supporting EPEL
[x]: MUST Sources contain only permissible code or content.
[x]: MUST %config files are marked noreplace or the reason is justified.
[!]: MUST Each %files section contains %defattr if rpm 4.4
Note: defattr() present in %files section. This is OK if packaging
for EPEL5. Otherwise not needed
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf is only needed if supporting EPEL5
[x]: MUST Large documentation files are in a -doc subpackage, if required.
[-]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[!]: MUST License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. No licenses
found. Please check the source files for licenses manually.
[!]: MUST Package consistently uses macros (instead of hard-coded directory
names).
Note: Using both %{buildroot} and $RPM_BUILD_ROOT
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST No %config files under /usr.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[-]: MUST Useful -debuginfo package or justification otherwise.
[x]: SHOULD Reviewer should test that the package builds in mock.
[!]: SHOULD If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to
include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[x]: SHOULD Package functions as described.
[x]: SHOULD Latest version is packaged.
[-]: SHOULD Package does not include license text files separate from
upstream.
[x]: SHOULD Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: SHOULD SourceX is a working URL.
[-]: SHOULD Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: SHOULD Package should compile and build into binary rpms on all supported
architectures.
[-]: SHOULD %check is present and all tests pass.
[x]:
[Bug 800899] Review Request: spacewalk-pylint - Pylint configuration for spacewalk python packages
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=800899 --- Comment #3 from Miroslav Suchý msu...@redhat.com 2012-05-16 11:34:40 EDT --- I'm not sure why the md5 mismatch, when I download spacewalk-pylint-0.3.tar.gz I got md5sum 6449170b4bf47b1634cc1e95aa89da72 too. Anyway, all other issues addressed, Updated: SRPM: http://miroslav.suchy.cz/fedora/spacewalk-pylint/spacewalk-pylint-0.4-1.fc16.src.rpm SPEC: http://miroslav.suchy.cz/fedora/spacewalk-pylint/spacewalk-pylint.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 800899] Review Request: spacewalk-pylint - Pylint configuration for spacewalk python packages
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=800899 Tomas Radej tra...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||tra...@redhat.com AssignedTo|nob...@fedoraproject.org|tra...@redhat.com --- Comment #1 from Tomas Radej tra...@redhat.com 2012-05-14 02:23:21 EDT --- Taking it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 800899] Review Request: spacewalk-pylint - Pylint configuration for spacewalk python packages
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=800899 Miroslav Suchý msu...@redhat.com changed: What|Removed |Added Blocks||452450(F-Spacewalk) Alias||spacewalk-pylint -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
