[Bug 802050] Review request: love - A free 2D game engine which enables easy game creation in Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=802050 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|love-0.8.0-2.fc17 |love-0.8.0-2.fc15 --- Comment #37 from Fedora Update System upda...@fedoraproject.org 2012-04-14 19:21:50 EDT --- love-0.8.0-2.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 802050] Review request: love - A free 2D game engine which enables easy game creation in Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=802050 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|love-0.8.0-2.fc15 |love-0.8.0-2.fc16 --- Comment #38 from Fedora Update System upda...@fedoraproject.org 2012-04-14 19:22:04 EDT --- love-0.8.0-2.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 802050] Review request: love - A free 2D game engine which enables easy game creation in Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=802050 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||love-0.8.0-2.fc17 Resolution||ERRATA Last Closed||2012-04-11 23:05:55 --- Comment #36 from Fedora Update System upda...@fedoraproject.org 2012-04-11 23:05:55 EDT --- love-0.8.0-2.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 802050] Review request: love - A free 2D game engine which enables easy game creation in Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=802050 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #35 from Fedora Update System upda...@fedoraproject.org 2012-04-05 14:24:24 EDT --- love-0.8.0-1.fc17 has been pushed to the Fedora 17 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 802050] Review request: love - A free 2D game engine which enables easy game creation in Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=802050 --- Comment #30 from Martin Airs mar...@airs.me.uk 2012-04-04 13:06:55 EDT --- Thanks Jeremy, love-0.8.0 installed and mari0 running sweet. Martin -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 802050] Review request: love - A free 2D game engine which enables easy game creation in Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=802050 --- Comment #31 from Jeremy Newton alexjn...@hotmail.com 2012-04-04 13:37:01 EDT --- (In reply to comment #30) Thanks Jeremy, love-0.8.0 installed and mari0 running sweet. Martin No problem! But please give my packages some Karma if you have time: https://admin.fedoraproject.org/updates/love?_csrf_token=a283ef2bc3a259b342ebdbe0f3b1da891c1412f7 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 802050] Review request: love - A free 2D game engine which enables easy game creation in Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=802050 --- Comment #32 from Fedora Update System upda...@fedoraproject.org 2012-04-04 15:52:04 EDT --- love-0.8.0-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/love-0.8.0-2.fc17 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 802050] Review request: love - A free 2D game engine which enables easy game creation in Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=802050 --- Comment #33 from Fedora Update System upda...@fedoraproject.org 2012-04-04 15:53:52 EDT --- love-0.8.0-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/love-0.8.0-2.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 802050] Review request: love - A free 2D game engine which enables easy game creation in Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=802050 --- Comment #34 from Fedora Update System upda...@fedoraproject.org 2012-04-04 15:54:50 EDT --- love-0.8.0-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/love-0.8.0-2.fc15 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 802050] Review request: love - A free 2D game engine which enables easy game creation in Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=802050 Jeremy Newton alexjn...@hotmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #25 from Jeremy Newton alexjn...@hotmail.com 2012-04-03 21:27:23 EDT --- New Package SCM Request === Package Name: love Short Description: A free 2D game engine which enables easy game creation in Lua Owners: mystro256 Branches: F15 F16 F17 devel InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 802050] Review request: love - A free 2D game engine which enables easy game creation in Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=802050 --- Comment #26 from Jon Ciesla limburg...@gmail.com 2012-04-03 22:02:22 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 802050] Review request: love - A free 2D game engine which enables easy game creation in Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=802050 --- Comment #27 from Jeremy Newton alexjn...@hotmail.com 2012-04-03 23:23:39 EDT --- It seems version 0.8.0 was tagged yesterday, so I'm going to import 0.8.0 as soon as I confirm this is a new sample release and not a mistake. Though at the moment, it seems like I won't need to make an unstable after all. Anyway, for Martin Airs and anyone who is interested in rebuilding in the mean time, here's the Updated SRPM: http://dl.dropbox.com/u/42480493/love-0.8.0-1.fc16.src.rpm (In reply to comment #26) Git done (by process-git-requests). Thanks :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 802050] Review request: love - A free 2D game engine which enables easy game creation in Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=802050 --- Comment #29 from Fedora Update System upda...@fedoraproject.org 2012-04-04 00:11:32 EDT --- love-0.8.0-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/love-0.8.0-1.fc17 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 802050] Review request: love - A free 2D game engine which enables easy game creation in Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=802050 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 802050] Review request: love - A free 2D game engine which enables easy game creation in Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=802050 --- Comment #28 from Fedora Update System upda...@fedoraproject.org 2012-04-04 00:08:46 EDT --- love-0.8.0-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/love-0.8.0-1.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 802050] Review request: love - A free 2D game engine which enables easy game creation in Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=802050 --- Comment #17 from Jeremy Newton alexjn...@hotmail.com 2012-03-30 11:50:46 EDT --- (In reply to comment #16) (In reply to comment #15) I take you're trying to run mari0? I can make an unstable version too if there's interest, since I sort of have interest in using the unstable myself. Indeed I am, there's someone else trying to run mari0 too on the games mailing list. Thanks Martin Alright, I'll post another review request for love unstable -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 802050] Review request: love - A free 2D game engine which enables easy game creation in Lua
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=802050
Gregor Tätzner gre...@freenet.de changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #18 from Gregor Tätzner gre...@freenet.de 2012-03-30 13:52:49 EDT
---
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
C/C++
[x]: MUST Package does not contain any libtool archives (.la)
[x]: MUST Package does not contain kernel modules.
[x]: MUST Package contains no static executables.
[x]: MUST Rpath absent or only used for internal libs.
[x]: MUST Package is not relocatable.
Generic
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
[x]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
names).
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint output is silent.
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
/home/greg/projects/Review/802050/love-0.7.2-linux-src.tar.gz :
MD5SUM this package : c3e678606bb9a870c31168e85b269e7e
MD5SUM upstream package : c3e678606bb9a870c31168e85b269e7e
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[ ]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[x]: MUST Useful -debuginfo package or justification otherwise.
[x]: SHOULD Reviewer should test that the package builds in mock.
Generated by fedora-review 0.2.0git
External plugins:
APPROVED
well done
minor issue:
- before you check in please pass %{?_smp_mflags} to the make command
i.e. make %{?_smp_mflags}
don't remove it...we want a fast build, don't we? :)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 802050] Review request: love - A free 2D game engine which enables easy game creation in Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=802050 --- Comment #19 from Gregor Tätzner gre...@freenet.de 2012-03-30 13:58:57 EDT --- (In reply to comment #17) (In reply to comment #16) (In reply to comment #15) I take you're trying to run mari0? I can make an unstable version too if there's interest, since I sort of have interest in using the unstable myself. Indeed I am, there's someone else trying to run mari0 too on the games mailing list. Thanks Martin Alright, I'll post another review request for love unstable If you don't mind a suggestion: Don't put a unstable package into the official repo. It's not discouraged or something like that but imho it's not worth the trouble to go through the review process. When you get sponsored you get access to fedorapeople webspace. There you could host your unofficial unstable package and prepare it for the next stable release. just my 2 cents ;) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 802050] Review request: love - A free 2D game engine which enables easy game creation in Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=802050 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|gre...@freenet.de --- Comment #20 from Rex Dieter rdie...@math.unl.edu 2012-03-30 14:12:09 EDT --- Jeremy, if you could share your Fedora Account System (FAS) username, I can get you sponsored into the packager group -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 802050] Review request: love - A free 2D game engine which enables easy game creation in Lua
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=802050
--- Comment #21 from Jeremy Newton alexjn...@hotmail.com 2012-03-30 16:57:20
EDT ---
(In reply to comment #18)
minor issue:
- before you check in please pass %{?_smp_mflags} to the make command
i.e. make %{?_smp_mflags}
don't remove it...we want a fast build, don't we? :)
Sure, will do. :)
(In reply to comment #19)
If you don't mind a suggestion: Don't put a unstable package into the official
repo. It's not discouraged or something like that but imho it's not worth the
trouble to go through the review process. When you get sponsored you get
access
to fedorapeople webspace. There you could host your unofficial unstable
package and prepare it for the next stable release.
just my 2 cents ;)
You're right, that does make more sense, I'll look into making a wiki page on
https://fedoraproject.org/wiki/Fedora_Project_Wiki
(In reply to comment #20)
Jeremy, if you could share your Fedora Account System (FAS) username, I can
get
you sponsored into the packager group
My FAS username is mystro256; is there anything else I need to do? Such as join
a group on FAS that I'm not already in? Also should I post a CVS request or do
you do that?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 802050] Review request: love - A free 2D game engine which enables easy game creation in Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=802050 --- Comment #23 from Jeremy Newton alexjn...@hotmail.com 2012-03-30 17:24:32 EDT --- Sorry the link should be https://fedoraproject.org/wiki/L%C3%96VE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 802050] Review request: love - A free 2D game engine which enables easy game creation in Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=802050 --- Comment #22 from Jeremy Newton alexjn...@hotmail.com 2012-03-30 17:23:36 EDT --- (In reply to comment #16) (In reply to comment #15) I take you're trying to run mari0? I can make an unstable version too if there's interest, since I sort of have interest in using the unstable myself. Indeed I am, there's someone else trying to run mari0 too on the games mailing list. Thanks Martin I'll get the unstable up and going as soon as I can; I made a wiki page to post information on love in regards to Fedora. Please check up on it in a few days to grab the unstable build: https://fedoraproject.org/wiki/L%C3%96VE/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 802050] Review request: love - A free 2D game engine which enables easy game creation in Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=802050 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 802050] Review request: love - A free 2D game engine which enables easy game creation in Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=802050 --- Comment #24 from Rex Dieter rdie...@math.unl.edu 2012-03-30 23:33:05 EDT --- sponsored, next step is for you to request SCM access: http://fedoraproject.org/wiki/PackageMaintainers/Join#Add_Package_to_Source_Code_Management_.28SCM.29_system_and_Set_Owner -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 802050] Review request: love - A free 2D game engine which enables easy game creation in Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=802050 Gregor Tätzner gre...@freenet.de changed: What|Removed |Added CC||dw...@infradead.org Component|Package Review |0x AssignedTo|gre...@freenet.de |dw...@infradead.org Flag|fedora-review? | --- Comment #8 from Gregor Tätzner gre...@freenet.de 2012-03-29 12:33:16 EDT --- you are magnificent! If our nearly invisible observer rdieter doesn't spot any issues I will do a formal review tomorrow. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 802050] Review request: love - A free 2D game engine which enables easy game creation in Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=802050 Martin mar...@airs.me.uk changed: What|Removed |Added CC||mar...@airs.me.uk --- Comment #9 from Martin mar...@airs.me.uk 2012-03-29 12:45:27 EDT --- I have tried to rpmbuild --rebuild love-0.7.2-3.fc16.src.rpm on F16 x86_64 and it fails with... checking for library containing glLoadIdentity... no configure: error: Can't LÖVE without OpenGL I have installed mesa-libGL-devel and a ton of other -devel files in hopes of finding one that satisfies this. which one am I missing?? Martin -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 802050] Review request: love - A free 2D game engine which enables easy game creation in Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=802050 --- Comment #11 from Martin mar...@airs.me.uk 2012-03-29 12:56:21 EDT --- Getting requirements for ./love.spec -- Already installed : DevIL-devel-1.7.8-6.fc16.x86_64 -- Already installed : libtiff-devel-3.9.5-1.fc16.x86_64 -- Already installed : freetype-devel-2.4.6-4.fc16.x86_64 -- Already installed : lua-devel-5.1.4-9.fc16.x86_64 -- Already installed : physfs-devel-1.0.2-3.fc15.x86_64 -- Already installed : SDL-devel-1.2.14-13.fc16.x86_64 -- Already installed : openal-soft-devel-1.12.854-2.fc15.x86_64 -- Already installed : 2:libogg-devel-1.2.2-3.fc15.x86_64 -- Already installed : 1:libvorbis-devel-1.3.3-1.fc16.x86_64 -- Already installed : flac-devel-1.2.1-6.fc12.x86_64 -- Already installed : 1:libmodplug-devel-0.8.8.4-1.fc16.x86_64 -- Already installed : libmng-devel-1.0.10-5.fc15.x86_64 -- Already installed : desktop-file-utils-0.18-4.fc16.x86_64 -- Already installed : libtool-2.4-9.fc16.x86_64 No uninstalled build requires seems ok?? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 802050] Review request: love - A free 2D game engine which enables easy game creation in Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=802050 --- Comment #10 from Gregor Tätzner gre...@freenet.de 2012-03-29 12:53:53 EDT --- (In reply to comment #9) I have tried to rpmbuild --rebuild love-0.7.2-3.fc16.src.rpm on F16 x86_64 and it fails with... checking for library containing glLoadIdentity... no configure: error: Can't LÖVE without OpenGL I have installed mesa-libGL-devel and a ton of other -devel files in hopes of finding one that satisfies this. which one am I missing?? Martin try to run yum-builddep on the spec file -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 802050] Review request: love - A free 2D game engine which enables easy game creation in Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=802050 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Component|0x |Package Review AssignedTo|dw...@infradead.org |nob...@fedoraproject.org Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 802050] Review request: love - A free 2D game engine which enables easy game creation in Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=802050 --- Comment #12 from Jon Ciesla limburg...@gmail.com 2012-03-29 13:25:53 EDT --- Don't set the cvs flag until the review is approved, thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 802050] Review request: love - A free 2D game engine which enables easy game creation in Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=802050 --- Comment #13 from Martin mar...@airs.me.uk 2012-03-29 13:34:37 EDT --- hmm ok, well it built in koji ok, http://koji.fedoraproject.org/koji/taskinfo?taskID=3943925 and I now have it installed, the funny thing is, the reason for all of this was to run something that I now discover requires 0.8.0 or higher, lol :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 802050] Review request: love - A free 2D game engine which enables easy game creation in Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=802050 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Flag||fedora-review? --- Comment #14 from Rex Dieter rdie...@math.unl.edu 2012-03-29 13:40:34 EDT --- re: comment #12 oops, meant to reset the fedora-review flag, and botched it. sorry. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 802050] Review request: love - A free 2D game engine which enables easy game creation in Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=802050 --- Comment #15 from Jeremy Newton alexjn...@hotmail.com 2012-03-29 14:19:06 EDT --- (In reply to comment #13) hmm ok, well it built in koji ok, http://koji.fedoraproject.org/koji/taskinfo?taskID=3943925 I take it must be an issue with your system, as I've tested it in mock (i686 and x64). Let me know if you have an other troubles with this later on and I now have it installed, the funny thing is, the reason for all of this was to run something that I now discover requires 0.8.0 or higher, lol :) I take you're trying to run mari0? I can make an unstable version too if there's interest, since I sort of have interest in using the unstable myself. (In reply to comment #8) you are magnificent! If our nearly invisible observer rdieter doesn't spot any issues I will do a formal review tomorrow. Thanks! Though I noticed I must be half asleep when I write these change logs haha, I'll fix it and re-upload it ;) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 802050] Review request: love - A free 2D game engine which enables easy game creation in Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=802050 --- Comment #16 from Martin Airs mar...@airs.me.uk 2012-03-29 18:45:13 EDT --- (In reply to comment #15) I take you're trying to run mari0? I can make an unstable version too if there's interest, since I sort of have interest in using the unstable myself. Indeed I am, there's someone else trying to run mari0 too on the games mailing list. Thanks Martin -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 802050] Review request: love - A free 2D game engine which enables easy game creation in Lua
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=802050
--- Comment #6 from Gregor Tätzner gre...@freenet.de 2012-03-28 05:05:15 EDT
---
(In reply to comment #3)
Good point, this is another thing I can send upstream. Although knowing the
current development, it probably won't be incorporated until 0.8 comes out.
Good enough. Please keep informing us about the progress. I think there is some
guideline about upstreaming patches. here it is
http://fedoraproject.org/wiki/Staying_close_to_upstream_projects
round 2:
-please use the %name macro whenever possible throughout the spec file i.e. in
the top section
-make %{?_smp_mflags} install DESTDIR=%{buildroot}
smp_mflags macro seems to be unnecessary since here no compilation is involved
-there is a typo in changelog 2
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 802050] Review request: love - A free 2D game engine which enables easy game creation in Lua
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=802050
--- Comment #7 from Jeremy Newton alexjn...@hotmail.com 2012-03-28 22:02:50
EDT ---
(In reply to comment #6)
(In reply to comment #3)
Good point, this is another thing I can send upstream. Although knowing the
current development, it probably won't be incorporated until 0.8 comes out.
Good enough. Please keep informing us about the progress. I think there is
some
guideline about upstreaming patches. here it is
http://fedoraproject.org/wiki/Staying_close_to_upstream_projects
Yep, I included the bug reports right into the new spec :)
round 2:
-please use the %name macro whenever possible throughout the spec file i.e. in
the top section
-make %{?_smp_mflags} install DESTDIR=%{buildroot}
smp_mflags macro seems to be unnecessary since here no compilation is involved
-there is a typo in changelog 2
Done! Here's the new files and I also made a man page, which I sent upstream
(issue 405, see spec):
SPEC:
http://dl.dropbox.com/u/42480493/love.spec
SRPM:
http://dl.dropbox.com/u/42480493/love-0.7.2-3.fc16.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 802050] Review request: love - A free 2D game engine which enables easy game creation in Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=802050 Gregor Tätzner gre...@freenet.de changed: What|Removed |Added Status|NEW |ASSIGNED CC||gre...@freenet.de AssignedTo|nob...@fedoraproject.org|gre...@freenet.de Flag||fedora-review? --- Comment #1 from Gregor Tätzner gre...@freenet.de 2012-03-27 12:57:53 EDT --- I'm going to take this review and help you out. If you package gets approved rdieter will sponsor you (I can't do that). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 802050] Review request: love - A free 2D game engine which enables easy game creation in Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=802050 --- Comment #2 from Gregor Tätzner gre...@freenet.de 2012-03-27 13:56:06 EDT --- just a quick shot: - your package doesnt build in mock -add desktop-file-utils and libtool as BuildRequires - place your sed magic in the %install section :) - please explain the optional patch. Why did you include it? Why isn't it in upstream? (In reply to comment #0) love.x86_64: W: no-manual-page-for-binary love This isn't critical, so ignored it. I can write a man page and send it upstream if needed. yeah non critical, but it would be really *cool* if you can do it :) love.src: W: invalid-url Source1: love-extra.tar.xz This source does not have a download link because I created it; a link above the source provides the source for the files I included (from Ubuntu's Debian files). I can provide a script to generate this if necessary. is there some reason why you didn't send this to upstream? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 802050] Review request: love - A free 2D game engine which enables easy game creation in Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=802050 --- Comment #3 from Jeremy Newton alexjn...@hotmail.com 2012-03-27 20:08:18 EDT --- (In reply to comment #1) I'm going to take this review and help you out. If you package gets approved rdieter will sponsor you (I can't do that). Awesome, thanks! (In reply to comment #2) just a quick shot: - your package doesnt build in mock -add desktop-file-utils and libtool as BuildRequires Ah, that's what I was missing, I knew I forgot something - place your sed magic in the %install section :) As in the line that says: sed -i 's/\r//' license.txt readme.txt In the install section? seems a little odd, shouldn't this be in the prep because its the equivalent of a patch? - please explain the optional patch. Why did you include it? Why isn't it in upstream? Good point, I should ask upstream to include this. (In reply to comment #0) love.x86_64: W: no-manual-page-for-binary love This isn't critical, so ignored it. I can write a man page and send it upstream if needed. yeah non critical, but it would be really *cool* if you can do it :) Haha yeah I'm planning to; I need to make one for a package I have in RPMFusion, so I will when I have some time to figure out how to make them. love.src: W: invalid-url Source1: love-extra.tar.xz This source does not have a download link because I created it; a link above the source provides the source for the files I included (from Ubuntu's Debian files). I can provide a script to generate this if necessary. is there some reason why you didn't send this to upstream? Good point, this is another thing I can send upstream. Although knowing the current development, it probably won't be incorporated until 0.8 comes out. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 802050] Review request: love - A free 2D game engine which enables easy game creation in Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=802050 --- Comment #4 from Rex Dieter rdie...@math.unl.edu 2012-03-27 20:44:21 EDT --- Re: the sed'ing I'd have to agree with Jeremy, that this is akin to patching, and really does best belong in %prep -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 802050] Review request: love - A free 2D game engine which enables easy game creation in Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=802050 --- Comment #5 from Jeremy Newton alexjn...@hotmail.com 2012-03-27 21:49:20 EDT --- Alright, I added the missing deps and tested in mock; it builds just fine. Here's the new files: SPEC: http://dl.dropbox.com/u/42480493/love.spec SRPM: http://dl.dropbox.com/u/42480493/love-0.7.2-2.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 802050] Review request: love - A free 2D game engine which enables easy game creation in Lua
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=802050 Jeremy Newton alexjn...@hotmail.com changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
