[Bug 805327] Review Request: pyrasite-gui - A graphical interface for monitoring and introspecting Python
https://bugzilla.redhat.com/show_bug.cgi?id=805327 Otto Urpelainen changed: What|Removed |Added Blocks||201449 (FE-DEADREVIEW) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 805327] Review Request: pyrasite-gui - A graphical interface for monitoring and introspecting Python
https://bugzilla.redhat.com/show_bug.cgi?id=805327 Otto Urpelainen changed: What|Removed |Added Status|NEW |CLOSED CC||otu...@iki.fi Resolution|--- |NOTABUG Last Closed||2021-05-23 07:15:29 --- Comment #5 from Otto Urpelainen --- Closing, since this request is really old, pyrasite itself has been retired from Fedora [1] and submitter's Bgzilla account is invalid. [1]: https://src.fedoraproject.org/rpms/pyrasite/blob/rawhide/f/dead.package -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
needinfo canceled: [Bug 805327] Review Request: pyrasite-gui - A graphical interface for monitoring and introspecting Python
Product: Fedora Version: rawhide Component: Package Review Package Review has canceled Package Review 's request for Ian Weller 's needinfo: Bug 805327: Review Request: pyrasite-gui - A graphical interface for monitoring and introspecting Python https://bugzilla.redhat.com/show_bug.cgi?id=805327 --- Comment #4 from Package Review --- This is an automatic action taken by review-stats script. The ticket reviewer failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we reset the status and the assignee of this ticket. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
[Bug 805327] Review Request: pyrasite-gui - A graphical interface for monitoring and introspecting Python
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=805327
Ian Weller i...@ianweller.org changed:
What|Removed |Added
Flags|needinfo?(i...@ianweller.org |
|) |
--- Comment #1 from Ian Weller i...@ianweller.org ---
Review checklist, last updated 2013-02-05
Based on https://fedoraproject.org/wiki/Packaging:ReviewGuidelines
Key: [X] passed, [F] failed, [-] irrelevant
[F] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
pyrasite-gui.src: W: spelling-error %description -l en_US gdb - db, gab, gob
pyrasite-gui.src: W: file-size-mismatch pyrasite-gui-2.0beta7.tar.gz = 64032,
http://pypi.python.org/packages/source/p/pyrasite-gui/pyrasite-gui-2.0beta7.tar.gz
= 64013
pyrasite-gui.noarch: W: spelling-error %description -l en_US gdb - db, gab,
gob
pyrasite-gui.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/pyrasite_gui/gui.py 0644L /usr/bin/env
pyrasite-gui.noarch: W: no-manual-page-for-binary pyrasite-gui
2 packages and 1 specfiles checked; 1 errors, 4 warnings.
Use sed to remove the shebang from pyrasite_gui/gui.py
[X] MUST: The package must be named according to the Package Naming Guidelines.
[X] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[X] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[F] MUST: The License field in the package spec file must match the actual
license.
License tag is GPLv3, actual license is GPLv3+
[X] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[X] MUST: The spec file must be written in American English.
[X] MUST: The spec file for the package MUST be legible.
[F] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task.
If no upstream URL can be specified for this package, please see the Source
URL Guidelines for how to deal with this.
da37b5dc938d9a515b8bd97cafd1667da96b40c21a84cdae310b3465d127bbe5
pyrasite-gui-2.0beta7.tar.gz
51aae6d513cca6adbd7cd2a072e8f70151b7828aac90b9dc0421019fdff001a2
pyrasite-gui-2.0beta7.tar.gz.1
[X] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[-] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed
in bugzilla, describing the reason that the package does not
compile/build/work on that architecture. The bug number MUST be placed in a
comment, next to the corresponding ExcludeArch line.
[F] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines;
inclusion of those as BuildRequires is optional. Apply common sense.
Koji build failed: ImportError: No module named setuptools
[-] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[-] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths,
must call ldconfig in %post and %postun.
[F] MUST: Packages must NOT bundle copies of system libraries.
Package bundles jQuery but I'm not sure what the rules for that are. jQuery
isn't listed on the bundling exceptions page:
https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries
however I *know* that many packages bundle jQuery.
[-] MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[X] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which
does create that directory.
[X] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations)
[X] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example.
[X] MUST: Each package must consistently use macros.
[X] MUST: The package must contain code, or permissable content.
[-] MUST: Large documentation files must go in a -doc subpackage. (The
[Bug 805327] Review Request: pyrasite-gui - A graphical interface for monitoring and introspecting Python
https://bugzilla.redhat.com/show_bug.cgi?id=805327 Bug 805327 depends on bug 805587, which changed state. Bug 805587 Summary: Review Request: jquery - The jQuery JavaScript Library https://bugzilla.redhat.com/show_bug.cgi?id=805587 What|Removed |Added Status|NEW |CLOSED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 805327] Review Request: pyrasite-gui - A graphical interface for monitoring and introspecting Python
https://bugzilla.redhat.com/show_bug.cgi?id=805327 Luke Macken lmac...@redhat.com changed: What|Removed |Added Flags||needinfo?(i...@ianweller.org ||) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 805327] Review Request: pyrasite-gui - A graphical interface for monitoring and introspecting Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=805327 Ian Weller i...@ianweller.org changed: What|Removed |Added Status|NEW |ASSIGNED CC||i...@ianweller.org AssignedTo|nob...@fedoraproject.org|i...@ianweller.org Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 805327] Review Request: pyrasite-gui - A graphical interface for monitoring and introspecting Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=805327 Luke Macken lmac...@redhat.com changed: What|Removed |Added Depends on||805587 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 805327] Review Request: pyrasite-gui - A graphical interface for monitoring and introspecting Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=805327 Luke Macken lmac...@redhat.com changed: What|Removed |Added Depends on||803149 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
