[Bug 806117] Review Request: Oplop - Generate account passwords based on account nicknames
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=806117 --- Comment #11 from Abdel Gadiel Martínez Lassonde --- I would like to change the package name to python-oplop instead of Oplop. Here are the updated links: SRPM: http://potty.fedorapeople.org/Oplop/1.6-3/python-oplop-1.6-3.fc18.src.rpm SPEC: http://potty.fedorapeople.org/Oplop/1.6-3/python-oplop.spec Regards. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YEMQSEFH14&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806117] Review Request: Oplop - Generate account passwords based on account nicknames
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=806117
Eduardo Echeverria changed:
What|Removed |Added
CC||echevemas...@gmail.com
--- Comment #10 from Eduardo Echeverria ---
Abdel, I suggest you rename this package to python-oplop instead of Oplop, in
the future this package will eventually have support for python3 (
as can be seen in setup.py) and you will have to provide support to upstream,
and do a sub-package python3-oplop. One way would be as follows, is better do
right now and not worry about having headaches after
%global pkgname Oplop
Name:python-oplop
Source0:
https://pypi.python.org/packages/source/O/%{pkgname}/%{pkgname}-%{version}.zip
%prep
%setup -qn %{pkgname}-%{version}
if you have plan to ship this package to el5 must be define python_sitelib and
python_sitearch macros
i.e.
%if 0%{?rhel} && 0%{?rhel} <= 5
%{!?python_sitelib: %global python_sitelib %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print(get_python_lib())")}
%{!?python_sitearch: %global python_sitearch %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print(get_python_lib(1))")}
%endif
See https://fedoraproject.org/wiki/Packaging:Python#Macros
Please add the LICENSE file.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=HRc9PyttN7&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806117] Review Request: Oplop - Generate account passwords based on account nicknames
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=806117 --- Comment #9 from Abdel Gadiel Martínez Lassonde --- I have updated the packages with the suggestions Mario did. Here are the links: http://potty.fedorapeople.org/Oplop/1.6-2/Oplop.spec http://potty.fedorapeople.org/Oplop/1.6-2/Oplop-1.6-2.fc18.src.rpm I'm sorry for the delay. Regards. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=evVFRywGfA&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806117] Review Request: Oplop - Generate account passwords based on account nicknames
https://bugzilla.redhat.com/show_bug.cgi?id=806117 --- Comment #8 from Mario Blättermann --- Ping...? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806117] Review Request: Oplop - Generate account passwords based on account nicknames
https://bugzilla.redhat.com/show_bug.cgi?id=806117
--- Comment #7 from Mario Blättermann ---
Release:1%{?dist}.2
This is wrong, it is only applicable in some special cases [1]. Each time you
change something in your spec, you have to bump the release tag. But this
doesn't mean, you have to add a number after, rather you have to bump the first
number:
Release:2%{?dist}
See [2] for more information.
[1]
http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Minor_release_bumps_for_old_branches
[2] http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Release_Tag
BTW, your srpm download link from comment #4 doesn't point to the newest
version. It is
http://potty.fedorapeople.org/Oplop/1.6-1/Oplop-1.6-1.fc17.2.src.rpm. Please
check the links once you have build a new srpm.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806117] Review Request: Oplop - Generate account passwords based on account nicknames
https://bugzilla.redhat.com/show_bug.cgi?id=806117 --- Comment #6 from Abdel Gadiel Martínez Lassonde --- It is updated. Please check :) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806117] Review Request: Oplop - Generate account passwords based on account nicknames
https://bugzilla.redhat.com/show_bug.cgi?id=806117 Mario Blättermann changed: What|Removed |Added CC||mario.blaetterm...@gmail.co ||m --- Comment #5 from Mario Blättermann --- To pull python2 as a runtime requirement is superfluous here, rpm picks it up automatically since python2-devel is a build dependency. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806117] Review Request: Oplop - Generate account passwords based on account nicknames
https://bugzilla.redhat.com/show_bug.cgi?id=806117 --- Comment #4 from Abdel Gadiel Martínez Lassonde --- I have updated the package with the suggestions you did. Here is the spec and src.rpm files link: http://potty.fedorapeople.org/Oplop/1.6-1/Oplop-1.6-1.fc17.1.src.rpm http://potty.fedorapeople.org/Oplop/1.6-1/Oplop.spec -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806117] Review Request: Oplop - Generate account passwords based on account nicknames
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=806117 --- Comment #3 from Michael Scherer 2012-04-29 05:13:53 EDT --- Any news ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806117] Review Request: Oplop - Generate account passwords based on account nicknames
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=806117 --- Comment #2 from Abdel Gadiel Martínez Lassonde 2012-03-27 06:55:52 EDT --- Thank you. I'm on it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806117] Review Request: Oplop - Generate account passwords based on account nicknames
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=806117
Michael Scherer changed:
What|Removed |Added
CC||m...@zarb.org
--- Comment #1 from Michael Scherer 2012-03-25 07:06:48 EDT ---
Hi,
a few notes :
- if you use python3, you should requires python3-devel, not python-devel
https://fedoraproject.org/wiki/Packaging:Python#BuildRequires
The same goes for python2 ( and the software seems to be in python2, so maybe
the requires is wrong )
- %doc PKG-INFO README build/* oplop/* bin/*
why is everything in %doc ?
- rm -rf %{buildroot} is no longer needed, so does %defattr and %clean, and the
BuildRoot tag, see :
https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean
https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions
- %{__python} setup.py install -O1 --root=%{buildroot} --record=INSTALLED_FILES
since INSTALLED_FILES is not used, I think you should remove it
https://fedoraproject.org/wiki/Packaging:Python#Byte_compiling
- Requires: python3 xclip
this is IMHO better to have 1 requires per line. This produce better diff , so
ease review of patches.
- I think the requires on python will be added automatically by rpm, so no need
to add it directly.
- unless you plan to use the rpm on EPEL 5, the definition of the macro is not
needed at the start of the spec, this is default since fedora 14 and can be
removed.
- the license should in %doc
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text and
if not, you should contact upstream to add a license file.
- there seems to be test in the zip, they should be run in %check.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
