[Bug 806117] Review Request: python-oplop - Generate account passwords based on account nicknames

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=806117

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Resolution|WONTFIX |NOTABUG



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 806117] Review Request: python-oplop - Generate account passwords based on account nicknames

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=806117

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 CC||quantum.anal...@gmail.com
 Blocks||201449 (FE-DEADREVIEW)
 Resolution|--- |WONTFIX
  Flags|fedora-review?  |
Last Closed||2017-10-04 23:05:01



--- Comment #25 from Elliott Sales de Andrade  ---
It seems not.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=201449
[Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter
response should be blocking this bug.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 806117] Review Request: python-oplop - Generate account passwords based on account nicknames

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=806117

Charalampos Stratakis  changed:

   What|Removed |Added

 CC||abdel.g.martine...@gmail.co
   ||m, cstra...@redhat.com
  Flags||needinfo?(abdel.g.martinez.
   ||l...@gmail.com)



--- Comment #24 from Charalampos Stratakis  ---
This project is now (not so) active on github:
https://github.com/brettcannon/oplop

Is there still a desire to package that?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 806117] Review Request: python-oplop - Generate account passwords based on account nicknames

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=806117



--- Comment #23 from Eduardo Echeverria echevemas...@gmail.com ---
with respect to naming,  guidelines can help to clarify .

https://fedoraproject.org/wiki/Packaging:NamingGuidelines#General_Naming

 When naming a package you can take some cues from the name of the upstream
tarball, project name from which this software came, and what has been used for
this package by other distributions/packagers in the past. Do not just blindly
follow those examples, however, as package names should strive to be consistent
within Fedora more than consistent between distros. You should generally use
lowercase and turn underscores into dashes unless there's a compelling reason
to follow a different upstream convention. 

Therefore, guidelines advise the use of lowercase, and in other distros (like
Arch linux), oplop is named in lowercase =
https://aur.archlinux.org/packages/oplop/?setlang=es

Please if you will to support py3 and py2, the correct BR are python2-devel and
python3-devel and as said @cicku, use the appropiate macros. 

Best Regards and happy holidays

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806117] Review Request: python-oplop - Generate account passwords based on account nicknames

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=806117



--- Comment #21 from Abdel Gadiel Martínez Lassonde 
abdel.g.martine...@gmail.com ---
Hi Eduardo and Christopher.

I follow your previous advices. Please review this package:
SPEC - http://potty.fedorapeople.org/Oplop/1.6.1-5/python-oplop.spec
SRPM -
http://potty.fedorapeople.org/Oplop/1.6.1-5/python-oplop-1.6.1-5.fc20.src.rpm

Thanks in advance.

Merry Xmas!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806117] Review Request: python-oplop - Generate account passwords based on account nicknames

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=806117

Christopher Meng cicku...@gmail.com changed:

   What|Removed |Added

 CC|cicku...@gmail.com  |



--- Comment #22 from Christopher Meng cicku...@gmail.com ---
Thank you.

New thoughts only stand by me:

1. It's packager's choice to choose which kind of sources should they use for
packaging, however I always choose the smallest one.

In this case, I would choose tar.gz sources instead of zipball as RPM Source0
tag.

But, since only differences is 7 kb, I think it's trivial to let you change.

2. I can see that this package support python3, as many reviewer have said, you
should enable python3 subpackage, and Fedora 22(maybe higher) will set python3
as default stack so you'd better do that. Currently the way of supporting
python3 in your spec is invalid, checkout a template or do it by yourself:

http://cicku.me/python-pygit2.spec

3. In pace with python3's moving on, you should set old python2 macro from
unversioned to versioned:

%{__python} -- %{__python2}

%{python_sitelib} -- %{python2_sitelib}

4. Upstream has clearly told you that this package supports testing:


Run python3 test_main.py. Do note that Python 3 is required to run the test
suite.

So you should add check section for it.

5. I don't know which name is better, Oplop or oplop? Because Oplop is the
tarball name, but I'm not sure about naming the package now for python
packages,   maybe Eduardo can answer that. ;)


I will let Eduardo finish this review and quit now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806117] Review Request: python-oplop - Generate account passwords based on account nicknames

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=806117

Christopher Meng cicku...@gmail.com changed:

   What|Removed |Added

 CC||cicku...@gmail.com



--- Comment #18 from Christopher Meng cicku...@gmail.com ---
It's nonsense to add support for EL5 as el5 only has py2.4

http://pkgs.org/search/?keyword=python-develsearch_on=namedistro=2

And looking into

https://github.com/brettcannon/oplop/blob/master/Python/setup.py

We can see it needs at least 2.6.

So please drop el5 support and remove all unneeded fields.

Another note is that 

https://github.com/brettcannon/oplop

should be the URL of this package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806117] Review Request: python-oplop - Generate account passwords based on account nicknames

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=806117



--- Comment #19 from Eduardo Echeverria echevemas...@gmail.com ---
I agree with @cicku

As I said above the package don't have support for python = 2.4; so do you
must remove the epel5 stuff

- %clean is not needed
- BuildRoot is not needed

and remove these lines:

%if 0%{?rhel}  0%{?rhel} = 5
%{!?python_sitelib: %global python_sitelib %(%{__python} -c from
distutils.sysconfig import get_python_lib; print(get_python_lib()))}
%{!?python_sitearch: %global python_sitearch %(%{__python} -c from
distutils.sysconfig import get_python_lib; print(get_python_lib(1)))}
%endif

btw, I don't know why always the pipy tarballs never contains the boilerplate
of the licenses (thing that annoying me), but in the package's github we can
see the license , please add of local way or build all the package directly
from the github's source =
https://github.com/brettcannon/oplop/blob/master/LICENSE


if you decide build from github's sources please handle the url following the
guidelines 

https://fedoraproject.org/wiki/Packaging:SourceURL#Github

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806117] Review Request: python-oplop - Generate account passwords based on account nicknames

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=806117



--- Comment #20 from Abdel Gadiel Martínez Lassonde 
abdel.g.martine...@gmail.com ---
Thanks for the information, @cicku and @echevemaster.

I would work on the package and upload the corrections.

Regards!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806117] Review Request: python-oplop - Generate account passwords based on account nicknames

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=806117



--- Comment #17 from Abdel Gadiel Martínez Lassonde 
abdel.g.martine...@gmail.com ---
Hi Eduardo!

Here are my updates for this packages:
SRPM:
http://potty.fedorapeople.org/Oplop/1.6.1-4/python-oplop-1.6.1-4.fc19.src.rpm
SPEC: http://potty.fedorapeople.org/Oplop/1.6.1-4/python-oplop.spec

Hope this time is OK.

Regards,
Abdel

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=vAmzVLoQdka=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806117] Review Request: python-oplop - Generate account passwords based on account nicknames

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=806117

--- Comment #16 from Eduardo Echeverria echevemas...@gmail.com ---
anew, any update here?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=yEJuHrH3FKa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806117] Review Request: python-oplop - Generate account passwords based on account nicknames

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=806117

--- Comment #15 from Eduardo Echeverria echevemas...@gmail.com ---
Ping, any update here?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=MJH3pfmv3ea=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806117] Review Request: python-oplop - Generate account passwords based on account nicknames

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=806117

--- Comment #14 from Abdel Gadiel Martínez Lassonde 
abdel.g.martine...@gmail.com ---
I will upload the corrections.

Thanks for your help.

Regards.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=EEahRXnfVRa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806117] Review Request: python-oplop - Generate account passwords based on account nicknames

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=806117

--- Comment #13 from Eduardo Echeverria echevemas...@gmail.com ---
Hi Abdel

== TODO == 
- Don't need do the duplicate declaration of %doc, easily you can include the
files in one only declaration, please fix

- Please add the boiler plate of the license in %Source1, upstream explain
explicitely in the LICENSE file  that the package is ASL2.0 and invite to
obtain a copy, the copy should be obtained from
http://www.apache.org/licenses/LICENSE-2.0.txt

- tests should be run at some point, when the package is approved ,please seek
work soon with upstream for provide tests that work well in python3 and
python2, also provide the opportunity to build the package correctly on both
stacks, Remember that we are not allowed to build python3 packages if upstream
does not give full support (and in this case, upstream not given this support)

- From what I see, you plan to ship this package to epel5 therefore need to
follow appropriate guidelines, see
http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#EL5, i.e. buildroot
present, clean of the buildroot,and %defattr, but there are a problem,  the
build fails on epel5.If you ask me, I am among those who believe that we should
gradually be left support to el5, and moving on to el6 directly. Why? make
things easier for packager and el6 also shares the same Fedora packaging
guidelines

- I copy and paste the el5 build error here:

+ /usr/bin/unzip -qq /builddir/build/SOURCES/Oplop-1.6.zip
+ STATUS=0
+ '[' 0 -ne 0 ']'
+ cd Oplop-1.6
++ /usr/bin/id -u
+ '[' 1001 = 0 ']'
++ /usr/bin/id -u
+ '[' 1001 = 0 ']'
+ /bin/chmod -Rf a+rX,u+w,g-w,o-w .
+ exit 0
Ejecutando(%build): /bin/sh -e /var/tmp/rpm-tmp.45353
+ umask 022
+ cd /builddir/build/BUILD
+ cd Oplop-1.6
+ LANG=C
+ export LANG
+ unset DISPLAY
+ /usr/bin/python setup.py build
  File setup.py, line 15
with open('README', 'r') as file:
^
SyntaxError: invalid syntax


afaik, the python binary on el5 is Python 2.4, with statement  was introduced
in python 2.5, (understand because I say it is easier to move on to epel 6?) 


== EPEL6 ==
the package build fails too, due to small error:

* File not found:
/builddir/build/BUILDROOT/python-oplop-1.6-3.el6.x86_64/usr/lib/python2.6/site-packages/Oplop-1.6-py2.7.egg-info

in the spec you have this line: 
%{python_sitelib}/%{zip_name}-%{version}-py2.7.egg-info 
this line should be
%{python_sitelib}/%{zip_name}-%{version}-*.egg-info

Regards

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=APBGh3ausaa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806117] Review Request: python-oplop - Generate account passwords based on account nicknames

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=806117

Eduardo Echeverria echevemas...@gmail.com changed:

   What|Removed |Added

Summary|Review Request: Oplop - |Review Request:
   |Generate account passwords  |python-oplop - Generate
   |based on account nicknames  |account passwords based on
   ||account nicknames

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=audFmVLqGZa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806117] Review Request: python-oplop - Generate account passwords based on account nicknames

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=806117

Eduardo Echeverria echevemas...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|echevemas...@gmail.com
  Flags||fedora-review?

--- Comment #12 from Eduardo Echeverria echevemas...@gmail.com ---
Abdel, I'll do the review, tomorrow.   
I've been busy in this week

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=oNDF32vRXMa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review