[Bug 806669] Review Request: janino - An embedded Java compiler

2012-05-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806669

Fedora Update System  changed:

   What|Removed |Added

   Fixed In Version|janino-2.6.1-11.fc17|janino-2.6.1-12.fc16

--- Comment #30 from Fedora Update System  
2012-05-19 03:00:14 EDT ---
janino-2.6.1-12.fc16 has been pushed to the Fedora 16 stable repository.  If
problems still persist, please make note of it in this bug report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806669] Review Request: janino - An embedded Java compiler

2012-05-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806669

--- Comment #29 from Fedora Update System  
2012-05-08 04:01:29 EDT ---
janino-2.6.1-12.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/janino-2.6.1-12.fc16

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806669] Review Request: janino - An embedded Java compiler

2012-05-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806669

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||janino-2.6.1-11.fc17
 Resolution||ERRATA
Last Closed||2012-05-07 00:18:59

--- Comment #28 from Fedora Update System  
2012-05-07 00:18:59 EDT ---
janino-2.6.1-11.fc17 has been pushed to the Fedora 17 stable repository.  If
problems still persist, please make note of it in this bug report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806669] Review Request: janino - An embedded Java compiler

2012-04-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806669

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

--- Comment #27 from Fedora Update System  
2012-04-28 13:11:42 EDT ---
Package janino-2.6.1-11.fc17:
* should fix your issue,
* was pushed to the Fedora 17 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing janino-2.6.1-11.fc17'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-6892/janino-2.6.1-11.fc17
then log in and leave karma (feedback).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806669] Review Request: janino - An embedded Java compiler

2012-04-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806669

--- Comment #26 from Fedora Update System  
2012-04-28 06:02:30 EDT ---
janino-2.6.1-11.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/janino-2.6.1-11.fc17

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806669] Review Request: janino - An embedded Java compiler

2012-04-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806669

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806669] Review Request: janino - An embedded Java compiler

2012-04-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806669

--- Comment #25 from Mary Ellen Foster  2012-04-27 11:33:11 
EDT ---
That looks fine to me -- now that the block is removed, you should go ahead and
build it for rawhide and F17.

Sorry for the delay

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806669] Review Request: janino - An embedded Java compiler

2012-04-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806669

--- Comment #24 from gil cattaneo  2012-04-19 11:55:44 EDT 
---
Spec URL: http://gil.fedorapeople.org/janino.spec
SRPM URL: http://gil.fedorapeople.org/janino-2.6.1-11.fc16.src.rpm
- Remove janino-parent as a BuildRequirement

afraid  ... i apologize for the inconvenience

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806669] Review Request: janino - An embedded Java compiler

2012-04-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806669

--- Comment #23 from Mary Ellen Foster  2012-04-19 10:05:34 
EDT ---
Argh, one more small thing: it shouldn't BuildRequire janino-parent any more

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806669] Review Request: janino - An embedded Java compiler

2012-04-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806669

--- Comment #22 from gil cattaneo  2012-04-18 12:04:44 EDT 
---
Spec URL: http://gil.fedorapeople.org/janino.spec
SRPM URL: http://gil.fedorapeople.org/janino-2.6.1-10.fc16.src.rpm
- moved all of the jar files into janino subdirectory

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806669] Review Request: janino - An embedded Java compiler

2012-04-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806669

--- Comment #21 from Mary Ellen Foster  2012-04-18 11:28:18 
EDT ---
Created attachment 578390
  --> https://bugzilla.redhat.com/attachment.cgi?id=578390
Proposed patch

It looks good -- and simpler, so mgoldmann should be pleased. :)

The only thing I'd suggest is to put all of the jar files into a %{name}
subdirectory, because I think the Java packaging guidelines require it
(https://fedoraproject.org/wiki/Packaging:Java#Split_JAR_files)

The attached patch should do that

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806669] Review Request: janino - An embedded Java compiler

2012-04-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806669

--- Comment #20 from gil cattaneo  2012-04-18 11:09:44 EDT 
---
Spec URL: http://gil.fedorapeople.org/janino.spec
SRPM URL: http://gil.fedorapeople.org/janino-2.6.1-9.fc16.src.rpm
merged commons-compiler, commons-compiler-jdk and janino-parent in main package

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806669] Review Request: janino - An embedded Java compiler

2012-04-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806669

--- Comment #19 from gil cattaneo  2012-04-18 10:38:58 EDT 
---
Spec URL: http://gil.fedorapeople.org/janino.spec
SRPM URL: http://gil.fedorapeople.org/janino-2.6.1-8.fc16.src.rpm
merged janino-parent

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806669] Review Request: janino - An embedded Java compiler

2012-04-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806669

--- Comment #18 from Jon Ciesla  2012-04-16 09:49:01 EDT 
---
Git done (by process-git-requests).

Unretired devel and f15, please take ownership, added f16 and f17.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806669] Review Request: janino - An embedded Java compiler

2012-04-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806669

gil cattaneo  changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #17 from gil cattaneo  2012-04-16 09:42:32 EDT 
---
Package Change Request
==
Package Name: janino
New Branches: f17
Owners: gil
InitialCC: java-sig

update to 2.6.1

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806669] Review Request: janino - An embedded Java compiler

2012-04-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806669

Mary Ellen Foster  changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #16 from Mary Ellen Foster  2012-04-16 09:17:54 
EDT ---
Looks good!

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806669] Review Request: janino - An embedded Java compiler

2012-04-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806669

--- Comment #15 from gil cattaneo  2012-04-16 08:53:49 EDT 
---
Spec URL: http://gil.fedorapeople.org/janino.spec
SRPM URL: http://gil.fedorapeople.org/janino-2.6.1-7.fc16.src.rpm- Remove
commons-compiler as a BuildRequirement
- Add janino-parent as a Requirement for janino commons-compiler(,-jdk) pkgs

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806669] Review Request: janino - An embedded Java compiler

2012-04-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806669

--- Comment #14 from Mary Ellen Foster  2012-04-16 05:16:17 
EDT ---
I just took a closer look at the (Build)Requirements, and there are a few
issues:

For the main janino package:
- Remove commons-compiler as a BuildRequirement
- Add janino-parent as a Requirement

For commons-compiler(-jdk):
- Add janino-parent as a Requirement

Other than that, I think it's ready to go ...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806669] Review Request: janino - An embedded Java compiler

2012-04-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806669

--- Comment #13 from gil cattaneo  2012-04-13 12:12:52 EDT 
---
Spec URL: http://gil.fedorapeople.org/janino.spec
SRPM URL: http://gil.fedorapeople.org/janino-2.6.1-6.fc16.src.rpm
removed BR unzip
used %{name} and %{version} in source and patch file names

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806669] Review Request: janino - An embedded Java compiler

2012-04-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806669

--- Comment #12 from Mary Ellen Foster  2012-04-13 09:32:16 
EDT ---
Summary:
- remove "unzip" as a BuildRequirement
- use %{name} and %{version} in source and patch file names

Otherwise, looks good

Issues:
[!]: MUST All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
 Note: These BR are not needed: unzip
See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2

===> Remove "unzip" as BuildRequirement


[!]: MUST If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %doc.
See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text

===> Not sure why this is warning about this; the use of the license seems fine


[!]: MUST Rpmlint output is silent.

rpmlint janino-2.6.1-4.fc18.noarch.rpm

janino.noarch: W: spelling-error %description -l en_US bytecode -> byte code,
byte-code, decorate
janino.noarch: W: spelling-error %description -l en_US evaluators -> evaluates,
evaporators, elevators
1 packages and 0 specfiles checked; 0 errors, 2 warnings.


rpmlint janino-javadoc-2.6.1-4.fc18.noarch.rpm

1 packages and 0 specfiles checked; 0 errors, 0 warnings.


rpmlint janino-2.6.1-4.fc18.src.rpm

janino.src: W: spelling-error %description -l en_US bytecode -> byte code,
byte-code, decorate
janino.src: W: spelling-error %description -l en_US evaluators -> evaluates,
evaporators, elevators
1 packages and 0 specfiles checked; 0 errors, 2 warnings.


rpmlint commons-compiler-jdk-2.6.1-4.fc18.noarch.rpm

commons-compiler-jdk.noarch: W: spelling-error %description -l en_US codehaus
-> Wodehouse
commons-compiler-jdk.noarch: W: spelling-error %description -l en_US
ExpressionEvaluator -> Expressionless
commons-compiler-jdk.noarch: W: spelling-error %description -l en_US janino ->
Janine
1 packages and 0 specfiles checked; 0 errors, 3 warnings.


See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint


===> Not a problem

[!]: MUST Sources used to build the package match the upstream source, as
 provided in the spec URL.
/home/mef3/806669/commons-compiler-2.6.1.pom :
  MD5SUM this package : None
  MD5SUM upstream package : d41d8cd98f00b204e9800998ecf8427e
/home/mef3/806669/commons-compiler-jdk-2.6.1.pom :
  MD5SUM this package : cf7244a092e8f6cf9e66f620b90fc5dd
  MD5SUM upstream package : d41d8cd98f00b204e9800998ecf8427e
/home/mef3/806669/janino-2.6.1.zip :
  MD5SUM this package : bd1f9d38b8329017e469503baf53cf5b
  MD5SUM upstream package : bd1f9d38b8329017e469503baf53cf5b
/home/mef3/806669/janino-2.6.1.pom :
  MD5SUM this package : 968962e5591e36bbec8696f70443b5f3
  MD5SUM upstream package : d41d8cd98f00b204e9800998ecf8427e

See: http://fedoraproject.org/wiki/Packaging/SourceURL

===> This is because you can't wget files from repo1.maven.org with the default
user agent. I
tried downloading them myself manually and got this, which matches the files in
the SRPM:
f99e0f69541e17c8f160799b056720b4  commons-compiler-2.6.1.pom
cf7244a092e8f6cf9e66f620b90fc5dd  commons-compiler-jdk-2.6.1.pom
968962e5591e36bbec8696f70443b5f3  janino-2.6.1.pom



Package Review
==

Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated



 Generic 
[x]: MUST Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
 least one supported primary architecture.
[!]: MUST All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
 Note: These BR are not needed: unzip
[x]: MUST Buildroot is not present
 Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
 Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm < 4.4
 Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf 

[Bug 806669] Review Request: janino - An embedded Java compiler

2012-04-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806669

--- Comment #11 from gil cattaneo  2012-04-13 09:16:07 EDT 
---
Spec URL: http://gil.fedorapeople.org/janino.spec
SRPM URL: http://gil.fedorapeople.org/janino-2.6.1-5.fc16.src.rpm
commons-compiler spec file merged

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806669] Review Request: janino - An embedded Java compiler

2012-04-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806669

--- Comment #10 from gil cattaneo  2012-04-13 08:23:03 EDT 
---
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3987665

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806669] Review Request: janino - An embedded Java compiler

2012-04-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806669

--- Comment #9 from Mary Ellen Foster  2012-04-13 07:48:05 
EDT ---
I will review this package

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806669] Review Request: janino - An embedded Java compiler

2012-04-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806669

--- Comment #8 from gil cattaneo  2012-04-13 07:46:57 EDT 
---
Spec URL: http://gil.fedorapeople.org/janino.spec
SRPM URL: http://gil.fedorapeople.org/janino-2.6.1-4.fc16.src.rpm
added missing BR maven-surefire-provider-junit4 for prevent mock build failure

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806669] Review Request: janino - An embedded Java compiler

2012-04-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806669

--- Comment #7 from gil cattaneo  2012-04-13 07:19:12 EDT 
---
at this time would not be superfluous?
in available sources, there are no tests to be performed
here https://svn.codehaus.org/janino/tags/V_2_6_1/ also there aren't tests to
be performed
tks

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806669] Review Request: janino - An embedded Java compiler

2012-04-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806669

--- Comment #6 from Mary Ellen Foster  2012-04-13 05:02:14 
EDT ---
I think there's a missing BuildRequirement on maven-surefire-provider-junit4

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806669] Review Request: janino - An embedded Java compiler

2012-04-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806669

Mary Ellen Foster  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Flag||fedora-review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806669] Review Request: janino - An embedded Java compiler

2012-04-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806669

--- Comment #5 from gil cattaneo  2012-04-10 13:10:22 EDT 
---
Spec URL: http://gil.fedorapeople.org/janino.spec
SRPM URL: http://gil.fedorapeople.org/janino-2.6.1-3.fc16.src.rpm
removed janino-parent commons-compiler modules.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806669] Review Request: janino - An embedded Java compiler

2012-04-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806669

--- Comment #4 from Mary Ellen Foster  2012-04-10 10:39:24 
EDT ---
commons-compiler and janino-parent are both now packaged for F17+, so you
should probably modify this spec to only build the actual "janino" part.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806669] Review Request: janino - An embedded Java compiler

2012-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806669

Mary Ellen Foster  changed:

   What|Removed |Added

 Blocks||805487

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806669] Review Request: janino - An embedded Java compiler

2012-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806669

Mary Ellen Foster  changed:

   What|Removed |Added

 AssignedTo|nob...@fedoraproject.org|mefos...@gmail.com

--- Comment #3 from Mary Ellen Foster  2012-03-30 11:29:28 
EDT ---
I'll review this; just waiting for commons-compiler review to finish

(NB: janino-parent is already accepted, and I've already got a separate package
for commons-compiler under review, so you can probably just package the
"janino" parts separately in this RPM)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806669] Review Request: janino - An embedded Java compiler

2012-03-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806669

Mary Ellen Foster  changed:

   What|Removed |Added

 CC||mefos...@gmail.com

--- Comment #2 from Mary Ellen Foster  2012-03-30 11:26:57 
EDT ---
*** Bug 805047 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806669] Review Request: janino - An embedded Java compiler

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806669

--- Comment #1 from gil cattaneo  2012-03-27 08:53:13 EDT 
---
Spec URL: http://gil.fedorapeople.org/janino.spec
SRPM URL: http://gil.fedorapeople.org/janino-2.6.1-2.fc16.src.rpm
merged with mefoster's janino spec files
provides janino, parent, commons-compiler and commons-compiler-jdk

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review