[Bug 807479] Review Request: spacewalk-setup-jabberd - Tools to setup jabberd for Spacewalk
https://bugzilla.redhat.com/show_bug.cgi?id=807479 --- Comment #24 from Fedora Update System upda...@fedoraproject.org --- spacewalk-setup-jabberd-1.8.5-1.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 807479] Review Request: spacewalk-setup-jabberd - Tools to setup jabberd for Spacewalk
https://bugzilla.redhat.com/show_bug.cgi?id=807479 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2012-09-08 22:51:26 --- Comment #22 from Fedora Update System upda...@fedoraproject.org --- spacewalk-setup-jabberd-1.8.5-1.fc16 has been pushed to the Fedora 16 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 807479] Review Request: spacewalk-setup-jabberd - Tools to setup jabberd for Spacewalk
https://bugzilla.redhat.com/show_bug.cgi?id=807479 --- Comment #23 from Fedora Update System upda...@fedoraproject.org --- spacewalk-setup-jabberd-1.8.5-1.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 807479] Review Request: spacewalk-setup-jabberd - Tools to setup jabberd for Spacewalk
https://bugzilla.redhat.com/show_bug.cgi?id=807479 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 807479] Review Request: spacewalk-setup-jabberd - Tools to setup jabberd for Spacewalk
https://bugzilla.redhat.com/show_bug.cgi?id=807479 --- Comment #18 from Fedora Update System upda...@fedoraproject.org --- spacewalk-setup-jabberd-1.8.5-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/spacewalk-setup-jabberd-1.8.5-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 807479] Review Request: spacewalk-setup-jabberd - Tools to setup jabberd for Spacewalk
https://bugzilla.redhat.com/show_bug.cgi?id=807479 --- Comment #19 from Fedora Update System upda...@fedoraproject.org --- spacewalk-setup-jabberd-1.8.5-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/spacewalk-setup-jabberd-1.8.5-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 807479] Review Request: spacewalk-setup-jabberd - Tools to setup jabberd for Spacewalk
https://bugzilla.redhat.com/show_bug.cgi?id=807479 --- Comment #20 from Fedora Update System upda...@fedoraproject.org --- spacewalk-setup-jabberd-1.8.5-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/spacewalk-setup-jabberd-1.8.5-1.fc16 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 807479] Review Request: spacewalk-setup-jabberd - Tools to setup jabberd for Spacewalk
https://bugzilla.redhat.com/show_bug.cgi?id=807479 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #21 from Fedora Update System upda...@fedoraproject.org --- spacewalk-setup-jabberd-1.8.5-1.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 807479] Review Request: spacewalk-setup-jabberd - Tools to setup jabberd for Spacewalk
https://bugzilla.redhat.com/show_bug.cgi?id=807479 --- Comment #15 from Miroslav Suchý msu...@redhat.com --- Thanks for the review. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 807479] Review Request: spacewalk-setup-jabberd - Tools to setup jabberd for Spacewalk
https://bugzilla.redhat.com/show_bug.cgi?id=807479 Miroslav Suchý msu...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #16 from Miroslav Suchý msu...@redhat.com --- New Package SCM Request === Package Name: spacewalk-setup-jabberd Short Description: Tools to setup jabberd for Spacewalk Owners: msuchy Branches: F-18, F-17, F-16, EL-6, EL-5 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 807479] Review Request: spacewalk-setup-jabberd - Tools to setup jabberd for Spacewalk
https://bugzilla.redhat.com/show_bug.cgi?id=807479 --- Comment #17 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 807479] Review Request: spacewalk-setup-jabberd - Tools to setup jabberd for Spacewalk
https://bugzilla.redhat.com/show_bug.cgi?id=807479 --- Comment #7 from Miroslav Suchý msu...@redhat.com --- We are waiting for somebody? Me? I hope not. I do not think the description is blocker. Please, proceed with full review. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 807479] Review Request: spacewalk-setup-jabberd - Tools to setup jabberd for Spacewalk
https://bugzilla.redhat.com/show_bug.cgi?id=807479 --- Comment #8 from Mario Blättermann mario.blaetterm...@gmail.com --- (In reply to comment #7) I do not think the description is blocker. (In reply to comment #2) Although english is not my mother-tongue, I do not see error there. But suggestions are welcome. Then you should apply our suggestions. It doesn't make sense to provide a description which is not good in terms of grammar. Some Pidgin English annoys users, even the non-English ones. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 807479] Review Request: spacewalk-setup-jabberd - Tools to setup jabberd for Spacewalk
https://bugzilla.redhat.com/show_bug.cgi?id=807479 --- Comment #9 from Miroslav Suchý msu...@redhat.com --- OK SPEC: http://miroslav.suchy.cz/fedora/spacewalk-setup-jabberd/spacewalk-setup-jabberd.spec SRPM: http://miroslav.suchy.cz/fedora/spacewalk-setup-jabberd/spacewalk-setup-jabberd-1.8.5-1.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 807479] Review Request: spacewalk-setup-jabberd - Tools to setup jabberd for Spacewalk
https://bugzilla.redhat.com/show_bug.cgi?id=807479
Mario Blättermann mario.blaetterm...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co
||m
Flags||fedora-review?
--- Comment #10 from Mario Blättermann mario.blaetterm...@gmail.com ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4425164
$ rpmlint -i -v *spacewalk-setup-jabberd.src: I: checking
spacewalk-setup-jabberd.src: I: checking-url https://fedorahosted.org/spacewalk
(timeout 10 seconds)
spacewalk-setup-jabberd.src: I: checking-url
https://fedorahosted.org/releases/s/p/spacewalk/spacewalk-setup-jabberd-1.8.5.tar.gz
(timeout 10 seconds)
spacewalk-setup-jabberd.noarch: I: checking
spacewalk-setup-jabberd.noarch: E: explicit-lib-dependency libxslt
You must let rpm find the library dependencies by itself. Do not put unneeded
explicit Requires: tags.
spacewalk-setup-jabberd.noarch: I: checking-url
https://fedorahosted.org/spacewalk (timeout 10 seconds)
spacewalk-setup-jabberd.spec: I: checking-url
https://fedorahosted.org/releases/s/p/spacewalk/spacewalk-setup-jabberd-1.8.5.tar.gz
(timeout 10 seconds)
2 packages and 1 specfiles checked; 1 errors, 0 warnings.
As already discussed, the libxslt requirement is OK.
%{_sysconfdir}/pki/spacewalk
has to be
%config(noreplace) %{_sysconfdir}/pki/spacewalk
No further issues. Once you've fixed the file list, I will do a full review.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 807479] Review Request: spacewalk-setup-jabberd - Tools to setup jabberd for Spacewalk
https://bugzilla.redhat.com/show_bug.cgi?id=807479
--- Comment #11 from Miroslav Suchý msu...@redhat.com ---
spacewalk-setup-jabberd.src: I: checking-url
https://fedorahosted.org/releases/s/p/spacewalk/spacewalk-setup-jabberd-1.8.5.tar.gz
(timeout 10 seconds)
I can download it without problem. Can it be either temporar network problem or
rpmlint issue?
%{_sysconfdir}/pki/spacewalk
has to be
%config(noreplace) %{_sysconfdir}/pki/spacewalk
There are no config files. It is just two directories.
If you insist, I can rewrite it to:
%dir %{_sysconfdir}/pki/spacewalk
%dir %{_sysconfdir}/pki/spacewalk/jabberd
But the former formulation is one line shorter :)
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 807479] Review Request: spacewalk-setup-jabberd - Tools to setup jabberd for Spacewalk
https://bugzilla.redhat.com/show_bug.cgi?id=807479
--- Comment #12 from Mario Blättermann mario.blaetterm...@gmail.com ---
(In reply to comment #11)
spacewalk-setup-jabberd.src: I: checking-url
https://fedorahosted.org/releases/s/p/spacewalk/spacewalk-setup-jabberd-1.8.
5.tar.gz (timeout 10 seconds)
I can download it without problem.
Me too. There was no error message at all. The timeout is just a hint.
%{_sysconfdir}/pki/spacewalk
has to be
%config(noreplace) %{_sysconfdir}/pki/spacewalk
There are no config files. It is just two directories.
If you insist, I can rewrite it to:
%dir %{_sysconfdir}/pki/spacewalk
%dir %{_sysconfdir}/pki/spacewalk/jabberd
But the former formulation is one line shorter :)
No, the folder ownership is OK. I think the folder itself should be marked as
(noreplace) to avoid to be overwritten by rpm when updating the package. For
the time being, the folder is empty, but once it contains config files, they
could get lost.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 807479] Review Request: spacewalk-setup-jabberd - Tools to setup jabberd for Spacewalk
https://bugzilla.redhat.com/show_bug.cgi?id=807479 --- Comment #13 from Miroslav Suchý msu...@redhat.com --- %config and %config(noreplace) affects only file(s). This does not change behaviour of installing directories. And if such directory exist and contains files, the content of directry is *never* removed. Only acl bits and ownership of that directory is set to values in that rpm. And this behaviour does not affect neither %config nor %config(noreplace). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 807479] Review Request: spacewalk-setup-jabberd - Tools to setup jabberd for Spacewalk
https://bugzilla.redhat.com/show_bug.cgi?id=807479
Mario Blättermann mario.blaetterm...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #14 from Mario Blättermann mario.blaetterm...@gmail.com ---
(In reply to comment #13)
%config and %config(noreplace) affects only file(s). This does not change
behaviour of installing directories.
And if such directory exist and contains files, the content of directry is
*never* removed. Only acl bits and ownership of that directory is set to
values in that rpm. And this behaviour does not affect neither %config nor
%config(noreplace).
Sorry, I didn't know about that in particular. OK, here we go:
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
GPLv2
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[.] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
$ sha256sum *
f8fa698410ae42082b4a60e7c6bd6d1d1616a106c561f19df01536fb6edd48fe
spacewalk-setup-jabberd-1.8.5.tar.gz
f8fa698410ae42082b4a60e7c6bd6d1d1616a106c561f19df01536fb6edd48fe
spacewalk-setup-jabberd-1.8.5.tar.gz.orig
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[+] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[.] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[.] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[+] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[+] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations)
[+] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage. (The
definition of large is left up to the packager's best judgement, but is not
restricted to size. Large can refer to either size or quantity).
[+] MUST: If a package includes something as %doc, it must not affect the
runtime of the application. To summarize: If it is in %doc, the program must
run properly if it is not present.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: Development files must be in a -devel package.
[.] MUST: In the vast majority of cases, devel packages must require the base
package
[Bug 807479] Review Request: spacewalk-setup-jabberd - Tools to setup jabberd for Spacewalk
https://bugzilla.redhat.com/show_bug.cgi?id=807479 --- Comment #6 from Mario Blättermann mario.blaetterm...@gmail.com --- Any progress here? I would like to take this for a full review. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 807479] Review Request: spacewalk-setup-jabberd - Tools to setup jabberd for Spacewalk
https://bugzilla.redhat.com/show_bug.cgi?id=807479 --- Comment #5 from Volker Fröhlich volke...@gmx.at --- I meant Script, which setup Jabberd for Spacewalk.. As far as I can tell, that should be Script, which sets up Jabberd for Spacewalk.. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 807479] Review Request: spacewalk-setup-jabberd - Tools to setup jabberd for Spacewalk
https://bugzilla.redhat.com/show_bug.cgi?id=807479 --- Comment #4 from Miroslav Suchý msu...@redhat.com --- I assume rpm fails on finding this dependency automatically, it's a common problem on noarch packages. Otherwise you hadn't added it explicitely. Am I right? Yes. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 807479] Review Request: spacewalk-setup-jabberd - Tools to setup jabberd for Spacewalk
https://bugzilla.redhat.com/show_bug.cgi?id=807479 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added CC||mario.blaetterm...@gmail.co ||m --- Comment #3 from Mario Blättermann mario.blaetterm...@gmail.com --- Koji scratch build: koji.fedoraproject.org/koji/taskinfo?taskID=4227836 Rpmlint is silent so far, only this issue: $ rpmlint -i -v * spacewalk-setup-jabberd.noarch: I: checking spacewalk-setup-jabberd.noarch: E: explicit-lib-dependency libxslt You must let rpm find the library dependencies by itself. Do not put unneeded explicit Requires: tags. I assume rpm fails on finding this dependency automatically, it's a common problem on noarch packages. Otherwise you hadn't added it explicitely. Am I right? Proposal for the description (I'm not a native English speaker, too): Jabberd setup script for Spacewalk. It will be used during the installation of the Spacewalk server or Spacewalk proxy. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 807479] Review Request: spacewalk-setup-jabberd - Tools to setup jabberd for Spacewalk
https://bugzilla.redhat.com/show_bug.cgi?id=807479
--- Comment #2 from Miroslav Suchý msu...@redhat.com ---
I guess this also goes to EL5?
Yes.
%{_bindir}/spacewalk-setup-jabberd -- You can use the name macro on this line.
I do not want to. This will not make packaging easier. IMHO it can just bring
complication later in future.
I think the description is not perfect from a grammatical point of view.
Although english is not my mother-tongue, I do not see error there. But
suggestions are welcome.
Updated:
SPEC:
http://miroslav.suchy.cz/fedora/spacewalk-setup-jabberd/spacewalk-setup-jabberd.spec
SRPM:
http://miroslav.suchy.cz/fedora/spacewalk-setup-jabberd/spacewalk-setup-jabberd-1.8.1-1.fc16.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 807479] Review Request: spacewalk-setup-jabberd - Tools to setup jabberd for Spacewalk
https://bugzilla.redhat.com/show_bug.cgi?id=807479
Volker Fröhlich volke...@gmx.at changed:
What|Removed |Added
CC||volke...@gmx.at
--- Comment #1 from Volker Fröhlich volke...@gmx.at ---
I guess this also goes to EL5? Anyways, you can delete the defattr line.
%{_bindir}/spacewalk-setup-jabberd -- You can use the name macro on this line.
%dir %{_datadir}/spacewalk
%{_datadir}/spacewalk/*
can be simplified to %{_datadir}/spacewalk. On the other hand: This directory
is already owned by spacewalk-branding. You should probably just require it, if
that makes sense.
The syntax for the two pki directories can also be simplified, if I don't miss
something here.
I think the description is not perfect from a grammatical point of view.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 807479] Review Request: spacewalk-setup-jabberd - Tools to setup jabberd for Spacewalk
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=807479 Miroslav Suchý msu...@redhat.com changed: What|Removed |Added Blocks||452450(F-Spacewalk) Summary|Review Request: |Review Request: |spacewalk-setup-jabberd |spacewalk-setup-jabberd - ||Tools to setup jabberd for ||Spacewalk -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
