[Bug 810010] Review Request: genders - file based database for cluster managment

2014-07-07 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=810010



--- Comment #26 from David Brown  ---
Package Change Request
==
Package Name: genders
New Branches: el7
Owners: dmlb2000

I'd like to start testing el7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 810010] Review Request: genders - file based database for cluster managment

2012-07-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=810010

--- Comment #25 from Fedora Update System  ---
genders-1.18-6.el5 has been pushed to the Fedora EPEL 5 stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 810010] Review Request: genders - file based database for cluster managment

2012-07-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=810010

--- Comment #24 from Fedora Update System  ---
genders-1.18-6.el6 has been pushed to the Fedora EPEL 6 stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 810010] Review Request: genders - file based database for cluster managment

2012-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=810010

--- Comment #23 from Fedora Update System  ---
genders-1.18-6.fc16 has been pushed to the Fedora 16 stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 810010] Review Request: genders - file based database for cluster managment

2012-07-24 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=810010

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2012-07-24 19:30:09

--- Comment #22 from Fedora Update System  ---
genders-1.18-6.fc17 has been pushed to the Fedora 17 stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 810010] Review Request: genders - file based database for cluster managment

2012-07-19 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=810010

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

--- Comment #21 from Fedora Update System  ---
genders-1.18-6.fc17 has been pushed to the Fedora 17 testing repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 810010] Review Request: genders - file based database for cluster managment

2012-07-16 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=810010

--- Comment #19 from Fedora Update System  ---
genders-1.18-6.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/genders-1.18-6.el5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 810010] Review Request: genders - file based database for cluster managment

2012-07-16 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=810010

--- Comment #18 from Fedora Update System  ---
genders-1.18-6.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/genders-1.18-6.el6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 810010] Review Request: genders - file based database for cluster managment

2012-07-16 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=810010

--- Comment #20 from Fedora Update System  ---
genders-1.18-6.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/genders-1.18-6.fc16

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 810010] Review Request: genders - file based database for cluster managment

2012-07-16 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=810010

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 810010] Review Request: genders - file based database for cluster managment

2012-07-16 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=810010

--- Comment #17 from Fedora Update System  ---
genders-1.18-6.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/genders-1.18-6.fc17

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 810010] Review Request: genders - file based database for cluster managment

2012-07-10 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=810010

--- Comment #16 from Kevin Fenzi  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 810010] Review Request: genders - file based database for cluster managment

2012-07-09 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=810010

Thomas Spura  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|toms...@fedoraproject.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 810010] Review Request: genders - file based database for cluster managment

2012-07-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=810010

David Brown  changed:

   What|Removed |Added

  Flags||fedora-cvs?

--- Comment #15 from David Brown  ---
New Package SCM Request
===
Package Name: genders
Short Description: File based database for cluster management
Owners: dmlb2000
Branches: f16 f17 el5 el6
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 810010] Review Request: genders - file based database for cluster managment

2012-07-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=810010

Thomas Spura  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |
   Assignee|toms...@fedoraproject.org   |nob...@fedoraproject.org
  Flags|fedora-review?  |fedora-review+

--- Comment #14 from Thomas Spura  ---
Please also link to the spec, as that's easier to look/download than the srpm.

The package looks fine:
- koji works:
  http://koji.fedoraproject.org/koji/taskinfo?taskID=4225804

I'll sponsor you to the packager group and this is now:

###

APPROVED

###

Next steps are:
* SCM admin request:
  https://fedoraproject.org/wiki/Package_SCM_admin_requests

* Importing into git:
  https://fedoraproject.org/wiki/Using_Fedora_GIT

###

Looks like there will be a problem with your mail address:
- Your bugzilla address is @pnl.gov
- Your FAS  address is @pnnl.gov

but they both MUST match or you won't have proper bugzilla power.

Please change one of those addresses accordingly.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 810010] Review Request: genders - file based database for cluster managment

2012-07-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=810010

--- Comment #13 from David Brown  ---
I noticed that mock for some reason on my systems chose to make the python
shared object 775 instead of 755 so I added a chmod in install.

http://dmlb2000.homelinux.org/packages/genders-1.18-5.fc17.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 810010] Review Request: genders - file based database for cluster managment

2012-07-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=810010

--- Comment #12 from David Brown  ---
I think I've seen this build failure before. I'm wondering if the automake
isn't exactly working in parallel correctly. I've removed the parallel build
for now since that seemed to work on my system.

I moved the compat stuff back into /usr/lib/genders and added the noarch stuff
(I think) to the compat package as well.

http://dmlb2000.homelinux.org/packages/genders-1.18-4.fc17.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 810010] Review Request: genders - file based database for cluster managment

2012-07-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=810010

Thomas Spura  changed:

   What|Removed |Added

  Flags||fedora-review?

--- Comment #11 from Thomas Spura  ---
Sorry, this totally fell of my radar... A ping would have been nice :)

REVIEW:

good:
- name ok
- parallel make
- %build ok
- %prep ok, nice python/perl provides scipt
- %install ok
- no *.la *.a
- ldconfig there
- rpmlint /home/tomspur/rpmbuild/SRPMS/genders-1.18-3.fc17.src.rpm
/home/tomspur/rpmbuild/RPMS/x86_64/genders-1.18-3.fc17.x86_64.rpm
/home/tomspur/rpmbuild/RPMS/x86_64/genders-compat-1.18-3.fc17.x86_64.rpm
/home/tomspur/rpmbuild/RPMS/x86_64/genders-perl-1.18-3.fc17.x86_64.rpm
/home/tomspur/rpmbuild/RPMS/x86_64/genders-python-1.18-3.fc17.x86_64.rpm
/home/tomspur/rpmbuild/RPMS/x86_64/libgenders-1.18-3.fc17.x86_64.rpm
/home/tomspur/rpmbuild/RPMS/x86_64/libgenders-devel-1.18-3.fc17.x86_64.rpm
/home/tomspur/rpmbuild/RPMS/x86_64/libgendersplusplus-1.18-3.fc17.x86_64.rpm
/home/tomspur/rpmbuild/RPMS/x86_64/libgendersplusplus-devel-1.18-3.fc17.x86_64.rpm
/home/tomspur/rpmbuild/RPMS/x86_64/genders-debuginfo-1.18-3.fc17.x86_64.rpm
genders.src: I: enchant-dictionary-not-found en_US
genders.src:113: W: rpm-buildroot-usage %build
--with-extension-destdir="%{buildroot}"
genders.src:128: E: hardcoded-library-path in %{_prefix}/lib/genders
genders.src:201: W: macro-in-%changelog %{buildroot}
libgenders.x86_64: W: shared-lib-calls-exit /usr/lib64/libgenders.so.0.3.0
exit@GLIBC_2.2.5
10 packages and 0 specfiles checked; 1 errors, 3 warnings.

Some bad things among them, but they must be, see above... :(

- CFLAGS respected

comments:
- Each library has it's own package, which is a bit too much. But your choice
:)
- Each package MUST have a license file, which means, it's fine, when a package
Requires an other *%{name}* package, which has a license file.
  But it's fine this way too.

NEEDSWORK:
- Why do you: ?
  mv %{buildroot}/%{_prefix}/lib/genders %{buildroot}/%{_libexecdir}/

  %{_prefix}/lib/genders is unfortunately the best, see comment #7.
- After that, please make the compat package noarch on EL6+ and Fedora. This
way, it's verified on each build, that those packages have the same content on
each arches, so multilib install is possible.

- It looks like 32bit has some problems. Logs over here:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4221409

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 810010] Review Request: genders - file based database for cluster managment

2012-04-13 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=810010

--- Comment #10 from Thomas Spura  2012-04-13 
06:42:11 EDT ---
(In reply to comment #8)
> And I'll have to submit more packages of better quality then ;).

Fine. The easiest way is still to do reviews of other packages, which is
basically what you did in bug #812161, just a bit more verbosely.
Some have a checklist:
http://fedoraproject.org/wiki/User:Jlaska/Package_Review_Checklist
but writing a list what you checked (and what remains as blocker in the review)
manually is fine either.

Submitting more packages is usually more work ;)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 810010] Review Request: genders - file based database for cluster managment

2012-04-12 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=810010

--- Comment #9 from David Brown  2012-04-12 18:16:13 EDT 
---
I was also able to get this to build on el5 and el6 as well.

http://dmlb2000.homelinux.org/packages/genders-1.18-3.el5.centos.src.rpm
http://dmlb2000.homelinux.org/packages/genders-1.18-3.el6.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 810010] Review Request: genders - file based database for cluster managment

2012-04-12 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=810010

--- Comment #8 from David Brown  2012-04-12 17:46:04 EDT 
---
I've updated the genders.spec from the original link and added the groups for
epel 5/6 builds.

http://dmlb2000.homelinux.org/packages/genders-1.18-3.fc18.src.rpm

And I'll have to submit more packages of better quality then ;).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 810010] Review Request: genders - file based database for cluster managment

2012-04-12 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=810010

--- Comment #7 from Thomas Spura  2012-04-12 
08:00:51 EDT ---
(In reply to comment #6)
> Updated the URLs above with the changes recommended. I also checked out EPEL
> and that seems to work as well.

Great, looks much better now :)
(A newline between every changelog and it would be fabulous :))

>  1. Apparently libgenders.so.0.3.0 calls exit(). This in case flex can't parse
> the primary genders config file. So I don't blame them for this since the
> entire library is useless in the condition the config file is wrong.

It would be best to report that upstream and suggesting the same like "rpmlint
-I":
"""
It is preferred for the library to return an actual error code and let the
calling program decide how to handle the situation.
"""

>  2. There's a hardcoded library path in the spec %{_prefix}/lib/genders. This
> is where the compat libraries live. The automake also has this same hard coded
> library path and the files put there are old perl scripts. So I'm open for
> suggestions on what the 'right' thing to do is with these files. Could go out
> in %{_datadir}/%{name}?

arch dependent files need to be in %{_libdir}/%{name}, but these are perl
files, so %{_datadir}/%{name} would be correct from packaging point of view.

BUT: It would be best to patch that directly and send it upstream and while
looking at this, I found this in genders-1.18/compat/Makefile.am:
"""
# Don't use ${libdir}, the /lib is a legacy path that must be maintained
gendlibdir = ${prefix}/lib/genders
"""

So it would be best, to just leave it in %{_prefix}/lib/genders as that is the
forced path by upstream...

>  3. EPEL build keeps complaining about having an unspecified group. However,
> its not needed when I build it on Fedora. Should I care that much?

I'd add the group "Development/Tools" for any non-lib package and to the
libraries "Development/Libraries". Tools, because it's a helper tool for
cluster administrators and I consider a cluster always as a kind of development
going on.

> Also to the initial review I don't have any 'informal reviews' not sure what
> they'd be and where I'd get a link for them.

Once you are sponsored to the packager group you can do reviews like explained
here:
http://fedoraproject.org/wiki/Package_Review_Process#Reviewer

But to get sponsored, we need to see, that you are familiar with the
guidelines. Here you have 2 possibilities:

* Put several packages for review
* Do 'informal reviews', that means, you can make comments to and improve other
pending reviews (preferably one that doesn't require a sponsor, because I'll
look to the review after you and can so directly approve it without needing to
sponsoring someone immediately).

Once you are sponsored to the packager group, you can directly approve other
reviews yourself.

More information about that is here:
http://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group

Feel free to ask, when you have further questions.
(Here or via mail)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 810010] Review Request: genders - file based database for cluster managment

2012-04-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=810010

--- Comment #6 from David Brown  2012-04-11 17:56:31 EDT 
---
Updated the URLs above with the changes recommended. I also checked out EPEL
and that seems to work as well.

http://dmlb2000.homelinux.org/packages/genders-1.18-2.fc18.src.rpm

There's three issues rpmlint still seems to show up with. 

 1. Apparently libgenders.so.0.3.0 calls exit(). This in case flex can't parse
the primary genders config file. So I don't blame them for this since the
entire library is useless in the condition the config file is wrong.

 2. There's a hardcoded library path in the spec %{_prefix}/lib/genders. This
is where the compat libraries live. The automake also has this same hard coded
library path and the files put there are old perl scripts. So I'm open for
suggestions on what the 'right' thing to do is with these files. Could go out
in %{_datadir}/%{name}?

 3. EPEL build keeps complaining about having an unspecified group. However,
its not needed when I build it on Fedora. Should I care that much?

Also to the initial review I don't have any 'informal reviews' not sure what
they'd be and where I'd get a link for them.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 810010] Review Request: genders - file based database for cluster managment

2012-04-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=810010

Tom "spot" Callaway  changed:

   What|Removed |Added

 CC||tcall...@redhat.com

--- Comment #5 from Tom "spot" Callaway  2012-04-11 
16:38:38 EDT ---
Just some drive-by comments:

* Your BuildRoot value is invalid, please see:
https://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#BuildRoot_tag

* The "." on its own line in each %description is unnecessary, please omit.

* When doing explicit Requires, you should be doing it differently, see:
https://fedoraproject.org/wiki/Packaging/Guidelines#Requires

As an example, you currently have:

Requires: libgenders-devel = %{version}, libgendersplusplus = %{version}

This should be:

Requires: libgenders-devel%{?_isa} = %{version}-%{release}
Requires: libgendersplusplus%{?_isa} = %{version}-%{release}

(splitting it across two lines is not required, i just did that for legibility)

* You are mixing macros, specifically, "$RPM_BUILD_ROOT" and "%{buildroot}".
You need to choose one and use it consistently. I strongly recommend using
"%{buildroot}".

* Your %defattr lines should be "%defattr(-,root,root,-)"

* To filter out those provides, see:
https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering

* When you make changes, please increment Release and add a new entry to the
%changelog, so we can see the progress over time. :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 810010] Review Request: genders - file based database for cluster managment

2012-04-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=810010

--- Comment #4 from David Brown  2012-04-09 17:52:14 EDT 
---
I've updated the genders.spec and src.rpm to remove the rhel checks entirely
and now it builds fine on RHEL with EPEL and rpmlint shows more warnings about
groups not specified.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 810010] Review Request: genders - file based database for cluster managment

2012-04-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=810010

--- Comment #3 from David Brown  2012-04-09 11:44:10 EDT 
---
Okay updated the genders.spec and src.rpm in the links above to include some of
the fixes. The command rpmlint shows no errors and only a couple of warnings.

I'm not sure how to ignore the autogenerated libfoo.so provides for the python
and perl packages.

Thanks for checking out the package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 810010] Review Request: genders - file based database for cluster managment

2012-04-07 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=810010

Thomas Spura  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||toms...@fedoraproject.org
 AssignedTo|nob...@fedoraproject.org|toms...@fedoraproject.org

--- Comment #2 from Thomas Spura  2012-04-07 
19:27:58 EDT ---
For more information on how to get sponsored see:
http://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group

Did you already do some informal reviews? Could you link them here, please?

The general guidelines are at:
http://fedoraproject.org/wiki/Packaging:Guidelines

As you are using python and perl, this also applies:
http://fedoraproject.org/wiki/Packaging:Python
http://fedoraproject.org/wiki/Packaging:Perl

First iteration of blocker issues:
- use a full url, that is wget'able:
  http://fedoraproject.org/wiki/Packaging:SourceURL
- Please include the manpage as genders.3.* and not as genders.3.gz, so the
compression format can change at any time
- *.la should be removed, whenever possible...
- When you really want to package the static libraries, they need to have it's
own -static package. In corner cases -static and -devel is the same package,
but only, when there are no shared libraries included:
  http://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries
- Please use parallel make:
  http://fedoraproject.org/wiki/Packaging:Guidelines#Parallel_make
- Be more specific in python %files and use %{python_sitearch}, e.g.
  %{python_sitearch}/%{name}.py*
  %{python_sitearch}/lib%{name}.so
  %{python_sitearch}/lib%{name}-*egg-info
- Always add a changelog entry to the footer and bump the release when you do
changes (and describe them in the changelog entry)

- Further rpmlint issues:

$ rpmlint /home/tom/rpmbuild/SRPMS/genders-1.18-1.fc16.src.rpm
/home/tom/rpmbuild/RPMS/x86_64/genders-1.18-1.fc16.x86_64.rpm
/home/tom/rpmbuild/RPMS/x86_64/genders-compat-1.18-1.fc16.x86_64.rpm
/home/tom/rpmbuild/RPMS/x86_64/genders-perl-1.18-1.fc16.x86_64.rpm
/home/tom/rpmbuild/RPMS/x86_64/genders-python-1.18-1.fc16.x86_64.rpm
/home/tom/rpmbuild/RPMS/x86_64/libgenders-1.18-1.fc16.x86_64.rpm
/home/tom/rpmbuild/RPMS/x86_64/libgenders-devel-1.18-1.fc16.x86_64.rpm
/home/tom/rpmbuild/RPMS/x86_64/libgendersplusplus-1.18-1.fc16.x86_64.rpm
/home/tom/rpmbuild/RPMS/x86_64/libgendersplusplus-devel-1.18-1.fc16.x86_64.rpm
/home/tom/rpmbuild/RPMS/x86_64/genders-debuginfo-1.18-1.fc16.x86_64.rpm
genders.src: W: summary-ended-with-dot C Static cluster configuration database.
genders.src: E: no-changelogname-tag
genders.src: W: invalid-license GPL
genders.src:78: W: rpm-buildroot-usage %build
--with-extension-destdir="$RPM_BUILD_ROOT"
genders.src:129: E: hardcoded-library-path in %{_prefix}/lib/genders/*
genders.src: W: invalid-url Source0: genders-1.18.tar.gz
genders.x86_64: W: summary-ended-with-dot C Static cluster configuration
database.
genders.x86_64: E: no-changelogname-tag
genders.x86_64: W: invalid-license GPL
genders-compat.x86_64: W: spelling-error Summary(en_US) compatability ->
comparability, compatibility, communicability
genders-compat.x86_64: W: summary-not-capitalized C compatability library
genders-compat.x86_64: E: no-changelogname-tag
genders-compat.x86_64: W: invalid-license GPL
genders-compat.x86_64: W: only-non-binary-in-usr-lib
genders-compat.x86_64: E: script-without-shebang /usr/lib/genders/hostlist.pl
genders-compat.x86_64: E: script-without-shebang /usr/lib/genders/gendlib.pl
genders-perl.x86_64: W: summary-not-capitalized C perl libraries
genders-perl.x86_64: E: no-changelogname-tag
genders-perl.x86_64: W: invalid-license GPL
genders-perl.x86_64: W: private-shared-object-provides
/usr/lib64/perl5/vendor_perl/auto/Libgenders/Libgenders.so
Libgenders.so()(64bit)
genders-perl.x86_64: W: private-shared-object-provides
/usr/lib64/perl5/vendor_perl/auto/Libgenders/Libgenders.so
Libgenders.so()(64bit)
genders-perl.x86_64: E: zero-length
/usr/lib64/perl5/vendor_perl/auto/Libgenders/Libgenders.bs
genders-perl.x86_64: W: hidden-file-or-dir
/usr/lib64/perl5/vendor_perl/auto/Libgenders/.packlist
genders-perl.x86_64: W: perl-temp-file
/usr/lib64/perl5/vendor_perl/auto/Libgenders/.packlist
genders-perl.x86_64: E: non-standard-executable-perm
/usr/lib64/perl5/vendor_perl/auto/Libgenders/Libgenders.so 0555L
genders-python.x86_64: W: summary-not-capitalized C python libraries
genders-python.x86_64: E: no-changelogname-tag
genders-python.x86_64: W: invalid-license GPL
genders-python.x86_64: W: private-shared-object-provides
/usr/lib64/python2.7/site-packages/libgenders.so libgenders.so()(64bit)
genders-python.x86_64: W: no-documentation
libgenders.x86_64: W: summary-not-capitalized C genders libraries
libgender

[Bug 810010] Review Request: genders - file based database for cluster managment

2012-04-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=810010

David Brown  changed:

   What|Removed |Added

 Blocks||177841(FE-NEEDSPONSOR)

--- Comment #1 from David Brown  2012-04-04 18:51:50 EDT 
---
Oh, by the way this is a new package for me so I'll be needing a sponsor for
this one.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 810010] Review Request: genders - file based database for cluster managment

2012-04-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=810010

David Brown  changed:

   What|Removed |Added

 Blocks||810019

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review