[Bug 810335] Review Request: python-fabulous - Makes your terminal output totally fabulous
https://bugzilla.redhat.com/show_bug.cgi?id=810335 --- Comment #16 from Fedora Update System --- python-fabulous-0.1.5-4.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810335] Review Request: python-fabulous - Makes your terminal output totally fabulous
https://bugzilla.redhat.com/show_bug.cgi?id=810335 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2012-05-22 11:42:05 --- Comment #15 from Fedora Update System --- python-fabulous-0.1.5-4.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810335] Review Request: python-fabulous - Makes your terminal output totally fabulous
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810335 Ralph Bean changed: What|Removed |Added Blocks||818293 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810335] Review Request: python-fabulous - Makes your terminal output totally fabulous
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810335 Ralph Bean changed: What|Removed |Added Blocks||818297 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810335] Review Request: python-fabulous - Makes your terminal output totally fabulous
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810335 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #14 from Fedora Update System 2012-04-26 15:26:58 EDT --- python-fabulous-0.1.5-4.fc17 has been pushed to the Fedora 17 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810335] Review Request: python-fabulous - Makes your terminal output totally fabulous
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810335 --- Comment #13 from Fedora Update System 2012-04-25 16:45:50 EDT --- python-fabulous-0.1.5-4.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-fabulous-0.1.5-4.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810335] Review Request: python-fabulous - Makes your terminal output totally fabulous
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810335 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810335] Review Request: python-fabulous - Makes your terminal output totally fabulous
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810335 --- Comment #12 from Fedora Update System 2012-04-25 16:29:59 EDT --- python-fabulous-0.1.5-4.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/python-fabulous-0.1.5-4.fc17 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810335] Review Request: python-fabulous - Makes your terminal output totally fabulous
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810335 --- Comment #11 from Jon Ciesla 2012-04-25 08:43:35 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810335] Review Request: python-fabulous - Makes your terminal output totally fabulous
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810335 Ralph Bean changed: What|Removed |Added Flag||fedora-cvs? --- Comment #10 from Ralph Bean 2012-04-24 23:43:32 EDT --- New Package SCM Request === Package Name: python-fabulous Short Description: Makes your terminal output totally fabulous Owners: ralph Branches: f17 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810335] Review Request: python-fabulous - Makes your terminal output totally fabulous
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810335 Ian Weller changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #9 from Ian Weller 2012-04-24 23:19:11 EDT --- Looks good to me. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810335] Review Request: python-fabulous - Makes your terminal output totally fabulous
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810335 --- Comment #8 from Ralph Bean 2012-04-22 22:35:30 EDT --- And yet another revision. Got the sphinx docs to build correctly with judicious use of PYTHONPATH. Spec URL: http://threebean.org/rpm/python-fabulous.spec SRPM URL: http://threebean.org/rpm/python-fabulous-0.1.5-4.fc17.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810335] Review Request: python-fabulous - Makes your terminal output totally fabulous
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810335 --- Comment #7 from Ralph Bean 2012-04-22 22:29:44 EDT --- (In reply to comment #6) > There's no requirement for doing so, but you might consider building the > Sphinx > documentation and putting it in %doc. (Then again, it's just a bunch of > autodoc > declarations, so it's the same thing you'd get with pydoc on the command line. > Your choice, really, if you think the HTML documentation is useful.) I took a stab at it but had some trouble getting it to work with "make -C docs html". It doesn't seem to be straightforward so I'm skipping it for now. > python-fabulous.src: W: file-size-mismatch fabulous-0.1.5.tar.gz = 322526, > http://lobstertech.com/media/file/fabulous/fabulous-0.1.5.tar.gz = 322052 > python-fabulous.noarch: W: wrong-file-end-of-line-encoding > /usr/share/doc/python-fabulous-0.1.5/README > python-fabulous.noarch: W: devel-file-in-non-devel-package > /usr/lib/python2.7/site-packages/fabulous/_xterm256.c > > Looks like upstream changed their source archive (blegh). Run dos2unix on > README and that should fix the end of line problem. You can also just nuke > _xterm256.c, it doesn't look like it's used at all and was just used as a > reference for xterm256.py. I put up a new revision that should fix those three: Spec URL: http://threebean.org/rpm/python-fabulous.spec SRPM URL: http://threebean.org/rpm/python-fabulous-0.1.5-3.fc17.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810335] Review Request: python-fabulous - Makes your terminal output totally fabulous
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810335 --- Comment #6 from Ian Weller 2012-04-22 22:06:28 EDT --- There's no requirement for doing so, but you might consider building the Sphinx documentation and putting it in %doc. (Then again, it's just a bunch of autodoc declarations, so it's the same thing you'd get with pydoc on the command line. Your choice, really, if you think the HTML documentation is useful.) rpmlint barfs: python-fabulous.src: W: file-size-mismatch fabulous-0.1.5.tar.gz = 322526, http://lobstertech.com/media/file/fabulous/fabulous-0.1.5.tar.gz = 322052 python-fabulous.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-fabulous-0.1.5/README python-fabulous.noarch: W: devel-file-in-non-devel-package /usr/lib/python2.7/site-packages/fabulous/_xterm256.c Looks like upstream changed their source archive (blegh). Run dos2unix on README and that should fix the end of line problem. You can also just nuke _xterm256.c, it doesn't look like it's used at all and was just used as a reference for xterm256.py. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810335] Review Request: python-fabulous - Makes your terminal output totally fabulous
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810335 --- Comment #4 from Ralph Bean 2012-04-22 21:19:08 EDT --- (In reply to comment #3) > If Ralph plans to build this for EPEL 5 or lower he will need to have the > sitelib definition. No plans to build for EPEL 5. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810335] Review Request: python-fabulous - Makes your terminal output totally fabulous
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810335 --- Comment #5 from Ralph Bean 2012-04-22 21:21:22 EDT --- Here is a second revision: Spec URL: http://threebean.org/rpm/python-fabulous.spec SRPM URL: http://threebean.org/rpm/python-fabulous-0.1.5-2.fc17.src.rpm - Patched out the bundled fonts. - Included COPYING and README in the %doc - Started using the modname macro at Germán Racca's suggestion. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810335] Review Request: python-fabulous - Makes your terminal output totally fabulous
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810335 --- Comment #3 from Ian Weller 2012-04-20 14:35:12 EDT --- (In reply to comment #2) > 2) I also don't see the definition of sitelib for noarch packages at the top > of > the spec file, as indicated in the template > /etc/rpmdevtools/spectemplate-python.spec. Is it not needed anymore? For all non-EOL releases of Fedora and EPEL 6, it is no longer needed. https://fedoraproject.org/wiki/Packaging:Python#Macros If Ralph plans to build this for EPEL 5 or lower he will need to have the sitelib definition. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810335] Review Request: python-fabulous - Makes your terminal output totally fabulous
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810335 Germán Racca changed: What|Removed |Added CC||gra...@gmail.com --- Comment #2 from Germán Racca 2012-04-20 10:29:25 EDT --- Hi Ralph, just some quick comments: 1) Why you don't use macros in the spec file? Instead of writing: Source0: http://lobstertech.com/media/file/fabulous/fabulous-0.1.5.tar.gz you should use: Source0: http://lobstertech.com/media/file/%{modname}/%{modname}-%{version}.tar.gz so you don't need to update this line every time you bump the sepc file and avoid compiling an old source by mistake. 2) I also don't see the definition of sitelib for noarch packages at the top of the spec file, as indicated in the template /etc/rpmdevtools/spectemplate-python.spec. Is it not needed anymore? HTH, Germán. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 810335] Review Request: python-fabulous - Makes your terminal output totally fabulous
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810335 --- Comment #1 from Ian Weller 2012-04-19 19:25:37 EDT --- Review checklist, last updated 2012-02-07 Based on https://fedoraproject.org/wiki/Packaging:ReviewGuidelines Key: [X] passed, [F] failed, [-] irrelevant [X] MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review. python-fabulous.noarch: W: no-documentation python-fabulous.noarch: W: devel-file-in-non-devel-package /usr/lib/python2.7/site-packages/fabulous/_xterm256.c You might consider including README in %doc as well as building the Sphinx documentation and including that in %doc. [X] MUST: The package must be named according to the Package Naming Guidelines. [X] MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. [X] MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. [X] MUST: The License field in the package spec file must match the actual license. [F] MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. The source tarball contains a COPYING file. [X] MUST: The spec file must be written in American English. [X] MUST: The spec file for the package MUST be legible. [X] MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. [X] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. [-] MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line. [X] MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines; inclusion of those as BuildRequires is optional. Apply common sense. [-] MUST: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden. [-] MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. [F] MUST: Packages must NOT bundle copies of system libraries. Not exactly a system library, but this package bundles font files, which is not okay. See: https://fedoraproject.org/wiki/Packaging:Guidelines#Avoid_bundling_of_fonts_in_other_packages [-] MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker. [X] MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. [X] MUST: A Fedora package must not list a file more than once in the spec file's %files listings. (Notable exception: license texts in specific situations) [X] MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. [X] MUST: Each package must consistently use macros. [X] MUST: The package must contain code, or permissable content. [-] MUST: Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity). [-] MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. [-] MUST: Static libraries must be in a -static package. [-] MUST: Development files must be in a -devel package. [-] MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name}%{?_isa} = %{version}-%{release} [-] MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built. [-] MUST: Packages containing GUI applications must include a %
[Bug 810335] Review Request: python-fabulous - Makes your terminal output totally fabulous
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=810335 Ian Weller changed: What|Removed |Added Status|NEW |ASSIGNED CC||i...@ianweller.org AssignedTo|nob...@fedoraproject.org|i...@ianweller.org Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review