[Bug 811782] Review Request: python-tw2-sqla - SQLAlchemy database layer for ToscaWidgets2
https://bugzilla.redhat.com/show_bug.cgi?id=811782 Ralph Bean rb...@redhat.com changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #12 from Ralph Bean rb...@redhat.com --- Package Change Request == Package Name: python-tw2-sqla New Branches: epel7 Owners: ralph InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 811782] Review Request: python-tw2-sqla - SQLAlchemy database layer for ToscaWidgets2
https://bugzilla.redhat.com/show_bug.cgi?id=811782 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 811782] Review Request: python-tw2-sqla - SQLAlchemy database layer for ToscaWidgets2
https://bugzilla.redhat.com/show_bug.cgi?id=811782 --- Comment #13 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 811782] Review Request: python-tw2-sqla - SQLAlchemy database layer for ToscaWidgets2
https://bugzilla.redhat.com/show_bug.cgi?id=811782 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- python-tw2-sqla-2.0.1-3.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 811782] Review Request: python-tw2-sqla - SQLAlchemy database layer for ToscaWidgets2
https://bugzilla.redhat.com/show_bug.cgi?id=811782 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2012-05-22 11:40:40 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- python-tw2-sqla-2.0.1-3.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 811782] Review Request: python-tw2-sqla - SQLAlchemy database layer for ToscaWidgets2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=811782 Ralph Bean rb...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #5 from Ralph Bean rb...@redhat.com 2012-05-04 11:04:57 EDT --- New Package SCM Request === Package Name: python-tw2-sqla Short Description: SQLAlchemy database layer for ToscaWidgets2 Owners: ralph Branches: f17 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 811782] Review Request: python-tw2-sqla - SQLAlchemy database layer for ToscaWidgets2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=811782 --- Comment #6 from Jon Ciesla limburg...@gmail.com 2012-05-04 11:30:13 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 811782] Review Request: python-tw2-sqla - SQLAlchemy database layer for ToscaWidgets2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=811782 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 811782] Review Request: python-tw2-sqla - SQLAlchemy database layer for ToscaWidgets2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=811782 --- Comment #7 from Fedora Update System upda...@fedoraproject.org 2012-05-04 14:01:42 EDT --- python-tw2-sqla-2.0.1-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/python-tw2-sqla-2.0.1-3.fc17 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 811782] Review Request: python-tw2-sqla - SQLAlchemy database layer for ToscaWidgets2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=811782 --- Comment #8 from Fedora Update System upda...@fedoraproject.org 2012-05-04 14:11:20 EDT --- python-tw2-sqla-2.0.1-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-tw2-sqla-2.0.1-3.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 811782] Review Request: python-tw2-sqla - SQLAlchemy database layer for ToscaWidgets2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=811782 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System upda...@fedoraproject.org 2012-05-04 18:15:58 EDT --- python-tw2-sqla-2.0.1-3.fc17 has been pushed to the Fedora 17 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 811782] Review Request: python-tw2-sqla - SQLAlchemy database layer for ToscaWidgets2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=811782 Ralph Bean rb...@redhat.com changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 811782] Review Request: python-tw2-sqla - SQLAlchemy database layer for ToscaWidgets2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=811782 Ralph Bean rb...@redhat.com changed: What|Removed |Added Flag|fedora-review? | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 811782] Review Request: python-tw2-sqla - SQLAlchemy database layer for ToscaWidgets2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=811782 Jerry James loganje...@gmail.com changed: What|Removed |Added CC||loganje...@gmail.com AssignedTo|nob...@fedoraproject.org|loganje...@gmail.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 811782] Review Request: python-tw2-sqla - SQLAlchemy database layer for ToscaWidgets2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=811782 Ralph Bean rb...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 811782] Review Request: python-tw2-sqla - SQLAlchemy database layer for ToscaWidgets2
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=811782
--- Comment #2 from Jerry James loganje...@gmail.com 2012-05-03 15:36:47 EDT
---
This package has the same directory ownership issue as python-tw2-dynforms, but
is otherwise in good shape.
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
Generic
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
[x]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
names).
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[!]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint output is silent.
rpmlint python-tw2-sqla-2.0.1-1.fc18.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
rpmlint python-tw2-sqla-2.0.1-1.fc18.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
/home/jamesjer/811782/tw2.sqla-2.0.1.tar.gz :
MD5SUM this package : 68c83611b466f43df68040b9c4bd7e5b
MD5SUM upstream package : 68c83611b466f43df68040b9c4bd7e5b
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[-]: MUST Useful -debuginfo package or justification otherwise.
[x]: SHOULD Reviewer should test that the package builds in mock.
[-]: SHOULD If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to
include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[x]: SHOULD Package functions as described.
[x]: SHOULD Latest version is packaged.
[x]: SHOULD Package does not include license text files separate from
upstream.
[x]: SHOULD SourceX is a working URL.
[-]: SHOULD Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: SHOULD Package should compile and build into binary rpms on all supported
architectures.
[x]: SHOULD %check is present and all tests pass.
[x]: SHOULD Packages should try to preserve timestamps of original installed
files.
[x]: SHOULD Spec use %global instead of %define.
Generated by fedora-review 0.1.3
External plugins:
--
Configure bugmail:
[Bug 811782] Review Request: python-tw2-sqla - SQLAlchemy database layer for ToscaWidgets2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=811782 --- Comment #3 from Ralph Bean rb...@redhat.com 2012-05-03 18:34:58 EDT --- New release which hopefully fixes the directory ownership issue pointed out by the reviewer. Spec URL: http://threebean.org/rpm/python-tw2-sqla.spec SRPM URL: http://threebean.org/rpm/python-tw2-sqla-2.0.1-2.fc17.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 811782] Review Request: python-tw2-sqla - SQLAlchemy database layer for ToscaWidgets2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=811782 Jerry James loganje...@gmail.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #4 from Jerry James loganje...@gmail.com 2012-05-03 18:47:05 EDT --- Looks good. This package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 811782] Review Request: python-tw2-sqla - SQLAlchemy database layer for ToscaWidgets2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=811782 Ralph Bean rb...@redhat.com changed: What|Removed |Added Blocks||818293 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 811782] Review Request: python-tw2-sqla - SQLAlchemy database layer for ToscaWidgets2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=811782 --- Comment #1 from Ralph Bean rb...@redhat.com 2012-05-02 19:06:56 EDT --- Upstream version bump to include LICENSE file. Spec URL: http://threebean.org/rpm/python-tw2-sqla.spec SRPM URL: http://threebean.org/rpm/python-tw2-sqla-2.0.1-1.fc17.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 811782] Review Request: python-tw2-sqla - SQLAlchemy database layer for ToscaWidgets2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=811782 Ralph Bean rb...@redhat.com changed: What|Removed |Added Blocks||812030 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 811782] Review Request: python-tw2-sqla - SQLAlchemy database layer for ToscaWidgets2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=811782 Ralph Bean rb...@redhat.com changed: What|Removed |Added Depends on||811769 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
