[Bug 812137] Review Request: polyclipping - Polygon clipping library
https://bugzilla.redhat.com/show_bug.cgi?id=812137 --- Comment #16 from Miro Hrončok mhron...@redhat.com --- From the history of Clipper API changes I'd say it will change rapidly in the future as well and maintaining it in EPEL7 will be pain. So I'm definitely not doing it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 812137] Review Request: polyclipping - Polygon clipping library
https://bugzilla.redhat.com/show_bug.cgi?id=812137 --- Comment #17 from Orion Poplawski or...@cora.nwra.com --- Thanks for the explanation. That sounds like a good reason to exclude it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 812137] Review Request: polyclipping - Polygon clipping library
https://bugzilla.redhat.com/show_bug.cgi?id=812137 Orion Poplawski or...@cora.nwra.com changed: What|Removed |Added CC||or...@cora.nwra.com --- Comment #15 from Orion Poplawski or...@cora.nwra.com --- Miro/Volker - Would you mind maintaining this in EPEL7? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 812137] Review Request: polyclipping - Polygon clipping library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=812137 Miro Hrončok mhron...@redhat.com changed: What|Removed |Added CC||mhron...@redhat.com --- Comment #12 from Miro Hrončok mhron...@redhat.com --- Package Change Request == Package Name: polyclipping Branches: f16 f17 f18 Owners: InitialCC: churchyard Please add churchyard with watch* permissions only to all Fedora branches. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=n438xlhhpVa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 812137] Review Request: polyclipping - Polygon clipping library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=812137 --- Comment #13 from Volker Fröhlich volke...@gmx.at --- You don't need a change request to achieve that. Just use this form to reach the desired privileges: https://admin.fedoraproject.org/pkgdb/acls/name/polyclipping -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dkbSLBUCRea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 812137] Review Request: polyclipping - Polygon clipping library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=812137 --- Comment #14 from Miro Hrončok mhron...@redhat.com --- Thanks. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8rBVFZblpYa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 812137] Review Request: polyclipping - Polygon clipping library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=812137 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||polyclipping-4.7.6-2.fc16 Resolution||ERRATA Last Closed||2012-05-04 16:29:49 --- Comment #10 from Fedora Update System upda...@fedoraproject.org 2012-05-04 16:29:49 EDT --- polyclipping-4.7.6-2.fc16 has been pushed to the Fedora 16 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 812137] Review Request: polyclipping - Polygon clipping library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=812137 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|polyclipping-4.7.6-2.fc16 |polyclipping-4.7.6-2.fc17 --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2012-05-04 18:56:20 EDT --- polyclipping-4.7.6-2.fc17 has been pushed to the Fedora 17 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 812137] Review Request: polyclipping - Polygon clipping library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=812137 --- Comment #6 from Jon Ciesla limburg...@gmail.com 2012-04-26 08:07:14 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 812137] Review Request: polyclipping - Polygon clipping library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=812137 --- Comment #7 from Fedora Update System upda...@fedoraproject.org 2012-04-26 09:08:38 EDT --- polyclipping-4.7.6-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/polyclipping-4.7.6-2.fc17 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 812137] Review Request: polyclipping - Polygon clipping library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=812137 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 812137] Review Request: polyclipping - Polygon clipping library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=812137 --- Comment #8 from Fedora Update System upda...@fedoraproject.org 2012-04-26 09:08:47 EDT --- polyclipping-4.7.6-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/polyclipping-4.7.6-2.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 812137] Review Request: polyclipping - Polygon clipping library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=812137 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System upda...@fedoraproject.org 2012-04-26 15:27:43 EDT --- polyclipping-4.7.6-2.fc17 has been pushed to the Fedora 17 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 812137] Review Request: polyclipping - Polygon clipping library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=812137 --- Comment #3 from Volker Fröhlich volke...@gmx.at 2012-04-25 12:36:37 EDT --- The license file is there. I suppose fedora-review didn't pick it up. Spec URL: http://www.geofrogger.net/review/polyclipping.spec SRPM URL: http://www.geofrogger.net/review/polyclipping-4.7.6-2.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 812137] Review Request: polyclipping - Polygon clipping library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=812137 Jerry James loganje...@gmail.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #4 from Jerry James loganje...@gmail.com 2012-04-25 14:45:19 EDT --- (In reply to comment #3) The license file is there. I suppose fedora-review didn't pick it up. Yes, I even saw that it was there, then forgot to change that part of the review. Sorry about that. The md5sums now match. The includedir path has been fixed. All MUST items are now okay, so this package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 812137] Review Request: polyclipping - Polygon clipping library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=812137 Volker Fröhlich volke...@gmx.at changed: What|Removed |Added Flag||fedora-cvs? --- Comment #5 from Volker Fröhlich volke...@gmx.at 2012-04-25 18:34:06 EDT --- New Package SCM Request === Package Name: polyclipping Short Description: Polygon clipping library Owners: volter Branches: f16 f17 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 812137] Review Request: polyclipping - Polygon clipping library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=812137 Jerry James loganje...@gmail.com changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|loganje...@gmail.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 812137] Review Request: polyclipping - Polygon clipping library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=812137 Jerry James loganje...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 812137] Review Request: polyclipping - Polygon clipping library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=812137 --- Comment #1 from Jerry James loganje...@gmail.com 2012-04-24 15:21:18 EDT --- I will review this package -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 812137] Review Request: polyclipping - Polygon clipping library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=812137 Jerry James loganje...@gmail.com changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 812137] Review Request: polyclipping - Polygon clipping library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=812137
--- Comment #2 from Jerry James loganje...@gmail.com 2012-04-24 15:58:13 EDT
---
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
C/C++
[x]: MUST ldconfig called in %post and %postun if required.
[x]: MUST Package does not contain any libtool archives (.la)
[x]: MUST Package does not contain kernel modules.
[x]: MUST Package contains no static executables.
[x]: MUST Rpath absent or only used for internal libs.
[x]: MUST Package is not relocatable.
[x]: MUST Development (unversioned) .so files in -devel subpackage, if
present.
Generic
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Fully versioned dependency in subpackages, if present.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
[-]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[-]: MUST License file installed when any subpackage combination is installed.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
names).
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[!]: MUST Package must own all directories that it creates.
%{_includedir}/%{name} is not owned. Either move clipper.hpp to
%{_includedir}, or changes the %files devel line to read
%{_includedir}/%{name}/.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[!]: MUST Rpmlint output is silent.
rpmlint polyclipping-debuginfo-4.7.6-1.fc18.i686.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
rpmlint polyclipping-4.7.6-1.fc18.src.rpm
polyclipping.src: W: spelling-error %description -l en_US boolean - Boolean,
boo lean, boo-lean
polyclipping.src: W: file-size-mismatch clipper_ver4.7.6.zip = 1462271,
http://downloads.sourceforge.net/polyclipping/clipper_ver4.7.6.zip = 1462266
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
rpmlint polyclipping-4.7.6-1.fc18.i686.rpm
polyclipping.i686: W: spelling-error %description -l en_US boolean - Boolean,
boo lean, boo-lean
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
rpmlint polyclipping-devel-4.7.6-1.fc18.i686.rpm
polyclipping-devel.i686: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
[!]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
/home/jamesjer/812137/clipper_ver4.7.6.zip :
MD5SUM this package : 623aea29d46b6a23d8567e26cfc33b84
MD5SUM upstream package : 70239e9a80c149cb6a8886c9e365eca4
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[x]: MUST Useful -debuginfo package or
[Bug 812137] Review Request: polyclipping - Polygon clipping library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=812137 Volker Fröhlich volke...@gmx.at changed: What|Removed |Added Blocks||737401 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
