[Bug 812587] Review Request: perl-FusionInventory-Agent-Task-Deploy - Software deployment support for FusionInventory Agent

2012-09-01 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=812587

Remi Collet fed...@famillecollet.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2012-09-01 03:02:35

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 812587] Review Request: perl-FusionInventory-Agent-Task-Deploy - Software deployment support for FusionInventory Agent

2012-05-31 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=812587

--- Comment #7 from Petr Pisar ppi...@redhat.com ---
(In reply to comment #5)
 Petr, can you please give me how to you detect BR ? Have a script or does
 (find ... | /usr/lib/rpm/perl.req) could be enough ?
 
I have no script. I just study META.yml and then grep -HnrE
'\(use|require|parent|base|ISA)\' Makefile.PL, lib, t and inc. And of course
I check the context of the used module. It can turn out that the module is just
eval-ed optional functionality or something like that.

The /usr/lib/rpm/perl.req is not perfect too. But studying it's results is also
helpful (I check the `rpm -q --requires -p' output).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 812587] Review Request: perl-FusionInventory-Agent-Task-Deploy - Software deployment support for FusionInventory Agent

2012-05-31 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=812587

Petr Pisar ppi...@redhat.com changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+

--- Comment #6 from Petr Pisar ppi...@redhat.com ---
Spec file changes:
--- perl-FusionInventory-Agent-Task-Deploy.spec.old 2012-05-29
07:05:23.025998958 -0400
+++ perl-FusionInventory-Agent-Task-Deploy.spec 2012-05-31 03:55:12.122006698
-0400
@@ -1,6 +1,6 @@
 Name:   perl-FusionInventory-Agent-Task-Deploy
 Version:2.0.0
-Release:2%{?dist}
+Release:3%{?dist}
 Summary:Software deployment support for FusionInventory Agent
 License:GPLv2+
 Group:  Development/Libraries
@@ -10,24 +10,38 @@
 BuildRoot:  %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 BuildArch:  noarch
 BuildRequires:  perl = 1:5.8.0
+BuildRequires:  perl(base)
 BuildRequires:  perl(inc::Module::Install)
 BuildRequires:  perl(Archive::Extract)
 BuildRequires:  perl(Archive::Tar)
+BuildRequires:  perl(Compress::Zlib)
+BuildRequires:  perl(Cwd)
+BuildRequires:  perl(Data::Dumper)
 BuildRequires:  perl(Digest::SHA)
+BuildRequires:  perl(Exporter)
 BuildRequires:  perl(File::Copy::Recursive)
+BuildRequires:  perl(File::Path)
+BuildRequires:  perl(File::Spec)
+BuildRequires:  perl(File::Which)
+BuildRequires:  perl(HTTP::Request)
+BuildRequires:  perl(HTTP::Request::Common)
+BuildRequires:  perl(HTTP::Server::Simple::CGI)
 BuildRequires:  perl(JSON)
+BuildRequires:  perl(LWP)
+BuildRequires:  perl(Net::IP)
+BuildRequires:  perl(POE)
 BuildRequires:  perl(POE::Component::Client::Ping)
+BuildRequires:  perl(POE::Component::Client::TCP)
 BuildRequires:  perl(Test::Compile)
 BuildRequires:  perl(Test::HTTP::Server::Simple)
+BuildRequires:  perl(Test::More)
+BuildRequires:  perl(UNIVERSAL::require)
 BuildRequires:  perl(URI::Escape)
 BuildRequires:  fusioninventory-agent = 2.2.0
-%if 0%{?fedora} = 14
-BuildRequires:  perl(HTTP::Server::Simple::Authen) perl(CGI)
-%endif

 Requires:   fusioninventory-agent = 2.2.0
-Requires:   perl(Digest::SHA)
 Requires:   perl(POE::Component::Client::Ping)
+Requires:   perl(POE::Component::Client::TCP)
 Requires:   perl(:MODULE_COMPAT_%(eval `%{__perl} -V:version`; echo
$version))

 # RPM 4.8
@@ -88,6 +102,9 @@


 %changelog
+* Wed May 30 2012 Remi Collet r...@fedoraproject.org - 2.0.0-3
+- fix BuildRequires/Requires from review #812587
+
 * Fri May 11 2012 Remi Collet r...@fedoraproject.org - 2.0.0-2
 - filter private provides/requires


 FIX: Build- and run-require `perl(POE::Component::Client::TCP)'
 (lib/FusionInventory/Agent/Task/Deploy/P2P.pm:9).
+BuildRequires:  perl(POE::Component::Client::TCP)
+Requires:   perl(POE::Component::Client::TCP)
Ok.

 FIX: Build-require `perl(File::Which)' (Makefile.PL:13).
+BuildRequires:  perl(File::Which)
Ok.

 TODO: Build-require `perl(base)' (lib/FusionInventory/Agent/Task/Deploy.pm:8).
+BuildRequires:  perl(base)
Ok.

 FIX: Build-require `perl(LWP)' (lib/FusionInventory/Agent/Task/Deploy.pm:11).
+BuildRequires:  perl(LWP)
Ok.

 FIX: Build-require `perl(Compress::Zlib)' 
 (lib/FusionInventory/Agent/Task/Deploy/Datastore/WorkDir.pm:7).
+BuildRequires:  perl(Compress::Zlib)
Ok.

 TODO: Build-require `perl(Exporter)' 
 (lib/FusionInventory/Agent/Task/Deploy/DiskFree.pm:5).
+BuildRequires:  perl(Exporter)
Ok.

 FIX: Build-require `perl(UNIVERSAL::require)' 
 (lib/FusionInventory/Agent/Task/Deploy/DiskFree.pm:10).
+BuildRequires:  perl(UNIVERSAL::require)
Ok.

 FIX: Build-require `perl(File::Spec)' 
 (lib/FusionInventory/Agent/Task/Deploy/Datastore.pm:8).
+BuildRequires:  perl(File::Spec)
Ok.

 FIX: Build-require `perl(HTTP::Request::Common)' 
 (lib/FusionInventory/Agent/Task/Deploy/P2P.pm:7).
+BuildRequires:  perl(HTTP::Request::Common)
Ok.

 FIX: Build-require `perl(Net::IP)' 
 (lib/FusionInventory/Agent/Task/Deploy/P2P.pm:8).
+BuildRequires:  perl(Net::IP)
Ok.

 FIX: Build-require `perl(POE)' 
 (lib/FusionInventory/Agent/Task/Deploy/P2P.pm:9).
+BuildRequires:  perl(POE)
Ok.

 FIX: Build-require `perl(Cwd)'
 (lib/FusionInventory/Agent/Task/Deploy/ActionProcessor.pm:6).
+BuildRequires:  perl(Cwd)
Ok.

 FIX: Build-require `perl(HTTP::Request)'
 (lib/FusionInventory/Agent/Task/Deploy/File.pm:10).
+BuildRequires:  perl(HTTP::Request)
Ok.

 FIX: Build-require `perl(Test::More)' (t/06spelling.t:6).
+BuildRequires:  perl(Test::More)
Ok.

 FIX: Build-require `perl(HTTP::Server::Simple::CGI)' (t/server.t:7).
+BuildRequires:  perl(HTTP::Server::Simple::CGI)

 FIX: Build-require `perl(Data::Dumper)' (t/server.t:12).
+BuildRequires:  perl(Data::Dumper)
Ok.

  TODO: You can remove the BuildRoot tag and it's cleaning if your are not
  intent to build this package in EPEL-5. The actions are implicit in newer
  distributions.
  TODO: Remove the %defattr from %files section. This is implicit in all

[Bug 812587] Review Request: perl-FusionInventory-Agent-Task-Deploy - Software deployment support for FusionInventory Agent

2012-05-31 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=812587

Remi Collet fed...@famillecollet.com changed:

   What|Removed |Added

  Flags||fedora-cvs?

--- Comment #8 from Remi Collet fed...@famillecollet.com ---
Thanks for your time.


New Package SCM Request
===
Package Name: perl-FusionInventory-Agent-Task-Deploy
Short Description: Software deployment support for FusionInventory Agent
Owners: remi
Branches: 
InitialCC: perl-sig

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 812587] Review Request: perl-FusionInventory-Agent-Task-Deploy - Software deployment support for FusionInventory Agent

2012-05-31 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=812587

--- Comment #9 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 812587] Review Request: perl-FusionInventory-Agent-Task-Deploy - Software deployment support for FusionInventory Agent

2012-05-30 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=812587

--- Comment #4 from Remi Collet fed...@famillecollet.com ---
Thanks for the comments.
I'm still sorry for missing BR (explicit vs implicit...)

All FIX and most TODO applied in 
https://github.com/remicollet/remirepo/commit/adef8d5a0d1e7cf165bfd3fea227d14267ffa1ea
(I still prefer to keep old stuff, builroot, defattr, clean, ... until RHEL-5
EOL)

Koji scratch BUILD
http://koji.fedoraproject.org/koji/taskinfo?taskID=4114765

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 812587] Review Request: perl-FusionInventory-Agent-Task-Deploy - Software deployment support for FusionInventory Agent

2012-05-30 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=812587

--- Comment #5 from Remi Collet fed...@famillecollet.com ---
off topic

Petr, can you please give me how to you detect BR ? Have a script or does (find
... | /usr/lib/rpm/perl.req) could be enough ?

I think I also need to mostly rewrite the BR+R for fusioninventory-agent (I
will be happy to have any comment, from you, on this package)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 812587] Review Request: perl-FusionInventory-Agent-Task-Deploy - Software deployment support for FusionInventory Agent

2012-05-29 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=812587

Petr Pisar ppi...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||ppi...@redhat.com
   Assignee|nob...@fedoraproject.org|ppi...@redhat.com
  Flags||fedora-review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 812587] Review Request: perl-FusionInventory-Agent-Task-Deploy - Software deployment support for FusionInventory Agent

2012-05-29 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=812587

--- Comment #2 from Petr Pisar ppi...@redhat.com ---
Source tar ball is original. Ok.
Summary verified from lib/FusionInventory/Agent/Task/Deploy.pm. Ok.
License verified from README and LICENSE. Ok.
URL and Source0 are usable. Ok.
No XS code. noarch BuildArch is Ok.

FIX: Build- and run-require `perl(POE::Component::Client::TCP)'
(lib/FusionInventory/Agent/Task/Deploy/P2P.pm:9).
FIX: Build-require `perl(File::Which)' (Makefile.PL:13).

TODO: Build-require `perl(base)' (lib/FusionInventory/Agent/Task/Deploy.pm:8).

FIX: Build-require `perl(LWP)' (lib/FusionInventory/Agent/Task/Deploy.pm:11).
FIX: Build-require `perl(Compress::Zlib)'
(lib/FusionInventory/Agent/Task/Deploy/Datastore/WorkDir.pm:7).

TODO: Build-require `perl(File::Path)'
(lib/FusionInventory/Agent/Task/Deploy/Datastore/WorkDir.pm:9).
TODO: Build-require `perl(Exporter)'
(lib/FusionInventory/Agent/Task/Deploy/DiskFree.pm:5).

FIX: Build-require `perl(UNIVERSAL::require)'
(lib/FusionInventory/Agent/Task/Deploy/DiskFree.pm:10).
FIX: Build-require `perl(File::Spec)'
(lib/FusionInventory/Agent/Task/Deploy/Datastore.pm:8).

FIX: Build-require `perl(HTTP::Request::Common)'
(lib/FusionInventory/Agent/Task/Deploy/P2P.pm:7).
FIX: Build-require `perl(Net::IP)'
(lib/FusionInventory/Agent/Task/Deploy/P2P.pm:8).
FIX: Build-require `perl(POE)'
(lib/FusionInventory/Agent/Task/Deploy/P2P.pm:9).
FIX: Build-require `perl(Cwd)'
(lib/FusionInventory/Agent/Task/Deploy/ActionProcessor.pm:6).
FIX: Build-require `perl(HTTP::Request)'
(lib/FusionInventory/Agent/Task/Deploy/File.pm:10).

FIX: Build-require `perl(Test::More)' (t/06spelling.t:6).
FIX: Build-require `perl(HTTP::Server::Simple::CGI)' (t/server.t:7).
FIX: Build-require `perl(Data::Dumper)' (t/server.t:12).

TODO: I can't see why perl(HTTP::Server::Simple::Authen) and perl(CGI) are
build-required. The modules are used nowhere. Are they needed?

TODO: You can remove the BuildRoot tag and it's cleaning if your are not intent
to build this package in EPEL-5. The actions are implicit in newer
distributions.

TODO: Remove the %defattr from %files section. This is implicit in all
distributions.

All tests pass. Ok.

TODO: Report a bug to upstream about undefined value (Use of uninitialized
value in string eq at
/builddir/build/BUILD/FusionInventory-Agent-Task-Deploy-2.0.0/blib/lib/FusionInventory/Agent/Task/Deploy/CheckProcessor.pm
line 14.).


$ rpmlint  perl-FusionInventory-Agent-Task-Deploy.spec
../SRPMS/perl-FusionInventory-Agent-Task-Deploy-2.0.0-2.fc18.src.rpm
../RPMS/noarch/perl-FusionInventory-Agent-Task-Deploy-2.0.0-2.fc18.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

$ rpm -q -lv -p
../RPMS/noarch/perl-FusionInventory-Agent-Task-Deploy-2.0.0-2.fc18.noarch.rpm 
drwxr-xr-x2 rootroot0 kvě 29 07:40
/usr/share/doc/perl-FusionInventory-Agent-Task-Deploy-2.0.0
-rw-r--r--1 rootroot 2250 dub  8 15:07
/usr/share/doc/perl-FusionInventory-Agent-Task-Deploy-2.0.0/Changes
-rw-r--r--1 rootroot17987 zář 20  2011
/usr/share/doc/perl-FusionInventory-Agent-Task-Deploy-2.0.0/LICENSE
-rw-r--r--1 rootroot  725 bře 18 19:11
/usr/share/doc/perl-FusionInventory-Agent-Task-Deploy-2.0.0/README
drwxr-xr-x2 rootroot0 kvě 29 07:40
/usr/share/fusioninventory/lib/FusionInventory/Agent/Task/Deploy
-rw-r--r--1 rootroot16869 dub  8 15:08
/usr/share/fusioninventory/lib/FusionInventory/Agent/Task/Deploy.pm
drwxr-xr-x2 rootroot0 kvě 29 07:40
/usr/share/fusioninventory/lib/FusionInventory/Agent/Task/Deploy/ActionProcessor
-rw-r--r--1 rootroot 2243 dub  8 15:04
/usr/share/fusioninventory/lib/FusionInventory/Agent/Task/Deploy/ActionProcessor.pm
drwxr-xr-x2 rootroot0 kvě 29 07:40
/usr/share/fusioninventory/lib/FusionInventory/Agent/Task/Deploy/ActionProcessor/Action
-rw-r--r--1 rootroot 2884 dub  8 15:04
/usr/share/fusioninventory/lib/FusionInventory/Agent/Task/Deploy/ActionProcessor/Action/Cmd.pm
-rw-r--r--1 rootroot  711 dub  8 15:04
/usr/share/fusioninventory/lib/FusionInventory/Agent/Task/Deploy/ActionProcessor/Action/Copy.pm
-rw-r--r--1 rootroot  470 dub  8 15:04
/usr/share/fusioninventory/lib/FusionInventory/Agent/Task/Deploy/ActionProcessor/Action/Delete.pm
-rw-r--r--1 rootroot  689 dub  8 15:04
/usr/share/fusioninventory/lib/FusionInventory/Agent/Task/Deploy/ActionProcessor/Action/Mkdir.pm
-rw-r--r--1 rootroot  702 dub  8 15:04
/usr/share/fusioninventory/lib/FusionInventory/Agent/Task/Deploy/ActionProcessor/Action/Move.pm
-rw-r--r--1 rootroot 2999 dub  8 15:04

[Bug 812587] Review Request: perl-FusionInventory-Agent-Task-Deploy - Software deployment support for FusionInventory Agent

2012-05-29 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=812587

--- Comment #3 from Remi Collet fed...@famillecollet.com ---
(In reply to comment #2)
 TODO: Report a bug to upstream about undefined value (Use of uninitialized
 value in string eq at
 /builddir/build/BUILD/FusionInventory-Agent-Task-Deploy-2.0.0/blib/lib/
 FusionInventory/Agent/Task/Deploy/CheckProcessor.pm line 14.).

http://forge.fusioninventory.org/issues/1591

I will provide a new spec ASAP.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 812587] Review Request: perl-FusionInventory-Agent-Task-Deploy - Software deployment support for FusionInventory Agent

2012-05-11 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=812587

--- Comment #1 from Remi Collet fed...@famillecollet.com 2012-05-11 11:02:46 
EDT ---
Cleanups + filter :

https://github.com/remicollet/remirepo/commit/a558fcd820da11efddbb6873ca9c09281a50948c

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 812587] Review Request: perl-FusionInventory-Agent-Task-Deploy - Software deployment support for FusionInventory Agent

2012-04-15 Thread bugzilla 
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=812587

Remi Collet fed...@famillecollet.com changed:

   What|Removed |Added

 Depends on||812586

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review