[Bug 813416] Review Request: drupal6-views_bonus - miscellaneous features that aren't distributed by Views itself
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=813416 --- Comment #21 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Ie5rB6FV3l&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 813416] Review Request: drupal6-views_bonus - miscellaneous features that aren't distributed by Views itself
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=813416 Shawn Iwinski changed: What|Removed |Added CC||shawn.iwin...@gmail.com Flags|fedora-cvs+ | Flags||fedora-cvs? --- Comment #20 from Shawn Iwinski --- Package Change Request == Package Name: drupal6-views_bonus New Branches: el5 Owners: ansilva siwinski InitialCC: Adding el5 branch to follow most other drupal6 packages. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=G19iVbNIey&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 813416] Review Request: drupal6-views_bonus - miscellaneous features that aren't distributed by Views itself
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=813416 Fedora Update System changed: What|Removed |Added Fixed In Version|drupal6-views_bonus-1.1-4.f |drupal6-views_bonus-1.1-4.f |c16 |c17 --- Comment #19 from Fedora Update System 2012-05-04 19:08:21 EDT --- drupal6-views_bonus-1.1-4.fc17 has been pushed to the Fedora 17 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 813416] Review Request: drupal6-views_bonus - miscellaneous features that aren't distributed by Views itself
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=813416 Fedora Update System changed: What|Removed |Added Fixed In Version|drupal6-views_bonus-1.1-4.e |drupal6-views_bonus-1.1-4.f |l6 |c16 --- Comment #18 from Fedora Update System 2012-05-04 16:27:53 EDT --- drupal6-views_bonus-1.1-4.fc16 has been pushed to the Fedora 16 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 813416] Review Request: drupal6-views_bonus - miscellaneous features that aren't distributed by Views itself
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=813416 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||drupal6-views_bonus-1.1-4.e ||l6 Resolution||ERRATA Last Closed||2012-05-04 11:58:26 --- Comment #17 from Fedora Update System 2012-05-04 11:58:26 EDT --- drupal6-views_bonus-1.1-4.el6 has been pushed to the Fedora EPEL 6 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 813416] Review Request: drupal6-views_bonus - miscellaneous features that aren't distributed by Views itself
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=813416 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #16 from Fedora Update System 2012-04-26 15:29:37 EDT --- drupal6-views_bonus-1.1-4.fc17 has been pushed to the Fedora 17 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 813416] Review Request: drupal6-views_bonus - miscellaneous features that aren't distributed by Views itself
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=813416 --- Comment #15 from Fedora Update System 2012-04-25 13:57:01 EDT --- drupal6-views_bonus-1.1-4.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/drupal6-views_bonus-1.1-4.fc17 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 813416] Review Request: drupal6-views_bonus - miscellaneous features that aren't distributed by Views itself
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=813416 --- Comment #14 from Fedora Update System 2012-04-25 13:55:50 EDT --- drupal6-views_bonus-1.1-4.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/drupal6-views_bonus-1.1-4.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 813416] Review Request: drupal6-views_bonus - miscellaneous features that aren't distributed by Views itself
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=813416 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 813416] Review Request: drupal6-views_bonus - miscellaneous features that aren't distributed by Views itself
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=813416 --- Comment #13 from Fedora Update System 2012-04-25 13:40:37 EDT --- drupal6-views_bonus-1.1-4.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/drupal6-views_bonus-1.1-4.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 813416] Review Request: drupal6-views_bonus - miscellaneous features that aren't distributed by Views itself
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=813416 --- Comment #12 from Jon Ciesla 2012-04-24 09:37:48 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 813416] Review Request: drupal6-views_bonus - miscellaneous features that aren't distributed by Views itself
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=813416 Anderson Silva changed: What|Removed |Added Flag||fedora-cvs? --- Comment #11 from Anderson Silva 2012-04-24 09:31:19 EDT --- New Package SCM Request === Package Name: drupal6-views_bonus Short Description: Views Bonus module for Drupal6 Owners: afsilva Branches: f16 f17 el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 813416] Review Request: drupal6-views_bonus - miscellaneous features that aren't distributed by Views itself
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=813416
Wesley Hearn changed:
What|Removed |Added
Flag||fedora-review+
--- Comment #10 from Wesley Hearn 2012-04-24 09:08:39 EDT
---
Good: MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[0]whearn@Desktop:/var/lib/mock/fedora-16-x86_64/result $ ls
build.log root.log
drupal6-views_bonus-1.1-4.fc16.noarch.rpm state.log
drupal6-views_bonus-1.1-4.fc16.src.rpm
[09:03 AM]
[0]whearn@Desktop:/var/lib/mock/fedora-16-x86_64/result $ rpmlint drupal6*.rpm
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
Good: MUST: The package must be named according to the Package Naming
Guidelines .
Good: MUST: The spec file name must match the base package %{name}, in the
format %{name}.spec unless your package has an exemption.
Good: MUST: The package must meet the Packaging Guidelines .
Good: MUST: The package must be licensed with a Fedora approved license and
meet the Licensing Guidelines .
See Note: MUST: The License field in the package spec file must match the
actual license.
Good: MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
Good: MUST: The spec file must be written in American English.
Good: MUST: The spec file for the package MUST be legible.
Good: MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use md5sum for this task.
If no upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
[0]whearn@Doom:~/rpmbuild/SOURCES $ md5sum views_bonus-6.x-1.1.tar.gz
160b37741523d9d833a206da0a7b101c views_bonus-6.x-1.1.tar.gz
[03:54 PM]
[0]whearn@Doom:~/rpmbuild/SOURCES $ curl
http://ftp.drupal.org/files/projects/views_bonus-6.x-1.1.tar.gz | md5sum -
% Total% Received % Xferd Average Speed TimeTime Time Current
Dload Upload Total SpentLeft Speed
100 17832 100 178320 0 168k 0 --:--:-- --:--:-- --:--:-- 272k
160b37741523d9d833a206da0a7b101c -
noarch: MUST: The package MUST successfully compile and build into binary rpms
on at least one primary architecture.
noarch: MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
Good: MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
Good: MUST: The spec file MUST handle locales properly. This is done by using
the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
noarch: MUST: Every binary RPM package (or subpackage) which stores shared
library files (not just symlinks) in any of the dynamic linker's default paths,
must call ldconfig in %post and %postun.
Good: MUST: Packages must NOT bundle copies of system libraries.
Good: MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
Good: MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
Good: MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations)
Good: MUST: Permissions on files must be set properly. Executables should be
set with executable permissions, for example.
Good: MUST: Each package must consistently use macros.
Good: MUST: The package must contain code, or permissable content.
Good: MUST: Large documentation files must go in a -doc subpackage. (The
definition of large is left up to the packager's best judgement, but is not
restricted to size. Large can refer to either size or quantity).
Good: MUST: If a package includes something as %doc, it must not affect the
runtime of the application. To summarize: If it is in %doc, the program must
run properly if it is not present.
Good: MUST: Static libraries must be in
[Bug 813416] Review Request: drupal6-views_bonus - miscellaneous features that aren't distributed by Views itself
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=813416 --- Comment #9 from Anderson Silva 2012-04-23 16:37:01 EDT --- Spec URL: http://people.redhat.com/~ansilva/drupal6-views_bonus.spec SRPM URL: http://people.redhat.com/~ansilva/drupal6-views_bonus-1.1-4.fc16.src.rpm new files up. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 813416] Review Request: drupal6-views_bonus - miscellaneous features that aren't distributed by Views itself
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=813416
--- Comment #8 from Wesley Hearn 2012-04-23 10:06:33 EDT ---
You forgot to add the README.txt to exclude.
It should be something like
48 %doc LICENSE.txt README.txt
49 %exclude %{drupal_modules}/%{modname}/LICENSE.txt
50 %exclude %{drupal_modules}/%{modname}/README.txt
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 813416] Review Request: drupal6-views_bonus - miscellaneous features that aren't distributed by Views itself
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=813416 --- Comment #7 from Anderson Silva 2012-04-20 16:44:10 EDT --- Spec URL: http://people.redhat.com/~ansilva/drupal6-views_bonus.spec SRPM URL: http://people.redhat.com/~ansilva/drupal6-views_bonus-1.1-3.fc16.src.rpm new files up. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 813416] Review Request: drupal6-views_bonus - miscellaneous features that aren't distributed by Views itself
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=813416 --- Comment #6 from Wesley Hearn 2012-04-20 16:36:17 EDT --- Ok, one small thing left it looks like, the README.txt should be listed in %doc. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 813416] Review Request: drupal6-views_bonus - miscellaneous features that aren't distributed by Views itself
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=813416 --- Comment #5 from Anderson Silva 2012-04-20 16:19:42 EDT --- doh! can you wget the src rpm again... it should be fixed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 813416] Review Request: drupal6-views_bonus - miscellaneous features that aren't distributed by Views itself
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=813416 --- Comment #4 from Wesley Hearn 2012-04-20 16:08:25 EDT --- [0]whearn@Doom:~/Downloads $ rpm -qlp drupal6-views_bonus-1.1-2.fc16.src.rpm LICENSE.txt drupal6-views-bonus.spec views_bonus-6.x-1.1.tar.gz -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 813416] Review Request: drupal6-views_bonus - miscellaneous features that aren't distributed by Views itself
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=813416 --- Comment #3 from Anderson Silva 2012-04-20 16:04:17 EDT --- it is named: drupal6-views_bonus.spec (there is a "views-bonus" on the host, but the link above it so drupal6-views_bonus.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 813416] Review Request: drupal6-views_bonus - miscellaneous features that aren't distributed by Views itself
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=813416 --- Comment #2 from Wesley Hearn 2012-04-20 16:00:25 EDT --- Spec file is named wrong. Should be named drupal6-views_bonus.spec, http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Spec_file_name -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 813416] Review Request: drupal6-views_bonus - miscellaneous features that aren't distributed by Views itself
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=813416 Wesley Hearn changed: What|Removed |Added CC||whe...@redhat.com AssignedTo|nob...@fedoraproject.org|whe...@redhat.com --- Comment #1 from Wesley Hearn 2012-04-20 13:40:16 EDT --- I will take this -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
