[Bug 814088] Review Request: fungal - a POJO kernel environment used by Ironjacamar standalone
https://bugzilla.redhat.com/show_bug.cgi?id=814088 --- Comment #2 from Lin Gao --- Change to 0.10.1.Final Spec URL: http://fedorapkgs-gaolin.rhcloud.com/fungal.spec SRPM URL: http://fedorapkgs-gaolin.rhcloud.com/fungal-0.10.1-1.Final.fc16.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 814088] Review Request: fungal - a POJO kernel environment used by Ironjacamar standalone
https://bugzilla.redhat.com/show_bug.cgi?id=814088 Lin Gao changed: What|Removed |Added Blocks|177841 | -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 814088] Review Request: fungal - a POJO kernel environment used by Ironjacamar standalone
https://bugzilla.redhat.com/show_bug.cgi?id=814088 --- Comment #3 from Lin Gao --- Fix the Release on: Spec URL: http://fedorapkgs-gaolin.rhcloud.com/fungal.spec SRPM URL: http://fedorapkgs-gaolin.rhcloud.com/fungal-0.10.1-1.fc16.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 814088] Review Request: fungal - a POJO kernel environment used by Ironjacamar standalone
https://bugzilla.redhat.com/show_bug.cgi?id=814088 James Hogarth changed: What|Removed |Added CC||james.hoga...@gmail.com, ||l...@redhat.com Flags||needinfo?(l...@redhat.com) --- Comment #11 from James Hogarth --- Lin are you able to progress this? If it's not possible let's close this review to try and tidy up a bit. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 814088] Review Request: fungal - a POJO kernel environment used by Ironjacamar standalone
https://bugzilla.redhat.com/show_bug.cgi?id=814088 Lin Gao changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |WONTFIX Flags|needinfo?(l...@redhat.com) | Last Closed||2015-12-04 03:37:02 --- Comment #12 from Lin Gao --- Sorry, I am too busy for now. Closed it as won'tfix -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 814088] Review Request: fungal - a POJO kernel environment used by Ironjacamar standalone
https://bugzilla.redhat.com/show_bug.cgi?id=814088 Mikolaj Izdebski changed: What|Removed |Added CC||mizde...@redhat.com Blocks|652183 (FE-JAVASIG) | --- Comment #9 from Mikolaj Izdebski --- Package is not ready for rewiew - lifting block on Java SIG. Feel free to add it once ready for review. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 814088] Review Request: fungal - a POJO kernel environment used by Ironjacamar standalone
https://bugzilla.redhat.com/show_bug.cgi?id=814088 --- Comment #10 from gil cattaneo --- Available fungal-0.11.0-final @ https://github.com/jesperpedersen/fungal/releases/tag/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 814088] Review Request: fungal - a POJO kernel environment used by Ironjacamar standalone
https://bugzilla.redhat.com/show_bug.cgi?id=814088 Mikolaj Izdebski changed: What|Removed |Added Flags|fedora-review+ | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8SWZVbEkLb&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 814088] Review Request: fungal - a POJO kernel environment used by Ironjacamar standalone
https://bugzilla.redhat.com/show_bug.cgi?id=814088 --- Comment #8 from Lin Gao --- The developer will include a license file in next release, but I need to wait for that. so I will re-submit this package till next release of fungal. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=drEigLepQK&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 814088] Review Request: fungal - a POJO kernel environment used by Ironjacamar standalone
https://bugzilla.redhat.com/show_bug.cgi?id=814088 Christopher Meng changed: What|Removed |Added Whiteboard||NotReady -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8EAPmPTwL0&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 814088] Review Request: fungal - a POJO kernel environment used by Ironjacamar standalone
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=814088 --- Comment #1 from Lin Gao 2012-04-19 04:21:09 EDT --- This is my first package to Fedora, thus needs a sponsor. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 814088] Review Request: fungal - a POJO kernel environment used by Ironjacamar standalone
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=814088 Lin Gao changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 814088] Review Request: fungal - a POJO kernel environment used by Ironjacamar standalone
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=814088 Jason Tibbitts changed: What|Removed |Added Flags||needinfo?(l...@redhat.com) --- Comment #4 from Jason Tibbitts --- I am triaging old review tickets. I apologize that it has been so long since anyone looked at this ticket, but there are more packages submitted now than the pool of reviewers can handle, and some tickets fall through the cracks. In order to keep the queue manageable, we need to occasionally find tickets which are not reviewable so as to not waste what reviewer time is available. Accordingly, I'm pinging this ticket and setting NEEDINFO. If you are still interested in having your package reviewed, please do the following: * Make sure your package still reflects the current status of its upstream. * Check that your package still builds on current Fedora releases. * Audit your package versus the current status of the packaging guidelines, current rpmlint and current fedora-review tools. And, finally, reply, making sure that the NEEDINFO flag gets cleared so that this ticket reappears in the review queue. I can't promise a review if you reply, but by closing out the stale tickets we can devote extra attention to the ones which aren't stale. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8wACFmKjt1&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 814088] Review Request: fungal - a POJO kernel environment used by Ironjacamar standalone
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=814088 Lin Gao changed: What|Removed |Added Flags|needinfo?(l...@redhat.com) | --- Comment #5 from Lin Gao --- Yes, I am still interested in having this package reviewed. Upgraded to latest release of fungal: SPec URL: http://repos.fedorapeople.org/repos/lgao/fungal/fungal.spec SRPM URL: http://repos.fedorapeople.org/repos/lgao/fungal/fungal-0.11.0-0.1.RC1.fc16.src.rpm Test koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5370812 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rUx926E2E9&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 814088] Review Request: fungal - a POJO kernel environment used by Ironjacamar standalone
https://bugzilla.redhat.com/show_bug.cgi?id=814088 Jason Tibbitts changed: What|Removed |Added Blocks||652183 (FE-JAVASIG) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MslvLbAehe&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 814088] Review Request: fungal - a POJO kernel environment used by Ironjacamar standalone
https://bugzilla.redhat.com/show_bug.cgi?id=814088 gil cattaneo changed: What|Removed |Added CC||punto...@libero.it Assignee|nob...@fedoraproject.org|punto...@libero.it Flags||fedora-review? --- Comment #6 from gil cattaneo --- would like to take this review -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=z5acsWWsUE&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 814088] Review Request: fungal - a POJO kernel environment used by Ironjacamar standalone
https://bugzilla.redhat.com/show_bug.cgi?id=814088
gil cattaneo changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #7 from gil cattaneo ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Javadoc subpackages should not have Requires: jpackage-utils
Note: jpackage-utils requires are automatically generated by the buildsystem
See: https://fedoraproject.org/wiki/Packaging:Java
- Bundled jar/class files should be removed before build
Note: Jar files in source (see attachment)
See:
http://fedoraproject.org/wiki/Packaging:Java#Pre-built_JAR_files_.2F_Other_bundled_software'
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Fully versioned dependency in subpackages, if present.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in fungal-
javadoc
[x]: Package complies to the Packaging Guidelines
[!]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"LGPL (v2.1 or later)", "Unknown or generated". 123 files have unknown
license. Detailed output of licensecheck in
/home/gil/814088-fungal/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 10240 bytes in 1 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
Java:
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
[x]: Fully versioned dependency in subpackages, if present.
[x]: Javadoc documentation files are generated and included in -javadoc
subpackage
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
Maven:
[x]: Pom files have correct Maven mapping
Note: Some add_maven_depmap calls found. Please check if they are correct
or update to latest guidelines
[x]: If package contains pom.xml files install it (including depmaps) even
when building with ant
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DOES NOT have Requires(post) and Requires(p
