[Bug 815566] Review Request: mybatis - SQL Mapping Framework for Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=815566 Gerard Ryan ger...@ryan.lt changed: What|Removed |Added Blocks|652183 (FE-JAVASIG) | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TrrxxlFanSa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 815566] Review Request: mybatis - SQL Mapping Framework for Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=815566 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2013-04-27 23:47:37 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=v6myzHfXI5a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 815566] Review Request: mybatis - SQL Mapping Framework for Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=815566 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- mybatis-3.2.2-2.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4y80KSI2EJa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 815566] Review Request: mybatis - SQL Mapping Framework for Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=815566 Bug 815566 depends on bug 954134, which changed state. Bug 954134 Summary: Review Request: mybatis-parent - The MyBatis parent POM https://bugzilla.redhat.com/show_bug.cgi?id=954134 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IasllAoRxOa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 815566] Review Request: mybatis - SQL Mapping Framework for Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=815566 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5xjLVjQFT2a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 815566] Review Request: mybatis - SQL Mapping Framework for Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=815566 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- mybatis-3.2.2-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/mybatis-3.2.2-2.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=q7gcE4ZZ6ma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 815566] Review Request: mybatis - SQL Mapping Framework for Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=815566 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- mybatis-3.2.2-2.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Rb1Irc1O4ga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 815566] Review Request: mybatis - SQL Mapping Framework for Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=815566 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gRj8TvHtsDa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 815566] Review Request: mybatis - SQL Mapping Framework for Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=815566 gil cattaneo punto...@libero.it changed: What|Removed |Added Flags||fedora-cvs? --- Comment #9 from gil cattaneo punto...@libero.it --- New Package SCM Request === Package Name: mybatis Short Description: SQL Mapping Framework for Java Owners: gil Branches: f18 f19 f20 InitialCC: java-sig -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vkPDj8j5jda=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 815566] Review Request: mybatis - SQL Mapping Framework for Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=815566 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zmAjBOe5Eza=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 815566] Review Request: mybatis - SQL Mapping Framework for Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=815566 Orion Poplawski or...@cora.nwra.com changed: What|Removed |Added Flags||fedora-review+ --- Comment #8 from Orion Poplawski or...@cora.nwra.com --- (In reply to comment #5) - The description is wrapped at 51 characters, this seems much too small. I would suggest 72-78. sorry really ...? really. It's a suggestion, but I've never seen a description wrapped so small. I'm not sure that the requires are correct. You might want to use %mvn_rpmbuild in F19+ to ensure that. I'm willing to see that fixed later as well. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fUGUTZHdMva=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 815566] Review Request: mybatis - SQL Mapping Framework for Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=815566 --- Comment #10 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cg9DyQK5mwa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 815566] Review Request: mybatis - SQL Mapping Framework for Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=815566 --- Comment #4 from gil cattaneo punto...@libero.it --- hi yes geronimo... Spec URL: http://gil.fedorapeople.org/mybatis/3.2.2/mybatis.spec SRPM URL: http://gil.fedorapeople.org/mybatis/3.2.2/mybatis-3.2.2-1.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0uOOmZhqcga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 815566] Review Request: mybatis - SQL Mapping Framework for Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=815566 --- Comment #5 from gil cattaneo punto...@libero.it --- - The description is wrapped at 51 characters, this seems much too small. I would suggest 72-78. sorry really ...? - hsqldb appears to be in Fedora yes but not series 2.x regards -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8i1bnECjwwa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 815566] Review Request: mybatis - SQL Mapping Framework for Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=815566 --- Comment #6 from gil cattaneo punto...@libero.it --- (In reply to comment #5) - hsqldb appears to be in Fedora yes but not series 2.x [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:testCompile (default-testCompile) on project mybatis: Compilation failure: Compilation failure: [ERROR] /home/gil/rpmbuild/BUILD/mybatis-3.2.2/src/test/java/org/apache/ibatis/jdbc/PooledDataSourceTest.java:[23,22] error: cannot find symbol [ERROR] symbol: class JDBCConnection [ERROR] location: package org.hsqldb.jdbc [ERROR] /home/gil/rpmbuild/BUILD/mybatis-3.2.2/src/test/java/org/apache/ibatis/jdbc/PooledDataSourceTest.java:[23,22] error: cannot find symbol [ERROR] symbol: class JDBCConnection [ERROR] location: package org.hsqldb.jdbc [ERROR] /home/gil/rpmbuild/BUILD/mybatis-3.2.2/src/test/java/org/apache/ibatis/jdbc/PooledDataSourceTest.java:[86,4] error: cannot find symbol [ERROR] symbol: class JDBCConnection [ERROR] location: class PooledDataSourceTest [ERROR] /home/gil/rpmbuild/BUILD/mybatis-3.2.2/src/test/java/org/apache/ibatis/jdbc/PooledDataSourceTest.java:[86,37] error: cannot find symbol [ERROR] - [Help 1] -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Bu8GuAYExIa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 815566] Review Request: mybatis - SQL Mapping Framework for Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=815566 gil cattaneo punto...@libero.it changed: What|Removed |Added Depends On||954134 --- Comment #7 from gil cattaneo punto...@libero.it --- Spec URL: http://gil.fedorapeople.org/mybatis/3.2.2/1/mybatis.spec SRPM URL: http://gil.fedorapeople.org/mybatis/3.2.2/1/mybatis-3.2.2-2.fc18.src.rpm - rebuilt with mybatis-parent support - run test suite with hsqldb 1.x -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=s1BklxQ99ga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 815566] Review Request: mybatis - SQL Mapping Framework for Java
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=815566
Orion Poplawski or...@cora.nwra.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||or...@cora.nwra.com
Assignee|nob...@fedoraproject.org|or...@cora.nwra.com
--- Comment #2 from Orion Poplawski or...@cora.nwra.com ---
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
Couple issues:
- Can we update to 3.2.2?
- The description is wrapped at 51 characters, this seems much too small. I
would suggest 72-78.
- hsqldb appears to be in Fedora
- I'm trying to figure out where javax.transaction comes from as well. Do you
know?
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Fully versioned dependency in subpackages, if present.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mybatis-
javadoc
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Apache (v2.0), Unknown or generated. 2 files have unknown license.
Detailed output of licensecheck in
/export/home/orion/redhat/mybatis-3.1.1/review-mybatis/licensecheck.txt
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 30720 bytes in 3 files.
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
Note: Using prebuilt packages
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
= SHOULD items =
Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[!]: Latest version is packaged.
Latest is 3.2.2
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary
[Bug 815566] Review Request: mybatis - SQL Mapping Framework for Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=815566 --- Comment #3 from Orion Poplawski or...@cora.nwra.com --- Looks like geronimo-jta provides javax.transaction. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oCT2CsPnlSa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 815566] Review Request: mybatis - SQL Mapping Framework for Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=815566 gil cattaneo punto...@libero.it changed: What|Removed |Added Depends On|815394 | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Wcf228Rzu4a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 815566] Review Request: mybatis - SQL Mapping Framework for Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=815566 --- Comment #1 from gil cattaneo punto...@libero.it --- Spec URL: http://gil.fedorapeople.org/mybatis.spec SRPM URL: http://gil.fedorapeople.org/mybatis-3.1.1-1.fc18.src.rpm tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=4821081 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CNq46YYG7wa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 815566] Review Request: mybatis - SQL Mapping Framework for Java
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=815566 gil cattaneo punto...@libero.it changed: What|Removed |Added Blocks||652183 (FE-JAVASIG) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sYlKLuumzGa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 815566] Review Request: mybatis - SQL Mapping Framework for Java
https://bugzilla.redhat.com/show_bug.cgi?id=815566 gil cattaneo punto...@libero.it changed: What|Removed |Added Blocks||848096 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 815566] Review Request: mybatis - SQL Mapping Framework for Java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=815566 gil cattaneo punto...@libero.it changed: What|Removed |Added Depends on||815394 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
