[Bug 816172] Review Request: perl-constant-defer - Constant subs with deferred value calculation
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=816172 --- Comment #10 from Fedora Update System --- perl-constant-defer-5-3.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816172] Review Request: perl-constant-defer - Constant subs with deferred value calculation
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=816172 Fedora Update System changed: What|Removed |Added Resolution|RAWHIDE |CURRENTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816172] Review Request: perl-constant-defer - Constant subs with deferred value calculation
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=816172 --- Comment #9 from Fedora Update System --- perl-constant-defer-5-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/perl-constant-defer-5-3.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816172] Review Request: perl-constant-defer - Constant subs with deferred value calculation
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=816172 --- Comment #8 from Miro Hrončok --- Thanks -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816172] Review Request: perl-constant-defer - Constant subs with deferred value calculation
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=816172 --- Comment #7 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816172] Review Request: perl-constant-defer - Constant subs with deferred value calculation
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=816172 Petr Pisar changed: What|Removed |Added Flags|fedora-cvs+ | Flags||fedora-cvs? --- Comment #6 from Petr Pisar --- Package Change Request == Package Name: perl-constant-defer New Branches: f17 Owners: ppisar mmaslano psabata InitialCC: perl-sig -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816172] Review Request: perl-constant-defer - Constant subs with deferred value calculation
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=816172 Miro Hrončok changed: What|Removed |Added CC||m...@hroncok.cz --- Comment #5 from Miro Hrončok --- Could you please make this available to f17? Thnaks -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816172] Review Request: perl-constant-defer - Constant subs with deferred value calculation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=816172 Petr Pisar changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||perl-constant-defer-5-1.fc1 ||8 Resolution||RAWHIDE Last Closed||2012-04-25 11:45:12 --- Comment #4 from Petr Pisar 2012-04-25 11:45:12 EDT --- You are right, it's requires out of eval in other test file. Thank you for the review and the repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816172] Review Request: perl-constant-defer - Constant subs with deferred value calculation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=816172 --- Comment #3 from Jon Ciesla 2012-04-25 10:48:26 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816172] Review Request: perl-constant-defer - Constant subs with deferred value calculation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=816172 Petr Pisar changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816172] Review Request: perl-constant-defer - Constant subs with deferred value calculation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=816172 --- Comment #2 from Petr Pisar 2012-04-25 10:39:42 EDT --- New Package SCM Request === Package Name: perl-constant-defer Short Description: Constant subs with deferred value calculation Owners: ppisar mmaslano psabata Branches: InitialCC: perl-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816172] Review Request: perl-constant-defer - Constant subs with deferred value calculation
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=816172
Petr Šabata changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #1 from Petr Šabata 2012-04-25 10:02:05 EDT ---
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
Generic
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[-]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm < 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
[-]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
names).
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint output is silent.
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
/home/contyk/src/review/816172/constant-defer-5.tar.gz :
MD5SUM this package : 519232b64896395b84b41f5300d1cab3
MD5SUM upstream package : 519232b64896395b84b41f5300d1cab3
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[-]: MUST Useful -debuginfo package or justification otherwise.
[x]: SHOULD Reviewer should test that the package builds in mock.
[-]: SHOULD If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to
include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[?]: SHOULD Package functions as described.
[x]: SHOULD Latest version is packaged.
[x]: SHOULD Package does not include license text files separate from
upstream.
[x]: SHOULD SourceX is a working URL.
[-]: SHOULD Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[-]: SHOULD Package should compile and build into binary rpms on all supported
architectures.
[x]: SHOULD %check is present and all tests pass.
[x]: SHOULD Packages should try to preserve timestamps of original installed
files.
[-]: SHOULD Spec use %global instead of %define.
Issues:
None. Approving.
However, it seems perl(Devel::FindRef) is always used in tests; you could move
it six lines up ;)
Generated by fedora-review 0.2.0git
External plugins:
--
Configure bugmail: https://b
[Bug 816172] Review Request: perl-constant-defer - Constant subs with deferred value calculation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=816172 Petr Pisar changed: What|Removed |Added Blocks||816214 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816172] Review Request: perl-constant-defer - Constant subs with deferred value calculation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=816172 Petr Šabata changed: What|Removed |Added Status|NEW |ASSIGNED CC||psab...@redhat.com AssignedTo|nob...@fedoraproject.org|psab...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
