[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=817315 --- Comment #47 from Fedora Update System upda...@fedoraproject.org --- megaglest-3.7.1-1.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=817315 --- Comment #48 from Fedora Update System upda...@fedoraproject.org --- megaglest-3.7.1-1.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=817315 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Resolution|ERRATA |CURRENTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=817315 --- Comment #46 from Fedora Update System upda...@fedoraproject.org --- megaglest-3.7.1-1.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=817315 --- Comment #43 from Fedora Update System upda...@fedoraproject.org --- megaglest-3.7.1-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/megaglest-3.7.1-1.fc16 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=817315 --- Comment #44 from Fedora Update System upda...@fedoraproject.org --- megaglest-3.7.1-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/megaglest-3.7.1-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=817315 --- Comment #45 from Fedora Update System upda...@fedoraproject.org --- megaglest-3.7.1-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/megaglest-3.7.1-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
https://bugzilla.redhat.com/show_bug.cgi?id=817315 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2012-08-18 20:26:43 --- Comment #41 from Fedora Update System upda...@fedoraproject.org --- megaglest-3.6.0.3-5.fc16 has been pushed to the Fedora 16 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
https://bugzilla.redhat.com/show_bug.cgi?id=817315 --- Comment #42 from Fedora Update System upda...@fedoraproject.org --- megaglest-3.6.0.3-5.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
https://bugzilla.redhat.com/show_bug.cgi?id=817315 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #40 from Fedora Update System upda...@fedoraproject.org --- megaglest-3.6.0.3-5.fc16 has been pushed to the Fedora 16 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
https://bugzilla.redhat.com/show_bug.cgi?id=817315 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
https://bugzilla.redhat.com/show_bug.cgi?id=817315 --- Comment #38 from Fedora Update System upda...@fedoraproject.org --- megaglest-3.6.0.3-5.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/megaglest-3.6.0.3-5.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
https://bugzilla.redhat.com/show_bug.cgi?id=817315 --- Comment #39 from Fedora Update System upda...@fedoraproject.org --- megaglest-3.6.0.3-5.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/megaglest-3.6.0.3-5.fc16 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
https://bugzilla.redhat.com/show_bug.cgi?id=817315 --- Comment #34 from Simone Caronni negativ...@gmail.com --- Woah. I haven't seen an updated spec file with one of the 2 suggested license clarifications but I'm sure you will add them in git. (In reply to comment #26) Technical guidelines are very important, but legal ones are even more so, and it's important to be as thourough as possible. Flagging FE-LEGAL will get someone with more expertise with licensing to have a look, and is always educational. Definitely. Package approved. Thanks, --Simone -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
https://bugzilla.redhat.com/show_bug.cgi?id=817315 --- Comment #35 from pcpa paulo.cesar.pereira.de.andr...@gmail.com --- (In reply to comment #34) Woah. I haven't seen an updated spec file with one of the 2 suggested license clarifications but I'm sure you will add them in git. Yes, my plan was to update it in git. Since you already expect it, I believe no need to upload a newer package :-) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
https://bugzilla.redhat.com/show_bug.cgi?id=817315 pcpa paulo.cesar.pereira.de.andr...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #36 from pcpa paulo.cesar.pereira.de.andr...@gmail.com --- New Package SCM Request === Package Name: megaglest Short Description: Open Source 3d real time strategy game Owners: pcpa Branches: f16 f17 InitialCC: pcpa -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
https://bugzilla.redhat.com/show_bug.cgi?id=817315 --- Comment #37 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
https://bugzilla.redhat.com/show_bug.cgi?id=817315 Tom spot Callaway tcall...@redhat.com changed: What|Removed |Added CC||tcall...@redhat.com Blocks|182235 (FE-Legal) | Assignee|negativ...@gmail.com|nob...@fedoraproject.org --- Comment #29 from Tom spot Callaway tcall...@redhat.com --- Summary: All the licenses found inside MegaGlest are compatible, because they all are either permissive (BSD, MIT, zlib), contain an or any later version clause (GPLv2+, GPLv3+), or are unversioned and get the or any later version clause by default (LGPLv2+). License tag on this could either be the simplified result of the combined licenses: # glexemel standalone tool is GPL+ # Other standalone tools are GPLv3+ # Game code is a combination of GPLv2+, GPLv3+, BSD, MIT, LGPLv2+, and # Copyright only License: GPLv3+ and GPL+ OR, if you want to be pedantic, the full tag would be: # glexemel standalone tool is GPL+ # Other standalone tools are GPLv3+ # Game code is a combination of GPLv2+, GPLv3+, BSD, MIT, LGPLv2+, and # Copyright only License: (GPLv2+ and GPLv3+ and LGPLv2+ and BSD and MIT and Copyright only) and GPLv3+ and GPL+ Either is correct, either is acceptable in Fedora. (I prefer the first one) You should ask upstream to consider marking the copyright and license inside the unmarked files that I found, they do an otherwise excellent job of this. Lifting FE-Legal. == Detailed License Audit == Package: MegaGlest 3.6.0.3 Main license assertion is GPLv3+ (COPYRIGHT.source_code.txt) zlib files (unmarked, but clearly from libSDL) NOTE: These files are only used on OSX, so they do not affect the Fedora license tag. === ./source/glest_game/main/macosx_main.h ./source/glest_game/main/macosx_main.m Unmarked PHP and SQL files from glest/megaglest, safe to assume GPLv3+ === ./source/masterserver/* Files marked as BSD (linked into game code) === ./source/shared_lib/sources/graphics/freetype-gl/*.c ./source/shared_lib/sources/platform/macosx/NSFont_OpenGL.h (OSX ONLY) ./source/shared_lib/sources/platform/macosx/NSFont_OpenGL.m (OSX ONLY) ./source/shared_lib/sources/platform/win32/glob.cpp (WINDOWS ONLY) Files marked as Copyright Only (extremely permissive licensing, linked into game code) === ./source/shared_lib/sources/streflop/libm/* Files marked as LGPLv2+ and BSD (linked into game code) === ./source/shared_lib/sources/streflop/Random.cpp Unmarked files, safe to treat as LGPLv2+ (linked into game code, see streflop/README.txt) === ./source/shared_lib/sources/streflop/SMath.cpp ./source/shared_lib/sources/streflop/streflopC.cpp Files marked as MIT (linked into game code) === ./source/shared_lib/sources/graphics/md5/*.cpp Files marked as GPL+ (but only in glexemel tool, not compiled into base game): === ./source/tools/glexemel/g2xml.c ./source/tools/glexemel/g3d_support.py ./source/tools/glexemel/g3d_support_b257.py ./source/tools/glexemel/g3d_support_b260.py ./source/tools/glexemel/g3dv4.h ./source/tools/glexemel/g3d_xml_exporter.py ./source/tools/glexemel/xml2g.c Files marked as GPLv2+ === ./source/configurator/configuration.cpp ./source/configurator/configuration.h ./source/configurator/main.cpp ./source/configurator/main.h ./source/g3d_viewer/main.cpp ./source/g3d_viewer/main.h ./source/g3d_viewer/renderer.cpp ./source/g3d_viewer/renderer.h ./source/glest_game/ai/ai.cpp ./source/glest_game/ai/ai.h ./source/glest_game/ai/ai_interface.cpp ./source/glest_game/ai/ai_interface.h ./source/glest_game/ai/ai_rule.cpp ./source/glest_game/ai/ai_rule.h ./source/glest_game/ai/annotated_map.cpp ./source/glest_game/ai/annotated_map.h ./source/glest_game/ai/cartographer.cpp ./source/glest_game/ai/cartographer.h ./source/glest_game/ai/cluster_map.cpp ./source/glest_game/ai/cluster_map.h ./source/glest_game/ai/influence_map.h ./source/glest_game/ai/node_pool.cpp ./source/glest_game/ai/node_pool.h ./source/glest_game/ai/path_finder.cpp ./source/glest_game/ai/path_finder.h ./source/glest_game/ai/route_planner.cpp ./source/glest_game/ai/route_planner.h ./source/glest_game/ai/search_engine.h ./source/glest_game/facilities/auto_test.cpp ./source/glest_game/facilities/auto_test.h ./source/glest_game/facilities/components.cpp ./source/glest_game/facilities/components.h ./source/glest_game/facilities/game_util.cpp ./source/glest_game/facilities/game_util.h ./source/glest_game/facilities/logger.cpp ./source/glest_game/facilities/logger.h ./source/glest_game/facilities/pos_iterator.cpp ./source/glest_game/facilities/pos_iterator.h ./source/glest_game/game/chat_manager.cpp ./source/glest_game/game/chat_manager.h ./source/glest_game/game/commander.cpp ./source/glest_game/game/commander.h ./source/glest_game/game/console.cpp ./source/glest_game/game/console.h ./source/glest_game/game/game_camera.cpp
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
https://bugzilla.redhat.com/show_bug.cgi?id=817315 --- Comment #30 from Jon Ciesla limburg...@gmail.com --- Thanks spot! -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
https://bugzilla.redhat.com/show_bug.cgi?id=817315 --- Comment #31 from pcpa paulo.cesar.pereira.de.andr...@gmail.com --- Many thanks for the audit. I will contact upstream about the suggestion; I did exchange several emails with a main developer some months ago when I made the initial review request and they are very friendly and want to help in getting it packaged. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
https://bugzilla.redhat.com/show_bug.cgi?id=817315 pcpa paulo.cesar.pereira.de.andr...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #32 from pcpa paulo.cesar.pereira.de.andr...@gmail.com --- New Package SCM Request === Package Name: megaglest Short Description: Open Source 3d real time strategy game Owners: pcpa Branches: f16 f17 InitialCC: pcpa -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
https://bugzilla.redhat.com/show_bug.cgi?id=817315 --- Comment #33 from Jon Ciesla limburg...@gmail.com --- Simone, can you confirm your approval post-legal review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
https://bugzilla.redhat.com/show_bug.cgi?id=817315 --- Comment #27 from Simone Caronni negativ...@gmail.com --- Ok! Thanks. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
https://bugzilla.redhat.com/show_bug.cgi?id=817315 --- Comment #28 from pcpa paulo.cesar.pereira.de.andr...@gmail.com --- (In reply to comment #26) I have some concerns. First, there's a mix of various versions of LPGL and GPL, among others. These are not all necessarily compatible. See: http://fedoraproject.org/wiki/Licensing#SoftwareLicenses and http://fedoraproject.org/wiki/Licensing#GPLCompatibilityMatrix There's the Doom3 md5 issue. By my reading, you can't include mt19937ar.c. I think you mean Random.cpp, there is some license analysis at https://launchpad.net/ubuntu/precise/+source/megaglest/+copyright Additionally, there are lots of files with no license information. In the presence of so many licenses, what applies to what? I'm flagging FE-LEGAL for additional review. Any of these is enough to block the package if now resolved completely. Technical guidelines are very important, but legal ones are even more so, and it's important to be as thourough as possible. Flagging FE-LEGAL will get someone with more expertise with licensing to have a look, and is always educational. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
https://bugzilla.redhat.com/show_bug.cgi?id=817315 --- Comment #25 from Simone Caronni negativ...@gmail.com --- Package looks good for me. Has someone anything else to say regarding licensing? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
https://bugzilla.redhat.com/show_bug.cgi?id=817315 Simone Caronni negativ...@gmail.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
https://bugzilla.redhat.com/show_bug.cgi?id=817315 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added CC||limburg...@gmail.com Blocks||182235 (FE-Legal) --- Comment #26 from Jon Ciesla limburg...@gmail.com --- I have some concerns. First, there's a mix of various versions of LPGL and GPL, among others. These are not all necessarily compatible. See: http://fedoraproject.org/wiki/Licensing#SoftwareLicenses and http://fedoraproject.org/wiki/Licensing#GPLCompatibilityMatrix There's the Doom3 md5 issue. By my reading, you can't include mt19937ar.c. Additionally, there are lots of files with no license information. In the presence of so many licenses, what applies to what? I'm flagging FE-LEGAL for additional review. Any of these is enough to block the package if now resolved completely. Technical guidelines are very important, but legal ones are even more so, and it's important to be as thourough as possible. Flagging FE-LEGAL will get someone with more expertise with licensing to have a look, and is always educational. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
https://bugzilla.redhat.com/show_bug.cgi?id=817315 --- Comment #24 from pcpa paulo.cesar.pereira.de.andr...@gmail.com --- New package addressing Simone review and updating license tag: Spec URL: http://fedorapeople.org/~pcpa/megaglest.spec SRPM URL: http://fedorapeople.org/~pcpa/megaglest-3.6.0.3-5.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
https://bugzilla.redhat.com/show_bug.cgi?id=817315 Bug 817315 depends on bug 817311, which changed state. Bug 817311 Summary: Review Request: miniupnpc - Library and tool to control NAT in UPnP-enabled routers https://bugzilla.redhat.com/show_bug.cgi?id=817311 What|Removed |Added Status|CLOSED |ASSIGNED Resolution|RAWHIDE |--- -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
https://bugzilla.redhat.com/show_bug.cgi?id=817315 Bug 817315 depends on bug 817306, which changed state. Bug 817306 Summary: Review Request: libircclient - C library to create IRC clients https://bugzilla.redhat.com/show_bug.cgi?id=817306 What|Removed |Added Status|CLOSED |ASSIGNED Resolution|RAWHIDE |--- -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
https://bugzilla.redhat.com/show_bug.cgi?id=817315 --- Comment #23 from pcpa paulo.cesar.pereira.de.andr...@gmail.com --- Thanks. Just opened all files in licensecheck output. (found it funny that numbers appear rounded, 350, 50, 10, but that is what I did count, maybe messed counting a bit a some point, but looked at every file) Before all mess below, I do not think it is a duplicate of the MD5 viewer, but an implementation in C++, while the other you posted is in C. After you check below :-) Is it ok to list license as GPLv3+ and GPLv2+ and LGPLv2+ and BSD and MIT ? 350 using this pattern: //You can redistribute this code and/or modify it under //the terms of the GNU General Public License as published //by the Free Software Foundation; either version 2 of the //License, or (at your option) any later version 50 using this pattern (in source/shared_lib/sources/streflop/libm subdir): /* * * Copyright (C) 1993 by Sun Microsystems, Inc. All rights reserved. * * Developed at SunPro, a Sun Microsystems, Inc. business. * Permission to use, copy, modify, and distribute this * software is freely granted, provided that this notice * is preserved. * */ 10 using this pattern: Code released according to the GNU Lesser General Public License Heavily relies on GNU Libm, itself depending on netlib fplibm, GNU MP, and IBM MP lib. Uses SoftFloat too. part of source/shared_lib/sources/platform/macosx/NSFont_OpenGL.h that licensecheck says UNKNOWN [...] * This program is Copyright © 2002 Bryan L Blackburn. All rights reserved. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions are met: * * 1. Redistributions of source code must retain the above copyright notice, *this list of conditions and the following disclaimer. * 2. Redistributions in binary form must reproduce the above copyright notice, *this list of conditions and the following disclaimer in the documentation *and/or other materials provided with the distribution. * 3. Neither the names Bryan L Blackburn, Withay.com, nor the names of any *contributors may be used to endorse or promote products derived from this *software without specific prior written permission. [...] source/tools/merge_new_language_vars/merge_new_language_vars.pl: # utility for megaglest, probably works for glest and GAE too # merge new language variables from the main language (english) to all other language files # by olaus, 20101222 # license: GPL v3 source/tools/convert_faction_xml2html/convert_faction_xml2html.pl: # script to create HTML-pages and diagrams from the glest-factions techtree # 20110120, bugs feedback to ol...@rupp.de # license: GPLv3 or newer /** * File:g2xml.c * Written: Jonathan Merritt jmerr...@warpax.com * * Description: * Converts G3D format files into an XML representation. * * Copyright (C) Jonathan Merritt 2005. * This file may be distributed under the terms of the GNU General Public * License. */ source/tools/glexemel/g3d.dtd: !-- A DTD for describing an XML representation of G3D version 4 files. Created by Jonathan Merritt jmerr...@warpax.com Copyright (C) Jonathan Merritt 2005. This DTD may be distributed under the terms of the GNU General Public License. -- source/tools/glexemel/g3d_xml_exporter.py: ### # Glest Model / Texture / Animation Exporter # for the game Glest that you can find at http://www.glest.org # copyright 2005-2006 By Vincent Gadoury # Started Date: December 18 2005 Put Public Decembre 20 2005 # Ver: 1.0(Jan 30 2009) # Distributed under the GNU PUBLIC LICENSE # Based on g3d_support.py by Andreas Becker # and on glexemel by Jonathan Merritt ### source/tools/glexemel/g3dv4.h: /** * File: g3dv4.h * * Description: * Data types used by the G3D format. * * This file is copied from portions of the Glest project: * http://www.glest.org * * This file may be distributed under the terms of the GNU General Public * License. */ source/tools/glexemel/g3d_support_b260.py: ### # Glest Model / Texture / UV / Animation Importer and Exporter # for the Game Glest that u can find http://www.glest.org # copyright 2005 By Andreas Becker (seltsam...@yahoo.de) # # 2011/05/25: v0.1 alpha1 # modified by William Zheng for Blender 2.57(loveheaven_zheng...@hotmail.com) # # Started Date: 07 June 2005 Put Public 20 June 2005 # Distributed under the GNU PUBLIC LICENSE source/tools/glexemel/g3d_support_b257.py: source/tools/glexemel/g3d_support.py:
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
https://bugzilla.redhat.com/show_bug.cgi?id=817315 --- Comment #15 from pcpa paulo.cesar.pereira.de.andr...@gmail.com --- (In reply to comment #12) This doesn't build for now in rawhide: DEBUG: -- Found Lua library: /usr/lib64/liblua.so DEBUG: -- Found Lua headers: /usr/include DEBUG: CMake Error at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:97 (MESSAGE): DEBUG: Could NOT find JPEG (missing: JPEG_LIBRARY JPEG_INCLUDE_DIR) DEBUG: Call Stack (most recent call first): DEBUG: /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:288 (_FPHSA_FAILURE_MESSAGE) DEBUG: /usr/share/cmake/Modules/FindJPEG.cmake:31 (FIND_PACKAGE_HANDLE_STANDARD_ARGS) DEBUG: source/shared_lib/CMakeLists.txt:124 (FIND_PACKAGE) DEBUG: -- Configuring incomplete, errors occurred! DEBUG: RPM build errors: DEBUG: error: Bad exit status from /var/tmp/rpm-tmp.Sc90ca (%build) DEBUG: Bad exit status from /var/tmp/rpm-tmp.Sc90ca (%build) DEBUG: Child return code was: 1 I will proceed with the review of all the other items in the meanwhile. It should be missing some magic to find openjpeg headers or openjpeg cmake files. It builds in my computer, so, I will just also add turbojpeg-devel as build requires. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
https://bugzilla.redhat.com/show_bug.cgi?id=817315 --- Comment #16 from pcpa paulo.cesar.pereira.de.andr...@gmail.com --- Updated spec and srpm: Spec URL: http://kenobi.mandriva.com/~pcpa/megaglest.spec SRPM URL: http://kenobi.mandriva.com/~pcpa/megaglest-3.6.0.3-4.fc16.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
https://bugzilla.redhat.com/show_bug.cgi?id=817315 --- Comment #17 from pcpa paulo.cesar.pereira.de.andr...@gmail.com --- cutpaste fail... Spec URL: http://fedorapeople.org/~pcpa/megaglest.spec SRPM URL: http://fedorapeople.org/~pcpa/megaglest-3.6.0.3-4.fc16.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
https://bugzilla.redhat.com/show_bug.cgi?id=817315 --- Comment #18 from pcpa paulo.cesar.pereira.de.andr...@gmail.com --- sorry again, I blame today being Friday 13th (use fc18) Spec URL: http://fedorapeople.org/~pcpa/megaglest.spec SRPM URL: http://fedorapeople.org/~pcpa/megaglest-3.6.0.3-4.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
https://bugzilla.redhat.com/show_bug.cgi?id=817315 --- Comment #19 from Simone Caronni negativ...@gmail.com --- Created attachment 598112 -- https://bugzilla.redhat.com/attachment.cgi?id=598112action=edit SPEC file patch -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
https://bugzilla.redhat.com/show_bug.cgi?id=817315
--- Comment #20 from Simone Caronni negativ...@gmail.com ---
Hello,
a couple of other issues regarding BuildRequires, I have attached a patch that
corrects the following:
1) The jpeg dependency is wrong, it is not turbojpeg-devel but
libjpeg-turbo-devel, only this way the turbojpeg headers are installed.
2) The command desktop-file-validate is part of desktop-file-utils, so that
needs to be a requirement as well.
3) The %{_iconsdir} macro is not evaluated unless you install the
jpackage-utils, here is the failure of the build in koji, look at the bottom:
http://kojipkgs.fedoraproject.org//work/tasks/8581/4238581/build.log
So if you want to use macros such as %{_iconsdir}, BuildRequires:
jpackage-utils is needed to make it sure that /etc/rpm/macros.jpackage surely
exists.
However
- This package does not seem to be related to Java
- So adding BR: jpackage-utils just to define %{_iconsdir} is not desired
- Also almost all packages on Fedora install files under %{_datadir}/icons/
So replacing %{_iconsdir} with %{_datadir}/icons is much preferable.
A simple 's|%{_iconsdir}|%{_datadir}/icons|g' in the spec file fixes the issue.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
https://bugzilla.redhat.com/show_bug.cgi?id=817315 --- Comment #21 from Simone Caronni negativ...@gmail.com --- Koji scratch build with the patch applied: http://koji.fedoraproject.org/koji/taskinfo?taskID=4238596 I have a request, I see miniupnpc and libircclient are both already built for f16 and f17, can you please push those two and megaglest, megaglest-data at least to f17 when the package is approved? If you need help with updates/bodhi please let me know. Thanks, --Simone -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
https://bugzilla.redhat.com/show_bug.cgi?id=817315 --- Comment #22 from Thomas Spura toms...@fedoraproject.org --- (In reply to comment #13) [x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. I kind of doubt that... Are you sure, that GPLv3+ as only license is enought? Just as examble: MD5 Model License permission - Doom 3's MD5 Viewer from [1] is bundled into megaglest and some other files look fishy. https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries $ licensecheck -r . | grep -v UNKNOWN | grep -v GPL (v3 or later) | wc 65 3555635 Directly 65 files to check explicitely... [1] http://tfc.duke.free.fr/ -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
https://bugzilla.redhat.com/show_bug.cgi?id=817315 --- Comment #11 from Simone Caronni negativ...@gmail.com --- I will review this package -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
https://bugzilla.redhat.com/show_bug.cgi?id=817315 Simone Caronni negativ...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
https://bugzilla.redhat.com/show_bug.cgi?id=817315 Simone Caronni negativ...@gmail.com changed: What|Removed |Added Status|ASSIGNED|NEW --- Comment #12 from Simone Caronni negativ...@gmail.com --- This doesn't build for now in rawhide: DEBUG: -- Found Lua library: /usr/lib64/liblua.so DEBUG: -- Found Lua headers: /usr/include DEBUG: CMake Error at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:97 (MESSAGE): DEBUG: Could NOT find JPEG (missing: JPEG_LIBRARY JPEG_INCLUDE_DIR) DEBUG: Call Stack (most recent call first): DEBUG: /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:288 (_FPHSA_FAILURE_MESSAGE) DEBUG: /usr/share/cmake/Modules/FindJPEG.cmake:31 (FIND_PACKAGE_HANDLE_STANDARD_ARGS) DEBUG: source/shared_lib/CMakeLists.txt:124 (FIND_PACKAGE) DEBUG: -- Configuring incomplete, errors occurred! DEBUG: RPM build errors: DEBUG: error: Bad exit status from /var/tmp/rpm-tmp.Sc90ca (%build) DEBUG: Bad exit status from /var/tmp/rpm-tmp.Sc90ca (%build) DEBUG: Child return code was: 1 I will proceed with the review of all the other items in the meanwhile. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
https://bugzilla.redhat.com/show_bug.cgi?id=817315
--- Comment #13 from Simone Caronni negativ...@gmail.com ---
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
Generic
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[!]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
Note: The package did not built BR could therefore not be checked or the
package failed to build because of missing BR
[x]: MUST Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
[x]: MUST Large documentation files are in a -doc subpackage, if required.
[!]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[!]: MUST License field in the package spec file matches the actual license.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
names).
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[!]: MUST Package must own all directories that it creates.
[!]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint output is silent.
[!]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
/home/slaanesh/Documents/fedora/817315/megaglest-source-3.6.0.3.tar.xz :
MD5SUM this package : 5a4a2429435031d9f9cc5d9535a9de9d
MD5SUM upstream package : 36427c1fce8e23911d9a5ca563770af8
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[x]: MUST Useful -debuginfo package or justification otherwise.
[!]: SHOULD Reviewer should test that the package builds in mock.
[-]: SHOULD If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to
include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[x]: SHOULD Package functions as described.
[x]: SHOULD Latest version is packaged.
[x]: SHOULD Package does not include license text files separate from
upstream.
[x]: SHOULD Patches link to upstream bugs/comments/lists or are otherwise
justified.
[x]: SHOULD SourceX / PatchY prefixed with %{name}.
[x]: SHOULD SourceX is a working URL.
[-]: SHOULD Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: SHOULD Package should compile and build into binary rpms on all supported
architectures.
[-]: SHOULD %check is present and all tests pass.
[x]: SHOULD Packages should try to preserve timestamps of original installed
files.
[x]: SHOULD Spec use %global instead of %define.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
https://bugzilla.redhat.com/show_bug.cgi?id=817315
--- Comment #14 from Simone Caronni negativ...@gmail.com ---
Issues:
[!]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[!]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
Note: The package did not built BR could therefore not be checked or the
package failed to build because of missing BR
[!]: SHOULD Reviewer should test that the package builds in mock.
Currently it doesn't build. Dependencies are ok, but the build does not
succeed, see comment #12.
[!]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[!]: MUST License field in the package spec file matches the actual license.
There's no license file packaged in the %doc directive, but is correctly
shipped inside the archive. Please add the following to the %files section:
%files
%doc AUTHORS.source_code.txt
%doc CHANGELOG.txt
%doc COPYRIGHT.source_code.txt
%doc gnu_gpl_3.0.txt
%doc README.txt
Release management and compiling docs are not useful inside the pre-compiled
binary rpm we'll be installing.
[!]: MUST Package must own all directories that it creates.
[!]: MUST Package does not own files or directories owned by other packages.
The files section relies on files in the megaglest folder, by adding the
megagles folder itself you ensure the directory is owned by the base megaglest
package and the megaglest-data package can rely on it for installing. See the
other review for the details.
%files
%{_datadir}/megaglest
[!]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
http://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net
As per the megaglest-data review, the sourceforge url downloads an html file,
according to the packaging guidelines sourceforge urls' should be explicitly
declared as in the packaging guidelines.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
https://bugzilla.redhat.com/show_bug.cgi?id=817315 Simone Caronni negativ...@gmail.com changed: What|Removed |Added CC||negativ...@gmail.com Assignee|nob...@fedoraproject.org|negativ...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
https://bugzilla.redhat.com/show_bug.cgi?id=817315 Bug 817315 depends on bug 817311, which changed state. Bug 817311 Summary: Review Request: miniupnpc - Library and tool to control NAT in UPnP-enabled routers https://bugzilla.redhat.com/show_bug.cgi?id=817311 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
https://bugzilla.redhat.com/show_bug.cgi?id=817315 Bug 817315 depends on bug 817306, which changed state. Bug 817306 Summary: Review Request: libircclient - C library to create IRC clients https://bugzilla.redhat.com/show_bug.cgi?id=817306 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
https://bugzilla.redhat.com/show_bug.cgi?id=817315 Michael Schwendt mschwe...@gmail.com changed: What|Removed |Added Depends On||828544 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
https://bugzilla.redhat.com/show_bug.cgi?id=817315 Simone Caronni negativ...@gmail.com changed: What|Removed |Added CC||negativ...@gmail.com --- Comment #8 from Simone Caronni negativ...@gmail.com --- Hello, have you filed the review for megaglest-data? I would like to review them. Regards, --Simone -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
https://bugzilla.redhat.com/show_bug.cgi?id=817315 --- Comment #9 from pcpa paulo.cesar.pereira.de.andr...@gmail.com --- (In reply to comment #8) Hello, Hi, have you filed the review for megaglest-data? I would like to review them. I will update the request tonight and make a proper megaglest-data review request, as now the remaining build requires (miniupnpc) was added to scm. I plan to submit it to fedora 16, 17 and rawhide. Regards, --Simone -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
https://bugzilla.redhat.com/show_bug.cgi?id=817315 --- Comment #10 from pcpa paulo.cesar.pereira.de.andr...@gmail.com --- Package was updated now that build requires are available. Some issues were corrected after experience with previous reviews :-) Added a new patch to build with gcc 4.7. Spec URL: http://fedorapeople.org/~pcpa/megaglest.spec SRPM URL: http://fedorapeople.org/~pcpa/megaglest-3.6.0.3-3.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=817315 --- Comment #7 from Thomas Spura toms...@fedoraproject.org 2012-05-03 03:50:36 EDT --- (In reply to comment #6) I updated the package, changelog, as well as bump release :-) to match the changes after reviews for libircclient and miniupnpc. Great :) The only question I have about bumping release, is that would not it be better to have a pattern of starting with 0.1 ... 0.9x and then bump to 1 when package is considered ok? No. 0.1 ... and up is for prereleases, e.g. when you package megaglest-3.6.1 (which might be available in the upstream repository, but is not released yet). More here: http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Package_Versioning megaglest-data.spec not modified. I guess, you need another review request for megaglest-data, as that's a differenc spec/package. But better revisit that, when the current dependencies are in. (As upstream releases both in separate packages, it might be best to do it that way too...) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=817315 --- Comment #6 from pcpa paulo.cesar.pereira.de.andr...@gmail.com 2012-05-02 20:32:07 EDT --- I updated the package, changelog, as well as bump release :-) to match the changes after reviews for libircclient and miniupnpc. The only question I have about bumping release, is that would not it be better to have a pattern of starting with 0.1 ... 0.9x and then bump to 1 when package is considered ok? megaglest-data.spec not modified. New spec and srpm: Spec URL: http://kenobi.mandriva.com/~pcpa/megaglest.spec SRPM URL: http://kenobi.mandriva.com/~pcpa/megaglest-3.6.0.3-2.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=817315 --- Comment #4 from pcpa paulo.cesar.pereira.de.andr...@gmail.com 2012-05-01 14:30:59 EDT --- I uploaded a newer megaglest spec and srpm on top of the previous ones, as now, with a shared libircclient, it is no longer required to apply the openssl patch. I will work on making some reviews as Jerry James suggested some packages for me to review, as he is also interested in a working sagemath package in Fedora. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=817315 --- Comment #5 from Thomas Spura toms...@fedoraproject.org 2012-05-01 15:16:06 EDT --- (In reply to comment #4) I uploaded a newer megaglest spec and srpm on top of the previous ones, as now, with a shared libircclient, it is no longer required to apply the openssl patch. As written in the other bug. Always bump the release, add a changelog entry etc... I will work on making some reviews as Jerry James suggested some packages for me to review, as he is also interested in a working sagemath package in Fedora. Great! I was too, but as it was VERY complicated with linbox/givario I gave up partly and am only using ipython and own scripts to do the work... But maybe that'll change again, who knows ;) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=817315 --- Comment #2 from pcpa paulo.cesar.pereira.de.andr...@gmail.com 2012-04-30 13:45:20 EDT --- I already made a block in FE-NEEDSPONSOR for another package https://bugzilla.redhat.com/show_bug.cgi?id=815624 and preferred not to spam it, but thanks for adding the block in the other packages :-) I did package megaglest very quickly in Fedora 16, just to have a feeling of packaging something larger, but still somewhat simple to package. What I am really interested is in contributing to The Science and Technology Special Interest Group. I made some informal package review requests, suggested some patches, contacted upstream, etc for a quite larger task, that is to package sagemath in Fedora (I did package and maintain sagemath in Mandriva for several years). I made quite a lot of comments recently in http://lists.fedoraproject.org/pipermail/scitech/2012-April/thread.html -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=817315 --- Comment #3 from Thomas Spura toms...@fedoraproject.org 2012-04-30 15:56:58 EDT --- (In reply to comment #2) I already made a block in FE-NEEDSPONSOR for another package https://bugzilla.redhat.com/show_bug.cgi?id=815624 Didn't saw that one (The list of review requests is quite large at the moment...). and preferred not to spam it, but thanks for adding the block in the other packages :-) There is no other way than that to get wider attention and inform reviewers of not being a sponsor ;) I did package megaglest very quickly in Fedora 16, just to have a feeling of packaging something larger, but still somewhat simple to package. Your packages look fine so far. What I am really interested is in contributing to The Science and Technology Special Interest Group. I made some informal package review requests, suggested some patches, contacted upstream, etc for a quite larger task, that is to package sagemath in Fedora (I did package and maintain sagemath in Mandriva for several years). I made quite a lot of comments recently in http://lists.fedoraproject.org/pipermail/scitech/2012-April/thread.html That is not a informal review, others should review your packages, but you didn't review other requests so far ;) That's described here: http://fedoraproject.org/wiki/Package_Review_Process#Reviewer I'd highly suggest you to do some reviews to get further familiar with the process, but I'll sponsor you now for libircclient (as soon that's ready) as your spec files look fine. Don't hesitate to ask, if you have further questions. (Here or via mail) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=817315 Thomas Spura toms...@fedoraproject.org changed: What|Removed |Added Depends on||817306 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=817315 Thomas Spura toms...@fedoraproject.org changed: What|Removed |Added Depends on||817311 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=817315 Thomas Spura toms...@fedoraproject.org changed: What|Removed |Added CC||toms...@fedoraproject.org --- Comment #1 from Thomas Spura toms...@fedoraproject.org 2012-04-29 10:50:27 EDT --- You are not yet a packager and want become one, is that right? To become one you should block FE-NEEDSPONSOR, so sponsors will find you. More information on how to get sponsored: http://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group#Submitting_quality_new_packages It would be great, when you'd do some informal reviews of other packages (if you haven'd done yet) and link them in your three reviews. More information here: http://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group#Reviewing_packages As this package needs the other two packages, I'll block FE-NEEDSPONSOR only in the other two ones. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
