[Bug 818718] Review Request: drupal6-fivestar - Five Star Module for Drupal6
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=818718 --- Comment #11 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HP31wbYSixa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 818718] Review Request: drupal6-fivestar - Five Star Module for Drupal6
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=818718 Shawn Iwinski shawn.iwin...@gmail.com changed: What|Removed |Added CC||shawn.iwin...@gmail.com Flags|fedora-cvs+ | Flags||fedora-cvs? --- Comment #10 from Shawn Iwinski shawn.iwin...@gmail.com --- Package Change Request == Package Name: drupal6-fivestar New Branches: el5 Owners: ansilva siwinski InitialCC: Adding el5 branch to follow most other drupal6 packages. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wcOkko7Qwea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 818718] Review Request: drupal6-fivestar - Five Star Module for Drupal6
https://bugzilla.redhat.com/show_bug.cgi?id=818718 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- drupal6-fivestar-1.20-2.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 818718] Review Request: drupal6-fivestar - Five Star Module for Drupal6
https://bugzilla.redhat.com/show_bug.cgi?id=818718 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2012-05-26 18:07:53 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- drupal6-fivestar-1.20-2.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 818718] Review Request: drupal6-fivestar - Five Star Module for Drupal6
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=818718 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #7 from Fedora Update System upda...@fedoraproject.org 2012-05-11 06:28:55 EDT --- drupal6-fivestar-1.20-2.fc16 has been pushed to the Fedora 16 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 818718] Review Request: drupal6-fivestar - Five Star Module for Drupal6
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=818718 --- Comment #3 from Jon Ciesla limburg...@gmail.com 2012-05-10 08:29:18 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 818718] Review Request: drupal6-fivestar - Five Star Module for Drupal6
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=818718 --- Comment #4 from Fedora Update System upda...@fedoraproject.org 2012-05-10 15:33:10 EDT --- drupal6-fivestar-1.20-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/drupal6-fivestar-1.20-2.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 818718] Review Request: drupal6-fivestar - Five Star Module for Drupal6
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=818718 --- Comment #5 from Fedora Update System upda...@fedoraproject.org 2012-05-10 15:37:15 EDT --- drupal6-fivestar-1.20-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/drupal6-fivestar-1.20-2.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 818718] Review Request: drupal6-fivestar - Five Star Module for Drupal6
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=818718 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|NEW |MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 818718] Review Request: drupal6-fivestar - Five Star Module for Drupal6
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=818718 --- Comment #6 from Fedora Update System upda...@fedoraproject.org 2012-05-10 15:38:29 EDT --- drupal6-fivestar-1.20-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/drupal6-fivestar-1.20-2.fc17 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 818718] Review Request: drupal6-fivestar - Five Star Module for Drupal6
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=818718
Wesley Hearn whe...@redhat.com changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #1 from Wesley Hearn whe...@redhat.com 2012-05-09 12:31:41 EDT ---
[OK] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
Fedora 16 Mock:
[12:18 PM]
[0]whearn@Desktop:/var/lib/mock/fedora-16-x86_64/result $ rpmlint
drupal6-fivestar-1.20-1.fc16.*
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
Fedora 17 Mock:
[12:19 PM]
[0]whearn@Desktop:/var/lib/mock/fedora-17-x86_64/result $ rpmlint
drupal6-fivestar-1.20-1.fc17.*
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
RHEL 6 Mock:
[12:20 PM]
[0]whearn@Desktop:/var/lib/mock/epel-6-x86_64/result $ rpmlint
drupal6-fivestar-1.20-1.el6.*
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
[OK] MUST: The package must be named according to the Package Naming Guidelines
.
[OK] MUST: The spec file name must match the base package %{name}, in the
format %{name}.spec unless your package has an exemption.
[OK] MUST: The package must meet the Packaging Guidelines .
[OK] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .
[OK] MUST: The License field in the package spec file must match the actual
license.
[SHOULD] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[OK] MUST: The spec file must be written in American English.
[OK] MUST: The spec file for the package MUST be legible.
[OK] MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use md5sum for this task.
If no upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
[12:04 PM]
[0]whearn@Desktop:~/rpmbuild/SOURCES $ md5sum fivestar-6.x-1.20.tar.gz
b94b84f96c0c5ebeb9440c3fb1bdbbff fivestar-6.x-1.20.tar.gz
[12:05 PM]
[0]whearn@Desktop:~/rpmbuild/SOURCES $ curl
http://ftp.drupal.org/files/projects/fivestar-6.x-1.20. ↳ tar.gz | md5sum
-
% Total% Received % Xferd Average Speed TimeTime Time
Current
Dload Upload Total SpentLeft Speed
100 78492 100 784920 0 147k 0 --:--:-- --:--:-- --:--:--
196k
b94b84f96c0c5ebeb9440c3fb1bdbbff -
[OK] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[OK] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[OK] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[OK] MUST: The spec file MUST handle locales properly. This is done by using
the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[OK] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
[OK] MUST: Packages must NOT bundle copies of system libraries.
[OK] MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[OK] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[OK] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations)
[OK] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example.
[OK] MUST: Each package must consistently use macros.
[OK] MUST: The package must contain code, or permissable content.
[OK] MUST: Large documentation files must go in a -doc subpackage. (The
definition of large is left up to the packager's best judgement, but is not
restricted to size. Large can refer to
[Bug 818718] Review Request: drupal6-fivestar - Five Star Module for Drupal6
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=818718 Anderson Silva ansi...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #2 from Anderson Silva ansi...@redhat.com 2012-05-09 17:20:42 EDT --- New Package SCM Request === Package Name: drupal6-fivestar Short Description: Adds a clean, attractive voting widget to nodes in Drupal6 Owners: afsilva Branches: f16 f17 el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 818718] Review Request: drupal6-fivestar - Five Star Module for Drupal6
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=818718 Wesley Hearn whe...@redhat.com changed: What|Removed |Added CC||whe...@redhat.com AssignedTo|nob...@fedoraproject.org|whe...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
