[Bug 819134] Review Request: python-okaara - python command line user interface development library

2014-02-10 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=819134

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 819134] Review Request: python-okaara - python command line user interface development library

2014-02-10 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=819134



--- Comment #26 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 819134] Review Request: python-okaara - python command line user interface development library

2014-02-10 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=819134

Alex Wood  changed:

   What|Removed |Added

 CC||aw...@redhat.com
  Flags|fedora-cvs+ |fedora-cvs?



--- Comment #25 from Alex Wood  ---
Package Change Request
==
Package Name: python-okaara
New Branches: el5 el6 epel7
Owners: awood jdob

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 819134] Review Request: python-okaara - python command line user interface development library

2012-07-17 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=819134

Jay Dobies  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2012-07-17 12:35:51

--- Comment #24 from Jay Dobies  ---
Builds completed in koji, closing as per the new package process guidelines.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 819134] Review Request: python-okaara - python command line user interface development library

2012-07-13 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=819134

--- Comment #23 from Jason Tibbitts  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 819134] Review Request: python-okaara - python command line user interface development library

2012-07-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=819134

Jay Dobies  changed:

   What|Removed |Added

  Flags||fedora-cvs?

--- Comment #22 from Jay Dobies  ---
New Package SCM Request
===
Package Name: python-okaara
Short Description: Library of Python functions that facilitate the creation of
command-line interfaces.
Owners: jdob
Branches: f16 f17
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 819134] Review Request: python-okaara - python command line user interface development library

2012-07-10 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=819134

Jason Tibbitts  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |
  Flags|fedora-review?  |fedora-review+

--- Comment #21 from Jason Tibbitts  ---
OK, cool.  Builds fine, and the tests appear to pass:
  Ran 12 tests in 0.011s
  OK

All complaints I had are fixed, so we're done.  I've sponsored you, and once
the permissions propagate you should be able to make your SCM request and get
this imported and build.

If you need assistance during the process, feel free to contact me on IRC in
#fedora-devel, or via email.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 819134] Review Request: python-okaara - python command line user interface development library

2012-07-09 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=819134

Jay Dobies  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|ti...@math.uh.edu

--- Comment #20 from Jay Dobies  ---
I have no idea how I did that. I changed it back to you.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 819134] Review Request: python-okaara - python command line user interface development library

2012-07-09 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=819134

--- Comment #19 from Jason Tibbitts  ---
Why did you reset the owner of this ticket to nobody?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 819134] Review Request: python-okaara - python command line user interface development library

2012-07-09 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=819134

Jay Dobies  changed:

   What|Removed |Added

   Assignee|ti...@math.uh.edu   |nob...@fedoraproject.org

--- Comment #18 from Jay Dobies  ---
I had python path set up on my machine and forgot to add it to %check. This
time I built to a new guest and the tests ran ok.

Spec URL: http://jdob.fedorapeople.org/okaara-src/python-okaara.spec
SRPM URL:
http://jdob.fedorapeople.org/okaara-src/python-okaara-1.0.21-1.fc17.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 819134] Review Request: python-okaara - python command line user interface development library

2012-07-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=819134

--- Comment #17 from Jason Tibbitts  ---
Hmm, this doesn't build for me:

+ nosetests
E
==
ERROR: Failure: ImportError (No module named okaara.prompt)
--
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/nose/loader.py", line 390, in
loadTestsFromName
addr.filename, addr.module)
  File "/usr/lib/python2.7/site-packages/nose/importer.py", line 39, in
importFromPath
return self.importFromDir(dir_path, fqname)
  File "/usr/lib/python2.7/site-packages/nose/importer.py", line 86, in
importFromDir
mod = load_module(part_fqname, fh, filename, desc)
  File "/builddir/build/BUILD/python-okaara-1.0.20/test/test_prompt.py", line
13, in 
import okaara.prompt
ImportError: No module named okaara.prompt
--
Ran 1 test in 0.003s
FAILED (errors=1)
error: Bad exit status from /var/tmp/rpm-tmp.lNKZ7r (%check)


Everything else looks good, though the comments are kind of funny.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 819134] Review Request: python-okaara - python command line user interface development library

2012-07-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=819134

--- Comment #16 from Jay Dobies  ---
Changes:
- Removed the %defattr line under %files
- Added a %check section to run unit tests
- Removed the python requires line; I checked and RHEL5 automatically adds an
abi requirement

I saw the guidelines section about conditionalizing the site macro but based on
your last comment I didn't change what I had originally.

Spec URL: http://jdob.fedorapeople.org/okaara-src/python-okaara.spec
SRPM URL:
http://jdob.fedorapeople.org/okaara-src/python-okaara-1.0.20-1.fc17.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 819134] Review Request: python-okaara - python command line user interface development library

2012-07-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=819134

--- Comment #15 from Jason Tibbitts  ---
Reading things more closely, I was wrong about the need to conditionalize that
puthon_sitelib macro on EL5.  The guidelines show a (complex) conditional for
that, but the way the macro is defined, it only kicks in if it's not already
defined so everything is fine.  Those guidelines really need a cleanup.

Still don't know if the python(abi) thing gets automatically done on EL5.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 819134] Review Request: python-okaara - python command line user interface development library

2012-07-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=819134

--- Comment #14 from Jason Tibbitts  ---
The whole bit is this:

X final provides and requires are sane:
   python-okaara = 1.0.19-1.fc18
  =
X  python >= 2.4
   python(abi) = 2.7

indicating that the needless "python >= 2.4" dependency is the issue here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 819134] Review Request: python-okaara - python command line user interface development library

2012-07-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=819134

--- Comment #13 from Jay Dobies  ---
I realized that too, I only requested Fedora branches because I didn't think
our need for RHEL5 mattered for this process. Now I know :)

I will check on the sitelib macro and, at worst case, add a RHEL5 condition for
it. I'll also add in the unit tests.

The only other one I'm unsure of is:
X final provides and requires are sane:
 python-okaara = 1.0.19-1.fc18

I checked the guidelines and I see a section about filtering out the
auto-generated provides, but I'm not sure what's wrong with how it's set up
today. Can you give me a little more detail on that issue?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 819134] Review Request: python-okaara - python command line user interface development library

2012-07-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=819134

--- Comment #12 from Jason Tibbitts  ---
No, they don't hurt anything; they're just useless in Fedora.  You only
requested fedora branches so I made the easy assumption that the stuff wasn't
necessary.  Personally I can't stand the stone-age complexity that supporting
ancient stuff like EL5 requires, don't want it in any of my packages and avoid
reviewing things that include it, but it's your package and I'm already
committed.

You still need to conditionalize at least the python_sitelib macro to kick in
only on EL5 as documented in the python packaging guidelines.  I thought that
the explicit python dependency was unnecessary even on EL5 (it's not mentioned
anywhere in the python guidelines) but I have no real way of knowing since I
only use Fedora.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 819134] Review Request: python-okaara - python command line user interface development library

2012-07-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=819134

--- Comment #11 from Jay Dobies  ---
Question about how to handle the RHEL5 pieces. This project is in use by Red
Hat and needs to be built for RHEL5 (this also explains the >= 2.4 line). Is
the proper way to handle this to leave these items in the spec since (I
believe) they aren't harming anything in Fedora or do I have to create a
separate spec for RHEL5 only builds?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 819134] Review Request: python-okaara - python command line user interface development library

2012-07-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=819134

Jason Tibbitts  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|ti...@math.uh.edu
  Flags||fedora-review?

--- Comment #10 from Jason Tibbitts  ---
OK, I'll do a full review and assign it back to jortel when I'm done so he gets
the credit.  Given that I know you're only packaging this for f16 and up, I'll
review based on that.  Unfortunately the previous review missed several things,
so I have some more comments.

The python_sitelib macro definition is unnecessary in Fedora (only EL5 needs
it)

BuildRoot is unnecessary in Fedora, as is the first line of %install, the
entire %clean section and the %defattr line in %files.  (Only EL5 needs the
first three; the latter is completely unnecessary.)

The Requires: python >= 2.4 line is unnecessary and somewhat misleading to
boot.  RPM will add a proper python(abi) dependency, and a package built for
f17 or rawhide won't install on something with only python 2.4 anyway.

Is your personal fedoraprople.org site the proper source for the tarball?  It
appears that you are the upstream but it seems odd.

There's some kind of test available.  Is it possible to run it in a %check
section?  

* source files match upstream.  sha256sum:
  bfba715817a7806b1f3ad62e0df0321de72aa0e549853d039eda951bfc2b
   python-okaara-1.0.19.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
X final provides and requires are sane:
   python-okaara = 1.0.19-1.fc18
  =
X  python >= 2.4
   python(abi) = 2.7

? %check is not present but there appears to be some sort of test suite.
* no bundled libraries.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 819134] Review Request: python-okaara - python command line user interface development library

2012-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=819134

Jason Tibbitts  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
 Blocks||177841 (FE-NEEDSPONSOR)
   Assignee|jor...@redhat.com   |nob...@fedoraproject.org
  Flags|fedora-review+  |

--- Comment #9 from Jason Tibbitts  ---
Fixing up this ticket because the submitter never indicated that sponsorship
was needed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 819134] Review Request: python-okaara - python command line user interface development library

2012-06-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=819134

--- Comment #8 from Jon Ciesla  ---
jdob is not a FAS account in the Packager group.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 819134] Review Request: python-okaara - python command line user interface development library

2012-06-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=819134

Jeff Ortel  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Flags||fedora-cvs?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 819134] Review Request: python-okaara - python command line user interface development library

2012-06-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=819134

Jeff Ortel  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 819134] Review Request: python-okaara - python command line user interface development library

2012-06-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=819134

--- Comment #7 from Jay Dobies  ---
New Package SCM Request
===
Package Name: python-okaara
Short Description: Library of Python functions that facilitate the creation of
command-line interfaces.
Owners: jdob
Branches: f16 f17
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 819134] Review Request: python-okaara - python command line user interface development library

2012-06-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=819134

Jeff Ortel  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Flags|fedora-review?  |fedora-review+

--- Comment #6 from Jeff Ortel  ---
Changes verified.

rpmlint:

[jortel@localhost pulp]$ rpmlint python-okaara-1.0.19-1.fc16.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

[jortel@localhost noarch]$ rpmlint python-okaara-1.0.19-1.fc16.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Package Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 819134] Review Request: python-okaara - python command line user interface development library

2012-05-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=819134

--- Comment #5 from Jay Dobies  ---
%define -> %global change made:

Spec URL: http://jdob.fedorapeople.org/okaara-src/python-okaara.spec
SRPM URL:
http://jdob.fedorapeople.org/okaara-src/python-okaara-1.0.19-1.fc16.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 819134] Review Request: python-okaara - python command line user interface development library

2012-05-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=819134

--- Comment #4 from Jeff Ortel  2012-05-18 17:50:46 EDT ---
Thanks Jay.  One last thing. At the beginning of the .spec, you used %define to
define the python_sitelib if not already defined.  The Packaging Guidelines
request that packagers use %global instead of %define for global macros.

http://fedoraproject.org/wiki/Packaging:Guidelines
see: "%global preferred over %define"

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 819134] Review Request: python-okaara - python command line user interface development library

2012-05-18 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=819134

--- Comment #3 from Jay Dobies  2012-05-18 11:30:30 
EDT ---
Changes made based on reviewer feedback and uploaded to the following
locations:

Spec URL: http://jdob.fedorapeople.org/okaara-src/python-okaara.spec
SRPM URL:
http://jdob.fedorapeople.org/okaara-src/python-okaara-1.0.18-1.fc16.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 819134] Review Request: python-okaara - python command line user interface development library

2012-05-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=819134

--- Comment #2 from Jeff Ortel  2012-05-16 17:29:47 EDT ---
Packaging looks good Jay.  Few minor items:

1) Should have a copy of the license should be included in the source and
referenced in the %doc.  See:
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text

2) Python packaging guidelines specifies python packages containing python2
source must have: BuildRequires: python2-devel.  See:
http://fedoraproject.org/wiki/Packaging:Python 

3) Suggest:
%files
%defattr(-,root,root,-)
- %{python_sitelib}/okaara/*
+ %{python_sitelib}/okaara/

Which will catch subdirectories under okaara if you refactor.



== MUST ==

[x] rpmlint must be run on the source rpm and all binary rpms the build
produces.

$ rpmlint python-okaara-1.0.17-1.fc16.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint python-okaara-1.0.17-1.fc16.noarch.rpm
python-okaara.noarch: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

[x] The package must be named according to the Package Naming Guidelines.
[x] The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[x] The package must meet the Packaging Guidelines.

[x] The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines.
[x] The License field in the package spec file must match the actual license.
[x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.

A copy of the license should be included in the source and referenced in the
%doc.

Suggest as LICENSE file at source root and add:
%doc LICENSE

See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text

[x] The spec file must be written in American English.
[x] The spec file for the package MUST be legible.
[x] The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
[x] The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
[x] If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.

[x] All build dependencies must be listed in BuildRequires, except for any that
are listed in the exceptions section of the Packaging Guidelines ; inclusion of
those as BuildRequires is optional. Apply common sense.

Need: BuildRequires: python2-devel

See: http://fedoraproject.org/wiki/Packaging:Python 

[x] The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[x] Every binary RPM package (or subpackage) which stores shared library files
(not just symlinks) in any of the dynamic linker's default paths, must call
ldconfig in %post and %postun.
[x] Packages must NOT bundle copies of system libraries.
[x] If the package is designed to be relocatable, the packager must state this
fact in the request for review, along with the rationalization for relocation
of that specific package. Without this, use of Prefix: /usr is considered a
blocker.
[x] A package must own all directories that it creates. If it does not create a
directory that it uses, then it should require a package which does create that
directory. 
[x] A Fedora package must not list a file more than once in the spec file's
%files listings. (Notable exception: license texts in specific situations)
[x] Permissions on files must be set properly. Executables should be set with
executable permissions, for example. 
[x] Each package must consistently use macros. 
[x] The package must contain code, or permissable content. 
[x] Large documentation files must go in a -doc subpackage. (The definition of
large is left up to the packager's best judgement, but is not restricted to
size. Large can refer to either size or quantity). 
[x] If a package includes something as %doc, it must not affect the runtime of
the application. To summarize: If it is in %doc, the program must run properly
if it is not present.
[x] Static libraries must be in a -static package.
[x] Development files must be in a -devel package.
[x] In the vast majority of cases, devel packages must require the base package
using a fully versioned dependency: Requires: %{name}%{?_isa} =
%{version

[Bug 819134] Review Request: python-okaara - python command line user interface development library

2012-05-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=819134

--- Comment #1 from Jay Dobies  2012-05-11 15:48:28 
EDT ---
Changes made based on reviewer feedback and uploaded to the following
locations:

Spec URL: http://jdob.fedorapeople.org/okaara-src/python-okaara.spec
SRPM URL:
http://jdob.fedorapeople.org/okaara-src/python-okaara-1.0.17-1.fc16.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 819134] Review Request: python-okaara - python command line user interface development library

2012-05-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=819134

Jeff Ortel  changed:

   What|Removed |Added

 CC||jor...@redhat.com
 AssignedTo|nob...@fedoraproject.org|jor...@redhat.com
   Flag||fedora-review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review