[Bug 819844] Review Request: luarocks - A deployment and management system for Lua modules
https://bugzilla.redhat.com/show_bug.cgi?id=819844 --- Comment #16 from Fedora Update System upda...@fedoraproject.org --- luarocks-2.0.8-2.el5 has been pushed to the Fedora EPEL 5 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819844] Review Request: luarocks - A deployment and management system for Lua modules
https://bugzilla.redhat.com/show_bug.cgi?id=819844 --- Comment #17 from Fedora Update System upda...@fedoraproject.org --- luarocks-2.0.8-2.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819844] Review Request: luarocks - A deployment and management system for Lua modules
https://bugzilla.redhat.com/show_bug.cgi?id=819844 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- luarocks-2.0.8-2.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819844] Review Request: luarocks - A deployment and management system for Lua modules
https://bugzilla.redhat.com/show_bug.cgi?id=819844 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2012-05-20 19:55:12 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- luarocks-2.0.8-2.fc16 has been pushed to the Fedora 16 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819844] Review Request: luarocks - A deployment and management system for Lua modules
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=819844
Ralph Bean rb...@redhat.com changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #6 from Ralph Bean rb...@redhat.com 2012-05-11 09:10:09 EDT ---
Packaged is APPROVED
Issues (not a MUST):
[!]: SHOULD %check is present and all tests pass.
- There is a test/run_tests.sh script, but I wasn't able to run it by hand.
This would be good to include in %check if you can get it to work.
That aside, I did verify that the installed program worked as expected.
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
Generic
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST %config files are marked noreplace or the reason is justified.
[x]: MUST Each %files section contains %defattr if rpm 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[-]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf is only needed if supporting EPEL5
[x]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
Note: Licenses found: *No copyright* UNKNOWN For detailed output of
licensecheck see file: /home/threebean/reviews/819844/licensecheck.txt
[x]: MUST Package consistently uses macros (instead of hard-coded directory
names).
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST No %config files under /usr.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint output is silent.
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
/home/threebean/reviews/819844/luarocks-2.0.8.tar.gz :
MD5SUM this package : 07cf84e352d86fe161f7b2ec43f360cc
MD5SUM upstream package : 07cf84e352d86fe161f7b2ec43f360cc
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[-]: MUST Useful -debuginfo package or justification otherwise.
[x]: SHOULD Reviewer should test that the package builds in mock.
[x]: SHOULD If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to
include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[x]: SHOULD Package functions as described.
[x]: SHOULD Latest version is packaged.
[x]: SHOULD Package does not include license text files separate from
upstream.
[x]: SHOULD SourceX is a working URL.
[-]: SHOULD Description and summary sections in the
[Bug 819844] Review Request: luarocks - A deployment and management system for Lua modules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819844 --- Comment #8 from Jon Ciesla limburg...@gmail.com 2012-05-11 11:10:28 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819844] Review Request: luarocks - A deployment and management system for Lua modules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819844 Michel Alexandre Salim michel+...@sylvestre.me changed: What|Removed |Added Flag||fedora-cvs? --- Comment #7 from Michel Alexandre Salim michel+...@sylvestre.me 2012-05-11 11:08:32 EDT --- Thanks! Will try and get the test suite working New Package SCM Request === Package Name: luarocks Short Description: A deployment and management system for Lua modules Owners: salimma Branches: el5 el6 f16 f17 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819844] Review Request: luarocks - A deployment and management system for Lua modules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819844 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819844] Review Request: luarocks - A deployment and management system for Lua modules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819844 --- Comment #9 from Fedora Update System upda...@fedoraproject.org 2012-05-11 13:12:15 EDT --- luarocks-2.0.8-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/luarocks-2.0.8-2.fc17 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819844] Review Request: luarocks - A deployment and management system for Lua modules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819844 --- Comment #12 from Fedora Update System upda...@fedoraproject.org 2012-05-11 13:13:04 EDT --- luarocks-2.0.8-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/luarocks-2.0.8-2.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819844] Review Request: luarocks - A deployment and management system for Lua modules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819844 --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2012-05-11 13:12:55 EDT --- luarocks-2.0.8-2.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/luarocks-2.0.8-2.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819844] Review Request: luarocks - A deployment and management system for Lua modules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819844 --- Comment #10 from Fedora Update System upda...@fedoraproject.org 2012-05-11 13:12:46 EDT --- luarocks-2.0.8-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/luarocks-2.0.8-2.el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819844] Review Request: luarocks - A deployment and management system for Lua modules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819844 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #13 from Fedora Update System upda...@fedoraproject.org 2012-05-11 17:53:51 EDT --- luarocks-2.0.8-2.fc17 has been pushed to the Fedora 17 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819844] Review Request: luarocks - A deployment and management system for Lua modules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819844 Ralph Bean rb...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||rb...@redhat.com AssignedTo|nob...@fedoraproject.org|rb...@redhat.com Flag||fedora-review? --- Comment #3 from Ralph Bean rb...@redhat.com 2012-05-10 10:47:11 EDT --- I'll review this one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819844] Review Request: luarocks - A deployment and management system for Lua modules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819844 --- Comment #4 from Ralph Bean rb...@redhat.com 2012-05-10 14:34:53 EDT --- Before I do the full review, are you planning to support EPEL5? If not, you'll need to remove the following line at the top of %install: rm -rf $RPM_BUILD_ROOT -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819844] Review Request: luarocks - A deployment and management system for Lua modules
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=819844
--- Comment #5 from Michel Alexandre Salim michel+...@sylvestre.me 2012-05-11
00:07:56 EDT ---
Thanks -- someone needs to eventually file a bug against the RPM spec
templates!
luarocks works fine on RHEL 5 (just tested it on the test machines), though for
it (and on RHEL 6) the spec needs some changes; I've guarded those changes with
%if 0%{?el5} and %if 0%{?rhel}.
http://salimma.fedorapeople.org/specs/funpl/luarocks-2.0.8-2.fc17.src.rpm
http://salimma.fedorapeople.org/specs/funpl/luarocks.spec
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819844] Review Request: luarocks - A deployment and management system for Lua modules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819844 --- Comment #1 from Michel Alexandre Salim michel+...@sylvestre.me 2012-05-08 07:32:54 EDT --- note: there's a previous, apparently abandoned review at https://bugzilla.redhat.com/show_bug.cgi?id=577514 -- will check there if the packager want to collaborate, and if not, close it as a duplicate -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819844] Review Request: luarocks - A deployment and management system for Lua modules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819844 Michel Alexandre Salim michel+...@sylvestre.me changed: What|Removed |Added CC||tho...@duboucher.eu --- Comment #2 from Michel Alexandre Salim michel+...@sylvestre.me 2012-05-08 10:05:14 EDT --- *** Bug 577514 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
