[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821224

MartinKG  changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #40 from MartinKG  ---
Package Change Request
==
Package Name: tntnet
New Branches: fc23 devel
Owners: martinkg
InitialCC: 

[please untire tntnet, because package vdr-lieve depends on it]

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821224

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821224



--- Comment #41 from Jon Ciesla  ---
This SCM request method has been deprecated. Please see
https://fedoraproject.org/wiki/PackageDB_admin_requests.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821224

MartinKG mgans...@alice.de changed:

   What|Removed |Added

 Blocks||1045756




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1045756
[Bug 1045756] Review Request: vdr-live - An interactive web interface for
VDR
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821224

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version||tntnet-2.2-3.fc19

--- Comment #39 from Fedora Update System upda...@fedoraproject.org ---
tntnet-2.2-3.fc19 has been pushed to the Fedora 19 stable repository.  If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=mwrTiytTW9a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=821224

--- Comment #37 from Fedora Update System upda...@fedoraproject.org ---
tntnet-2.2-3.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/tntnet-2.2-3.fc19

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=tCpI89UzVca=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=821224

Ville Skyttä ville.sky...@iki.fi changed:

   What|Removed |Added

 CC|ville.sky...@iki.fi |

--- Comment #38 from Ville Skyttä ville.sky...@iki.fi ---
Martin: same thing here, please do not add ages old review tickets to package
updates in bodhi, it's just unnecessary spam. The tntnet-2.2-3.fc19 update does
not fix this bug - this one has been closed for about 7 months already.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=03pIXRWcqAa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821224

MartinKG mgans...@alice.de changed:

   What|Removed |Added

Version|17  |rawhide

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821224

MartinKG mgans...@alice.de changed:

   What|Removed |Added

  Flags|fedora-cvs+ |
  Flags||fedora-cvs?

--- Comment #35 from MartinKG mgans...@alice.de ---
Package Change Request
==
Package Name: tntnet
New Branches: fc18
Owners: martinkg
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821224

--- Comment #36 from Jon Ciesla limburg...@gmail.com ---
f18 branch exists.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821224

--- Comment #34 from Fedora Update System upda...@fedoraproject.org ---
tntnet-2.1-15.fc18 has been pushed to the Fedora 18 stable repository.  If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821224

--- Comment #33 from Fedora Update System upda...@fedoraproject.org ---
tntnet-2.1-15.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/tntnet-2.1-15.fc18

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821224

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Resolution|NEXTRELEASE |ERRATA

--- Comment #31 from Fedora Update System upda...@fedoraproject.org ---
tntnet-2.1-13.fc17 has been pushed to the Fedora 17 stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821224

--- Comment #32 from Fedora Update System upda...@fedoraproject.org ---
tntnet-2.1-13.fc16 has been pushed to the Fedora 16 stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821224

--- Comment #27 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821224

MartinKG mgans...@alice.de changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2012-07-26 15:00:03

--- Comment #28 from MartinKG mgans...@alice.de ---
the package built successfully

http://koji.fedoraproject.org/koji/taskinfo?taskID=4332353
http://koji.fedoraproject.org/koji/taskinfo?taskID=4332380
http://koji.fedoraproject.org/koji/taskinfo?taskID=4332418

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821224

--- Comment #30 from Fedora Update System upda...@fedoraproject.org ---
tntnet-2.1-13.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/tntnet-2.1-13.fc16

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821224

Michel Alexandre Salim michel+...@sylvestre.me changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+

--- Comment #25 from Michel Alexandre Salim michel+...@sylvestre.me ---
Everything looks fine; I'm approving this package, but could you add a new line
between every changelog entry? Makes them easier to read.

Sorry for the delay (traveling for the past week)

APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821224

--- Comment #26 from MartinKG mgans...@alice.de ---
New Package SCM Request
===
Package Name: tntnet
Short Description: A web application server for web applications.
Owners: martinkg
Branches: f16 f17
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821224

MartinKG mgans...@alice.de changed:

   What|Removed |Added

  Flags||fedora-cvs?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821224

--- Comment #24 from MartinKG mgans...@alice.de ---
Michel,

finally i need your approval for the review.

%changelog
* Wed Jul 18 2012 Martin Gansser linux4mar...@gmx.de - 2.1-11
- added missing build requirement kernel-headers

SRPM URL:
https://www.disk.dsl.o2online.de/FclyPlh/RPMS/VDR/tntnet/tntnet-2.1-11.fc17/tntnet-2.1-11.fc17.src.rpm?a=nbJNcrhhSu0

Spec URL:
https://www.disk.dsl.o2online.de/FclyPlh/RPMS/VDR/tntnet/tntnet-2.1-11.fc17/tntnet.spec?a=RxrHP0VmxnE

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821224

--- Comment #23 from MartinKG mgans...@alice.de ---
%changelog
* Fri Jul 13 2012 Martin Gansser linux4mar...@gmx.de - 2.1-10
- added upstream link for gcc 4.7 patch
- changed license type
- make install preserve timestamps

SRPM URL:
https://www.disk.dsl.o2online.de/FclyPlh/RPMS/VDR/tntnet/tntnet-2.1-10.fc17/tntnet-2.1-10.fc17.src.rpm?a=PHr6ioR2ftc

Spec URL:
https://www.disk.dsl.o2online.de/FclyPlh/RPMS/VDR/tntnet/tntnet-2.1-10.fc17/tntnet.spec?a=hewbR_GWzS4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821224

--- Comment #22 from Michel Alexandre Salim michel+...@sylvestre.me ---
The following snippet fixes the issue of files being installed without
preserving modification timestamps:


--- tntnet.spec.orig2012-07-06 13:58:16.506339380 +0700
+++ tntnet.spec2012-07-13 11:27:45.005457825 +0700
@@ -34,7 +34,7 @@
 %patch1 -p1

 %build
-%configure --disable-static
+INSTALL=install -p %configure --disable-static
 make %{?_smp_mflags}

 %install

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821224

--- Comment #21 from Michel Alexandre Salim michel+...@sylvestre.me ---
Apologies for the delay, here's the review. There are some changes needed
still, but the package looks almost ready for approval.


Package Review
==

Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated



 C/C++ 
[x]: MUST Package does not contain any libtool archives (.la)
[x]: MUST Package does not contain kernel modules.
[x]: MUST Package contains no static executables.
[x]: MUST Rpath absent or only used for internal libs.
[x]: MUST Package is not relocatable.


 Generic 
[x]: EXTRA Rpmlint is run on all installed packages.
 Note: There are rpmlint messages (see attachment).
[x]: EXTRA Spec file according to URL is the same as in SRPM.
[x]: MUST Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
 least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
 Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
 Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST %config files are marked noreplace or the reason is justified.
[x]: MUST Each %files section contains %defattr if rpm  4.4
 Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[-]: MUST Package contains desktop file if it is a GUI application.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Fully versioned dependency in subpackages, if present.
[x]: MUST Package complies to the Packaging Guidelines
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
 Note: rm -rf would be needed if support for EPEL5 is required
[-]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %doc.
[!]: MUST License field in the package spec file matches the actual license.
 Note: Checking original sources for licenses Licenses found:
 zlib/libpng, UNKNOWN, *No copyright* UNKNOWN, GPL (v2 or later),
 LGPL (v2.1 or later) For detailed output of licensecheck see file:

/home/michel/sources/fedora/projects/FedoraReview/src/821224-tntnet/licensecheck.txt
 - framework/common/gcryptinit.c is GPLv2+, this should be added to the
list
 of licenses (with a comment indicating which file is affected)
 - framework/common/unzip.h is under the zlib license -- ditto, add it to
 the list, so this should be e.g.:

 # GPLv2+: framework/common/gcryptinit.c
 # zlib:   framework/common/unzip.h
 License: LGPLv2+ and GPLv2+ and zlib

[x]: MUST License file installed when any subpackage combination is installed.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
 names).
[x]: MUST Package is named using only allowed ascii characters.
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST No %config files under /usr.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: MUST Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: MUST Package contains systemd file(s) if in need.
[x]: MUST File names are valid UTF-8.
[x]: MUST Useful -debuginfo package or justification otherwise.
[x]: SHOULD Reviewer should test that the package 

[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821224

--- Comment #20 from MartinKG mgans...@alice.de ---
%changelog
* Thu Jul 3 2012 Martin Gansser linux4mar...@gmx.de - 2.1-9
- removed rm in install section
- removed systemd readme file
- added link to upstream systemd patch

SRPM URL:
https://www.disk.dsl.o2online.de/FclyPlh/RPMS/VDR/tntnet/tntnet-2.1-9.fc17/tntnet-2.1-9.fc17.src.rpm?a=nO4gxRikyFw

Spec URL:
https://www.disk.dsl.o2online.de/FclyPlh/RPMS/VDR/tntnet/tntnet-2.1-9.fc17/tntnet.spec?a=UEQ3_9_VG28

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821224

Ville Skyttä ville.sky...@iki.fi changed:

   What|Removed |Added

  Flags|needinfo?(mgans...@alice.de |
   |)   |

--- Comment #16 from Ville Skyttä ville.sky...@iki.fi ---
I'm assuming Martin did those changes by accident, I (being his sponsor) just
tried to undo the mess. There's no way I could have affected who is the
requestor of the fedora-review flag so it got set to me. So I think you're
still very welcome to do this review.

BTW, 0x is not a catch-all component, it's real software.
http://www.nopcode.org/0x/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821224

--- Comment #17 from MartinKG mgans...@alice.de ---
Ville has alread pointed me out to do not change the flag. I am not aware of
the fact that I have changed the flags,
I didn't know what is going on. Michael you're welcome to make this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821224

--- Comment #18 from Ville Skyttä ville.sky...@iki.fi ---
I *guess* what happened is that the component was for some reason changed to
0x, and because the fedora-review flag is not valid for that component
(it's only for Package Review), it got lost.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821224

Ville Skyttä ville.sky...@iki.fi changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|michel+...@sylvestre.me

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821224

Michel Alexandre Salim michel+...@sylvestre.me changed:

   What|Removed |Added

  Flags|fedora-review?  |

--- Comment #19 from Michel Alexandre Salim michel+...@sylvestre.me ---
Ah, that poor maintainer of 0x, how many bugs accidentally get assigned to
it due to Bugzilla mix-ups? I think having a fake '0xDEAD' component might not
be such a bad idea.

Clearing fedora-review, would have to set it again on the next update, I think.
Sorry for the noise.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821224

Michel Alexandre Salim michel+...@sylvestre.me changed:

   What|Removed |Added

  Flags||fedora-review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821224

Michel Alexandre Salim michel+...@sylvestre.me changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||michel+...@sylvestre.me
   Assignee|nob...@fedoraproject.org|michel+...@sylvestre.me
  Flags||fedora-review?

--- Comment #13 from Michel Alexandre Salim michel+...@sylvestre.me ---
Taking this review

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821224

MartinKG mgans...@alice.de changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
 CC||dw...@infradead.org
  Component|Package Review  |0x
   Assignee|michel+...@sylvestre.me |dw...@infradead.org
  Flags|fedora-review?  |

--- Comment #14 from MartinKG mgans...@alice.de ---
%changelog
* Sun Jun 24 2012 Martin Gansser linux4mar...@gmx.de - 2.1-8
- removed group and user apache from tntnet.conf
- added own group tntnet to tntnet.conf
- added creation of users and groups in pre section

SRPM URL:
https://www.disk.dsl.o2online.de/FclyPlh/RPMS/VDR/tntnet/tntnet-2.1-8.fc17/tntnet-2.1-8.fc17.src.rpm?a=mrLedpPhCkY

Spec URL:
https://www.disk.dsl.o2online.de/FclyPlh/RPMS/VDR/tntnet/tntnet-2.1-8.fc17/tntnet.spec?a=l2tVN0d4nz0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821224

Ville Skyttä ville.sky...@iki.fi changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC|dw...@infradead.org |
  Component|0x  |Package Review
   Assignee|dw...@infradead.org |nob...@fedoraproject.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821224

Ville Skyttä ville.sky...@iki.fi changed:

   What|Removed |Added

  Flags||fedora-review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821224

Michel Alexandre Salim michel+...@sylvestre.me changed:

   What|Removed |Added

  Flags||needinfo?(mgans...@alice.de
   ||)

--- Comment #15 from Michel Alexandre Salim michel+...@sylvestre.me ---
Er, Martin, what's going on here? I see the reviewer flag reset and then
switched to Ville Skytta (though according to Bugzilla's email, you did this,
not Ville -- didn't even know that's possible), and for a while the component
was changed from Package Review to 0x, that catch-all component for
miscategorized bugs.

Let me know if you want me to do this review - seems like the flag change was
inadvertent, but I'd of course let Ville do the review if that's your
intention.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821224

--- Comment #12 from MartinKG mgans...@alice.de ---
%changelog
* Wed Jun 20 2012 Martin Gansser linux4mar...@gmx.de - 2.1-6
- changed group and user for fedora to apache

SRPM URL:
https://www.disk.dsl.o2online.de/FclyPlh/RPMS/VDR/tntnet/tntnet-2.1-6.fc17/tntnet-2.1-6.fc17.src.rpm?a=tFMXkddUWZc

Spec URL:
https://www.disk.dsl.o2online.de/FclyPlh/RPMS/VDR/tntnet/tntnet-2.1-6.fc17/tntnet.spec?a=kM34wjXeOIQ

reviewer are welcome !

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821224

--- Comment #9 from MartinKG mgans...@alice.de ---
need Sponsor !

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821224

--- Comment #10 from Ville Skyttä ville.sky...@iki.fi ---
(In reply to comment #9)
 need Sponsor !

Nope, you don't need a sponsor (I'm your sponsor), you presumably mean that you
need a reviewer for this package...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821224

--- Comment #11 from MartinKG mgans...@alice.de ---
right, i need a reviewer, I hope you had time.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821224

--- Comment #7 from MartinKG mgans...@alice.de ---
changelog
* Sun Jun 17 2012 Martin Gansser linux4mar...@gmx.de - 2.1-4
- fixed missing slash in path

SRPM URL:
https://www.disk.dsl.o2online.de/FclyPlh/RPMS/VDR/tntnet/tntnet-2.1-4.fc17/tntnet-2.1-4.fc17.src.rpm?a=XHzgXD-SHWg

Spec URL:
https://www.disk.dsl.o2online.de/FclyPlh/RPMS/VDR/tntnet/tntnet-2.1-4.fc17/tntnet.spec?a=CZjSIpgHbIs

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821224

--- Comment #8 from MartinKG mgans...@alice.de ---
changelog
* Sun Jun 17 2012 Martin Gansser linux4mar...@gmx.de - 2.1-5
- fixed more missing slash in path
- fixed missing system unit file

SRPM URL:
https://www.disk.dsl.o2online.de/FclyPlh/RPMS/VDR/tntnet/tntnet-2.1-5.fc17/tntnet-2.1-5.fc17.src.rpm?a=VyadDn9veOk

Spec URL:
https://www.disk.dsl.o2online.de/FclyPlh/RPMS/VDR/tntnet/tntnet-2.1-5.fc17/tntnet.spec?a=qZFtm5BVgSM

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821224

--- Comment #5 from Robin Lee robinlee.s...@gmail.com ---
This one:

$ svn diff -r 1363:1364
Index: framework/defcomp/static.cpp
===
--- framework/defcomp/static.cpp(revision 1363)
+++ framework/defcomp/static.cpp(revision 1364)
@@ -51,6 +51,7 @@
 #include netinet/in.h
 #include netinet/tcp.h
 #include sys/poll.h
+#include unistd.h
 #include typeinfo
 #include errno.h
 #endif

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821224

--- Comment #6 from MartinKG mgans...@alice.de ---

changelog
* Sat Jun 16 2012 Martin Gansser linux4mar...@gmx.de - 2.1-3
- gcc-4.7 patch
- added systemd service file
- removed sysv init stuff
- cleanup spec file

SRPM URL:
https://www.disk.dsl.o2online.de/FclyPlh/RPMS/VDR/tntnet/tntnet-2.1-3.fc17/tntnet-2.1-3.fc17.src.rpm?a=_U5sHZnowaA

Spec URL:
https://www.disk.dsl.o2online.de/FclyPlh/RPMS/VDR/tntnet/tntnet-2.1-3.fc17/tntnet.spec?a=36s7Yu8HXtQ

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821224

--- Comment #2 from Robin Lee robinlee.s...@gmail.com ---
Upstream svn1364 patch is required to build with GCC 4.7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821224

--- Comment #3 from Robin Lee robinlee.s...@gmail.com ---
How about adding a systemd configuration?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821224

--- Comment #4 from MartinKG mgans...@alice.de ---
Robin,

is this the patch you mean ?

--- tntnet-2.1/framework/common/tnt/object.h2012-02-09 19:47:38.0
+0100
+++ tntnet-svn1364/framework/common/tnt/object.h2012-06-15
22:58:58.400842102 +0200
@@ -59,7 +59,7 @@
   ~PointerObject()
 { destroyPolicydata_type::destroy(ptr); }
   void set(data_type* ptr_)
-{ destroy(ptr); ptr = ptr_; }
+{ destroyPolicydata_type::destroy(ptr); ptr = ptr_; }
   data_type* get()  { return ptr; }
   };

~

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821224

Bug 821224 depends on bug 821220, which changed state.

Bug 821220 Summary: cxxtools - A collection of general-purpose C++ classes
https://bugzilla.redhat.com/show_bug.cgi?id=821220

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NEXTRELEASE

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821224

--- Comment #1 from MartinKG mgans...@alice.de ---
changelog
* Tue May 29 2012 Martin Gansser linux4mar...@gmx.de - 2.1-2
- removed license comment
- removed empty files
- fixed Requires and Group tag

SRPM URL:
https://www.disk.dsl.o2online.de/FclyPlh/RPMS/VDR/tntnet/tntnet-2.1-2.fc17.src.rpm?a=ShCi6YqDM8k

Spec URL:
https://www.disk.dsl.o2online.de/FclyPlh/RPMS/VDR/tntnet/tntnet.spec?a=whNW54z8GWs

rpmlint output:
rpmlint tntnet-2.1-2.fc17.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

rpmlint cxxtools-2.1.1-2.fc17.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

rpmlint cxxtools-devel-2.1.1-2.fc17.x86_64.rpm
cxxtools-devel.x86_64: W: no-documentation
cxxtools-devel.x86_64: W: no-manual-page-for-binary cxxtools-config
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

rpmlint cxxtools-debuginfo-2.1.1-2.fc17.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=821224

Ville Skyttä ville.sky...@iki.fi changed:

   What|Removed |Added

 Blocks|177841  |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=821224

MartinKG mgans...@alice.de changed:

   What|Removed |Added

 Blocks||177841(FE-NEEDSPONSOR)
 Depends on||821220

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821224] tntnet - A web application server for web applications

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=821224

MartinKG mgans...@alice.de changed:

   What|Removed |Added

 Blocks||821233

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review