[Bug 821284] Review Request: dbunit - DbUnit Framework - extension for JUnit
https://bugzilla.redhat.com/show_bug.cgi?id=821284 --- Comment #8 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821284] Review Request: dbunit - DbUnit Framework - extension for JUnit
https://bugzilla.redhat.com/show_bug.cgi?id=821284 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821284] Review Request: dbunit - DbUnit Framework - extension for JUnit
https://bugzilla.redhat.com/show_bug.cgi?id=821284 gil cattaneo punto...@libero.it changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||dbunit-2.5.0-2.fc22 Resolution|--- |RAWHIDE Last Closed||2014-08-05 09:18:13 --- Comment #9 from gil cattaneo punto...@libero.it --- Task Info: http://koji.fedoraproject.org/koji/taskinfo?taskID=7243519 Build Info: http://koji.fedoraproject.org/koji/buildinfo?buildID=550621 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821284] Review Request: dbunit - DbUnit Framework - extension for JUnit
https://bugzilla.redhat.com/show_bug.cgi?id=821284 gil cattaneo punto...@libero.it changed: What|Removed |Added Blocks|652183 (FE-JAVASIG) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821284] Review Request: dbunit - DbUnit Framework - extension for JUnit
https://bugzilla.redhat.com/show_bug.cgi?id=821284 Eduardo Mayorga e...@mayorgalinux.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #6 from Eduardo Mayorga e...@mayorgalinux.com --- PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821284] Review Request: dbunit - DbUnit Framework - extension for JUnit
https://bugzilla.redhat.com/show_bug.cgi?id=821284 gil cattaneo punto...@libero.it changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from gil cattaneo punto...@libero.it --- Thanks for the review! New Package SCM Request === Package Name: dbunit Short Description: A JUnit extension targeted for database-driven projects Owners: gil InitialCC: java-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821284] Review Request: dbunit - DbUnit Framework - extension for JUnit
https://bugzilla.redhat.com/show_bug.cgi?id=821284
Eduardo Mayorga e...@mayorgalinux.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|e...@mayorgalinux.com
Flags||fedora-review?
--- Comment #4 from Eduardo Mayorga e...@mayorgalinux.com ---
May I suggest you to use %global enable_tests 0? This would make this
consistent with other packages and easier to read.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues:
===
- Spec file as given by url differs from SRPM's one.
- Incorrect FSF address found in license file and headers in source code.
Upstream should be informed about this.
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
LGPL (v2.1 or later) (with incorrect FSF address), Unknown or
generated. 56 files have unknown license. Detailed output of
licensecheck in /home/makerpm/821284-dbunit/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/maven-metadata
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/maven-metadata
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 30720 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
Note: Maven packages do not need to (Build)Require jpackage-utils. It is
pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
Maven:
[x]: If package contains pom.xml files
[Bug 821284] Review Request: dbunit - DbUnit Framework - extension for JUnit
https://bugzilla.redhat.com/show_bug.cgi?id=821284 --- Comment #5 from gil cattaneo punto...@libero.it --- (In reply to Eduardo Mayorga from comment #4) Issues: === - Spec file as given by url differs from SRPM's one. should fixed - Incorrect FSF address found in license file and headers in source code. Upstream should be informed about this. Open https://sourceforge.net/p/dbunit/bugs/357/ Spec URL: http://gil.fedorapeople.org/dbunit.spec SRPM URL: http://gil.fedorapeople.org/dbunit-2.5.0-2.fc19.src.rpm - fix some review issues -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821284] Review Request: dbunit - DbUnit Framework - extension for JUnit
https://bugzilla.redhat.com/show_bug.cgi?id=821284 --- Comment #2 from Eduardo Mayorga e...@mayorgalinux.com --- Update to 2.5.1 and I'll review this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821284] Review Request: dbunit - DbUnit Framework - extension for JUnit
https://bugzilla.redhat.com/show_bug.cgi?id=821284 --- Comment #3 from gil cattaneo punto...@libero.it --- (In reply to Eduardo Mayorga from comment #2) Update to 2.5.1 and I'll review this. I prefer use a stable release instead of a SNAPSHOT Spec URL: http://gil.fedorapeople.org/dbunit.spec SRPM URL: http://gil.fedorapeople.org/dbunit-2.5.0-1.fc19.src.rpm - Update to 2.5.0 Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=7234351 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821284] Review Request: dbunit - DbUnit Framework - extension for JUnit
https://bugzilla.redhat.com/show_bug.cgi?id=821284 Bug 821284 depends on bug 821283, which changed state. Bug 821283 Summary: Review Request: gsbase - A collection of java utility classes https://bugzilla.redhat.com/show_bug.cgi?id=821283 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BMgvHKIc5Ea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821284] Review Request: dbunit - DbUnit Framework - extension for JUnit
https://bugzilla.redhat.com/show_bug.cgi?id=821284 --- Comment #1 from gil cattaneo punto...@libero.it --- Spec URL: http://gil.fedorapeople.org/dbunit.spec SRPM URL: http://gil.fedorapeople.org/dbunit-2.4.9-1.fc18.src.rpm - Update to 2.4.9 Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=5405694 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QxdXqYXSxta=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821284] Review Request: dbunit - DbUnit Framework - extension for JUnit
https://bugzilla.redhat.com/show_bug.cgi?id=821284 gil cattaneo punto...@libero.it changed: What|Removed |Added Blocks||848096 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821284] Review Request: dbunit - DbUnit Framework - extension for JUnit
https://bugzilla.redhat.com/show_bug.cgi?id=821284 gil cattaneo punto...@libero.it changed: What|Removed |Added Blocks||652183 (FE-JAVASIG) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821284] Review Request: dbunit - DbUnit Framework - extension for JUnit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=821284 gil cattaneo punto...@libero.it changed: What|Removed |Added Depends on||805487, 820343, 821283 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
